March 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: DataCenterStorageListModel update availability ref...
by derez＠redhat.com 30 Mar '15

30 Mar '15

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: DataCenterStorageListModel update availability refactor. ...................................................................... webadmin: DataCenterStorageListModel update availability refactor. Currently every time a selected DC is changed, or whenever the availability of storage domains of a DC should be updated in the DC's storage tab, the program runs through all the domains all over again for each boolean value it needs. (e.g. is there a master domain, is there an ISO domain, etc...). This patch replaces the multiple iterations into one. at the end of the iteration all the boolean values will be set. This is a better design for future boolean values to add in code redundancy and clearness aspects. Change-Id: I88abe054994257e2d3bd781d4d3b53aece75cd2c Signed-off-by: Amit Aviram <aaviram(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterStorageListModel.java 1 file changed, 19 insertions(+), 27 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Daniel Erez: Looks good to me, approved Allon Mureinik: Looks good to me, but someone else must approve Amit Aviram: Verified -- To view, visit https://gerrit.ovirt.org/38585 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I88abe054994257e2d3bd781d4d3b53aece75cd2c Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: restapi: data_center element under openstack_volume_provider
by derez＠redhat.com 30 Mar '15

30 Mar '15

Daniel Erez has submitted this change and it was merged. Change subject: restapi: data_center element under openstack_volume_provider ...................................................................... restapi: data_center element under openstack_volume_provider Populate data_center element on doPopulate of OpenstackVolumeProvider. I.e. when using "All-Content: true", data_center element should be populated and returned. Feature Page: http://www.ovirt.org/Features/Cinder_Integration Change-Id: Id253f9bc482b6dd499cfcce604c7b960d9d90b55 Bug-Url: https://bugzilla.redhat.com/1185826 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/openstack/BackendOpenStackVolumeProviderResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/openstack/BackendOpenStackVolumeProvidersResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/openstack/BackendOpenStackVolumeProviderResourceTest.java 3 files changed, 77 insertions(+), 5 deletions(-) Approvals: Juan Hernandez: Looks good to me, approved Daniel Erez: Verified -- To view, visit https://gerrit.ovirt.org/39327 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id253f9bc482b6dd499cfcce604c7b960d9d90b55 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: restapi: add CINDER to StorageDomainType
by derez＠redhat.com 30 Mar '15

30 Mar '15

Daniel Erez has submitted this change and it was merged. Change subject: restapi: add CINDER to StorageDomainType ...................................................................... restapi: add CINDER to StorageDomainType * Added VOLUME to StorageType enum. * Modified StorageDomainMapper accordingly. Feature Page: http://www.ovirt.org/Features/Cinder_Integration Change-Id: Iffd9f87d1cd750b165eed0223b59b11d69494b8b Bug-Url: https://bugzilla.redhat.com/1185826 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/StorageDomainType.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/StorageDomainMapper.java 2 files changed, 5 insertions(+), 1 deletion(-) Approvals: Juan Hernandez: Looks good to me, approved Daniel Erez: Verified -- To view, visit https://gerrit.ovirt.org/39326 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iffd9f87d1cd750b165eed0223b59b11d69494b8b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: restapi: add CINDER to StorageType
by derez＠redhat.com 30 Mar '15

30 Mar '15

Daniel Erez has submitted this change and it was merged. Change subject: restapi: add CINDER to StorageType ...................................................................... restapi: add CINDER to StorageType * Added CINDER to StorageType enum. * Modified StorageDomainMapper accordingly. Feature Page: http://www.ovirt.org/Features/Cinder_Integration Change-Id: I731440d6953f4cea54d65bc53c01dc3485578a3f Bug-Url: https://bugzilla.redhat.com/1185826 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/StorageType.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/StorageDomainMapper.java 2 files changed, 6 insertions(+), 1 deletion(-) Approvals: Juan Hernandez: Looks good to me, approved Daniel Erez: Verified -- To view, visit https://gerrit.ovirt.org/39325 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I731440d6953f4cea54d65bc53c01dc3485578a3f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: add management net validation on host move to anothe...
by oourfali＠redhat.com 30 Mar '15

30 Mar '15

Oved Ourfali has submitted this change and it was merged. Change subject: engine: add management net validation on host move to another cluster ...................................................................... engine: add management net validation on host move to another cluster Add management network validation on host move to another cluster. The operatin is banned if management network name in the target cluster is differs from the source one. Change-Id: I7ef330309ccc90142c8734454ddcf6f2f3587abc Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeVDSClusterCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 5 files changed, 34 insertions(+), 2 deletions(-) Approvals: Martin Mucha: Looks good to me, but someone else must approve Alona Kaplan: Looks good to me, approved Yevgeny Zaspitsky: Verified -- To view, visit https://gerrit.ovirt.org/39183 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7ef330309ccc90142c8734454ddcf6f2f3587abc Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: jsonrpc: two way heartbeats
by oourfali＠redhat.com 30 Mar '15

30 Mar '15

Oved Ourfali has submitted this change and it was merged. Change subject: jsonrpc: two way heartbeats ...................................................................... jsonrpc: two way heartbeats Change-Id: Ie0c903a20f3bc97b9b1665fd69f7dd840bb62672 Signed-off-by: pkliczewski <piotr.kliczewski(a)gmail.com> Bug-Url: https://bugzilla.redhat.com/1184835 --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java 1 file changed, 3 insertions(+), 2 deletions(-) Approvals: Piotr Kliczewski: Verified Oved Ourfali: Looks good to me, approved Eldad Marciano: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/38003 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie0c903a20f3bc97b9b1665fd69f7dd840bb62672 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Eldad Marciano <emarcian(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: eldad marciano <mseldad(a)gmail.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: removed unused PPC network drivers
by ofrenkel＠redhat.com 30 Mar '15

30 Mar '15

Omer Frenkel has submitted this change and it was merged. Change subject: engine: removed unused PPC network drivers ...................................................................... engine: removed unused PPC network drivers Removed e1000 and rtl8139 network drivers from osinfo-defaults.properties configuration file for ppc64 architecture. Change-Id: Icff0b9d6862f5bc7bc03a16738eea434698d42ab Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1199208 Signed-off-by: Shmuel Melamud <smelamud(a)redhat.com> --- M packaging/conf/osinfo-defaults.properties 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Shmuel Leib Melamud: Verified Omer Frenkel: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/39316 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icff0b9d6862f5bc7bc03a16738eea434698d42ab Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Disabled selection of table rows
by kmayilsa＠redhat.com 30 Mar '15

30 Mar '15

Kanagaraj M has submitted this change and it was merged. Change subject: webadmin: Disabled selection of table rows ...................................................................... webadmin: Disabled selection of table rows Earlier the gluster volume sanpshot config listing table supported selection of rows, and it used to cause issues as the editable column values used to become invisible. Disabled the row selection for the table so that user can only change the values in the text boxes. Change-Id: I27ab7ee81745d468d0423294cc06b9183406c103 Signed-off-by: Shubhendu Tripathi <shtripat(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/GlusterClusterSnapshotConfigureOptionsPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/GlusterVolumeSnapshotConfigureOptionsPopupView.java 2 files changed, 4 insertions(+), 0 deletions(-) Approvals: Shubhendu Tripathi: Verified Kanagaraj M: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/39235 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I27ab7ee81745d468d0423294cc06b9183406c103 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: packaging: setup: pki: upgrade cert templates
by sbonazzo＠redhat.com 30 Mar '15

30 Mar '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: pki: upgrade cert templates ...................................................................... packaging: setup: pki: upgrade cert templates the certificate template may be modified over time, and has recently. due to legacy pki approach and until we rewrite the pki, we must regenerate configuration taking the AIA from existing template. Change-Id: Ia975aad12e97ce0287cd6414e7ab91ea2ca6c0f9 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/pki/ca.py 1 file changed, 79 insertions(+), 11 deletions(-) Approvals: Alon Bar-Lev: Verified Sandro Bonazzola: Looks good to me, approved Yedidyah Bar David: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/38644 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia975aad12e97ce0287cd6414e7ab91ea2ca6c0f9 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: packaging: setup: pki: cleanup ca module
by sbonazzo＠redhat.com 30 Mar '15

30 Mar '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: pki: cleanup ca module ...................................................................... packaging: setup: pki: cleanup ca module Change-Id: I032621fb44cd08a6e02d7a806a876c8cc3ab4f0f Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/setup/ovirt_engine_setup/engine/constants.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/pki/ca.py 2 files changed, 36 insertions(+), 54 deletions(-) Approvals: Alon Bar-Lev: Verified Sandro Bonazzola: Looks good to me, approved oVirt Jenkins CI Server: Looks good to me, but someone else must approve Yedidyah Bar David: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/38643 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I032621fb44cd08a6e02d7a806a876c8cc3ab4f0f Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0