March 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: engine: Use type safety any[Set|List]Of matcher
by ofrenkel＠redhat.com 04 Mar '15

04 Mar '15

Omer Frenkel has submitted this change and it was merged. Change subject: engine: Use type safety any[Set|List]Of matcher ...................................................................... engine: Use type safety any[Set|List]Of matcher Change-Id: I8c8c5662d1a26d89116d9819bb6c232272705f52 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/CommonVmPoolWithVmsCommandTestAbstract.java 1 file changed, 9 insertions(+), 8 deletions(-) Approvals: Omer Frenkel: Looks good to me, approved Moti Asayag: Verified -- To view, visit https://gerrit.ovirt.org/38342 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8c8c5662d1a26d89116d9819bb6c232272705f52 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Reduce visibility of class members
by ofrenkel＠redhat.com 04 Mar '15

04 Mar '15

Omer Frenkel has submitted this change and it was merged. Change subject: engine: Reduce visibility of class members ...................................................................... engine: Reduce visibility of class members Change-Id: I5b09628085a02dbcc984f6cb6f8e0de30a4dca1c Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommonVmPoolWithVmsCommand.java 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Omer Frenkel: Looks good to me, approved Moti Asayag: Verified -- To view, visit https://gerrit.ovirt.org/38341 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5b09628085a02dbcc984f6cb6f8e0de30a4dca1c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Add disk snapshot ID column to two tables
by tnisan＠redhat.com 04 Mar '15

04 Mar '15

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Add disk snapshot ID column to two tables ...................................................................... webadmin: Add disk snapshot ID column to two tables This patch adds a disk snapshot ID column to the tables in: 1. Virtual Machines -> Snapshots -> Disks 2. Storage -> Disk Snapshots Change-Id: Ic3942f5da249c674aa4d3c7db949f8165fd74d04 Signed-off-by: Idan Shaby <ishaby(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/disks/DisksViewColumns.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/VmSnapshotInfoPanel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/storage/SubTabStorageSnapshotView.java 4 files changed, 27 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Looks good to me, but someone else must approve Allon Mureinik: Looks good to me, approved Idan Shaby: Verified -- To view, visit https://gerrit.ovirt.org/38266 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic3942f5da249c674aa4d3c7db949f8165fd74d04 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Candace Sheremeta <cshereme(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Clear redundant eclipse warnings
by ofrenkel＠redhat.com 04 Mar '15

04 Mar '15

Omer Frenkel has submitted this change and it was merged. Change subject: engine: Clear redundant eclipse warnings ...................................................................... engine: Clear redundant eclipse warnings Change-Id: I607e43912323d02c1ae6a02cbcacf51d8a9cd655 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmPoolWithVmsCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmPoolWithVmsCommandTest.java 2 files changed, 1 insertion(+), 2 deletions(-) Approvals: Omer Frenkel: Looks good to me, approved Moti Asayag: Verified -- To view, visit https://gerrit.ovirt.org/38340 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I607e43912323d02c1ae6a02cbcacf51d8a9cd655 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Cleanup VmPoolParametersBase
by ofrenkel＠redhat.com 04 Mar '15

04 Mar '15

Omer Frenkel has submitted this change and it was merged. Change subject: core: Cleanup VmPoolParametersBase ...................................................................... core: Cleanup VmPoolParametersBase Change-Id: I9997f7d1958df5f3c751583500c6756ce5f23707 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VmPoolParametersBase.java 1 file changed, 15 insertions(+), 15 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Moti Asayag: Verified -- To view, visit https://gerrit.ovirt.org/38339 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9997f7d1958df5f3c751583500c6756ce5f23707 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: userportal: Descriptive message if VM name is already in use
by ofrenkel＠redhat.com 04 Mar '15

04 Mar '15

Omer Frenkel has submitted this change and it was merged. Change subject: userportal: Descriptive message if VM name is already in use ...................................................................... userportal: Descriptive message if VM name is already in use When user tries to create a VM with the name that is already in use, the Name input field is highlighted and tooltip says "Name is already used in the environment, create new unique name." instead of less descriptive one "Name must be unique." Change-Id: I283b7fb7ca556d8aa52c94fbe54cea00151b2a9c Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1190144 Signed-off-by: Shmuel Melamud <smelamud(a)redhat.com> --- M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tomas Jelinek: Looks good to me, approved Shmuel Leib Melamud: Verified Omer Frenkel: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/38081 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I283b7fb7ca556d8aa52c94fbe54cea00151b2a9c Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: fix engine-notifier ETL service messages
by oourfali＠redhat.com 04 Mar '15

04 Mar '15

Oved Ourfali has submitted this change and it was merged. Change subject: core: fix engine-notifier ETL service messages ...................................................................... core: fix engine-notifier ETL service messages Basically changing "History" to "ETL" in messages Change-Id: I9bc8805f1a7c7d37158750fef6d8bcedd14e67ca Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1195200 Signed-off-by: emesika <emesika(a)redhat.com> --- M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties 2 files changed, 6 insertions(+), 6 deletions(-) Approvals: Shirly Radco: Looks good to me, but someone else must approve Eli Mesika: Verified Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/38353 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9bc8805f1a7c7d37158750fef6d8bcedd14e67ca Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-dwh[master]: packaging: setup: clean up db connection plugins
by sradco＠redhat.com 04 Mar '15

04 Mar '15

Shirly Radco has submitted this change and it was merged. Change subject: packaging: setup: clean up db connection plugins ...................................................................... packaging: setup: clean up db connection plugins Move around code to proper locations - engine connection from connection.py to engine_connection.py, and setup-related from common to setup, similarly to engine and reports. Without this patch, engine-cleanup with dwh fails if problems in postgresql.conf are found. Bug-Url: https://bugzilla.redhat.com/1176457 Bug-Url: https://bugzilla.redhat.com/1077267 Change-Id: I64fff2d8fc9677e6138581add9c167501d9c783e Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-common/ovirt-engine-dwh/db/connection.py M packaging/setup/plugins/ovirt-engine-common/ovirt-engine-dwh/db/engine_connection.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-dwh/db/__init__.py A packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-dwh/db/engine_connection.py 4 files changed, 198 insertions(+), 136 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Shirly Radco: Looks good to me, approved Simone Tiraboschi: Looks good to me, but someone else must approve Yedidyah Bar David: Verified -- To view, visit https://gerrit.ovirt.org/37870 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I64fff2d8fc9677e6138581add9c167501d9c783e Gerrit-PatchSet: 4 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: dal: Get geo-rep session with slave host and volume
by masayag＠redhat.com 04 Mar '15

04 Mar '15

Moti Asayag has submitted this change and it was merged. Change subject: dal: Get geo-rep session with slave host and volume ...................................................................... dal: Get geo-rep session with slave host and volume Added a query to get a geo-rep session given a slave host and volume name Change-Id: I1776500724a56acee9798066241e8b2c88b16836 Bug-Url: https://bugzilla.redhat.com/1125845 Signed-off-by: Sahina Bose <sabose(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterGeoRepDao.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterGeoRepDaoDbFacadeImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/gluster/GlusterGeoRepDaoTest.java M packaging/dbscripts/gluster_georep_sp.sql A packaging/dbscripts/upgrade/03_06_0950_add_idx_gluster_georep_slavehostname.sql 5 files changed, 35 insertions(+), 0 deletions(-) Approvals: Sahina Bose: Verified Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/34216 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1776500724a56acee9798066241e8b2c88b16836 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <wallaroo1976(a)gmail.com> Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in jenkins[master]: Adding smarter cleaning of ovirt node jobs
by tlitovsk＠redhat.com 04 Mar '15

04 Mar '15

Anatoly Litovsky has submitted this change and it was merged. Change subject: Adding smarter cleaning of ovirt node jobs ...................................................................... Adding smarter cleaning of ovirt node jobs Change-Id: I53438a6f20a88d433ba7fd67e0eca79ebf7642f1 Signed-off-by: Tolik Litovsky <tlitovsk(a)redhat.com> --- M jobs/confs/shell-scripts/ovirt_node_cleanup.sh 1 file changed, 11 insertions(+), 7 deletions(-) Approvals: Anatoly Litovsky: Verified; Looks good to me, approved Max Kovgan: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/38363 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I53438a6f20a88d433ba7fd67e0eca79ebf7642f1 Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Anatoly Litovsky <tlitovsk(a)redhat.com> Gerrit-Reviewer: Anatoly Litovsky <tlitovsk(a)redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com> Gerrit-Reviewer: Max Kovgan <kovganm(a)gmail.com> Gerrit-Reviewer: Max Kovgan <mvk(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0