March 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: add DiskStorageType column to disks table
by derez＠redhat.com 24 Mar '15

24 Mar '15

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: add DiskStorageType column to disks table ...................................................................... webadmin: add DiskStorageType column to disks table Adding DiskStorageType (Image/LUN/Cinder) column to disks table ('All' view). Change-Id: I7c72bb8a9228172a36e5a94953888b561587452c Bug-Url: https://bugzilla.redhat.com/1185826 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/disks/DisksViewColumns.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/BaseVmDiskListModelTable.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabDiskView.java 3 files changed, 21 insertions(+), 0 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/39048 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7c72bb8a9228172a36e5a94953888b561587452c Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: add CinderVolumeType to disk dialog
by derez＠redhat.com 24 Mar '15

24 Mar '15

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: add CinderVolumeType to disk dialog ...................................................................... webadmin: add CinderVolumeType to disk dialog Adding 'Volume Type' editor to add/edit Cinder disk dialog. Change-Id: Iacfd46fb0e2965788cf46d1d078dffede5fb8d3a Bug-Url: https://bugzilla.redhat.com/1185826 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDiskPopupWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDiskPopupWidget.ui.xml 3 files changed, 14 insertions(+), 1 deletion(-) Approvals: Daniel Erez: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/39049 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iacfd46fb0e2965788cf46d1d078dffede5fb8d3a Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: add CinderVolumeType column to disks table
by derez＠redhat.com 24 Mar '15

24 Mar '15

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: add CinderVolumeType column to disks table ...................................................................... webadmin: add CinderVolumeType column to disks table * Adding CinderVolumeType column to disks tables ('Cinder' view). * Removing (now) redundant 'lun' column. Change-Id: Id7557d41be6f14404bcc3fc5eeae4bb1bf61f2e5 Bug-Url: https://bugzilla.redhat.com/1185826 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/disks/DisksViewColumns.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/BaseVmDiskListModelTable.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabDiskView.java 3 files changed, 21 insertions(+), 33 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/39050 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id7557d41be6f14404bcc3fc5eeae4bb1bf61f2e5 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: add CinderVolumeType to common.gwt.xml
by derez＠redhat.com 24 Mar '15

24 Mar '15

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: add CinderVolumeType to common.gwt.xml ...................................................................... webadmin: add CinderVolumeType to common.gwt.xml Adding CinderVolumeType to common.gwt.xml. Change-Id: I663f1fc7925886d7640bcb13e0ba9b94fcdd679c Bug-Url: https://bugzilla.redhat.com/1185826 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/39047 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I663f1fc7925886d7640bcb13e0ba9b94fcdd679c Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: add disk dialog - support Cinder
by derez＠redhat.com 24 Mar '15

24 Mar '15

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: add disk dialog - support Cinder ...................................................................... webadmin: add disk dialog - support Cinder Support Cinder in add/edit disk dialog. Change-Id: I858c3a5a9426fa5571955b9d1e6ed9b41be891ac Bug-Url: https://bugzilla.redhat.com/1185826 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractModelBoundPopupWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDiskPopupWidget.java M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Linq.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/AbstractDiskModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/EditDiskModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewDiskModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java 10 files changed, 236 insertions(+), 60 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/39046 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I858c3a5a9426fa5571955b9d1e6ed9b41be891ac Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: disks table - add Cinder radio button
by derez＠redhat.com 24 Mar '15

24 Mar '15

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: disks table - add Cinder radio button ...................................................................... webadmin: disks table - add Cinder radio button Added Cinder radio button to Disks main-tab table and VMs->Disks sub-tab table. Change-Id: I857d3b96f284b7a54aba2639f406c3dfc069cb3a Bug-Url: https://bugzilla.redhat.com/1185826 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/disks/DisksViewRadioGroup.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/BaseVmDiskListModelTable.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabDiskView.java 4 files changed, 40 insertions(+), 23 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/39045 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I857d3b96f284b7a54aba2639f406c3dfc069cb3a Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: StorageDomainFreeSpaceRenderer - support Cinder
by derez＠redhat.com 24 Mar '15

24 Mar '15

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: StorageDomainFreeSpaceRenderer - support Cinder ...................................................................... webadmin: StorageDomainFreeSpaceRenderer - support Cinder StorageDomainFreeSpaceRenderer - in case of a Cinder storage domain, return just its name. Change-Id: Ia0b98cd4082331e7c4fe009676b5765ae9066c01 Bug-Url: https://bugzilla.redhat.com/1185826 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/renderer/StorageDomainFreeSpaceRenderer.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Daniel Erez: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/39044 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia0b98cd4082331e7c4fe009676b5765ae9066c01 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: DisksViewColumns - support Cinder
by derez＠redhat.com 24 Mar '15

24 Mar '15

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: DisksViewColumns - support Cinder ...................................................................... webadmin: DisksViewColumns - support Cinder DiskStorageType - support CINDER DiskStorageType in relevant columns. Change-Id: I2803cc160fcd4ab31b8bb8c4298e9307ef534802 Bug-Url: https://bugzilla.redhat.com/1185826 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/disks/DisksViewColumns.java 1 file changed, 16 insertions(+), 8 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/39043 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2803cc160fcd4ab31b8bb8c4298e9307ef534802 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: add Cinder DiskStorageType to enums
by derez＠redhat.com 24 Mar '15

24 Mar '15

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: add Cinder DiskStorageType to enums ...................................................................... webadmin: add Cinder DiskStorageType to enums Adding CINDER DiskStorageType to enums.java/properties. Change-Id: Iff15df38d154f23578bf6a5c71c98111daaf3ba4 Bug-Url: https://bugzilla.redhat.com/1185826 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Enums.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/Enums.properties 2 files changed, 3 insertions(+), 0 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/39042 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iff15df38d154f23578bf6a5c71c98111daaf3ba4 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: AddDiskCommand - extract addManagedDevice to a method
by derez＠redhat.com 24 Mar '15

24 Mar '15

Daniel Erez has submitted this change and it was merged. Change subject: core: AddDiskCommand - extract addManagedDevice to a method ...................................................................... core: AddDiskCommand - extract addManagedDevice to a method Extract VmDeviceUtils.addManagedDevice to a method in AddDiskCommand/AddCinderDiskCommand. Change-Id: I6e8f4eaeddc4bec08a5dd509054d357f03670445 Bug-Url: https://bugzilla.redhat.com/1185826 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddCinderDiskCommand.java 2 files changed, 14 insertions(+), 27 deletions(-) Approvals: Daniel Erez: Verified Maor Lipchuk: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/39063 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6e8f4eaeddc4bec08a5dd509054d357f03670445 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0