March 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: aaa: Fix LogoutSessionCommand
by oourfali＠redhat.com 10 Mar '15

10 Mar '15

Oved Ourfali has submitted this change and it was merged. Change subject: aaa: Fix LogoutSessionCommand ...................................................................... aaa: Fix LogoutSessionCommand 1. Provides missing constructor LogoutSessionCommand(VdcActionParametersBase, CommandContext) 2. Adds canDoAction() to suppress execution of the command when sessionId has already been terminated Change-Id: Ib3d799973e7d136d1375813691f9311eae35592a Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/LogoutSessionCommand.java 1 file changed, 11 insertions(+), 1 deletion(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Martin Peřina: Verified Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/38540 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib3d799973e7d136d1375813691f9311eae35592a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: Add sessions main tab
by oourfali＠redhat.com 10 Mar '15

10 Mar '15

Oved Ourfali has submitted this change and it was merged. Change subject: webadmin: Add sessions main tab ...................................................................... webadmin: Add sessions main tab Add sessions main tab with ability to see list of active session and to terminate them. The can be selected through the system tree. Change-Id: Ide80e57411ff075f26cba84cc8a952a05343fdd6 Bug-Url: https://bugzilla.redhat.com/1025796 Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/SearchBackend.gwt.xml M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/help/HelpTag.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/CommonModel.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/SessionListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/SystemTreeItemType.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/SystemTreeModel.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/TerminateSessionsModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/place/WebAdminApplicationPlaces.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java M frontend/webadmin/modules/webadmin/exclude-filters.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/ClientGinjectorExtension.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/PresenterModule.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/UiCommonModule.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/SessionModule.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/AbstractMainTabWithDetailsPresenter.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/MainTabSessionPresenter.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabSessionView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/tree/SystemTreeItemCell.java 20 files changed, 507 insertions(+), 7 deletions(-) Approvals: Martin Peřina: Verified Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/38384 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ide80e57411ff075f26cba84cc8a952a05343fdd6 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: define auto-completion for EngineSession objects
by oourfali＠redhat.com 10 Mar '15

10 Mar '15

Oved Ourfali has submitted this change and it was merged. Change subject: engine: define auto-completion for EngineSession objects ...................................................................... engine: define auto-completion for EngineSession objects Define auto-completion for EngineSession objects. Change-Id: I187848874a509c7f26ae7a0ddf5dc18540107d5c Bug-Url: https://bugzilla.redhat.com/1025796 Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SearchObjectAutoCompleter.java M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SearchObjects.java A backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SessionConditionFieldAutoCompleter.java M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SyntaxContainer.java 4 files changed, 49 insertions(+), 0 deletions(-) Approvals: Martin Peřina: Verified Oved Ourfali: Looks good to me, approved Yevgeny Zaspitsky: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/38383 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I187848874a509c7f26ae7a0ddf5dc18540107d5c Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <wallaroo1976(a)gmail.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: add TerminateSession command
by oourfali＠redhat.com 10 Mar '15

10 Mar '15

Oved Ourfali has submitted this change and it was merged. Change subject: engine: add TerminateSession command ...................................................................... engine: add TerminateSession command Add TerminateSession command. Change-Id: Iebdc71abbd51d2eb01b2b3d9c877626d57d68d23 Bug-Url: https://bugzilla.redhat.com/1025796 Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Signed-off-by: Martin Perina <mperina(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/TerminateSessionCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/TerminateSessionParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 5 files changed, 106 insertions(+), 0 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Martin Peřina: Verified Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/38382 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iebdc71abbd51d2eb01b2b3d9c877626d57d68d23 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <wallaroo1976(a)gmail.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Add SessionDataContainer.getSessionIdBySeqId method
by oourfali＠redhat.com 10 Mar '15

10 Mar '15

Oved Ourfali has submitted this change and it was merged. Change subject: engine: Add SessionDataContainer.getSessionIdBySeqId method ...................................................................... engine: Add SessionDataContainer.getSessionIdBySeqId method Adds engineSessionId into SessionInfo instance and SessionDataContainer.getSessionIdBySeqId method to get engineSessionId by its database id. Change-Id: I4069c594a553c45869bf45cfa680da4c1b65dabb Bug-Url: https://bugzilla.redhat.com/1025796 Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/SessionDataContainer.java 1 file changed, 13 insertions(+), 1 deletion(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Martin Peřina: Verified Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/38380 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4069c594a553c45869bf45cfa680da4c1b65dabb Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: tools: Validate WebSocketProxy config value
by emesika＠redhat.com 10 Mar '15

10 Mar '15

Eli Mesika has submitted this change and it was merged. Change subject: tools: Validate WebSocketProxy config value ...................................................................... tools: Validate WebSocketProxy config value Change-Id: I84b02d25a15762ba24544bd678328e6532d360ac Bug-Url: https://bugzilla.redhat.com/1184164 Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com> --- A backend/manager/tools/src/main/java/org/ovirt/engine/core/config/entity/helper/WebSocketProxyLocationValueHelper.java A backend/manager/tools/src/test/java/org/ovirt/engine/core/config/entity/helper/WebSocketProxyLocationValueHelperTest.java M packaging/etc/engine-config/engine-config.properties 3 files changed, 135 insertions(+), 1 deletion(-) Approvals: Martin Peřina: Looks good to me, but someone else must approve Eli Mesika: Verified; Looks good to me, approved Frank Kobzik: Verified -- To view, visit https://gerrit.ovirt.org/37498 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I84b02d25a15762ba24544bd678328e6532d360ac Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5.2]: core: adding missing action group
by tnisan＠redhat.com 10 Mar '15

10 Mar '15

Tal Nisan has submitted this change and it was merged. Change subject: core: adding missing action group ...................................................................... core: adding missing action group Adding missing DISK_LIVE_STORAGE_MIGRATION key to LocalizedEnums Change-Id: I4be8a3e779bab3da00d9954488c0fedb48c8a50e Bug-Url: https://bugzilla.redhat.com/1199812 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/LocalizedEnums.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties 2 files changed, 3 insertions(+), 0 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/38507 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4be8a3e779bab3da00d9954488c0fedb48c8a50e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5.2 Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-hosted-engine-ha[master]: Fix PEP8 issues introduced by update to pep8 1.6.2
by msivak＠redhat.com 10 Mar '15

10 Mar '15

Martin Sivák has submitted this change and it was merged. Change subject: Fix PEP8 issues introduced by update to pep8 1.6.2 ...................................................................... Fix PEP8 issues introduced by update to pep8 1.6.2 Change-Id: I6bb1256fca8fe50259b95531fa14eb33da68c19d Signed-off-by: Martin Sivak <msivak(a)redhat.com> --- M build/python.inc M ovirt_hosted_engine_ha/agent/state_data.py M ovirt_hosted_engine_ha/agent/state_data_test.py M ovirt_hosted_engine_ha/agent/state_machine.py M ovirt_hosted_engine_ha/agent/states.py M ovirt_hosted_engine_ha/broker/notifications.py M ovirt_hosted_engine_ha/broker/storage_broker.py M ovirt_hosted_engine_ha/client/client.py M ovirt_hosted_engine_ha/lib/fsm/__init__.py M ovirt_hosted_engine_ha/lib/fsm/machine.py M ovirt_hosted_engine_ha/lib/monotonic.py M ovirt_hosted_engine_ha/lib/storage_backends.py M ovirt_hosted_engine_ha/lib/storage_backends_test.py 13 files changed, 37 insertions(+), 37 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Martin Sivák: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/38496 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6bb1256fca8fe50259b95531fa14eb33da68c19d Gerrit-PatchSet: 3 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-ha[master]: Correct corrupted block 0 when setting global maintenance
by msivak＠redhat.com 10 Mar '15

10 Mar '15

Martin Sivák has submitted this change and it was merged. Change subject: Correct corrupted block 0 when setting global maintenance ...................................................................... Correct corrupted block 0 when setting global maintenance There is a chance of traceback when global maintenance mode is being enabled or disabled and the global block (0) is corrupted. This fixes that and corrects the block format. Change-Id: I861efd082d13020c6d6425a772d07dd3eb254c7c Signed-off-by: Martin Sivak <msivak(a)redhat.com> --- M ovirt_hosted_engine_ha/client/client.py 1 file changed, 6 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Martin Sivák: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/38495 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I861efd082d13020c6d6425a772d07dd3eb254c7c Gerrit-PatchSet: 3 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-ha[master]: Lockspace reset tool support
by msivak＠redhat.com 10 Mar '15

10 Mar '15

Martin Sivák has submitted this change and it was merged. Change subject: Lockspace reset tool support ...................................................................... Lockspace reset tool support A new method is added to the Client class. reset_lockspace(force=False) This method connects to the broker, retrieves stats and verifies that all hosts reported stopped==True and that the HA cluster is in global maintenance mode. It then uses sanlock to reinitialize the lockspace used to protect agent id numbers. Change-Id: I1c9d1c329ad56f288aac50077411778f99d194f0 Signed-off-by: Martin Sivak <msivak(a)redhat.com> --- M ovirt_hosted_engine_ha/client/client.py 1 file changed, 47 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Martin Sivák: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/38494 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1c9d1c329ad56f288aac50077411778f99d194f0 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0