March 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: restapi: reconfigure values on import data Storage Domain.
by mlipchuk＠redhat.com 01 Mar '15

01 Mar '15

Maor Lipchuk has submitted this change and it was merged. Change subject: restapi: reconfigure values on import data Storage Domain. ...................................................................... restapi: reconfigure values on import data Storage Domain. Add the ability to set general fields such as name, description, comment and wipe after delete once a data storage domain is being imported. The rsdl.wsdl is already describe those fields as optional. Change-Id: I2ef7baa850bd6da08ae27d41ebe9e4ad525fbe9b Bug-Url: https://bugzilla.redhat.com/1195724 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainsResource.java 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Ori Liel: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/38244 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2ef7baa850bd6da08ae27d41ebe9e4ad525fbe9b Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-reports[ovirt-engine-reports-3.5]: build: post ovirt-engine-reports-3.5.2_rc
by ydary＠redhat.com 01 Mar '15

01 Mar '15

Yaniv Dary has submitted this change and it was merged. Change subject: build: post ovirt-engine-reports-3.5.2_rc ...................................................................... build: post ovirt-engine-reports-3.5.2_rc Change-Id: I2bc7af17869de4cbcdd4bc9ba79376d534064341 Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- M version.mak 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Shirly Radco: Verified Yaniv Dary: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/38181 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2bc7af17869de4cbcdd4bc9ba79376d534064341 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-reports Gerrit-Branch: ovirt-engine-reports-3.5 Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-reports[ovirt-engine-reports-3.5]: build: ovirt-engine-reports-3.5.2_rc
by ydary＠redhat.com 01 Mar '15

01 Mar '15

Yaniv Dary has submitted this change and it was merged. Change subject: build: ovirt-engine-reports-3.5.2_rc ...................................................................... build: ovirt-engine-reports-3.5.2_rc Change-Id: Ibb36729629400cdb09b1ff68e87b4fce4642bea2 Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- M version.mak 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Shirly Radco: Verified Yaniv Dary: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/38180 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibb36729629400cdb09b1ff68e87b4fce4642bea2 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-reports Gerrit-Branch: ovirt-engine-reports-3.5 Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-dwh[ovirt-engine-dwh-3.5]: build: ovirt-engine-dwh-3.5.2_rc
by ydary＠redhat.com 01 Mar '15

01 Mar '15

Yaniv Dary has submitted this change and it was merged. Change subject: build: ovirt-engine-dwh-3.5.2_rc ...................................................................... build: ovirt-engine-dwh-3.5.2_rc Change-Id: Id4cf514b96fd9392c2186b07601201c9dee15d30 Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- M version.mak 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Shirly Radco: Verified Yaniv Dary: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/38182 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id4cf514b96fd9392c2186b07601201c9dee15d30 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-dwh Gerrit-Branch: ovirt-engine-dwh-3.5 Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-dwh[ovirt-engine-dwh-3.5]: build: post ovirt-engine-dwh-3.5.2_rc
by ydary＠redhat.com 01 Mar '15

01 Mar '15

Yaniv Dary has submitted this change and it was merged. Change subject: build: post ovirt-engine-dwh-3.5.2_rc ...................................................................... build: post ovirt-engine-dwh-3.5.2_rc Change-Id: I67f41d0a6c6851332e7ce980cd78594ecfae3965 Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- M version.mak 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Shirly Radco: Verified Yaniv Dary: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/38183 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I67f41d0a6c6851332e7ce980cd78594ecfae3965 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-dwh Gerrit-Branch: ovirt-engine-dwh-3.5 Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: backend: print exception when uncought
by oourfali＠redhat.com 01 Mar '15

01 Mar '15

Oved Ourfali has submitted this change and it was merged. Change subject: backend: print exception when uncought ...................................................................... backend: print exception when uncought probably missing {} but better to dump stacktrace in this case. Change-Id: I428fa86c0bcbda39033bc62bd5c193187e3fef7e Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Alon Bar-Lev: Verified Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/38207 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I428fa86c0bcbda39033bc62bd5c193187e3fef7e Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5.2]: aaa : process initialization errors
by oourfali＠redhat.com 01 Mar '15

01 Mar '15

Oved Ourfali has submitted this change and it was merged. Change subject: aaa : process initialization errors ...................................................................... aaa : process initialization errors During initialization we should print and ignore exceptions from the built-in providers. At EngineExtensionsLoader each time load() or initialize() is called, there should be a try/catch to show potentials errors. same for the entry engineInitialize(). Change-Id: I63265947ff066857db19d2534628d46f01b9f2e9 Bug-Url: https://bugzilla.redhat.com/1194410 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/extensionsmgr/EngineExtensionsManager.java 2 files changed, 52 insertions(+), 8 deletions(-) Approvals: Alon Bar-Lev: Verified Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/38204 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I63265947ff066857db19d2534628d46f01b9f2e9 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5.2 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5]: aaa : process initialization errors
by oourfali＠redhat.com 01 Mar '15

01 Mar '15

Oved Ourfali has submitted this change and it was merged. Change subject: aaa : process initialization errors ...................................................................... aaa : process initialization errors During initialization we should print and ignore exceptions from the built-in providers. At EngineExtensionsLoader each time load() or initialize() is called, there should be a try/catch to show potentials errors. same for the entry engineInitialize(). Change-Id: I63265947ff066857db19d2534628d46f01b9f2e9 Bug-Url: https://bugzilla.redhat.com/1194410 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/extensionsmgr/EngineExtensionsManager.java 2 files changed, 52 insertions(+), 8 deletions(-) Approvals: Alon Bar-Lev: Verified Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/38203 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I63265947ff066857db19d2534628d46f01b9f2e9 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: Add fk constraint on vm_interface_statistics
by tnisan＠redhat.com 01 Mar '15

01 Mar '15

Tal Nisan has submitted this change and it was merged. Change subject: core: Add fk constraint on vm_interface_statistics ...................................................................... core: Add fk constraint on vm_interface_statistics Once a network interface is being removed from the Data Base its corresponding statistics data in _vm_interface_statistics should be removed also. Currently, when a Storge Domain is being detached from a Data Center, all the data related to it is being removed from the Data Base. Since there is no foreign key between vm_interface and vm_interface_statistics which does cascade delete there are left overs which are left in vm_interface_statistics although the vm_interface was deleted. also, remove redundant vm interface statistic without VM. Changing the test accordingly. Change-Id: I53cf2737ef91cf967c93990fcb237f6c4e12a8f8 Bug-Url: https://bugzilla.redhat.com/1197348 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/network/VmNetworkStatisticsDaoTest.java M backend/manager/modules/dal/src/test/resources/fixtures.xml A packaging/dbscripts/upgrade/03_05_1240_add_delete_contraint_vm_interface_statistics.sql 3 files changed, 6 insertions(+), 11 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/38243 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I53cf2737ef91cf967c93990fcb237f6c4e12a8f8 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: Add managed devices to OVF
by tnisan＠redhat.com 01 Mar '15

01 Mar '15

Tal Nisan has submitted this change and it was merged. Change subject: core: Add managed devices to OVF ...................................................................... core: Add managed devices to OVF Add all managed devices to the VM before generating the OVF for OVF_STORE disk. Change-Id: Ie0e912c9b2950f1461ae95f4704f18b818b83a3b Bug-Url: https://bugzilla.redhat.com/1197444 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/OvfUpdateProcessHelper.java 1 file changed, 3 insertions(+), 20 deletions(-) Approvals: Tal Nisan: Verified Allon Mureinik: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/38242 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie0e912c9b2950f1461ae95f4704f18b818b83a3b Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0