April 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.5-gluster]: engine: Added username to geo-rep commands
by sabose＠redhat.com 30 Apr '15

30 Apr '15

Sahina Bose has submitted this change and it was merged. Change subject: engine: Added username to geo-rep commands ...................................................................... engine: Added username to geo-rep commands To support non-root geo-rep session management Change-Id: I3fcdc7c29abb88916eacc048f2708ea68540134a Signed-off-by: Sahina Bose <sabose(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/DeleteGeoRepSessionCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/PauseGlusterVolumeGeoRepSessionCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/ResetDefaultGeoRepConfigCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/ResumeGeoRepSessionCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/SetGeoRepConfigCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/StartGlusterVolumeGeoRepCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/StopGeoRepSessionCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/gluster/GlusterVolumeGeoRepConfigVdsParameters.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/DeleteGlusterVolumeGeoRepSessionVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GetGlusterVolumeGeoRepConfigListVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GetGlusterVolumeGeoRepSessionListVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GetGlusterVolumeGeoRepSessionStatusVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/PauseGlusterVolumeGeoRepSessionVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/ResumeGeoRepSessionVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/SetGlusterVolumeGeoRepConfigDefaultVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/SetGlusterVolumeGeoRepConfigVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/StartGlusterVolumeGeoRepVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/StopGlusterVolumeGeoRepSessionVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerConnector.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerWrapper.java 22 files changed, 370 insertions(+), 141 deletions(-) Approvals: Sahina Bose: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/40455 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3fcdc7c29abb88916eacc048f2708ea68540134a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5-gluster Gerrit-Owner: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5-gluster]: engine, webadmin: Show RDMA port if present
by sabose＠redhat.com 30 Apr '15

30 Apr '15

Sahina Bose has submitted this change and it was merged. Change subject: engine,webadmin: Show RDMA port if present ...................................................................... engine,webadmin: Show RDMA port if present If volume supports RDMA transport, then the details view needs to support displaying the RDMA port values. Change-Id: I4cfc22a9bc6461b31a50ffe1c1350bf827802570 Signed-off-by: Sahina Bose <sabose(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/BrickProperties.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterServerService.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GlusterVolumeStatusReturnForXmlRpc.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/BrickPropertiesModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/BrickAdvancedDetailsPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/BrickAdvancedDetailsPopupView.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/cluster/SubTabClusterServiceView.java 8 files changed, 78 insertions(+), 9 deletions(-) Approvals: Sahina Bose: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/40454 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4cfc22a9bc6461b31a50ffe1c1350bf827802570 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5-gluster Gerrit-Owner: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5-gluster]: webadmin: Add an indicator if volume snapshot is scheduled
by sabose＠redhat.com 30 Apr '15

30 Apr '15

Sahina Bose has submitted this change and it was merged. Change subject: webadmin: Add an indicator if volume snapshot is scheduled ...................................................................... webadmin: Add an indicator if volume snapshot is scheduled Added an indicator column to volume tab, to indicate if volume snapshot creation is scheduled. Change-Id: I4ea607285caaa343c389813681bd9e782381ae86 Signed-off-by: Shubhendu Tripathi <shtripat(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationResources.java A frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/images/snapshot_scheduled.png M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabVolumeView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/cell/VolumeInfoCell.java 5 files changed, 13 insertions(+), 13 deletions(-) Approvals: Shubhendu Tripathi: Verified Sahina Bose: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/40410 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4ea607285caaa343c389813681bd9e782381ae86 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5-gluster Gerrit-Owner: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5-gluster]: engine, webadmin: Add an indicator if geo-replication is enabled
by sabose＠redhat.com 30 Apr '15

30 Apr '15

Sahina Bose has submitted this change and it was merged. Change subject: engine,webadmin: Add an indicator if geo-replication is enabled ...................................................................... engine,webadmin: Add an indicator if geo-replication is enabled Added an indicator column to Volume tab, to indicate if a volume is a geo-replication master or slave Change-Id: I28178b8ef03ea7cc83097cb99bc2d2be90061434 Signed-off-by: Sahina Bose <sabose(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterVolumeEntity.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterVolumeDaoDbFacadeImpl.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationResources.java A frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/images/volume_georep_master.png A frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/images/volume_georep_slave.png M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationMessages.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabVolumeView.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/cell/VolumeInfoCell.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/VolumeInfoColumn.java M packaging/dbscripts/create_views.sql 11 files changed, 134 insertions(+), 3 deletions(-) Approvals: Sahina Bose: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/40409 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I28178b8ef03ea7cc83097cb99bc2d2be90061434 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5-gluster Gerrit-Owner: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5.3]: core: Check attached VMs snapshot status when moving a disk
by tnisan＠redhat.com 30 Apr '15

30 Apr '15

Tal Nisan has submitted this change and it was merged. Change subject: core: Check attached VMs snapshot status when moving a disk ...................................................................... core: Check attached VMs snapshot status when moving a disk Change-Id: I80feffc9f11aed1bc8fa7a6f80562d05ce815c56 Bug-Url: https://bugzilla.redhat.com/1211330 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyDiskCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/MoveOrCopyDiskCommandTest.java 2 files changed, 61 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Verified Allon Mureinik: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/40444 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I80feffc9f11aed1bc8fa7a6f80562d05ce815c56 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5.3 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: Check attached VMs snapshot status when moving a disk
by tnisan＠redhat.com 30 Apr '15

30 Apr '15

Tal Nisan has submitted this change and it was merged. Change subject: core: Check attached VMs snapshot status when moving a disk ...................................................................... core: Check attached VMs snapshot status when moving a disk Change-Id: I80feffc9f11aed1bc8fa7a6f80562d05ce815c56 Bug-Url: https://bugzilla.redhat.com/1211330 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyDiskCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/MoveOrCopyDiskCommandTest.java 2 files changed, 59 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Verified Allon Mureinik: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/40443 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I80feffc9f11aed1bc8fa7a6f80562d05ce815c56 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5-gluster]: engine, webadmin: use slave host id instead of slave host name
by sabose＠redhat.com 30 Apr '15

30 Apr '15

Sahina Bose has submitted this change and it was merged. Change subject: engine, webadmin: use slave host id instead of slave host name ...................................................................... engine, webadmin: use slave host id instead of slave host name The canDoAction of create georep session command checks if host is monitored by engine and tries to get host based on the passed host details. Previously,this used to be obtained using host name and UI used to pass the host name which is VDS#getName but the backend expected dns resolvable name which is provided by VDS#getHostName. The UI can't pass VDS#getHostName because its not available in there. The UI lists vds as obtained from the bricks of eligible/non-eligible volumes. The volume can provide only brick servernames and server ids. So, its better to obtain vds based on its id rather than on name. The above reasons required this change to be introduced. Change-Id: I4440eddbc2616c7ca89feaae3ba0e67d93562213 Signed-off-by: Anmol Babu <anbabu(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/CreateGlusterVolumeGeoRepSessionCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GeoRepSessionCommandBase.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/CreateGlusterVolumeGeoRepSessionCommandTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/gluster/GlusterVolumeGeoRepSessionParameters.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterGeoRepDao.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterGeoRepDaoDbFacadeImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/gluster/GlusterGeoRepDaoTest.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/GlusterVolumeGeoRepCreateModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeGeoRepListModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/GlusterVolumeGeoRepCreateSessionPopupView.java M packaging/dbscripts/gluster_georep_sp.sql 11 files changed, 53 insertions(+), 48 deletions(-) Approvals: Eli Mesika: Looks good to me, but someone else must approve anmolbabu: Verified Sahina Bose: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/40417 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4440eddbc2616c7ca89feaae3ba0e67d93562213 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5-gluster Gerrit-Owner: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5-gluster]: webadmin: Show geo-rep user name in view
by sabose＠redhat.com 30 Apr '15

30 Apr '15

Sahina Bose has submitted this change and it was merged. Change subject: webadmin: Show geo-rep user name in view ...................................................................... webadmin: Show geo-rep user name in view With non-root geo-rep user, we need to display the user name in the list view. Adding this in the patch. Change-Id: I0b37a23d637158815b3b3265b2a016f10effc6d9 Signed-off-by: Sahina Bose <sabose(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/gluster/SubTabVolumeGeoRepView.java 2 files changed, 10 insertions(+), 0 deletions(-) Approvals: Sahina Bose: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/40452 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0b37a23d637158815b3b3265b2a016f10effc6d9 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5-gluster Gerrit-Owner: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5-gluster]: engine: Added username to georep session
by sabose＠redhat.com 30 Apr '15

30 Apr '15

Sahina Bose has submitted this change and it was merged. Change subject: engine: Added username to georep session ...................................................................... engine: Added username to georep session Geo-rep session supports non root user as well now, hence adding the username to georep session entity Updated the commands to use this property Change-Id: I5015c11891600c8e44710fc45c43cfcca8da941c Signed-off-by: Sahina Bose <sabose(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterGeoRepSession.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterGeoRepDaoDbFacadeImpl.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GlusterVolumeGeoRepStatusForXmlRpc.java M packaging/dbscripts/create_views.sql M packaging/dbscripts/gluster_georep_sp.sql A packaging/dbscripts/upgrade/03_05_1440_add_username_column_to_georep_session.sql 6 files changed, 24 insertions(+), 5 deletions(-) Approvals: Sahina Bose: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/40450 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5015c11891600c8e44710fc45c43cfcca8da941c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5-gluster Gerrit-Owner: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5.3]: core: Add Africa/Algiers Time Zone
by tnisan＠redhat.com 30 Apr '15

30 Apr '15

Tal Nisan has submitted this change and it was merged. Change subject: core: Add Africa/Algiers Time Zone ...................................................................... core: Add Africa/Algiers Time Zone Change-Id: Ia573080ed2a145c4198cb72985b1185cd3f78223 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1210633 Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/TimeZoneType.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Martin Betak: Verified -- To view, visit https://gerrit.ovirt.org/40384 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia573080ed2a145c4198cb72985b1185cd3f78223 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5.3 Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0