May 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: engine: Avoid static access to DbFacade from VdsManager
by masayag＠redhat.com 19 May '15

19 May '15

Moti Asayag has submitted this change and it was merged. Change subject: engine: Avoid static access to DbFacade from VdsManager ...................................................................... engine: Avoid static access to DbFacade from VdsManager Change-Id: Ie76e5e3c8f66287200c28d2afc9a51d3961cc244 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/ResourceManager.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java 2 files changed, 24 insertions(+), 25 deletions(-) Approvals: Maor Lipchuk: Looks good to me, approved Moti Asayag: Verified -- To view, visit https://gerrit.ovirt.org/40939 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie76e5e3c8f66287200c28d2afc9a51d3961cc244 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <wallaroo1976(a)gmail.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: engine: Inject DAOs to ResourceManager
by masayag＠redhat.com 19 May '15

19 May '15

Moti Asayag has submitted this change and it was merged. Change subject: engine: Inject DAOs to ResourceManager ...................................................................... engine: Inject DAOs to ResourceManager Change-Id: I1ce6d4b10514997578abf3cce91833d5a531dc10 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/ResourceManager.java 1 file changed, 34 insertions(+), 10 deletions(-) Approvals: Moti Asayag: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/40938 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1ce6d4b10514997578abf3cce91833d5a531dc10 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <wallaroo1976(a)gmail.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: engine: Avoid static access to ResourceManager from HostMoni...
by masayag＠redhat.com 19 May '15

19 May '15

Moti Asayag has submitted this change and it was merged. Change subject: engine: Avoid static access to ResourceManager from HostMonitoring ...................................................................... engine: Avoid static access to ResourceManager from HostMonitoring This allow to mock the ResourceManager easily in tests and avoids the use of deprecated functionality. Change-Id: I38e3e08c5d502ce4139df2a2f7c46ff0d0503378 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/HostMonitoring.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/HostMonitoringTest.java 3 files changed, 11 insertions(+), 13 deletions(-) Approvals: Moti Asayag: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/40937 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I38e3e08c5d502ce4139df2a2f7c46ff0d0503378 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <wallaroo1976(a)gmail.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: engine: Delete EventMap* classes
by masayag＠redhat.com 19 May '15

19 May '15

Moti Asayag has submitted this change and it was merged. Change subject: engine: Delete EventMap* classes ...................................................................... engine: Delete EventMap* classes Those classes are an ancient history from the previous step of notification service's evolution and are no longer in use. Change-Id: Ied050f97a1e3c8497011d9cd1348f940f5d877d1 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/EventMap.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/EventMapId.java 2 files changed, 0 insertions(+), 70 deletions(-) Approvals: Eli Mesika: Looks good to me, approved mooli tayer: Looks good to me, but someone else must approve Moti Asayag: Verified -- To view, visit https://gerrit.ovirt.org/40944 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ied050f97a1e3c8497011d9cd1348f940f5d877d1 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Mooli Tayer <mtayer(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Logging a renamed entity only on success
by masayag＠redhat.com 19 May '15

19 May '15

Moti Asayag has submitted this change and it was merged. Change subject: engine: Logging a renamed entity only on success ...................................................................... engine: Logging a renamed entity only on success If the command failed, the update command is failed and rollbacked, hence no 'renamed-entity' event occurred. Logging an event for 'renamed-entity' is required only if the command has ended successfully. Change-Id: I99d9db3654e4ec8f765fc9097827488a4f0e252a Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java 1 file changed, 6 insertions(+), 2 deletions(-) Approvals: Eli Mesika: Looks good to me, approved Omer Frenkel: Looks good to me, approved Moti Asayag: Verified -- To view, visit https://gerrit.ovirt.org/40945 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I99d9db3654e4ec8f765fc9097827488a4f0e252a Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: packaging: engine-backup: Fix for postgresql 8
by sbonazzo＠redhat.com 19 May '15

19 May '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: engine-backup: Fix for postgresql 8 ...................................................................... packaging: engine-backup: Fix for postgresql 8 pg_cmd used to always pass '-d database' to all pg commands. This breaks on postgresql8's pg_dump, which only accepts the database name as a non-option argument. Change-Id: Ia1164822326ad117e960309f914450b4eefb2c98 Bug-Url: https://bugzilla.redhat.com/1222553 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/bin/engine-backup.sh 1 file changed, 9 insertions(+), 1 deletion(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Looks good to me, but someone else must approve Yedidyah Bar David: Verified -- To view, visit https://gerrit.ovirt.org/41118 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia1164822326ad117e960309f914450b4eefb2c98 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin, userportal: Prevent blank template sub-templates
by tjelinek＠redhat.com 19 May '15

19 May '15

Tomas Jelinek has submitted this change and it was merged. Change subject: webadmin, userportal: Prevent blank template sub-templates ...................................................................... webadmin, userportal: Prevent blank template sub-templates Frontend part Change-Id: I6b35a0f1b79a22ad25a26bb57acf5f5c68cf79c6 Bug-Url: https://bugzilla.redhat.com/1205813 Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> --- M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewTemplateVmModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UserPortalNewTemplateVmModelBehavior.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 6 files changed, 52 insertions(+), 13 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Jakub Niedermertl: Verified -- To view, visit https://gerrit.ovirt.org/40500 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6b35a0f1b79a22ad25a26bb57acf5f5c68cf79c6 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: packaging: engine-backup: log postgres commands
by sbonazzo＠redhat.com 19 May '15

19 May '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: engine-backup: log postgres commands ...................................................................... packaging: engine-backup: log postgres commands Log postgres commands (pg_dump, psql) stdout/stderr directly to main log if we do not parse them, instead of using a temporary log and appending it. If we do parse them, do not die on error before appending to main log. Bug-Url: https://bugzilla.redhat.com/1222554 Change-Id: Ic45bdf97523a8a5ce1edcf03af8876414b9302ec Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/bin/engine-backup.sh 1 file changed, 14 insertions(+), 20 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Looks good to me, but someone else must approve Jenkins CI: Looks good to me, but someone else must approve Yedidyah Bar David: Verified -- To view, visit https://gerrit.ovirt.org/41117 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic45bdf97523a8a5ce1edcf03af8876414b9302ec Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: engine, webadmin: Corrected action and type values
by sabose＠redhat.com 19 May '15

19 May '15

Sahina Bose has submitted this change and it was merged. Change subject: engine, webadmin: Corrected action and type values ...................................................................... engine, webadmin: Corrected action and type values Corrected action and type values for gluster volume snapshot configuration case. Change-Id: I3fe24a150c49129cba904b4613fdc9146dc96e1f Signed-off-by: Shubhendu Tripathi <shtripat(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/UpdateGlusterVolumeSnapshotConfigCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 5 files changed, 10 insertions(+), 3 deletions(-) Approvals: Jenkins CI: Looks good to me, but someone else must approve Shubhendu Tripathi: Verified Einav Cohen: Looks good to me, approved Sahina Bose: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/40899 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3fe24a150c49129cba904b4613fdc9146dc96e1f Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-release[master]: 3.5 - gluster: add userspace-rcu from EPEL
by sbonazzo＠redhat.com 19 May '15

19 May '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: 3.5 - gluster: add userspace-rcu from EPEL ...................................................................... 3.5 - gluster: add userspace-rcu from EPEL Gluster 3.7.0 has been released and is hitting 3.5 existing deployments requiring userspace-rcu from EPEL. Change-Id: I5edb767b1d7521d1babcd59e7169629db8995802 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> Reported-By: Stefano Danzi <s.danzi(a)hawai.it> --- M ovirt-release-3.5/configure.ac M ovirt-release-3.5/ovirt-el6-deps.repo.in M ovirt-release-3.5/ovirt-el7-deps.repo.in M ovirt-release-3.5/ovirt-release35.spec.in 4 files changed, 17 insertions(+), 10 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/41114 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5edb767b1d7521d1babcd59e7169629db8995802 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-release Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0