May 2015 - Engine-commits - oVirt List Archives

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.2]: packaging: setup: always storing HOST_ID as an int
by sbonazzo＠redhat.com 13 May '15

13 May '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: always storing HOST_ID as an int ...................................................................... packaging: setup: always storing HOST_ID as an int always storing HOST_ID as an int Change-Id: Ie3585bda2704c8ef50899874b7e76648c27792aa Bug-Url: https://bugzilla.redhat.com/1221290 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M src/plugins/ovirt-hosted-engine-setup/storage/storage.py 1 file changed, 12 insertions(+), 9 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified -- To view, visit https://gerrit.ovirt.org/40846 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie3585bda2704c8ef50899874b7e76648c27792aa Gerrit-PatchSet: 2 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-1.2 Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-hosted-engine-setup[master]: packaging: setup: always storing HOST_ID as an int
by sbonazzo＠redhat.com 13 May '15

13 May '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: always storing HOST_ID as an int ...................................................................... packaging: setup: always storing HOST_ID as an int always storing HOST_ID as an int Change-Id: Ie3585bda2704c8ef50899874b7e76648c27792aa Bug-Url: https://bugzilla.redhat.com/1216172 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M src/plugins/ovirt-hosted-engine-setup/storage/storage.py 1 file changed, 13 insertions(+), 10 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified -- To view, visit https://gerrit.ovirt.org/40778 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie3585bda2704c8ef50899874b7e76648c27792aa Gerrit-PatchSet: 4 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: Introduce a column for additional host statuses
by masayag＠redhat.com 13 May '15

13 May '15

Moti Asayag has submitted this change and it was merged. Change subject: webadmin: Introduce a column for additional host statuses ...................................................................... webadmin: Introduce a column for additional host statuses The new column will be used to present the additional host statuses, such as updates available and external events. The current patch adds the 'update available' icon, when an upgrade is available for hosts. Change-Id: I5797668b9875b5b4b90aa4dfb992b5cd15ccdb2c Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationResources.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationTemplates.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabHostView.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/cell/HostAdditionalStatusCell.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/HostAdditionalStatusColumn.java A frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/update_available.png 7 files changed, 87 insertions(+), 2 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/40635 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5797668b9875b5b4b90aa4dfb992b5cd15ccdb2c Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: Clear warnings
by masayag＠redhat.com 13 May '15

13 May '15

Moti Asayag has submitted this change and it was merged. Change subject: webadmin: Clear warnings ...................................................................... webadmin: Clear warnings Change-Id: I6d2f597f89a91765035c6a22b24dceaf94d3c5ba Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/InstallModel.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Alona Kaplan: Looks good to me, approved Moti Asayag: Verified Oved Ourfali: Looks good to me, but someone else must approve Objections: Jenkins CI: Fails -- To view, visit https://gerrit.ovirt.org/40634 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6d2f597f89a91765035c6a22b24dceaf94d3c5ba Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-reports[ovirt-engine-reports-3.5]: build: post ovirt-engine-reports-3.5.3_rc
by sradco＠redhat.com 13 May '15

13 May '15

Shirly Radco has submitted this change and it was merged. Change subject: build: post ovirt-engine-reports-3.5.3_rc ...................................................................... build: post ovirt-engine-reports-3.5.3_rc Change-Id: Ic25f50db9de9e08a1a17ee14b4e4bbc1ee3e96c2 Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- M version.mak 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Shirly Radco: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/40885 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic25f50db9de9e08a1a17ee14b4e4bbc1ee3e96c2 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-reports Gerrit-Branch: ovirt-engine-reports-3.5 Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-reports[ovirt-engine-reports-3.5]: build: ovirt-engine-reports-3.5.3_rc
by sradco＠redhat.com 13 May '15

13 May '15

Shirly Radco has submitted this change and it was merged. Change subject: build: ovirt-engine-reports-3.5.3_rc ...................................................................... build: ovirt-engine-reports-3.5.3_rc Change-Id: Ic63ae9f70199c5f8ccccc222bab5082372e853d9 Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- M ovirt-engine-reports.spec.in M version.mak 2 files changed, 6 insertions(+), 3 deletions(-) Approvals: Shirly Radco: Verified; Looks good to me, approved Jenkins CI: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/40884 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic63ae9f70199c5f8ccccc222bab5082372e853d9 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-reports Gerrit-Branch: ovirt-engine-reports-3.5 Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: make EventQueue a CDI Singleton, dump jndi
by rgolan＠redhat.com 13 May '15

13 May '15

Roy Golan has submitted this change and it was merged. Change subject: core: make EventQueue a CDI Singleton, dump jndi ...................................................................... core: make EventQueue a CDI Singleton, dump jndi - EventQueueMonitor is now a Singleton bean till now it was an EJB so we can lookup it. It used the tangled EjbStrategy* to get the dependency replaced in test time. This is not needed anymore when using CDI - drop jndi usage and use CDI instead instead of doing a jndi lookup all instances could be injected info beans. Change-Id: I966e995dd10b93d968cec135f10ab55f1bd729a7 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitVdsOnUpCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsEventListener.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/eventqueue/EventQueueMonitor.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ActivateStorageDomainCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DeactivateStorageDomainCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RecoveryStoragePoolCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageDomainCommandBase.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/DeactivateStorageDomainCommandTest.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsProxyData.java 10 files changed, 78 insertions(+), 75 deletions(-) Approvals: Roy Golan: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/40642 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I966e995dd10b93d968cec135f10ab55f1bd729a7 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Dudi Maroshi <dudi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: GuideMe can't activate hosts
by oourfali＠redhat.com 13 May '15

13 May '15

Oved Ourfali has submitted this change and it was merged. Change subject: webadmin: GuideMe can't activate hosts ...................................................................... webadmin: GuideMe can't activate hosts Add check-box for host activation directly from DataCenter/Cluster GuideMe dialog. Change-Id: I983ad2c714ff945541de5f0b0d6f95e524f7edbc Bug-Url: https://bugzilla.redhat.com/1098603 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/GuideModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterGuideModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterGuideModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/MoveHost.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/MoveHostData.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmGuideModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/guide/MoveHostPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/guide/MoveHostPopupView.ui.xml 9 files changed, 277 insertions(+), 50 deletions(-) Approvals: Ravi Nori: Verified Alexander Wels: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/39992 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I983ad2c714ff945541de5f0b0d6f95e524f7edbc Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Save graphics devices when VM is running
by ofrenkel＠redhat.com 13 May '15

13 May '15

Omer Frenkel has submitted this change and it was merged. Change subject: core: Save graphics devices when VM is running ...................................................................... core: Save graphics devices when VM is running Added support of saving of VM's graphics devices for the next run if VM properties are edited when it is running. Notification to user is displayed as well. Added @EditableDeviceOnVmStatusField annotation to VmManagementParametersBase.graphicsDevices field and extended the @EditableDeviceOnVmStatusField annotation to support fields of VmDevice and Map type in addition to Boolean. Also added missing functionality in ProcessDownVmCommand and InstanceTypeManager to restore graphics devices. Change-Id: I9cce664ae9fafe2713c014a95b4569b8c7e45f8e Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1210382 Signed-off-by: Shmuel Melamud <smelamud(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmChangedFieldsForNextRunQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ProcessDownVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VmManagementParametersBase.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/VmDeviceUpdate.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/instancetypes/InstanceTypeManager.java 7 files changed, 269 insertions(+), 77 deletions(-) Approvals: Tomas Jelinek: Looks good to me, but someone else must approve Jenkins CI: Looks good to me, but someone else must approve Shmuel Leib Melamud: Verified Omer Frenkel: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/40037 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9cce664ae9fafe2713c014a95b4569b8c7e45f8e Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Shmuel Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: Removed unused variable
by masayag＠redhat.com 13 May '15

13 May '15

Moti Asayag has submitted this change and it was merged. Change subject: webadmin: Removed unused variable ...................................................................... webadmin: Removed unused variable Change-Id: I6f8892245b1f02d94d3582274cd8f043af936a82 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/InstallModel.java 1 file changed, 0 insertions(+), 4 deletions(-) Approvals: Alona Kaplan: Looks good to me, approved Moti Asayag: Verified Oved Ourfali: Looks good to me, but someone else must approve Objections: Jenkins CI: Fails -- To view, visit https://gerrit.ovirt.org/40633 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6f8892245b1f02d94d3582274cd8f043af936a82 Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0