June 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: restapi: Vm Icons - REST part
by juan.hernandez＠redhat.com 18 Jun '15

18 Jun '15

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Vm Icons - REST part ...................................................................... restapi: Vm Icons - REST part * /icons and /icons/{id} read-only collection of all available icons * /operatingsystems/{id} <small_icon>, <large_icon> added, references to default icon pair operating system * /vms/{id} <small_icon>, <large_icon> added, references to icons of vm. They be updated/created separately using PUT/POST of icon id, or by PUT/POST data of large icon, new icon can by assigned. * /templates/{id} similar as /vms/{id} Change-Id: I9599565257e1e9d3e6293931fa35a7ad6f5a5f52 Bug-Url: https://bugzilla.redhat.com/1103175 Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> --- A backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/IconResource.java A backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/IconsResource.java M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/utils/ApiRootLinksCreator.java M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/utils/LinkHelper.java M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd M backend/manager/modules/restapi/interface/definition/src/main/resources/jyaml.yml M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/BackendApplication.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/logging/Messages.java A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendIconResource.java A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendIconsResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendOperatingSystemResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendOperatingSystemsResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendTemplateResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendTemplatesResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmsResource.java A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/util/IconHelper.java M backend/manager/modules/restapi/jaxrs/src/main/resources/org/ovirt/engine/api/restapi/logging/Messages.properties M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/AbstractBackendBaseTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendApiResourceTest.java A backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendIconResourceTest.java A backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendIconsResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendTemplateBasedResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendTemplateResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendTemplatesBasedResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendTemplatesResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmsResourceTest.java A backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/IconTestHelpler.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmBaseMapper.java A backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmIconMapper.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java 33 files changed, 917 insertions(+), 30 deletions(-) Approvals: Jakub Niedermertl: Verified Juan Hernandez: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/40655 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9599565257e1e9d3e6293931fa35a7ad6f5a5f52 Gerrit-PatchSet: 24 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: dont check vmManager timestamp if it wasnt set
by ofrenkel＠redhat.com 18 Jun '15

18 Jun '15

Omer Frenkel has submitted this change and it was merged. Change subject: core: dont check vmManager timestamp if it wasnt set ...................................................................... core: dont check vmManager timestamp if it wasnt set when engine starts, the first monitoring cycle will always skip the current running vms because the VmManager objects for them are created only after fetching the information from vdsm, so the time check will always fail. the check is changed to verify that some value has been set, and if not it considered ok to do the monitoring cycle. Change-Id: I6ced6416b4015b86aeb75371224ad68dc1f5b74c Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmManager.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmsMonitoring.java 2 files changed, 3 insertions(+), 4 deletions(-) Approvals: Jenkins CI: Passed CI tests Omer Frenkel: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/42497 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6ced6416b4015b86aeb75371224ad68dc1f5b74c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: send maxMemory and maxMemSlots only if hotplug memory ...
by ofrenkel＠redhat.com 18 Jun '15

18 Jun '15

Omer Frenkel has submitted this change and it was merged. Change subject: core: send maxMemory and maxMemSlots only if hotplug memory is supported ...................................................................... core: send maxMemory and maxMemSlots only if hotplug memory is supported in case new vdsm runs in old (< 3.6) cluster, the engine will send the new maxMemory and maxMemorySlots parameters on run vm, but these are not supported with old emulated machines, and will cause the run to fail. sending the new parameters only if hotplug memory is supported in the cluster. Change-Id: I194a4eee3736d0de842fcf3474a4f6f0580b6577 Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilderBase.java 1 file changed, 8 insertions(+), 6 deletions(-) Approvals: Jenkins CI: Passed CI tests Francesco Romani: Looks good to me, but someone else must approve Omer Frenkel: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/42499 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I194a4eee3736d0de842fcf3474a4f6f0580b6577 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-iso-uploader[refs/meta/config]: Add Abandon permission to ovirt-iso-uploader group
by dcaroest＠redhat.com 18 Jun '15

18 Jun '15

David Caro has submitted this change and it was merged. Change subject: Add Abandon permission to ovirt-iso-uploader group ...................................................................... Add Abandon permission to ovirt-iso-uploader group --- M project.config 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Sandro Bonazzola: Passed CI tests David Caro: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/42526 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia6b95d300497186977da706217015a54c9b80b71 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-iso-uploader Gerrit-Branch: refs/meta/config Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-iso-uploader[master]: ovirt-iso-uploader: Provide more informative error messages
by sbonazzo＠redhat.com 18 Jun '15

18 Jun '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: ovirt-iso-uploader: Provide more informative error messages ...................................................................... ovirt-iso-uploader: Provide more informative error messages The code was modified to provide more information on connection failures, so now more specific information will be available to users. Also some error logic was added to process request errors, that is errors that happen after the successful connection was established, e.g. bad authentication etc. Now we can provide specific messages based on the return code e.g. 401, 503 etc. Change-Id: Ib0c846a556d9658821e855567ca9688e7eb390c1 Signed-off-by: Lev Veyde <lveyde(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1182344 --- M src/__main__.py 1 file changed, 24 insertions(+), 7 deletions(-) Approvals: Lev Veyde: Verified Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/42519 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib0c846a556d9658821e855567ca9688e7eb390c1 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-iso-uploader Gerrit-Branch: master Gerrit-Owner: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: unregister secrets on deactivate Cinder storage domain
by derez＠redhat.com 18 Jun '15

18 Jun '15

Daniel Erez has submitted this change and it was merged. Change subject: core: unregister secrets on deactivate Cinder storage domain ...................................................................... core: unregister secrets on deactivate Cinder storage domain Invoke UnregisterLibvirtSecrets command on all hosts upon Cinder storage domain deactivation. Change-Id: I5cbe774859e5bc159300b21d0ea91a92ea9ff1cf Bug-Url: https://bugzilla.redhat.com/1185826 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/CINDERStorageHelper.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DeactivateStorageDomainCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageDomainCommandBase.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 5 files changed, 83 insertions(+), 0 deletions(-) Approvals: Daniel Erez: Verified Jenkins CI: Passed CI tests Maor Lipchuk: Looks good to me, approved Objections: Jenkins CI: I would prefer that you didn't submit this -- To view, visit https://gerrit.ovirt.org/41560 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5cbe774859e5bc159300b21d0ea91a92ea9ff1cf Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: add RegisterLibvritSecretsVdsCommand
by derez＠redhat.com 18 Jun '15

18 Jun '15

Daniel Erez has submitted this change and it was merged. Change subject: core: add RegisterLibvritSecretsVdsCommand ...................................................................... core: add RegisterLibvritSecretsVdsCommand Adding RegisterLibvirtSecretsVDSCommand and integrate with vdsm's registerSecrets api. Change-Id: Ib14bbf18dff4d89bf0bb29cdbdd65547cb72a178 Bug-Url: https://bugzilla.redhat.com/1185826 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/RegisterLibvirtSecretsVDSParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSCommandType.java M backend/manager/modules/dal/src/main/resources/bundles/VdsmErrors.properties M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/RegisterLibvirtSecretsVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsProperties.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerConnector.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerWrapper.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/VdsmErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/VdsmErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/VdsmErrors.properties 12 files changed, 111 insertions(+), 0 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/41557 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib14bbf18dff4d89bf0bb29cdbdd65547cb72a178 Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: getAllByStoragePoolIdFilteredByActiveStorageDomains
by derez＠redhat.com 18 Jun '15

18 Jun '15

Daniel Erez has submitted this change and it was merged. Change subject: core: getAllByStoragePoolIdFilteredByActiveStorageDomains ...................................................................... core: getAllByStoragePoolIdFilteredByActiveStorageDomains Adding 'GetAllLibvirtSecretsAllByStoragePoolIdFilteredByActiveDomains' stored procedure - used for registering all relevant secrets upon host activation. Change-Id: Iae886c19afbabd11f013b17e5d304aaf9c199b09 Bug-Url: https://bugzilla.redhat.com/1185826 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/LibvirtSecretDao.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/LibvirtSecretDaoDbFacadeImpl.java M packaging/dbscripts/libvirt_secrets_sp.sql 3 files changed, 31 insertions(+), 0 deletions(-) Approvals: Eli Mesika: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Daniel Erez: Verified Maor Lipchuk: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/41563 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iae886c19afbabd11f013b17e5d304aaf9c199b09 Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: unregisterLibvirtSecrets on remove
by derez＠redhat.com 18 Jun '15

18 Jun '15

Daniel Erez has submitted this change and it was merged. Change subject: core: unregisterLibvirtSecrets on remove ...................................................................... core: unregisterLibvirtSecrets on remove Invoke UnregisterLibvirtSecrets command upon removing a libvirt secret. Change-Id: I53b2982a1b40f9305028fa38eaba08e718fa6e79 Bug-Url: https://bugzilla.redhat.com/1185826 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/storage/LibvirtSecretCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/storage/RemoveLibvirtSecretCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/CINDERStorageHelper.java 3 files changed, 21 insertions(+), 6 deletions(-) Approvals: Daniel Erez: Verified Jenkins CI: Verified; Passed CI tests Maor Lipchuk: Looks good to me, approved Objections: Jenkins CI: I would prefer that you didn't submit this -- To view, visit https://gerrit.ovirt.org/41562 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I53b2982a1b40f9305028fa38eaba08e718fa6e79 Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: registerLibvirtSecrets on add and update secret
by derez＠redhat.com 18 Jun '15

18 Jun '15

Daniel Erez has submitted this change and it was merged. Change subject: core: registerLibvirtSecrets on add and update secret ...................................................................... core: registerLibvirtSecrets on add and update secret Invoke RegisterLibvirtSecrets command upon adding a new libvirt secret or updating an existing one. Change-Id: I9d000e7d4cfcc946b7d055c9ed205aa54e9e2c7b Bug-Url: https://bugzilla.redhat.com/1185826 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/storage/AddLibvirtSecretCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/storage/LibvirtSecretCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/storage/UpdateLibvirtSecretCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/CINDERStorageHelper.java 4 files changed, 45 insertions(+), 8 deletions(-) Approvals: Daniel Erez: Verified Jenkins CI: Verified; Passed CI tests Maor Lipchuk: Looks good to me, approved Objections: Jenkins CI: I would prefer that you didn't submit this -- To view, visit https://gerrit.ovirt.org/41561 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9d000e7d4cfcc946b7d055c9ed205aa54e9e2c7b Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0