June 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: services, setup: vmconsole/openssh integration
by sbonazzo＠redhat.com 15 Jun '15

15 Jun '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: services, setup: vmconsole/openssh integration ...................................................................... services, setup: vmconsole/openssh integration integration between ovirt-engine and ovirt-vmconsole-proxy, using the openssh certificates Includes: - helpers to integrate ovirt-engine and ovirt-vmconsole-proxy - setup plugins for PKI artifacts Attention points: - the setup code intentionally does the bulk of work in the engine directories, and copy the configuration/pki files only as last step. Doing so, if for any reason the proper directory is not accessible by setup, the correct configuration is created anyway, and the admin has just to copy it with the right permissions. Feature wiki page: http://www.ovirt.org/Features/Serial_Console Bug-Url: https://bugzilla.redhat.com/1223671 Change-Id: I740e37d5c34633bbe51922fb047d6b1a0a2431b6 Signed-off-by: Francesco Romani <fromani(a)redhat.com> --- M packaging/setup/ovirt_engine_setup/engine/constants.py M packaging/setup/ovirt_engine_setup/vmconsole_proxy_helper/constants.py M packaging/setup/plugins/ovirt-engine-setup/vmconsole_proxy_helper/pki.py 3 files changed, 274 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Yedidyah Bar David: Looks good to me, but someone else must approve Francesco Romani: Verified -- To view, visit https://gerrit.ovirt.org/41329 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I740e37d5c34633bbe51922fb047d6b1a0a2431b6 Gerrit-PatchSet: 20 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-hosted-engine-setup[master]: Add intellij files to .gitignore
by sbonazzo＠redhat.com 15 Jun '15

15 Jun '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: Add intellij files to .gitignore ...................................................................... Add intellij files to .gitignore Change-Id: I76fab22d129db4bcac8e252a66614eec8f6ff6d9 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M .gitignore 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Verified; Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/42341 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I76fab22d129db4bcac8e252a66614eec8f6ff6d9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: services, setup: ovirt-vmconsole integration
by sbonazzo＠redhat.com 15 Jun '15

15 Jun '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: services, setup: ovirt-vmconsole integration ...................................................................... services, setup: ovirt-vmconsole integration integration between ovirt-engine and ovirt-vmconsole-proxy. Includes: - helpers to integrate ovirt-engine and ovirt-vmconsole-proxy - setup plugins for PKI artifacts Key assumption: ovirt-vmconsole-proxy-helper will run on the same host of ovirt-engine. The setup code intentionally does the bulk of work in the engine directories, and copy the configuration/pki files only as last step. Doing so, if for any reason the proper directory is not accessible by setup, the correct configuration is created anyway, and the admin has just to copy it with the right permissions. When the helper is actually run through ovirt-vmconsole-proxy, selinux prevents its execution. This will be addressed by a followup patch. Feature wiki page: http://www.ovirt.org/Features/Serial_Console Bug-Url: https://bugzilla.redhat.com/1223671 Change-Id: I034ef8e6d10da5dc93eda61e0c5c518ca13a5a28 Signed-off-by: Vitor de Lima <vdelima(a)redhat.com> Signed-off-by: Francesco Romani <fromani(a)redhat.com> --- M .gitignore M Makefile M ovirt-engine.spec.in A packaging/etc/ovirt-vmconsole-proxy-helper.conf.d/README.in A packaging/firewalld/vmconsole-proxy/ovirt-vmconsole-proxy.xml.in A packaging/libexec/ovirt-vmconsole-proxy-helper/__init__.py A packaging/libexec/ovirt-vmconsole-proxy-helper/ovirt-vmconsole-list.py A packaging/libexec/ovirt-vmconsole-proxy-helper/ovirt-vmconsole-proxy-helper.conf.in A packaging/libexec/ovirt-vmconsole-proxy-helper/ovirt_vmconsole_conf.py.in A packaging/setup/ovirt_engine_setup/vmconsole_proxy_helper/__init__.py A packaging/setup/ovirt_engine_setup/vmconsole_proxy_helper/config.py.in A packaging/setup/ovirt_engine_setup/vmconsole_proxy_helper/constants.py A packaging/setup/plugins/ovirt-engine-setup/vmconsole_proxy_helper/__init__.py A packaging/setup/plugins/ovirt-engine-setup/vmconsole_proxy_helper/config.py A packaging/setup/plugins/ovirt-engine-setup/vmconsole_proxy_helper/pki.py 15 files changed, 1,231 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Yedidyah Bar David: Looks good to me, but someone else must approve Francesco Romani: Verified -- To view, visit https://gerrit.ovirt.org/35906 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I034ef8e6d10da5dc93eda61e0c5c518ca13a5a28 Gerrit-PatchSet: 53 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vitor de Lima <vdelima(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: Vitor de Lima <vdelima(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: gluster: Disable gluster cli based snapshot scheduling
by masayag＠redhat.com 15 Jun '15

15 Jun '15

Moti Asayag has submitted this change and it was merged. Change subject: gluster: Disable gluster cli based snapshot scheduling ...................................................................... gluster: Disable gluster cli based snapshot scheduling Introduced changes to disable gluster CLI based volume snapshot scheduling if engine is used. It looks for the existence of a meta volume in gluster and if so, disables the CLI based volume snapshot scheduling by setting a required flag. Later gluster refers the same flag and does not allow re-enabling of CLI based volume snapshot shcheduling from command line. Change-Id: I6bc06f246f30769c5edaf981876c2a51ddd4fffd Bug-URL: https://bugzilla.redhat.com/1230342 Bug-URL: https://bugzilla.redhat.com/1215600 Signed-off-by: Shubhendu Tripathi <shtripat(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/DisableGlusterCliSnapshotScheduleInternalCommand.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterVolumeSnapshotCliScheduleFlagQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterSyncJob.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/ScheduleGlusterVolumeSnapshotCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GlusterSyncJobTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDSGroup.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllErrors.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/ConfigurationValues.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSCommandType.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsGroupDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties M backend/manager/modules/dal/src/main/resources/bundles/VdsmErrors.properties M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VdsGroupDAOTest.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/AbstractGlusterBrokerCommand.java A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/OverrideGlusterVolumeSnapshotScheduleVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerConnector.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerWrapper.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/VdsmErrors.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/GlusterVolumeSnapshotListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/GlusterVolumeSnapshotModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeBrickListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/volumes/VolumeListModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/LocalizedEnums.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/GlusterVolumeSnapshotCreatePopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/GlusterVolumeSnapshotCreatePopupView.ui.xml M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties A packaging/dbscripts/upgrade/03_06_1590_add_gluster_cli_based_snapshot_scheduled_column_to_vds_groups.sql M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql M packaging/dbscripts/vds_groups_sp.sql 42 files changed, 459 insertions(+), 24 deletions(-) Approvals: Jenkins CI: Looks good to me, but someone else must approve Shubhendu Tripathi: Verified Sahina Bose: Looks good to me, approved Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/39945 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6bc06f246f30769c5edaf981876c2a51ddd4fffd Gerrit-PatchSet: 25 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-live[ovirt-live-3.5]: build: ovirt-live-3.5.3
by sbonazzo＠redhat.com 15 Jun '15

15 Jun '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: build: ovirt-live-3.5.3 ...................................................................... build: ovirt-live-3.5.3 Change-Id: I722f0bdeb386ae9a80b157cd5bfa41e8c16534aa Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M centos/Makefile M centos/kickstart/ovirt-live-ovirt-custom.ks.in 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/42343 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I722f0bdeb386ae9a80b157cd5bfa41e8c16534aa Gerrit-PatchSet: 1 Gerrit-Project: ovirt-live Gerrit-Branch: ovirt-live-3.5 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: Tooltip in Disks subtab shows Original Allocation ...
by tnisan＠redhat.com 14 Jun '15

14 Jun '15

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Tooltip in Disks subtab shows Original Allocation Policy ...................................................................... webadmin: Tooltip in Disks subtab shows Original Allocation Policy 1. Select a VM in Virtual Machines list. 2. Select Disks subtab. 3. Select Images radio button. Allocation Policy column in the disks table shows current allocation policy of the disk. If snapshots were created, the current allocation policy will be always "Thin provision", while allocation policy of the original disk may be different. To make the original allocation policy easily accessible, tooltip was added to the Allocation Policy column. The original allocation policy is displayed in the tooltip. Change-Id: I267eb950c57f4c5cca92d5fdd04e1294b1b2f2b0 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1117003 Signed-off-by: Shmuel Melamud <smelamud(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/disks/DisksViewColumns.java 2 files changed, 30 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Looks good to me, but someone else must approve Shmuel Leib Melamud: Verified -- To view, visit https://gerrit.ovirt.org/41071 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I267eb950c57f4c5cca92d5fdd04e1294b1b2f2b0 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Shmuel Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: RemoveAllVmCinderDisks - set parent on build params
by derez＠redhat.com 14 Jun '15

14 Jun '15

Daniel Erez has submitted this change and it was merged. Change subject: core: RemoveAllVmCinderDisks - set parent on build params ...................................................................... core: RemoveAllVmCinderDisks - set parent on build params Set parent command and parameters on buildChildCommandParameters to ensure a correct list of children commands RemoveAllVmCinderDisksCommandCallBack. Change-Id: I1bfa9f3b2da974bd40ec3aefc65c925d15e63183 Bug-Url: https://bugzilla.redhat.com/1185826 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveAllVmCinderDisksCommand.java 1 file changed, 4 insertions(+), 2 deletions(-) Approvals: Daniel Erez: Verified Maor Lipchuk: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/42323 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1bfa9f3b2da974bd40ec3aefc65c925d15e63183 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: RemoveAllVmCinderDisks - handle command statuses
by derez＠redhat.com 14 Jun '15

14 Jun '15

Daniel Erez has submitted this change and it was merged. Change subject: core: RemoveAllVmCinderDisks - handle command statuses ...................................................................... core: RemoveAllVmCinderDisks - handle command statuses Handle NOT_STARTED and SUCCEEDED command statuses on RemoveAllVmCinderDisksCommandCallBack. Change-Id: I1ead34e33f11ff5667b02522c6fb16d00e354ea6 Bug-Url: https://bugzilla.redhat.com/1185826 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveAllVmCinderDisksCommandCallBack.java 1 file changed, 6 insertions(+), 1 deletion(-) Approvals: Daniel Erez: Verified Maor Lipchuk: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/42324 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1ead34e33f11ff5667b02522c6fb16d00e354ea6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: validate Cinder disks status on RunVmValidator
by derez＠redhat.com 14 Jun '15

14 Jun '15

Daniel Erez has submitted this change and it was merged. Change subject: core: validate Cinder disks status on RunVmValidator ...................................................................... core: validate Cinder disks status on RunVmValidator Include Cinder disks on RunVmValidator (getVmImageDisks method), to ensure relevant validations on Cinder disks. Change-Id: Iedd79e2f257a80505cca19b7ec8d7e72797eeaee Bug-Url: https://bugzilla.redhat.com/1185826 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/RunVmValidator.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Daniel Erez: Verified Maor Lipchuk: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/42322 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iedd79e2f257a80505cca19b7ec8d7e72797eeaee Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Fix NPE when removing a VM with Cinder disks.
by derez＠redhat.com 14 Jun '15

14 Jun '15

Daniel Erez has submitted this change and it was merged. Change subject: core: Fix NPE when removing a VM with Cinder disks. ...................................................................... core: Fix NPE when removing a VM with Cinder disks. Remove disk from snapshot's OVF only if the snapshot exists. Change the parameter class passed to coco to be RemoveCinderDiskParameters. Change-Id: I570f59bac7e1bc569d82767b8c6fee0b0d997ccb Bug-Url: https://bugzilla.redhat.com/1185826 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveAllVmCinderDisksCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveCinderDiskCommand.java 2 files changed, 10 insertions(+), 6 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Jenkins CI: Looks good to me, but someone else must approve Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/42333 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I570f59bac7e1bc569d82767b8c6fee0b0d997ccb Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0