June 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: userportal, webadmin: removed duplicates
by tjelinek＠redhat.com 11 Jun '15

11 Jun '15

Tomas Jelinek has submitted this change and it was merged. Change subject: userportal,webadmin: removed duplicates ...................................................................... userportal,webadmin: removed duplicates • 2 duplicate anonymous IAsyncConverter class refactored to sole inner class • removed duplicate method. Bug-Url: https://bugzilla.redhat.com/1200952 Change-Id: Ic8ee48edeacd5719a421a7a3d3a78f2f54dc11bf Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java 1 file changed, 29 insertions(+), 45 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Martin Mucha: Verified Jenkins CI: Verified -- To view, visit https://gerrit.ovirt.org/41278 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic8ee48edeacd5719a421a7a3d3a78f2f54dc11bf Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5-gluster]: webadmin: add showErrorDialog property to runMultipleAction
by kmayilsa＠redhat.com 11 Jun '15

11 Jun '15

Kanagaraj M has submitted this change and it was merged. Change subject: webadmin: add showErrorDialog property to runMultipleAction ...................................................................... webadmin: add showErrorDialog property to runMultipleAction The property will alow to controll whether to show a pop-up dialog with the error or not. Change-Id: I703c95dd2c8bfc2ff3cc997019dcd15fd671d234 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/Frontend.java 1 file changed, 49 insertions(+), 3 deletions(-) Approvals: anmolbabu: Verified Kanagaraj M: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/42186 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I703c95dd2c8bfc2ff3cc997019dcd15fd671d234 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5-gluster Gerrit-Owner: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5-gluster]: webadmin: add waitForResult property to runMultipleAction
by kmayilsa＠redhat.com 11 Jun '15

11 Jun '15

Kanagaraj M has submitted this change and it was merged. Change subject: webadmin: add waitForResult property to runMultipleAction ...................................................................... webadmin: add waitForResult property to runMultipleAction The waitForResult property is a flag to return the result after running the whole action and not just the can do action. Change-Id: Ia94ec1334f9d33fd74ac2c773a5ad1d25c82eb96 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/Frontend.java 1 file changed, 11 insertions(+), 7 deletions(-) Approvals: anmolbabu: Verified Kanagaraj M: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/42187 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia94ec1334f9d33fd74ac2c773a5ad1d25c82eb96 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5-gluster Gerrit-Owner: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5-gluster]: webadmin Add UI Error handling in rebalance and remove-brick
by kmayilsa＠redhat.com 11 Jun '15

11 Jun '15

Kanagaraj M has submitted this change and it was merged. Change subject: webadmin Add UI Error handling in rebalance and remove-brick ...................................................................... webadmin Add UI Error handling in rebalance and remove-brick Add UI Error handling in rebalance and remove-brick Change-Id: I4c83499028981f0846b0406d68823e7a72c89441 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1042808 Signed-off-by: Anmol Babu <anbabu(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeBrickListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/volumes/VolumeListModel.java 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: anmolbabu: Verified Kanagaraj M: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/42188 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4c83499028981f0846b0406d68823e7a72c89441 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5-gluster Gerrit-Owner: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5-gluster]: webadmin : Fix SizeUnit refactor build failures
by kmayilsa＠redhat.com 11 Jun '15

11 Jun '15

Kanagaraj M has submitted this change and it was merged. Change subject: webadmin : Fix SizeUnit refactor build failures ...................................................................... webadmin : Fix SizeUnit refactor build failures This patch fixes the build failures introduced by the recently merged refactoring patch the refactors SizeConverter.SizeUnit units. Change-Id: I2fc159fafa66683c8e6b385e6b283c229c7cc592 Signed-off-by: Anmol Babu <anbabu(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/VolumeRebalanceStatusPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/quota/QuotaPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabQuotaView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/datacenter/SubTabDataCenterStorageView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/disk/SubTabDiskStorageView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/host/SubTabHostGlusterStorageDevicesView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/quota/SubTabQuotaStorageView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/renderer/VolumeCapacityRenderer.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/storage/VMsTree.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/BrickCapacityCell.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/RebalanceFileSizeColumn.java 11 files changed, 18 insertions(+), 18 deletions(-) Approvals: anmolbabu: Verified Kanagaraj M: Looks good to me, approved Sahina Bose: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/42166 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2fc159fafa66683c8e6b385e6b283c229c7cc592 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5-gluster Gerrit-Owner: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: engine: Added new alerts for brick/volume status changes
by kmayilsa＠redhat.com 11 Jun '15

11 Jun '15

Kanagaraj M has submitted this change and it was merged. Change subject: engine: Added new alerts for brick/volume status changes ...................................................................... engine: Added new alerts for brick/volume status changes adds new alerts for server/volume removed from CLI, updates brick state change alerts and automatically remove alerts once the entity is UP. Change-Id: Ibad5ed6078bd33cd9c9decdabca6747709be4ba4 Signed-off-by: Karnan TC <kchidamb(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterSyncJob.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GlusterSyncJobTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/AuditLog.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AlertDirector.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogableBase.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/gluster/GlusterAuditLogUtil.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/AuditLogDAO.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/AuditLogDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties M packaging/dbscripts/audit_log_sp.sql A packaging/dbscripts/upgrade/03_06_1520_add_brickInfo_audit_log_table.sql 13 files changed, 182 insertions(+), 12 deletions(-) Approvals: Karnan t c: Verified Sahina Bose: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/40566 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibad5ed6078bd33cd9c9decdabca6747709be4ba4 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Karnan t c <kchidamb(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Karnan t c <kchidamb(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: removing redundant check
by alkaplan＠redhat.com 11 Jun '15

11 Jun '15

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: removing redundant check ...................................................................... webadmin: removing redundant check Findbugs complain about the test, as it will always be true if the object is not null. So, we can just return the object, as it will either be null, or VDS. Change-Id: Ia69328ecd3be647ce72ef21f4aeb073d95072596 Signed-off-by: Oved Ourfali <oourfali(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/HostAdditionalStatusColumn.java 1 file changed, 1 insertion(+), 6 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved Jenkins CI: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/42165 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia69328ecd3be647ce72ef21f4aeb073d95072596 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: gluster: Confirmation dialog for removing a volume snapshot ...
by kmayilsa＠redhat.com 11 Jun '15

11 Jun '15

Kanagaraj M has submitted this change and it was merged. Change subject: gluster: Confirmation dialog for removing a volume snapshot schedule ...................................................................... gluster: Confirmation dialog for removing a volume snapshot schedule Introduced a confirmation dialog while removing a gluster volume snapshot schedule as its a disruptive action. Change-Id: If269bba8f3952cf72936c5ed27f9b198fd90220a Bug-Url: https://bugzilla.redhat.com/1226129 Signed-off-by: Shubhendu Tripathi <shtripat(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/help/HelpTag.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/GlusterVolumeSnapshotListModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java 3 files changed, 38 insertions(+), 1 deletion(-) Approvals: Jenkins CI: Verified; Looks good to me, but someone else must approve Shubhendu Tripathi: Verified Kanagaraj M: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/41851 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If269bba8f3952cf72936c5ed27f9b198fd90220a Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Change method access modifier to public for auditlog.
by mlipchuk＠redhat.com 11 Jun '15

11 Jun '15

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Change method access modifier to public for auditlog. ...................................................................... core: Change method access modifier to public for auditlog. Change the access modifier of getDiskAlias to public for audit log purposes. Change-Id: Icc0169c141db7c137015fd3cb5aa1b6c4dc665ee Bug-Url: https://bugzilla.redhat.com/1185826 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveCinderDiskCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Daniel Erez: Looks good to me, approved Jenkins CI: Looks good to me, but someone else must approve Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/42130 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icc0169c141db7c137015fd3cb5aa1b6c4dc665ee Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: load vms from export domain on-demand
by ahadas＠redhat.com 11 Jun '15

11 Jun '15

Arik Hadas has submitted this change and it was merged. Change subject: webadmin: load vms from export domain on-demand ...................................................................... webadmin: load vms from export domain on-demand Do not load VMs from the export domain until the user click a 'load' button. Change-Id: I17d884236e738835f909f96662eee7a9d2428378 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportVmsModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/ImportVmsPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/ImportVmsPopupView.ui.xml 4 files changed, 83 insertions(+), 97 deletions(-) Approvals: Arik Hadas: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/42096 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I17d884236e738835f909f96662eee7a9d2428378 Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0