June 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: cow-sparse base volumes of templates
by ahadas＠redhat.com 01 Jun '15

01 Jun '15

Arik Hadas has submitted this change and it was merged. Change subject: webadmin: cow-sparse base volumes of templates ...................................................................... webadmin: cow-sparse base volumes of templates Allow the user to specify the format of template volumes. The type of the volumes is generated according to its format and the storage type according to the following rules: QCow -> SPARSE RAW + File -> SPARSE RAW + Block -> PREALLOCATED That way, the user can set base volume of a template to be QCOW+SPARSE which was not possible to set before. Change-Id: Id269321c793e4b2af2c8efb153c37a3721f8cbf7 Bug-Url: https://bugzilla.redhat.com/1168576 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmMakeTemplatePopupWidget.ui.xml M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/DisksAllocationItemView.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/DisksAllocationItemView.ui.xml M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/DisksAllocationView.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/DisksAllocationModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/DiskModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewTemplateVmModelBehavior.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Enums.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/Enums.properties M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/vm/VmMakeTemplatePopupView.java 11 files changed, 83 insertions(+), 7 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Verified; Looks good to me, but someone else must approve Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/38377 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id269321c793e4b2af2c8efb153c37a3721f8cbf7 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Fix RPM build
by juan.hernandez＠redhat.com 01 Jun '15

01 Jun '15

Juan Hernandez has submitted this change and it was merged. Change subject: core: Fix RPM build ...................................................................... core: Fix RPM build Fixes RPM build issue introduced in patch I2288d0bd0584c7ba17f3dabaff268e40cbdddbea. Change-Id: I3c2fa67e5c1dee7c59870589a7dc48a644bda07a Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M ovirt-engine.spec.in 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Martin Peřina: Verified Juan Hernandez: Verified; Looks good to me, approved Anatoly Litovsky: Looks good to me, but someone else must approve Moti Asayag: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/41788 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3c2fa67e5c1dee7c59870589a7dc48a644bda07a Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Anatoly Litovsky <tlitovsk(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: update scheduling stats only if GetStats succeeded
by ahadas＠redhat.com 01 Jun '15

01 Jun '15

Arik Hadas has submitted this change and it was merged. Change subject: core: update scheduling stats only if GetStats succeeded ...................................................................... core: update scheduling stats only if GetStats succeeded Move the update of scheduling stats to be after validating the call to GetStats succeeded. Change-Id: Id30a895423de2cec4163aad8b4e51db60cbfa8e4 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/HostMonitoring.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Arik Hadas: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/41569 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id30a895423de2cec4163aad8b4e51db60cbfa8e4 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: introduce v2v jobs
by ahadas＠redhat.com 01 Jun '15

01 Jun '15

Arik Hadas has submitted this change and it was merged. Change subject: core: introduce v2v jobs ...................................................................... core: introduce v2v jobs Introduce jobs that represent a conversion done by virt-v2v. VDSM reports these jobs in the statistics, they are received by the host-monitoring and stored in VdsManager so they will be available later on for monitoring by the convert-command. Change-Id: Id289c99db807a359b195127736326d9d1b1bbd23 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/V2VJobInfo.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDS.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsStatistics.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/HostMonitoring.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsProperties.java M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml 8 files changed, 198 insertions(+), 1 deletion(-) Approvals: Omer Frenkel: Looks good to me, approved Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/40650 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id289c99db807a359b195127736326d9d1b1bbd23 Gerrit-PatchSet: 23 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Extend Bond entity to contain slaves
by alkaplan＠redhat.com 01 Jun '15

01 Jun '15

Alona Kaplan has submitted this change and it was merged. Change subject: core: Extend Bond entity to contain slaves ...................................................................... core: Extend Bond entity to contain slaves Change-Id: I2d657f759b402d4841f1dc62567490003912dd4f Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/Bond.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/VdsNetworkInterface.java 2 files changed, 35 insertions(+), 1 deletion(-) Approvals: Martin Mucha: Verified Alona Kaplan: Looks good to me, approved Jenkins CI: Verified; Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/32909 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2d657f759b402d4841f1dc62567490003912dd4f Gerrit-PatchSet: 29 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Introduce HostSetupNetworksParameters parameters
by alkaplan＠redhat.com 01 Jun '15

01 Jun '15

Alona Kaplan has submitted this change and it was merged. Change subject: core: Introduce HostSetupNetworksParameters parameters ...................................................................... core: Introduce HostSetupNetworksParameters parameters The HostSetupNetworksParameters are the api for the new HostSetupNetworks commands, for configuring networks and bonds on hosts. Change-Id: If353c08a8db257333d7696df0c7c887d179bc41a Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/HostSetupNetworksParameters.java 1 file changed, 96 insertions(+), 0 deletions(-) Approvals: Martin Mucha: Verified Alona Kaplan: Looks good to me, approved Jenkins CI: Verified; Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/32776 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If353c08a8db257333d7696df0c7c887d179bc41a Gerrit-PatchSet: 28 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: engine: Add NetworkAttachment dao
by alkaplan＠redhat.com 01 Jun '15

01 Jun '15

Alona Kaplan has submitted this change and it was merged. Change subject: engine: Add NetworkAttachment dao ...................................................................... engine: Add NetworkAttachment dao Change-Id: I84187f3900b9e3f8a917fc4e4126de9e50e231b4 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/IpConfiguration.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/DbFacade.java A backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/NetworkAttachmentDao.java A backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/NetworkAttachmentDaoDbFacadeImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/FixturesTool.java A backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/network/NetworkAttachmentDaoTest.java M backend/manager/modules/dal/src/test/resources/fixtures.xml M packaging/dbscripts/network_sp.sql A packaging/dbscripts/upgrade/03_06_1460_add_network_attachment.sql 9 files changed, 562 insertions(+), 39 deletions(-) Approvals: Martin Mucha: Verified Alona Kaplan: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/32581 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I84187f3900b9e3f8a917fc4e4126de9e50e231b4 Gerrit-PatchSet: 29 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Introduce NetworkAttachment entity
by alkaplan＠redhat.com 01 Jun '15

01 Jun '15

Alona Kaplan has submitted this change and it was merged. Change subject: core: Introduce NetworkAttachment entity ...................................................................... core: Introduce NetworkAttachment entity The class is used for describing a network which is attached to a network interface. Change-Id: Ided81dc2be68dc4c7a9d491697f887cdae477a2c Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/IpConfiguration.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/NetworkAttachment.java M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml 3 files changed, 232 insertions(+), 0 deletions(-) Approvals: Martin Mucha: Verified Alona Kaplan: Looks good to me, approved Jenkins CI: Verified; Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/32411 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ided81dc2be68dc4c7a9d491697f887cdae477a2c Gerrit-PatchSet: 24 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Introduce BusinessEntityMap
by alkaplan＠redhat.com 01 Jun '15

01 Jun '15

Alona Kaplan has submitted this change and it was merged. Change subject: core: Introduce BusinessEntityMap ...................................................................... core: Introduce BusinessEntityMap The map allows to identify a Nameable business entity within the map either by its name or by its id. The map will be useful when certain entities provided by the clients either by their ID or by name and that entity should be resolved by those identifiers, i.e. NetworkAttachment or Bond. Change-Id: I4540f813f8a787a38ba3e692b6ddd3fcc6be536a Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/BusinessEntityMap.java A backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/businessentities/BusinessEntityMapTest.java 2 files changed, 254 insertions(+), 0 deletions(-) Approvals: Martin Mucha: Verified Alona Kaplan: Looks good to me, approved Jenkins CI: Verified; Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/33329 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4540f813f8a787a38ba3e692b6ddd3fcc6be536a Gerrit-PatchSet: 28 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <wallaroo1976(a)gmail.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: replace duplicated code with builders
by ahadas＠redhat.com 01 Jun '15

01 Jun '15

Arik Hadas has submitted this change and it was merged. Change subject: webadmin: replace duplicated code with builders ...................................................................... webadmin: replace duplicated code with builders Add a builder that maps properties in UnitVmModel to AddVmTemplateParameters and a builder that is a composite of KernelParamsVmBaseToVmBaseBuilder DedicatedVmForVdsVmBaseToVmBaseBuilder MigrationOptionsVmBaseToVmBaseBuilder and UsbPolicyVmBaseToVmBaseBuilder. These builders replace the duplicated code that was added when the clone template from snapshot operation was added to the snapshots sub-tab. Change-Id: Ibfbc42621b15d3115fba2f1da27d8489e72281fc Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/builders/template/UnitToAddVmTemplateParametersBuilder.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/builders/template/VmBaseToVmBaseForTemplateCompositeBaseBuilder.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmSnapshotListModel.java 4 files changed, 58 insertions(+), 50 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Jenkins CI: Verified; Looks good to me, but someone else must approve Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/41639 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibfbc42621b15d3115fba2f1da27d8489e72281fc Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0