July 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: userportal, webadmin: refactored badly overgrown method to mo...
by alkaplan＠redhat.com 27 Jul '15

27 Jul '15

Alona Kaplan has submitted this change and it was merged. Change subject: userportal,webadmin: refactored badly overgrown method to more understandable parts ...................................................................... userportal,webadmin: refactored badly overgrown method to more understandable parts • method broken into three methods: ◦ method checking if there's valid operation for first operand. ◦ method handling unary operation applied on first operand ◦ method handling binary operations. • removed unnecessary elses to reduce indentation • overloaded operationFor methods moved close together • 'instanceof BondNetworkInterfaceModel' is performed on closer superclass (NetworkInterfaceModel) instead of NetworkItemModel to allow move casting to caller method (handleBinaryOperation) and altered one (binaryOperationWithNetworkInterfaceModelOperand) can deal only with NetworkInterfaceModel and not with NetworkItemModel. Change-Id: Ie84e1c7fb7324279b5a8687d1ad6ffc605f921a0 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/NetworkOperationFactory.java 2 files changed, 187 insertions(+), 129 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/37641 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie84e1c7fb7324279b5a8687d1ad6ffc605f921a0 Gerrit-PatchSet: 95 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: userportal, webadmin: removed useless class.
by alkaplan＠redhat.com 27 Jul '15

27 Jul '15

Alona Kaplan has submitted this change and it was merged. Change subject: userportal,webadmin: removed useless class. ...................................................................... userportal,webadmin: removed useless class. Change-Id: I7fb82f9390633bd33cb067d7df7f7bf95caff70e Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostSetupNetworksModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/NetworkOperationFactory.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/NetworkItemPanel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/NetworkPanel.java 4 files changed, 25 insertions(+), 28 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/37640 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7fb82f9390633bd33cb067d7df7f7bf95caff70e Gerrit-PatchSet: 96 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: pacakging: use printf instead of echo -n
by sbonazzo＠redhat.com 27 Jul '15

27 Jul '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: pacakging: use printf instead of echo -n ...................................................................... pacakging: use printf instead of echo -n echo -n is not part of POSIX[1], cause issues with dash, standard alternative is printf[2]. [1] http://pubs.opengroup.org/onlinepubs/9699919799/utilities/echo.html [2] http://pubs.opengroup.org/onlinepubs/9699919799/utilities/printf.html Change-Id: I521f176eabcf69a77b9f00a5d4ddd59437378dd0 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/bin/engine-backup.sh M packaging/bin/pki-enroll-openssh-cert.sh M packaging/services/ovirt-engine-notifier/ovirt-engine-notifier.sysv.in M packaging/services/ovirt-engine/ovirt-engine.sysv.in M packaging/services/ovirt-fence-kdump-listener/ovirt-fence-kdump-listener.sysv.in M packaging/services/ovirt-websocket-proxy/ovirt-websocket-proxy.sysv.in 6 files changed, 10 insertions(+), 10 deletions(-) Approvals: Alon Bar-Lev: Verified Sandro Bonazzola: Looks good to me, approved Jenkins CI: Passed CI tests Yedidyah Bar David: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/43967 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I521f176eabcf69a77b9f00a5d4ddd59437378dd0 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5.4]: build: ovirt-engine-3.5.4.1
by tnisan＠redhat.com 27 Jul '15

27 Jul '15

Tal Nisan has submitted this change and it was merged. Change subject: build: ovirt-engine-3.5.4.1 ...................................................................... build: ovirt-engine-3.5.4.1 Change-Id: Id552d04899de3a1a935cfe873c22fe02f20ba3af Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M ovirt-engine.spec.in M version.mak 2 files changed, 5 insertions(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/44023 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id552d04899de3a1a935cfe873c22fe02f20ba3af Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5.4 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-hosted-engine-setup[master]: packaging: setup: get NIC list from VDSM
by sbonazzo＠redhat.com 27 Jul '15

27 Jul '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: get NIC list from VDSM ...................................................................... packaging: setup: get NIC list from VDSM Getting NIC list from VDSM intead of directly getting it using the low level ethtool to better integrate with that. Change-Id: Ie8a1a9daf03287eeee8653bd765ac743f11cf3c5 Bug-Url: https://bugzilla.redhat.com/1131918 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M src/plugins/ovirt-hosted-engine-setup/network/bridge.py 1 file changed, 26 insertions(+), 46 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified Jenkins CI: Passed CI tests Yedidyah Bar David: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/43829 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie8a1a9daf03287eeee8653bd765ac743f11cf3c5 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-image-uploader[master]: ovirt-image-uploader: Provide more informative error messages
by sbonazzo＠redhat.com 27 Jul '15

27 Jul '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: ovirt-image-uploader: Provide more informative error messages ...................................................................... ovirt-image-uploader: Provide more informative error messages The code was modified to provide more information on connection failures, so now more specific information will be available to users. Also some error logic was added to process request errors, that is errors that happen after the successful connection was established, e.g. bad authentication etc. Now we can provide specific messages based on the return code e.g. 401, 503 etc. Change-Id: I66d8c6dc59169bdc798256bd2d150fbc8cda7665 Signed-off-by: Lev Veyde <lveyde(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1182344 --- M src/__main__.py 1 file changed, 24 insertions(+), 8 deletions(-) Approvals: Lev Veyde: Verified Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/42554 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I66d8c6dc59169bdc798256bd2d150fbc8cda7665 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-image-uploader Gerrit-Branch: master Gerrit-Owner: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: Fixing maven invocation
by sbonazzo＠redhat.com 27 Jul '15

27 Jul '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: Fixing maven invocation ...................................................................... Fixing maven invocation Also adjusted the memory params Change-Id: Ice69aa8c8da1cb819fbdf38d7a3db8cda770aaad Signed-off-by: David Caro <dcaroest(a)redhat.com> --- M automation/build-artifacts.sh 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved; Passed CI tests Eyal Edri: Looks good to me, but someone else must approve David Caro: Verified; Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/43727 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ice69aa8c8da1cb819fbdf38d7a3db8cda770aaad Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Modify NetworkAttachment IpConfiguration element
by masayag＠redhat.com 27 Jul '15

27 Jul '15

Moti Asayag has submitted this change and it was merged. Change subject: core: Modify NetworkAttachment IpConfiguration element ...................................................................... core: Modify NetworkAttachment IpConfiguration element The IpConfiguration is slightly changed to consist the list of ipv4 addresses with the boot protocol as part of them. Change-Id: I0ca65e3c71a4933f7cda9525bc453be03d4a3ec8 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/NetworkConfigurator.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/NetworkAttachmentValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/NetworkAttachmentValidatorTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/IPv4Address.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/IpConfiguration.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/HostNetwork.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/NetworkAttachmentDaoImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/network/NetworkAttachmentDaoTest.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HostNetworkAttachmentsPersister.java M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HostNetworkAttachmentsPersisterTest.java 11 files changed, 50 insertions(+), 39 deletions(-) Approvals: Alona Kaplan: Looks good to me, approved Jenkins CI: Passed CI tests Moti Asayag: Verified -- To view, visit https://gerrit.ovirt.org/43678 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0ca65e3c71a4933f7cda9525bc453be03d4a3ec8 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.2]: build: post ovirt-hosted-engine-setup-1.2.5.2
by sbonazzo＠redhat.com 27 Jul '15

27 Jul '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: build: post ovirt-hosted-engine-setup-1.2.5.2 ...................................................................... build: post ovirt-hosted-engine-setup-1.2.5.2 Change-Id: Ib2091fdf0e81d407a2f1edcb8b97b89c89b26822 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M configure.ac M ovirt-hosted-engine-setup.spec.in 2 files changed, 9 insertions(+), 6 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/44016 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib2091fdf0e81d407a2f1edcb8b97b89c89b26822 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-1.2 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.2]: build: ovirt-hosted-engine-setup-1.2.5.2
by sbonazzo＠redhat.com 27 Jul '15

27 Jul '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: build: ovirt-hosted-engine-setup-1.2.5.2 ...................................................................... build: ovirt-hosted-engine-setup-1.2.5.2 Change-Id: I8dea8e834dab135aa35787623a0c7f2c1d0155fb Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M configure.ac M ovirt-hosted-engine-setup.spec.in 2 files changed, 7 insertions(+), 4 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/44015 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8dea8e834dab135aa35787623a0c7f2c1d0155fb Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-1.2 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0