July 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: extapi: authn: logout should accept auth record
by masayag＠redhat.com 16 Jul '15

16 Jul '15

Moti Asayag has submitted this change and it was merged. Change subject: extapi: authn: logout should accept auth record ...................................................................... extapi: authn: logout should accept auth record this must have been an error in documentation, logout should accept an auth record, from which it can extract principal and other information such as session id. we can fix this now as there is no known usage of logout so far. Change-Id: I8616bebdcdb620e8d38c171e07af8c93edfd9b17 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/LogoutSessionCommand.java M backend/manager/modules/extensions-api-root/extensions-api/src/main/java/org/ovirt/engine/api/extensions/aaa/Authn.java 2 files changed, 3 insertions(+), 3 deletions(-) Approvals: Alon Bar-Lev: Verified Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/43691 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8616bebdcdb620e8d38c171e07af8c93edfd9b17 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: handle failure in vms monitoring
by ofrenkel＠redhat.com 15 Jul '15

15 Jul '15

Omer Frenkel has submitted this change and it was merged. Change subject: core: handle failure in vms monitoring ...................................................................... core: handle failure in vms monitoring currently if exception is thrown during vms monitoring (mostly during analyzing) the exception is not caught. since monitoring is always called from scheduler/event dispatcher, the only log is ~: [] Failed to invoke scheduled method perform: null which is useless so instead, changed VmsMonitoring.perform() to catch the exception and log it. Change-Id: I2c7c86f2b4b6d8041717b284c9dd07a84ada6969 Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmsMonitoring.java 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Omer Frenkel: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/43671 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2c7c86f2b4b6d8041717b284c9dd07a84ada6969 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: adding support for serial child commands execution
by laravot＠redhat.com 15 Jul '15

15 Jul '15

Liron Aravot has submitted this change and it was merged. Change subject: core: adding support for serial child commands execution ...................................................................... core: adding support for serial child commands execution This patch adds SerialChildCommandsExecutionCallback and SerialChildExecutingCommand. The SerialChildCommandsExecutionCallback is a callback that currently supports serial child execution until a failure is encountered or until the execution is finished. The use the callback the command needs to implement the SerialChildExecutingCommand interface. Change-Id: I729c97375525eaa2cf4274d4365765bcb10bd19e Signed-off-by: laravot(a)redhat.com <laravot(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SerialChildCommandsExecutionCallback.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SerialChildExecutingCommand.java 2 files changed, 73 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Liron Aravot: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/41699 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I729c97375525eaa2cf4274d4365765bcb10bd19e Gerrit-PatchSet: 16 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: adding ConcurrentChildCommandsExecutionCallback
by laravot＠redhat.com 15 Jul '15

15 Jul '15

Liron Aravot has submitted this change and it was merged. Change subject: core: adding ConcurrentChildCommandsExecutionCallback ...................................................................... core: adding ConcurrentChildCommandsExecutionCallback This patch adds the ConcurrentChildCommandsExecutionCallback callback. This callback is used to track the execution of number of child commands and call the endAction() method when the execution is done. Change-Id: I69d6d592a76e24466af32462ff9fc4f9c888b6f3 Signed-off-by: laravot(a)redhat.com <laravot(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ConcurrentChildCommandsExecutionCallback.java 1 file changed, 28 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Liron Aravot: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/41698 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I69d6d592a76e24466af32462ff9fc4f9c888b6f3 Gerrit-PatchSet: 16 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: support printing arrays in vdsm resposne
by ofrenkel＠redhat.com 15 Jul '15

15 Jul '15

Omer Frenkel has submitted this change and it was merged. Change subject: core: support printing arrays in vdsm resposne ...................................................................... core: support printing arrays in vdsm resposne Change-Id: I88041fd06cd439af066294b988d5fc172c22b0d3 Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/xmlrpc/XmlRpcObjectDescriptor.java 1 file changed, 6 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Omer Frenkel: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/43612 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I88041fd06cd439af066294b988d5fc172c22b0d3 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: adding ChildCommandsCallbackBase
by laravot＠redhat.com 15 Jul '15

15 Jul '15

Liron Aravot has submitted this change and it was merged. Change subject: core: adding ChildCommandsCallbackBase ...................................................................... core: adding ChildCommandsCallbackBase Change-Id: I1d5eb9ec92e20b1de5220e5b9101d93971f74487 Signed-off-by: laravot(a)redhat.com <laravot(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChildCommandsCallbackBase.java 1 file changed, 119 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Liron Aravot: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/42359 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1d5eb9ec92e20b1de5220e5b9101d93971f74487 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: restapi: Get signed WebSocket proxy ticket over REST
by tjelinek＠redhat.com 15 Jul '15

15 Jul '15

Tomas Jelinek has submitted this change and it was merged. Change subject: restapi: Get signed WebSocket proxy ticket over REST ...................................................................... restapi: Get signed WebSocket proxy ticket over REST POST /vms/{vmid}/graphicsconsoles/{consoleid}/proxyticket <action/> - <action> <proxy_ticket> <value>ticket_content</value> </proxy_ticket> </action> Change-Id: I1701fee8cd36c714cd5ac0d28ef076c51531b9d6 Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1181030 --- M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/VmGraphicsConsoleResource.java M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmGraphicsConsoleResource.java 4 files changed, 56 insertions(+), 0 deletions(-) Approvals: Jakub Niedermertl: Verified Juan Hernandez: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/42412 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1701fee8cd36c714cd5ac0d28ef076c51531b9d6 Gerrit-PatchSet: 18 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: introduce a refresher that only polls all-vm-stats
by ahadas＠redhat.com 15 Jul '15

15 Jul '15

Arik Hadas has submitted this change and it was merged. Change subject: core: introduce a refresher that only polls all-vm-stats ...................................................................... core: introduce a refresher that only polls all-vm-stats The events based refresher is now using poll refresher to poll for AllVmStats instead of having its own code for polling. This change reduce the code duplication between event based refresher and polling based refresher. Change-Id: I36a920a6a710012c7f31581cdf88a247e421df82 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/PollAllVmStatsOnlyRefresher.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/EventVMStatsRefresher.java 2 files changed, 31 insertions(+), 22 deletions(-) Approvals: Jenkins CI: Passed CI tests Omer Frenkel: Looks good to me, approved Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/42787 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I36a920a6a710012c7f31581cdf88a247e421df82 Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-hosted-engine-setup[master]: packaging: require ovirt-setup-lib
by sbonazzo＠redhat.com 15 Jul '15

15 Jul '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: require ovirt-setup-lib ...................................................................... packaging: require ovirt-setup-lib Change-Id: I67d7208a5e97f73c60e8d4045860eafc5dbd829b Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M ovirt-hosted-engine-setup.spec.in M src/bin/ovirt-hosted-engine-setup.env M src/plugins/ovirt-hosted-engine-setup/storage/blockd.py 3 files changed, 3 insertions(+), 4 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests Yedidyah Bar David: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/43677 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I67d7208a5e97f73c60e8d4045860eafc5dbd829b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core, webadmin: GetSignedWebsocketProxyTicketQuery added
by ofrenkel＠redhat.com 15 Jul '15

15 Jul '15

Omer Frenkel has submitted this change and it was merged. Change subject: core, webadmin: GetSignedWebsocketProxyTicketQuery added ...................................................................... core, webadmin: GetSignedWebsocketProxyTicketQuery added * Query producing websocket proxy ticket that allows to connect to ovirt-websocket-proxy.py * Minor frontend refactoring allowing easy ticket validity testing while debugging Change-Id: I3f6ce72a45151f0a1e16d58b9fc27a41e53cef74 Bug-Url: https://bugzilla.redhat.com/1181030 Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetSignedWebsocketProxyTicketQuery.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineError.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetSignedWebsocketProxyTicketParams.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java M backend/manager/modules/dal/src/main/resources/bundles/VdsmErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/VdsmErrors.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/WebClientConsoleInvoker.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/VdsmErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/VdsmErrors.properties 9 files changed, 133 insertions(+), 1 deletion(-) Approvals: Tomas Jelinek: Looks good to me, but someone else must approve Jakub Niedermertl: Verified Jenkins CI: Passed CI tests Omer Frenkel: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/43173 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3f6ce72a45151f0a1e16d58b9fc27a41e53cef74 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0