July 2015 - Engine-commits - oVirt List Archives

Change in ovirt-node-plugin-vdsm[master]: spec: remove space char
by dougsland＠redhat.com 30 Jul '15

30 Jul '15

Douglas Schilling Landgraf has submitted this change and it was merged. Change subject: spec: remove space char ...................................................................... spec: remove space char Change-Id: I52a6b933b504f832212206e72ff497070177cb12 Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> Reviewed-on: https://gerrit.ovirt.org/44169 Continuous-Integration: Jenkins CI --- M ovirt-node-plugin-vdsm.spec.in 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, approved; Passed CI tests Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/44169 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I52a6b933b504f832212206e72ff497070177cb12 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-node-plugin-vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-node-plugin-vdsm[master]: spec: create /var/log/vdsm-reg
by dougsland＠redhat.com 30 Jul '15

30 Jul '15

Douglas Schilling Landgraf has submitted this change and it was merged. Change subject: spec: create /var/log/vdsm-reg ...................................................................... spec: create /var/log/vdsm-reg vdsm-upgrade writes into /var/log/vdsm-reg. We must provide this directory. Change-Id: I7cac54d3ab73ed3fb136bfecd2dec5f87506e868 Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> Reviewed-on: https://gerrit.ovirt.org/44038 Continuous-Integration: Jenkins CI Reviewed-by: Dan Kenigsberg <danken(a)redhat.com> --- M ovirt-node-plugin-vdsm.spec.in 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, approved; Passed CI tests Jenkins CI: Passed CI tests Dan Kenigsberg: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/44038 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7cac54d3ab73ed3fb136bfecd2dec5f87506e868 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-node-plugin-vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: engine: add HasErrata interface
by gshereme＠redhat.com 29 Jul '15

29 Jul '15

Greg Sheremeta has submitted this change and it was merged. Change subject: engine: add HasErrata interface ...................................................................... engine: add HasErrata interface This interfaces can be used to indicate that a business entity has an Errata. Change-Id: Iaad7f5f088d39ce4d890757a24a189a04c46dba9 Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/HasErrata.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDS.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml 4 files changed, 14 insertions(+), 2 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Jenkins CI: Passed CI tests Greg Sheremeta: Verified -- To view, visit https://gerrit.ovirt.org/44101 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaad7f5f088d39ce4d890757a24a189a04c46dba9 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: engine: ErrataCounts rework, added Unknown errata severity
by gshereme＠redhat.com 29 Jul '15

29 Jul '15

Greg Sheremeta has submitted this change and it was merged. Change subject: engine: ErrataCounts rework, added Unknown errata severity ...................................................................... engine: ErrataCounts rework, added Unknown errata severity * simplified ErrataCounts -- GWT compiler was crashing when trying to compile this class. I could not figue out the problem. Rather than waste time on it, I just redid the class to count on demand. I think this makes it easier to read and understand, anyway. * added 'Unknown' severity to Errata and made it the default. Change-Id: I71d8864b778d0c32e950edc0f879462fbc4a0a8d Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetErrataCountsForHostQueryTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/ErrataCounts.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Erratum.java 3 files changed, 62 insertions(+), 120 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Jenkins CI: Passed CI tests Greg Sheremeta: Verified -- To view, visit https://gerrit.ovirt.org/44100 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I71d8864b778d0c32e950edc0f879462fbc4a0a8d Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: userportal, webadmin: create AlertPanel
by gshereme＠redhat.com 29 Jul '15

29 Jul '15

Greg Sheremeta has submitted this change and it was merged. Change subject: userportal, webadmin: create AlertPanel ...................................................................... userportal, webadmin: create AlertPanel * created AlertPanel widget to render the PatternFly alert. * replaced all by-hand uses of PatternFly alert with AlertPanel. * also created PatternflyConstants to hold constants related to the use of PatternFly. Change-Id: Id8d22f082a6386f664c75f9ce84c2726f32e3076 Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/css/PatternflyConstants.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/AbstractLoginFormView.java A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/panel/AlertPanel.java A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/panel/AlertPanel.ui.xml M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/login/view/LoginFormView.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/login/view/LoginFormView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/login/view/LoginFormView.ui.xml 7 files changed, 230 insertions(+), 65 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Jenkins CI: Passed CI tests Greg Sheremeta: Verified -- To view, visit https://gerrit.ovirt.org/44104 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id8d22f082a6386f664c75f9ce84c2726f32e3076 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: userportal, webadmin: added progress_dots image resources
by gshereme＠redhat.com 29 Jul '15

29 Jul '15

Greg Sheremeta has submitted this change and it was merged. Change subject: userportal, webadmin: added progress_dots image resources ...................................................................... userportal, webadmin: added progress_dots image resources added progress_dots image resources. This is the same image GWT uses for its built-in 'spinner' in grids. Allows us to use the same image in other places. Change-Id: I160b167a1b433a1e5eb53e94618641bf27ceb5b2 Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationResources.java A frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/images/dialog/progress_dots.gif 2 files changed, 3 insertions(+), 0 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Greg Sheremeta: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/44106 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I160b167a1b433a1e5eb53e94618641bf27ceb5b2 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: fix system tree Guest icon
by gshereme＠redhat.com 29 Jul '15

29 Jul '15

Greg Sheremeta has submitted this change and it was merged. Change subject: webadmin: fix system tree Guest icon ...................................................................... webadmin: fix system tree Guest icon system tree Guest icon was too skinny, causing poor alignment with the other icons. Fixed. Change-Id: I1e6054875ce57a54ec1cac7d2e7870573be2ca1a Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationResources.java A frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/images/user_tree.png M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/tree/SystemTreeItemCell.java 3 files changed, 4 insertions(+), 1 deletion(-) Approvals: Alexander Wels: Looks good to me, approved Greg Sheremeta: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/44105 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1e6054875ce57a54ec1cac7d2e7870573be2ca1a Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: weadmin, userportal: added comments to uicommon popup and ev...
by gshereme＠redhat.com 29 Jul '15

29 Jul '15

Greg Sheremeta has submitted this change and it was merged. Change subject: weadmin, userportal: added comments to uicommon popup and event infra ...................................................................... weadmin, userportal: added comments to uicommon popup and event infra Change-Id: I2d496a53e6089e499cdbda4a0aec74f7f3a15316 Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/AbstractSubTabPresenter.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/model/DetailTabModelProvider.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/model/ModelBoundPopupHandler.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/model/SearchableDetailModelProvider.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/model/TabModelProvider.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/tab/AbstractTabPanel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Event.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/AbstractSubTabTableView.java 8 files changed, 129 insertions(+), 70 deletions(-) Approvals: Greg Sheremeta: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/44102 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2d496a53e6089e499cdbda4a0aec74f7f3a15316 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: host-deploy: introduce deploy unit
by masayag＠redhat.com 29 Jul '15

29 Jul '15

Moti Asayag has submitted this change and it was merged. Change subject: host-deploy: introduce deploy unit ...................................................................... host-deploy: introduce deploy unit deploy unit will enable more flexible selection of what is enabled during session. it will also enable to share code between deploy and management processes. this is major rework of host-deploy usage, should not change anything actually sent to host. side effect is much shorter sources. Change-Id: Ida75efb7d42b1317b541d8720911f2578cc8b900 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/HostUpgradeManager.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/InstallVdsInternalCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/VdsDeploy.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/VdsDeployBase.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/VdsDeployIptablesUnit.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/VdsDeployKdumpUnit.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/VdsDeployMiscUnit.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/VdsDeployOpenStackUnit.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/VdsDeployPKIUnit.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/VdsDeployPackagesUnit.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/VdsDeployUnit.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/VdsDeployVdsmUnit.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/VdsDeployVmconsoleUnit.java D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/VdsMgmtPackages.java 14 files changed, 1,366 insertions(+), 1,099 deletions(-) Approvals: Jenkins CI: Passed CI tests Moti Asayag: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/44005 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ida75efb7d42b1317b541d8720911f2578cc8b900 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: introduce ImportVmFromVmwareModel
by ahadas＠redhat.com 29 Jul '15

29 Jul '15

Arik Hadas has submitted this change and it was merged. Change subject: webadmin: introduce ImportVmFromVmwareModel ...................................................................... webadmin: introduce ImportVmFromVmwareModel Import VM from OVA file has a lot in common with import from VMware. Therefore, ImportVmFromExternalProviderModel is changed to hold the common things and VMware-specific things are moved to ImportVmFromVmwareModel. Change-Id: I7f0ed04073a6ee1e2b79852568c6d283a0dde3b4 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportVmFromExternalProviderModel.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportVmFromVmwareModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportVmsModel.java 3 files changed, 139 insertions(+), 110 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/44128 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7f0ed04073a6ee1e2b79852568c6d283a0dde3b4 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0