July 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: userportal, webadmin: cleanup date rendering classes
by gshereme＠redhat.com 28 Jul '15

28 Jul '15

Greg Sheremeta has submitted this change and it was merged. Change subject: userportal, webadmin: cleanup date rendering classes ...................................................................... userportal, webadmin: cleanup date rendering classes Modified AbstractFullDateTimeRenderer to be a generic date renderer for the entire application. Removed AbstractGeneralDateTimeRenderer as it seemed to be useless. Change-Id: Ibc10d922359caa58f9f608f67c93e2bf6d32c0e8 Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/renderer/FullDateTimeRenderer.java D frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/renderer/GlusterRebalanceDateTimeRenderer.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/AbstractFullDateTimeColumn.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/snapshot/SnapshotsViewColumns.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/VolumeRebalanceStatusPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabTemplateView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/storage/SubTabStorageRegisterTemplateView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/storage/SubTabStorageRegisterVmView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/storage/SubTabStorageTemplateBackupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/storage/SubTabStorageVmBackupView.java D frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/renderer/GeneralDateTimeRenderer.java D frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/AbstractGeneralDateTimeColumn.java 12 files changed, 83 insertions(+), 107 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Jenkins CI: Passed CI tests Greg Sheremeta: Verified -- To view, visit https://gerrit.ovirt.org/42875 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibc10d922359caa58f9f608f67c93e2bf6d32c0e8 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: fix assert error in GroupedListModelListBox
by awels＠redhat.com 28 Jul '15

28 Jul '15

Alexander Wels has submitted this change and it was merged. Change subject: webadmin: fix assert error in GroupedListModelListBox ...................................................................... webadmin: fix assert error in GroupedListModelListBox - Editing a Host in debug mode would generate an assert error due to the acceptable values not being set before selecting a value. Change-Id: Id35a0f447cb1d014526b6124477b6d1fd6455183 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/GroupedListModelListBox.java 1 file changed, 10 insertions(+), 2 deletions(-) Approvals: Alexander Wels: Verified Jenkins CI: Passed CI tests Vojtech Szocs: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/44029 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id35a0f447cb1d014526b6124477b6d1fd6455183 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in jenkins[master]: Adding fabric-ovirt project
by dcaroest＠redhat.com 28 Jul '15

28 Jul '15

David Caro has submitted this change and it was merged. Change subject: Adding fabric-ovirt project ...................................................................... Adding fabric-ovirt project Change-Id: I554dd06f38de53c33db0624690e9a723ed2a10ff Signed-off-by: David Caro <dcaroest(a)redhat.com> --- A jobs/confs/yaml/jobs/fabic-ovirt/fabric-ovirt_standard.yaml A jobs/confs/yaml/scms/fabric-ovirt.yaml 2 files changed, 24 insertions(+), 0 deletions(-) Approvals: Barak Korren: Looks good to me Jenkins CI: Passed CI tests David Caro: Verified; Ready for merge -- To view, visit https://gerrit.ovirt.org/43786 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I554dd06f38de53c33db0624690e9a723ed2a10ff Gerrit-PatchSet: 5 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Max Kovgan <mvk(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Sagi Shnaidman <sshnaidm(a)redhat.com>

1 0

Change in ovirt-engine[master]: userportal, webadmin: Disabled textboxes has gray text
by gshereme＠redhat.com 28 Jul '15

28 Jul '15

Greg Sheremeta has submitted this change and it was merged. Change subject: userportal, webadmin: Disabled textboxes has gray text ...................................................................... userportal, webadmin: Disabled textboxes has gray text It fixes bug in 'normalize.css' library (imported through PatternFly) that cause text of disabled inputs to be black instead of gray. Change-Id: I8d05fad020ad32b069a918600315b50571291e63 Bug-Url: https://bugzilla.redhat.com/1166053 Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> --- M packaging/branding/ovirt.brand/ovirt-patternfly-compat.css 1 file changed, 8 insertions(+), 0 deletions(-) Approvals: Jakub Niedermertl: Verified Greg Sheremeta: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/44025 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8d05fad020ad32b069a918600315b50571291e63 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-hosted-engine-setup[master]: packaging: setup: rejecting blank SP UUID from CLI answerfile
by sbonazzo＠redhat.com 28 Jul '15

28 Jul '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: rejecting blank SP UUID from CLI answerfile ...................................................................... packaging: setup: rejecting blank SP UUID from CLI answerfile hosted-engine generates answer file with a blank SP UUID for additional hosts cause it correctly disconnected its SD from that SP. In order to reply a deployment, we still need a random SP_UUID so it now refuses blank SP UUID from CLI answer files. Change-Id: I7e5355840f84f8e76c19ac7458407b69b0b8cf8f Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M src/plugins/ovirt-hosted-engine-setup/storage/storage.py 1 file changed, 6 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/44088 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7e5355840f84f8e76c19ac7458407b69b0b8cf8f Gerrit-PatchSet: 4 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: cleanup - removed unused method in StorageDomainValidator
by amureini＠redhat.com 28 Jul '15

28 Jul '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: cleanup - removed unused method in StorageDomainValidator ...................................................................... core: cleanup - removed unused method in StorageDomainValidator Change-Id: Ic1dfcedda5a8a9c946e82b89a757610cc966d59b Signed-off-by: Vered Volansky <vvolansk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/storage/StorageDomainValidator.java 1 file changed, 0 insertions(+), 9 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved; Passed CI tests Vered Volansky: Verified -- To view, visit https://gerrit.ovirt.org/44008 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic1dfcedda5a8a9c946e82b89a757610cc966d59b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Create a helper for hosted engine functions
by rgolan＠redhat.com 28 Jul '15

28 Jul '15

Roy Golan has submitted this change and it was merged. Change subject: core: Create a helper for hosted engine functions ...................................................................... core: Create a helper for hosted engine functions Change-Id: I91f5c38115c5c9fd5c7d9f262b181468cdab805f Bug-Url: https://bugzilla.redhat.com/1167262 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostedengine/HostedEngineHelper.java 1 file changed, 180 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Roy Golan: Verified Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/43369 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I91f5c38115c5c9fd5c7d9f262b181468cdab805f Gerrit-PatchSet: 16 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-hosted-engine-setup[master]: packaging: setup: add also appliance hostname in its /etc/hosts
by sbonazzo＠redhat.com 28 Jul '15

28 Jul '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: add also appliance hostname in its /etc/hosts ...................................................................... packaging: setup: add also appliance hostname in its /etc/hosts Now engine-setup on the appliance ensures that the appliance is able to resolve itself hostname. Allowing it via /etc/hosts for static configurations. Change-Id: Idf3899de1a0e96f6169349fe29fff6a917a53cce Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M src/plugins/ovirt-hosted-engine-setup/vm/cloud_init.py 1 file changed, 18 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/44076 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idf3899de1a0e96f6169349fe29fff6a917a53cce Gerrit-PatchSet: 3 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-node-plugin-vdsm[master]: engine_page: avoid check of fqdn
by dougsland＠redhat.com 28 Jul '15

28 Jul '15

Douglas Schilling Landgraf has submitted this change and it was merged. Change subject: engine_page: avoid check of fqdn ...................................................................... engine_page: avoid check of fqdn To keep the previous behaviour during TUI registration, do not check FQDN of certificate. Change-Id: I8301722fa39cc0d5fcc25e69bee04c1d2888b46a Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> Reviewed-on: https://gerrit.ovirt.org/44064 Continuous-Integration: Jenkins CI Reviewed-by: Fabian Deutsch <fabiand(a)redhat.com> --- M src/engine_page.py 1 file changed, 1 insertion(+), 5 deletions(-) Approvals: Fabian Deutsch: Looks good to me, but someone else must approve Douglas Schilling Landgraf: Verified; Looks good to me, approved; Passed CI tests Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/44064 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8301722fa39cc0d5fcc25e69bee04c1d2888b46a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-node-plugin-vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: graphicsProtocol in changed fields list
by ofrenkel＠redhat.com 28 Jul '15

28 Jul '15

Omer Frenkel has submitted this change and it was merged. Change subject: core: graphicsProtocol in changed fields list ...................................................................... core: graphicsProtocol in changed fields list After editing parameters of a running VM, list of changed fields that will be updated on the next run is displayed to user. Graphics devices are presented in this list as separate devices (SPICE and VNC) while corresponding to the single field in the UI ("Graphics protocol"). To correct this, 'name' parameter was introduced into @EditableDeviceOnVmStatusField annotation. If it is present, its value will be displayed to the user in the changed fields list, instead of device type name. If two devices have the same name, it will be included into the list only once. This allows, in our case, to present SPICE and VNC devices as single 'graphicsProtocol' field. Change-Id: I95facdae456ca904f1e0d1ece32a96658992b2eb Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1238742 Signed-off-by: Shmuel Melamud <smelamud(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmChangedFieldsForNextRunQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VmManagementParametersBase.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/EditableDeviceOnVmStatusField.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/VmDeviceUpdate.java 5 files changed, 42 insertions(+), 25 deletions(-) Approvals: Jenkins CI: Passed CI tests Shmuel Leib Melamud: Verified Omer Frenkel: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/43938 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I95facdae456ca904f1e0d1ece32a96658992b2eb Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0