September 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: ConnectAllHostsToLunCommand#validateConnectedLuns
by tnisan＠redhat.com 27 Sep '15

27 Sep '15

Tal Nisan has submitted this change and it was merged. Change subject: core: ConnectAllHostsToLunCommand#validateConnectedLuns ...................................................................... core: ConnectAllHostsToLunCommand#validateConnectedLuns Replaced fully qualified @throws definition with the simple class name, as EngineException is already imported. Change-Id: I5d31af8409f801b67bf5ddace925619b266396c9 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ConnectAllHostsToLunCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved; Passed CI tests Allon Mureinik: Verified Freddy Rolland: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/46435 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5d31af8409f801b67bf5ddace925619b266396c9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: ConnectAllHostsToLunCommand#createReturnValue
by tnisan＠redhat.com 27 Sep '15

27 Sep '15

Tal Nisan has submitted this change and it was merged. Change subject: core: ConnectAllHostsToLunCommand#createReturnValue ...................................................................... core: ConnectAllHostsToLunCommand#createReturnValue The whole point of overriding this method is using a different return value. This patch makes it explicit by specifying the return type accordingly, in order to improve the code's readability. Change-Id: Id73db450e19b6a9836df893693cd2bb125e08223 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ConnectAllHostsToLunCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified Freddy Rolland: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/46434 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id73db450e19b6a9836df893693cd2bb125e08223 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5]: engine: Add lock on Extend SD command
by tnisan＠redhat.com 27 Sep '15

27 Sep '15

Tal Nisan has submitted this change and it was merged. Change subject: engine: Add lock on Extend SD command ...................................................................... engine: Add lock on Extend SD command In order to prevent to run the Extend Storage Domain command twice at the same time, an exclusive lock is added to the command. Running this command twice will put the VG in a partial state, creating a PV twice on the same device. Change-Id: Ib9062ba235daa1d25298f1d295b17d15e1528c80 Backport-To: 3.6 Bug-Url: https://bugzilla.redhat.com/1265906 Signed-off-by: Fred Rolland <frolland(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ExtendSANStorageDomainCommand.java 1 file changed, 18 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Looks good to me, approved; Passed CI tests Allon Mureinik: Looks good to me, but someone else must approve Freddy Rolland: Verified -- To view, visit https://gerrit.ovirt.org/46657 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib9062ba235daa1d25298f1d295b17d15e1528c80 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: restapi: Remove deprecated power management elements
by juan.hernandez＠redhat.com 26 Sep '15

26 Sep '15

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Remove deprecated power management elements ...................................................................... restapi: Remove deprecated power management elements Currently the host power management configuration is part of the host resource, using embedded configuration elements: <power_management type="apc"> <enabled>true</enabled> <address>myaddress</address> <username>myaddress</username> <options> <option name="port" value="22/> </option name="slot" value="5/> </options> ... </power_management> This has been changed some time ago, in order to support multiple power management agents, introducing a new "/hosts/{host:id}/fenceagents" collection. The old "type" attribute, the old "address", "username" and "password" elements, and the inner "agents" element directly inside "power_management" were preserved for backwards compatibility. This patch completely remove all these elements, so the only way to query or modify the power management agents is now the "/hosts/{host:id}/fenceagents" sub-collection. Change-Id: I8c57bfd49e2ceaffb4f1c8f1c371a25f0bed68ef Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/README.md M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml M backend/manager/modules/restapi/interface/definition/src/main/schema/api.xsd M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendCapabilitiesResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostsResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/util/FenceOptionsParser.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendCapabilitiesResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendCapabilityResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/util/FenceOptionsParserTest.java D backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/DeprecatedPowerManagementMapper.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/HostMapper.java D backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/DeprecatedPowerManagementMapperTest.java M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/HostMapperTest.java 14 files changed, 150 insertions(+), 670 deletions(-) Approvals: Ori Liel: Looks good to me, approved Juan Hernandez: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/46059 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8c57bfd49e2ceaffb4f1c8f1c371a25f0bed68ef Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Remove useless map in "AddVmTemplateCommand"
by juan.hernandez＠redhat.com 26 Sep '15

26 Sep '15

Juan Hernandez has submitted this change and it was merged. Change subject: core: Remove useless map in "AddVmTemplateCommand" ...................................................................... core: Remove useless map in "AddVmTemplateCommand" This is needed in order to avoid the following findbugs warning: Useless object created Our analysis shows that this object is useless. It's created and modified, but its value never go outside of the method or produce any side-effect. Either there is a mistake and object was intended to be used or it can be removed. This analysis rarely produces false-positives. Common false-positive cases include: - This object used to implicitly throw some obscure exception. - This object used as a stub to generalize the code. - This object used to hold strong references to weak/soft-referenced objects. Bug kind and pattern: UC - UC_USELESS_OBJECT Change-Id: I40cb6ee841129bce0f91b4965d08f13cf7658acc Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java 1 file changed, 0 insertions(+), 2 deletions(-) Approvals: Juan Hernandez: Verified; Passed CI tests Maor Lipchuk: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/46577 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I40cb6ee841129bce0f91b4965d08f13cf7658acc Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: Get "UnassignedDataCenterId" using class instead o...
by juan.hernandez＠redhat.com 26 Sep '15

26 Sep '15

Juan Hernandez has submitted this change and it was merged. Change subject: webadmin: Get "UnassignedDataCenterId" using class instead of instance ...................................................................... webadmin: Get "UnassignedDataCenterId" using class instead of instance This is needed in order to avoid the following find bugs warning: Return value of method without side effect is ignored This code calls a method and ignores the return value. However our analysis shows that the method (including its implementations in subclasses if any) does not produce any effect other than return value. Thus this call can be removed. We are trying to reduce the false positives as much as possible, but in some cases this warning might be wrong. Common false-positive cases include: - The method is designed to be overridden and produce a side effect in other projects which are out of the scope of the analysis. - The method is called to trigger the class loading which may have a side effect. - The method is called just to get some exception. If you feel that our assumption is incorrect, you can use a @CheckReturnValue annotation to instruct FindBugs that ignoring the return value of this method is acceptable. Bug kind and pattern: RV - RV_RETURN_VALUE_IGNORED_NO_SIDE_EFFECT Change-Id: I897dab051d8200b22ff2b8a39a6c9a2d3075ef1e Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/ImportStorageModelBehavior.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Passed CI tests Alexander Wels: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/46553 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I897dab051d8200b22ff2b8a39a6c9a2d3075ef1e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: webadmin: new host provider error message
by piotr.kliczewski＠gmail.com 25 Sep '15

25 Sep '15

Piotr Kliczewski has submitted this change and it was merged. Change subject: webadmin: new host provider error message ...................................................................... webadmin: new host provider error message - When checking the check box for the Foreman/Satellite without selecting a provider and clicking ok, the missing selection was not being highlighted properly. This patch fixes that. Change-Id: Id39034fbed4753ed50a22fd1816af269a5f4729f Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1263323 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java 2 files changed, 8 insertions(+), 0 deletions(-) Approvals: Alexander Wels: Verified Jenkins CI: Passed CI tests Greg Sheremeta: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/46723 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id39034fbed4753ed50a22fd1816af269a5f4729f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5]: restapi: Added pool type to VmPool model
by piotr.kliczewski＠gmail.com 25 Sep '15

25 Sep '15

Piotr Kliczewski has submitted this change and it was merged. Change subject: restapi: Added pool type to VmPool model ...................................................................... restapi: Added pool type to VmPool model Added 'type' field to VmPool model that allows to specify type of the pool when creating it in the form: <type>automatic</type> or <type>manual</type> For backward compatibility, if type of the pool is not specified, VmPoolType.Automatic is used by default. Change-Id: If3922af13a19374d93c8bfc54457cbfbff8341a6 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1244841 Signed-off-by: Shmuel Melamud <smelamud(a)redhat.com> --- A backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/VmPoolType.java M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendCapabilitiesResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmPoolsResource.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmPoolMapper.java 6 files changed, 86 insertions(+), 3 deletions(-) Approvals: Juan Hernandez: Looks good to me, approved Jenkins CI: Passed CI tests Shmuel Leib Melamud: Verified Omer Frenkel: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/46299 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If3922af13a19374d93c8bfc54457cbfbff8341a6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin, userportal: Fix IE image size quirk
by awels＠redhat.com 25 Sep '15

25 Sep '15

Alexander Wels has submitted this change and it was merged. Change subject: webadmin,userportal: Fix IE image size quirk ...................................................................... webadmin,userportal: Fix IE image size quirk IE automatically adds "width" and "height" attributes, with values taken from "src" image data, when an <img> element is created via Image constructor function. For example: var img = new Image(); img.src = "foo.png"; // adds "width" and "height" automatically document.body.appendChild(img); This causes render issues for images that use "src" attribute for initial placeholder image and CSS styling for the actual image. For example: <style> .fooImage { background: url("foo.png"); width: 400px; height: 200px; } </style> <img src="clear.cache.gif" class="fooImage"> In IE, above <img> element would have "width" and "height" attributes, with values from "clear.cache.gif" placeholder image, added automatically: <img src="clear.cache.gif" width="1" height="1" class="fooStyle"> To fix this quirk, "width" and "height" attributes of such images are set to value "auto": <img src="clear.cache.gif" width="auto" height="auto" class="fooStyle"> Change-Id: Ia17eb684cb08c0cb2cd610e38974bc9992e48285 Bug-Url: https://bugzilla.redhat.com/1255428 Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/gin/BaseSystemModule.java A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/system/BrowserHacks.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/ClientAgentType.java 3 files changed, 85 insertions(+), 2 deletions(-) Approvals: Alexander Wels: Verified; Looks good to me, approved Jenkins CI: Passed CI tests Greg Sheremeta: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/46377 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia17eb684cb08c0cb2cd610e38974bc9992e48285 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in jenkins[master]: ovirt-optimizer_standard: drop fc21
by sbonazzo＠redhat.com 25 Sep '15

25 Sep '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: ovirt-optimizer_standard: drop fc21 ...................................................................... ovirt-optimizer_standard: drop fc21 Fix: ovirt-optimizer-ui-0.9-1.fc21.noarch from check-custom-fc21 unresolved deps: ovirt-engine-webadmin-portal >= 0:3.5 since we don't build ovirt-engine for FC21 Change-Id: Ifb28ca1a79257d04128d935e273f21e3e80a2cc7 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M jobs/confs/projects/ovirt-optimizer/ovirt-optimizer_standard.yaml M jobs/confs/projects/ovirt/publish-rpms-nightly-3.6.yaml M jobs/confs/projects/ovirt/publish-rpms-nightly-master.yaml 3 files changed, 6 insertions(+), 7 deletions(-) Approvals: Sandro Bonazzola: Verified; Ready for merge Martin Sivák: Looks good to me Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/46717 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifb28ca1a79257d04128d935e273f21e3e80a2cc7 Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0