September 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Exclude the ME_ENUM_FIELD_SETTER findbugs warning
by juan.hernandez＠redhat.com 29 Sep '15

29 Sep '15

Juan Hernandez has submitted this change and it was merged. Change subject: core: Exclude the ME_ENUM_FIELD_SETTER findbugs warning ...................................................................... core: Exclude the ME_ENUM_FIELD_SETTER findbugs warning Findbugs doesn't like that the OsRepositoryImpl.init method is public, but we need that because it is the mechanism that we use to lazyly initialize the OS repository. This is the findbugs warning: Public enum method unconditionally sets its field This public method declared in public enum unconditionally sets enum field, thus this field can be changed by malicious code or by accident from another package. Though mutable enum fields may be used for lazy initialization, it's a bad practice to expose them to the outer world. Consider removing this method or declaring it package-private. Bug kind and pattern: ME - ME_ENUM_FIELD_SETTER This patch changes the exclude filters for the "utils" project so that this findbugs warning will be ignored. Change-Id: Ibe37f727663fef92bc559edc7d2d665ccdf1aed5 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/utils/exclude-filters.xml 1 file changed, 12 insertions(+), 0 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/46595 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibe37f727663fef92bc559edc7d2d665ccdf1aed5 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Make "SysprepHandler.timeZoneIndex" private
by juan.hernandez＠redhat.com 29 Sep '15

29 Sep '15

Juan Hernandez has submitted this change and it was merged. Change subject: core: Make "SysprepHandler.timeZoneIndex" private ...................................................................... core: Make "SysprepHandler.timeZoneIndex" private This is needed in order to avoid the following findbugs warning: Field is a mutable collection which should be package protected A mutable collection instance is assigned to a final static field, thus can be changed by malicious code or by accident from another package. The field could be made package protected to avoid this vulnerability. Alternatively you may wrap this field into Collections.unmodifiableSet/List/Map/etc. to avoid this vulnerability. Bug kind and pattern: MS - MS_MUTABLE_COLLECTION_PKGPROTECT Change-Id: I6fc8e9cf3218312d53acc87eda3b66e373ef9ca0 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SysprepHandler.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/46598 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6fc8e9cf3218312d53acc87eda3b66e373ef9ca0 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: restapi: Remove the intermediate "tag.parent" element
by juan.hernandez＠redhat.com 29 Sep '15

29 Sep '15

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Remove the intermediate "tag.parent" element ...................................................................... restapi: Remove the intermediate "tag.parent" element Currently the relationship bettween a tag and it's parent tag used to be represented using an intermedite "parent" tag, that in turn contains another "tag" element: <tag> <name>mytag</name> <parent> <tag id="..." href="..."/> </parent> </tag> This patch simplifies this structure so that only one "parent" element is used now: <tag> <name>mytag</name> <parent id="..." href="..."/> </tag> Change-Id: I2c4b7a5147a60e55360ca0c4326d7613238b0709 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/README.md M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml M backend/manager/modules/restapi/interface/definition/src/main/schema/api.xsd M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendTagResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendTagsResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendTagResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendTagsResourceTest.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/TagMapper.java 8 files changed, 52 insertions(+), 42 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/46810 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2c4b7a5147a60e55360ca0c4326d7613238b0709 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: restapi: Rename the random number generator "source" elements
by juan.hernandez＠redhat.com 29 Sep '15

29 Sep '15

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Rename the random number generator "source" elements ...................................................................... restapi: Rename the random number generator "source" elements Currently the random number generator sources are reported using a collection of "source" elements wrapped by an element with a name reflecting its use. For example, the required random number generator sources of a cluster are reported as follows: GET /clusters/{cluster:id} <cluster> ... <required_rng_sources> <source>RANDOM</source> </required_rng_sources> ... </cluster> And the random number generator sources suported by a host are reported as follows: GET /hosts/{host:id} <host> ... <hardware_information> <supported_rng_sources> <source>RANDOM</source> </supported_rng_sources> </hardware_information> ... </host> This isn't consistent with the rest of the API, where collections are wrapped by a name in plural and elements by the same name in singular. This patch fixes that. The required random number generator sources will now be reported as follows: GET /clusters/{cluster:id} <cluster> ... <required_rng_sources> <required_rng_sourcesRANDOM</required_rng_source> </required_rng_sources> ... </cluster> And the random number generator sources supported by a host will be reported as follows: GET /hosts/{host:id} <host> ... <hardware_information> <supported_rng_sources> <supported_rng_source>RANDOM</supported_rng_source> </supported_rng_sources> </hardware_information> ... </host> Note the use of "required_rng_source" and "supported_rng_source" instead of just "source". Change-Id: I316139c2521a5dde573a3d2396944281c9c68fb9 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/README.md M backend/manager/modules/restapi/interface/definition/src/main/schema/api.xsd M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/validation/ClusterValidator.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/ClusterMapper.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/HostMapper.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/RngDeviceMapper.java M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/ClusterMapperTest.java 7 files changed, 116 insertions(+), 30 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/46808 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I316139c2521a5dde573a3d2396944281c9c68fb9 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Don't replace Jackson provided by application server
by mperina＠redhat.com 29 Sep '15

29 Sep '15

Martin Peřina has submitted this change and it was merged. Change subject: core: Don't replace Jackson provided by application server ...................................................................... core: Don't replace Jackson provided by application server The following patch replaced the version of Jackson provided by the application server (1.9.2) with the one needed by the OpenStack client (1.9.9): core: Use Jackson 1.9.9 https://gerrit.ovirt.org/33959 That is no longer needed because WildFly 8.2 includes version 1.9.13 (in addition to version 2.x, in a different Java package). JBoss EAP includes version 1.9.9 since version 6.1. Change-Id: I4f003f68e74dadb7ae22a3ba2cd0d561a4f5eedd Bug-Url: https://bugzilla.redhat.com/1266544 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/dependencies/common/pom.xml D backend/manager/dependencies/common/src/main/modules/org/codehaus/jackson/jackson-core-asl/main/module.xml D backend/manager/dependencies/common/src/main/modules/org/codehaus/jackson/jackson-jaxrs/main/module.xml D backend/manager/dependencies/common/src/main/modules/org/codehaus/jackson/jackson-mapper-asl/main/module.xml D backend/manager/dependencies/common/src/main/modules/org/codehaus/jackson/jackson-xc/main/module.xml 5 files changed, 0 insertions(+), 134 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve; Passed CI tests Martin Peřina: Looks good to me, approved Juan Hernandez: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/46798 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4f003f68e74dadb7ae22a3ba2cd0d561a4f5eedd Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Remove public setter from enum "StorageDomainOvfInfoSt...
by juan.hernandez＠redhat.com 29 Sep '15

29 Sep '15

Juan Hernandez has submitted this change and it was merged. Change subject: core: Remove public setter from enum "StorageDomainOvfInfoStatus" ...................................................................... core: Remove public setter from enum "StorageDomainOvfInfoStatus" This is needed in order to avoid the following findbugs warning: Public enum method unconditionally sets its field This public method declared in public enum unconditionally sets enum field, thus this field can be changed by malicious code or by accident from another package. Though mutable enum fields may be used for lazy initialization, it's a bad practice to expose them to the outer world. Consider removing this method or declaring it package-private. Bug kind and pattern: ME - ME_ENUM_FIELD_SETTER Change-Id: I1caf9f40d215fea937cb7deee412563e562b486b Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StorageDomainOvfInfoStatus.java 1 file changed, 0 insertions(+), 4 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/46582 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1caf9f40d215fea937cb7deee412563e562b486b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: restapi: Remove the "permissions.clone" element
by juan.hernandez＠redhat.com 29 Sep '15

29 Sep '15

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Remove the "permissions.clone" element ...................................................................... restapi: Remove the "permissions.clone" element This element isn't really part of the representation of permissions, but a parameter of the operations to create virtual machines or templates: POST /vms <vm> <template id="..."> <permissions> <clone>true</clone> </permissions> </template> </action> POST /templates <template> <vm id="..."> <permissions> <clone>true</clone> </permissions> </vm> </template> This patch removes this element, and replaces it with a new "clone_permissions" matrix parameter: POST /vms;clone_permissions <vm> <template id="..."/> </vm> POST /templates;clone_permissions <template> <vm id="..."/> </template> Change-Id: Ia4add8156ff082d703d25cf3b8a2e40336102869 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/README.md M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml M backend/manager/modules/restapi/interface/definition/src/main/schema/api.xsd M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendTemplatesResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmsResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendTemplatesResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmsResourceTest.java 7 files changed, 75 insertions(+), 27 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/46786 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia4add8156ff082d703d25cf3b8a2e40336102869 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: Network utilisation is not shown for the VM
by piotr.kliczewski＠gmail.com 29 Sep '15

29 Sep '15

Piotr Kliczewski has submitted this change and it was merged. Change subject: core: Network utilisation is not shown for the VM ...................................................................... core: Network utilisation is not shown for the VM Network utilization was not shown for a vm. The network utilization was calculated but not added to the network utilization history. Change-Id: I81100cc8369abe1ff8929478e1556c4e1ab81c2a Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1196640 Signed-off-by: Marcin Mirecki <mmirecki(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmAnalyzer.java 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Marcin Mirecki: Verified Alona Kaplan: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Omer Frenkel: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/46575 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I81100cc8369abe1ff8929478e1556c4e1ab81c2a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5]: packaging: pythonlib: service: by default redirect to /dev/n...
by piotr.kliczewski＠gmail.com 29 Sep '15

29 Sep '15

Piotr Kliczewski has submitted this change and it was merged. Change subject: packaging: pythonlib: service: by default redirect to /dev/null stdout/stderr ...................................................................... packaging: pythonlib: service: by default redirect to /dev/null stdout/stderr this avoid handle inheritance into the daemon process, enables detaching properly from the init.d parent. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1267187 Change-Id: I621a86647c2df1784e94cada25f8a907b5a2f3f3 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> (cherry picked from commit 931f8d1011ced54c60bcacd1220d99e524206478) --- M packaging/pythonlib/ovirt_engine/service.py M packaging/services/ovirt-fence-kdump-listener/ovirt-fence-kdump-listener.py 2 files changed, 2 insertions(+), 5 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/46781 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I621a86647c2df1784e94cada25f8a907b5a2f3f3 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in jenkins[master]: repo_closure_check: fix command line on el7 master
by sbonazzo＠redhat.com 29 Sep '15

29 Sep '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: repo_closure_check: fix command line on el7 master ...................................................................... repo_closure_check: fix command line on el7 master Change-Id: I46c537f9f7b44afba06897386a2a7971c98809e7 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M jobs/packaging/repo_closure_check.sh 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me; Passed CI tests; Ready for merge -- To view, visit https://gerrit.ovirt.org/46802 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I46c537f9f7b44afba06897386a2a7971c98809e7 Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0