September 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.6]: core: Fix of NPE in UnsupportedVmCpuClusterEditChecker
by tnisan＠redhat.com 10 Sep '15

10 Sep '15

Tal Nisan has submitted this change and it was merged. Change subject: core: Fix of NPE in UnsupportedVmCpuClusterEditChecker ...................................................................... core: Fix of NPE in UnsupportedVmCpuClusterEditChecker Cpu name may not be set in Default cluster right after engine installation. This caused NPE in isApplicable() method. Change-Id: I2df36c004018bef751bd67dc2f9b8eae7cfe616a Bug-Url: https://bugzilla.redhat.com/1261851 Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UnsupportedVmCpuClusterEditChecker.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Jakub Niedermertl: Verified Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/46001 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2df36c004018bef751bd67dc2f9b8eae7cfe616a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: webadmin: races in pool edit
by tnisan＠redhat.com 10 Sep '15

10 Sep '15

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: races in pool edit ...................................................................... webadmin: races in pool edit 2 bugs: 1 if the pool was not based on the latest template the model was not properly inited 2 initTemplate() was called in init - but it triggered (async) the templateWithVersion_SelectedItemChanged and in parallel the clusters are loaded. If the clusters were set up before the templateWithVersion_SelectedItemChanged was called, it was ok. If the opposite way around, NPE was thrown Change-Id: I59dcd4b870b76ae849d4a5993adfc6202694e5e7 Bug-Url: https://bugzilla.redhat.com/1260917 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ExistingPoolModelBehavior.java 1 file changed, 3 insertions(+), 2 deletions(-) Approvals: Tomas Jelinek: Verified Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/45937 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I59dcd4b870b76ae849d4a5993adfc6202694e5e7 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Fix of NPE in UnsupportedVmCpuClusterEditChecker
by shavivi＠redhat.com 10 Sep '15

10 Sep '15

Shahar Havivi has submitted this change and it was merged. Change subject: core: Fix of NPE in UnsupportedVmCpuClusterEditChecker ...................................................................... core: Fix of NPE in UnsupportedVmCpuClusterEditChecker Cpu name may not be set in Default cluster right after engine installation. This caused NPE in isApplicable() method. Change-Id: I2df36c004018bef751bd67dc2f9b8eae7cfe616a Bug-Url: https://bugzilla.redhat.com/1261851 Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UnsupportedVmCpuClusterEditChecker.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Jakub Niedermertl: Verified Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Martin Betak: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/45988 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2df36c004018bef751bd67dc2f9b8eae7cfe616a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: unable to remove unmanaged network
by alkaplan＠redhat.com 10 Sep '15

10 Sep '15

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: unable to remove unmanaged network ...................................................................... webadmin: unable to remove unmanaged network Change-Id: Ia3730e394bacb74741922d773758c8d1d34ff6d5 Bug-Url: https://bugzilla.redhat.com/1257027 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostSetupNetworksModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/LogicalNetworkModel.java 2 files changed, 6 insertions(+), 2 deletions(-) Approvals: Martin Mucha: Verified Alona Kaplan: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/45336 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia3730e394bacb74741922d773758c8d1d34ff6d5 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Change IsoDomainListSynchronizer ctor to private
by tnisan＠redhat.com 10 Sep '15

10 Sep '15

Tal Nisan has submitted this change and it was merged. Change subject: core: Change IsoDomainListSynchronizer ctor to private ...................................................................... core: Change IsoDomainListSynchronizer ctor to private The class is a singleton which ctor was made protected wrongly in order to use it for tests, the ctor should be private Change-Id: I2c3c40843d55fe8368747b5b8aadb01de58e9250 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/IsoDomainListSyncronizer.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Verified Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/45919 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2c3c40843d55fe8368747b5b8aadb01de58e9250 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: block move and copy for Cinder disks
by tnisan＠redhat.com 10 Sep '15

10 Sep '15

Tal Nisan has submitted this change and it was merged. Change subject: core: block move and copy for Cinder disks ...................................................................... core: block move and copy for Cinder disks Blocking move/copy operations on CanDo for Cinder disks: * Added validation on DiskValidator. * Modified CanDo on MoveDisksCommand and CopyImageGroupCommand. * Updated tests accordingly. Change-Id: I3c166b4f0190d0384283d69eab3e188b35986b2b Bug-Url: https://bugzilla.redhat.com/1258932 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CopyImageGroupCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExportRepoImageCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveDisksCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/storage/DiskValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ExportRepoImageCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/MoveDisksCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/MoveOrCopyDiskCommandTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 12 files changed, 62 insertions(+), 25 deletions(-) Approvals: Tal Nisan: Passed CI tests Daniel Erez: Verified Maor Lipchuk: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/45955 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3c166b4f0190d0384283d69eab3e188b35986b2b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: webadmin: Fence agent duplicate ip
by tnisan＠redhat.com 10 Sep '15

10 Sep '15

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Fence agent duplicate ip ...................................................................... webadmin: Fence agent duplicate ip - The code was allowing the user to enter a duplicate management ip, compared to the existing fence agents. This would allow one to create duplicate entries that a lot of the code was not able to handle. This patch now checks if the management ip address of a new fence agent is already there. - Also check the list of existing fence agents when loading and will remove duplicate management ips from the list. Change-Id: I419d7acdf98c1cbeec3c18b0c0eb339e9cf25ba7 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1257575 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/FenceAgentModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java 3 files changed, 47 insertions(+), 9 deletions(-) Approvals: Alexander Wels: Verified Jenkins CI: Passed CI tests Vojtech Szocs: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/45880 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I419d7acdf98c1cbeec3c18b0c0eb339e9cf25ba7 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: restapi: Serial console public key config
by tnisan＠redhat.com 10 Sep '15

10 Sep '15

Tal Nisan has submitted this change and it was merged. Change subject: restapi: Serial console public key config ...................................................................... restapi: Serial console public key config Add REST API to list, add and delete SSH Public Keys to users. Due to internal limitations, at most one key can be registered to any user. The API, however, already expose a collection interface to accomodate future extensions. Change-Id: I8a4fb034637d57e7d61255bdb4ad0b6ea1076717 Bug-Url: https://bugzilla.redhat.com/1254445 Signed-off-by: Francesco Romani <fromani(a)redhat.com> --- A backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/aaa/SSHPublicKeyResource.java A backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/aaa/SSHPublicKeysResource.java M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/aaa/UserResource.java M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/aaa/BackendSSHPublicKeyResource.java A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/aaa/BackendSSHPublicKeysResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/aaa/BackendUserResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/aaa/BackendUsersResource.java A backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/SSHPublicKeyMapper.java 10 files changed, 329 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Passed CI tests Juan Hernandez: Looks good to me, approved Francesco Romani: Verified -- To view, visit https://gerrit.ovirt.org/45974 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8a4fb034637d57e7d61255bdb4ad0b6ea1076717 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: add ssh_public_key_id
by tnisan＠redhat.com 10 Sep '15

10 Sep '15

Tal Nisan has submitted this change and it was merged. Change subject: core: add ssh_public_key_id ...................................................................... core: add ssh_public_key_id Next patch wants to expose SSH key configurations to REST API. To properly support this, we need to have per-key GUID, so this patch add the field to UserProfile, until we split out proper SSH public key entity. Noteworthy addition: SSH Public Key and its ID must always be updated together. Change-Id: I02ed638971c2aa45edb48fc7d3a6942f061356f5 Bug-Url: https://bugzilla.redhat.com/1254445 Signed-off-by: Francesco Romani <fromani(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddUserProfileCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateUserProfileCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/UserProfileParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/UserProfile.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/UserProfileDaoImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/UserProfileDaoTest.java M backend/manager/modules/dal/src/test/resources/fixtures.xml A packaging/dbscripts/upgrade/03_06_1810_add_ssh_public_key_id_to_user_profiles_table.sql M packaging/dbscripts/user_profiles_sp.sql 9 files changed, 47 insertions(+), 8 deletions(-) Approvals: Tal Nisan: Passed CI tests Francesco Romani: Verified Omer Frenkel: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/45973 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I02ed638971c2aa45edb48fc7d3a6942f061356f5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: simplify RemoveUserProfileCommand
by tnisan＠redhat.com 10 Sep '15

10 Sep '15

Tal Nisan has submitted this change and it was merged. Change subject: core: simplify RemoveUserProfileCommand ...................................................................... core: simplify RemoveUserProfileCommand RemoveUserProfileCommand had too complex check logic which never triggered. The problem is that client code always use UserID as key, and it may not know (and care about) the profile ID. This patch simplifies the code without making the command less correct: like the other UserProfileCommands, any logged user can only change its own profile. Change-Id: Ie08dd783be8e60207ef49bf98fd991b357391fd7 Bug-Url: https://bugzilla.redhat.com/1254445 Signed-off-by: Francesco Romani <fromani(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddUserProfileCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveUserProfileCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateUserProfileCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UserProfilesOperationCommandBase.java 4 files changed, 17 insertions(+), 13 deletions(-) Approvals: Tal Nisan: Passed CI tests Francesco Romani: Verified Omer Frenkel: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/45972 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie08dd783be8e60207ef49bf98fd991b357391fd7 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0