September 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.6]: core: userprofile: handle guid != userid
by tnisan＠redhat.com 10 Sep '15

10 Sep '15

Tal Nisan has submitted this change and it was merged. Change subject: core: userprofile: handle guid != userid ...................................................................... core: userprofile: handle guid != userid frontend never fills the userId into UserProfileParameters, relying on two facts: - user is logged and implicit in every webadmin/userportal session - that backend will always and only manipulate the profile of the current user, discarding any value is passed. A future patch will add RESTAPI support for key manipulation, and RESTAPI can transparently pass any guid, and backend must explicitely return error if user is not allowed to make changes. This patch enhances userprofile support to accomodate both frontend and RESTAPI needs. Change-Id: I0d1912d48f8b84e7108833331ce5d0620487213f Bug-Url: https://bugzilla.redhat.com/1254445 Signed-off-by: Francesco Romani <fromani(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UserProfilesOperationCommandBase.java 1 file changed, 11 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Passed CI tests Francesco Romani: Verified Omer Frenkel: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/45971 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0d1912d48f8b84e7108833331ce5d0620487213f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: add query to support restapi
by tnisan＠redhat.com 10 Sep '15

10 Sep '15

Tal Nisan has submitted this change and it was merged. Change subject: core: add query to support restapi ...................................................................... core: add query to support restapi RESTAPI will expose ssh public key as collection - not as single instance, to be future compatible. However, backend knows there is at most one key, embedded inside the UserProfile. This patch fills the gap, returning a list of UserProfiles to fit restapi needs. The most correct approach would be to return a list of backend' SSHPublicKeys, but backend has not this Class yet. Change-Id: Ie39404e9eccb15480f79e4438489b8aa0e0895df Bug-Url: https://bugzilla.redhat.com/1254445 Signed-off-by: Francesco Romani <fromani(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetUserProfileAsListQuery.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java 2 files changed, 30 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Francesco Romani: Verified Omer Frenkel: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/45970 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie39404e9eccb15480f79e4438489b8aa0e0895df Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: block Glance domain removal if tasks are running
by tnisan＠redhat.com 10 Sep '15

10 Sep '15

Tal Nisan has submitted this change and it was merged. Change subject: core: block Glance domain removal if tasks are running ...................................................................... core: block Glance domain removal if tasks are running Introduced GlanceProviderValidator and overridden validateRemoveProvider method to block removal when there are related running tasks. Change-Id: Ic25eb1bd61fb33248f3eb4893443d705a6a9bb6d Bug-Url: https://bugzilla.redhat.com/1213763 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExportRepoImageCommand.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/storage/GlanceProviderValidator.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/storage/OpenStackImageProviderProxy.java 3 files changed, 51 insertions(+), 5 deletions(-) Approvals: Tal Nisan: Passed CI tests Daniel Erez: Verified Allon Mureinik: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/45793 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic25eb1bd61fb33248f3eb4893443d705a6a9bb6d Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: engine: fix HostSetupNetworksValidatorTest
by masayag＠redhat.com 10 Sep '15

10 Sep '15

Moti Asayag has submitted this change and it was merged. Change subject: engine: fix HostSetupNetworksValidatorTest ...................................................................... engine: fix HostSetupNetworksValidatorTest Fix HostSetupNetworksValidatorTest. Change-Id: I3a29d6c4f707b8d1241f84fd5b9819f25889c567 Bug-Url: https://bugzilla.redhat.com/1115098 Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksValidatorTest.java 2 files changed, 9 insertions(+), 5 deletions(-) Approvals: Moti Asayag: Looks good to me, approved; Passed CI tests Yevgeny Zaspitsky: Verified -- To view, visit https://gerrit.ovirt.org/45995 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3a29d6c4f707b8d1241f84fd5b9819f25889c567 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: restapi: Add README.md
by juan.hernandez＠redhat.com 10 Sep '15

10 Sep '15

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Add README.md ...................................................................... restapi: Add README.md This patch adds a README.md file to the top level project of the RESTAPI. Change-Id: Ia48d9ac6e398f2cfe70a91d09bc61fadfbe9e7b3 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- A backend/manager/modules/restapi/README.md 1 file changed, 9 insertions(+), 0 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/45991 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia48d9ac6e398f2cfe70a91d09bc61fadfbe9e7b3 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: engine: fix NETWORK_CANNOT_DETACH_NETWORK_USED_BY_VMS msg
by masayag＠redhat.com 10 Sep '15

10 Sep '15

Moti Asayag has submitted this change and it was merged. Change subject: engine: fix NETWORK_CANNOT_DETACH_NETWORK_USED_BY_VMS msg ...................................................................... engine: fix NETWORK_CANNOT_DETACH_NETWORK_USED_BY_VMS msg Fix NETWORK_CANNOT_DETACH_NETWORK_USED_BY_VMS message. Change-Id: I513d13becb3bd6f44615af56b3428ab6a8fc12d0 Bug-Url: https://bugzilla.redhat.com/1115098 Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksValidator.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 5 files changed, 9 insertions(+), 7 deletions(-) Approvals: Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved Yevgeny Zaspitsky: Verified -- To view, visit https://gerrit.ovirt.org/45958 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I513d13becb3bd6f44615af56b3428ab6a8fc12d0 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in otopi[master]: core: reorder unicode str() construction
by Alon Bar-Lev 10 Sep '15

10 Sep '15

Alon Bar-Lev has submitted this change and it was merged. Change subject: core: reorder unicode str() construction ...................................................................... core: reorder unicode str() construction move __repr__ detection to lower priority as object contain this by default and do not call to __str__ for some reason. this cause objects that only override __str__ method to return incorrect string. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1255638 Change-Id: I8df43b87801e1b8cfc1269bf89b83dcdf3f0f7ff Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M src/otopi/common.py 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/45990 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8df43b87801e1b8cfc1269bf89b83dcdf3f0f7ff Gerrit-PatchSet: 1 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Update the version of Jandex
by juan.hernandez＠redhat.com 10 Sep '15

10 Sep '15

Juan Hernandez has submitted this change and it was merged. Change subject: core: Update the version of Jandex ...................................................................... core: Update the version of Jandex This patch updates the version of Jandex used by the JBoss modules plugin, so that it is the same actually used by the application server. In addition this updated version of Jandex fixes a bug that forced us to do an extra copy of .jar files. We no longer need to do that. Change-Id: I1eb62c51e7199483c1869f3eff3244fba2b1b6a6 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M build-tools-root/jboss-modules-maven-plugin/pom.xml M build-tools-root/jboss-modules-maven-plugin/src/main/java/org/ovirt/engine/build/ModulesMojo.java 2 files changed, 18 insertions(+), 32 deletions(-) Approvals: Martin Peřina: Looks good to me, but someone else must approve Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/45873 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1eb62c51e7199483c1869f3eff3244fba2b1b6a6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: scheduler: Select first schedulable VM from candidate pool
by rgolan＠redhat.com 10 Sep '15

10 Sep '15

Roy Golan has submitted this change and it was merged. Change subject: scheduler: Select first schedulable VM from candidate pool ...................................................................... scheduler: Select first schedulable VM from candidate pool When enforcing affinity groups, the enforcer should check every possible candidate until it finds the first schedulable migration instead of choosing one possible candidate randomly and do nothing if the migration of that candidate is not schedulable. Bug-Url: https://bugzilla.redhat.com/1251742 Change-Id: Icd7d039a49252028f8ce14b5ddcb3e9183e62e9a Signed-off-by: Roman Mohr <rmohr(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/arem/AffinityRulesEnforcer.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/scheduling/arem/AffinityRulesEnforcerTest.java 2 files changed, 71 insertions(+), 36 deletions(-) Approvals: Roman Mohr: Verified Jenkins CI: Passed CI tests Roy Golan: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/45346 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icd7d039a49252028f8ce14b5ddcb3e9183e62e9a Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Dudi Maroshi <dudi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tomer Saban <tsaban(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: engine: attach operation fails for new network with label
by tnisan＠redhat.com 10 Sep '15

10 Sep '15

Tal Nisan has submitted this change and it was merged. Change subject: engine: attach operation fails for new network with label ...................................................................... engine: attach operation fails for new network with label Attaching a network to NIC fails via label when the NIC has a label and a new network is created with the same label. (Same error for VLAN/non-VLAN and non-VM network) Change-Id: Ib03c247150982e23a9642caba8e3890e6715f2d1 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1252125 Signed-off-by: Marcin Mirecki <mmirecki(a)redhat.com> (cherry picked from commit 83f9cc6bac44413ce00e1cabd164c77bd53dd934) --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/ManageLabeledNetworksParametersBuilderImpl.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Marcin Mirecki: Verified Alona Kaplan: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/45903 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib03c247150982e23a9642caba8e3890e6715f2d1 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0