September 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.6]: core: Initialize volume for volume classification.
by tnisan＠redhat.com 10 Sep '15

10 Sep '15

Tal Nisan has submitted this change and it was merged. Change subject: core: Initialize volume for volume classification. ...................................................................... core: Initialize volume for volume classification. Cloned Cinder disk should have volume classification specified as volume. Change-Id: I76094a8220e93ce26d109d6a10834d58f8d6acee Bug-Url: https://bugzilla.redhat.com/1255221 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/CloneSingleCinderDiskCommand.java 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/45938 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I76094a8220e93ce26d109d6a10834d58f8d6acee Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in jenkins[master]: Remove renew of CA.pem
by eedri＠redhat.com 10 Sep '15

10 Sep '15

Eyal Edri has submitted this change and it was merged. Change subject: Remove renew of CA.pem ...................................................................... Remove renew of CA.pem Removing renew ca.pem from answers file when installing engine. Change-Id: I8d32fc902b82d9b7507b1589ea398a4953a651af Signed-off-by: Sagi Shnaidman <sshnaidm(a)redhat.com> --- M jobs/ovirt-engine_upgrade_to_3.5/setup.file.otopi 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Sandro Bonazzola: Looks good to me Sagi Shnaidman: Verified; Ready for review Eyal Edri: Looks good to me; Passed CI tests; Ready for merge Yedidyah Bar David: Looks good to me -- To view, visit https://gerrit.ovirt.org/45862 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8d32fc902b82d9b7507b1589ea398a4953a651af Gerrit-PatchSet: 2 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Sagi Shnaidman <sshnaidm(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Sagi Shnaidman <sshnaidm(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

1 0

Change in jenkins[master]: Fix when running with mock as main gid
by dcaroest＠redhat.com 10 Sep '15

10 Sep '15

David Caro has submitted this change and it was merged. Change subject: Fix when running with mock as main gid ...................................................................... Fix when running with mock as main gid The mock group is 'renamed' to mockbuild inside the chroot, so trying to create it again fails, this only happens when the user running the script has mock as it's main gid. Change-Id: I99a842f7a4f4576dc4bb3dc62695946954c2ac2d Signed-off-by: David Caro <dcaroest(a)redhat.com> --- M mock_configs/mock_runner.sh 1 file changed, 8 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me; Ready for review David Caro: Verified; Passed CI tests; Ready for merge -- To view, visit https://gerrit.ovirt.org/45981 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I99a842f7a4f4576dc4bb3dc62695946954c2ac2d Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Anatoly Litovsky <tlitovsk(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Max Kovgan <mvk(a)redhat.com> Gerrit-Reviewer: Paz Dangur <pdangur(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Enable memory hotplug on ppc64
by tjelinek＠redhat.com 10 Sep '15

10 Sep '15

Tomas Jelinek has submitted this change and it was merged. Change subject: core: Enable memory hotplug on ppc64 ...................................................................... core: Enable memory hotplug on ppc64 Change-Id: I8dc6eae1d6b6e112a3805fb2095ba58a831fcb9d Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1224886 Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Martin Betak: Verified Omer Frenkel: Looks good to me, approved Michal Skrivanek: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/45729 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8dc6eae1d6b6e112a3805fb2095ba58a831fcb9d Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <mskrivan(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: build: cleanup war packaging
by masayag＠redhat.com 10 Sep '15

10 Sep '15

Moti Asayag has submitted this change and it was merged. Change subject: build: cleanup war packaging ...................................................................... build: cleanup war packaging archive classes as jar. avoid archiving maven information. Change-Id: I6a6a28f11993f86794c955f210543c02ac209185 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/docs/pom.xml M backend/manager/modules/services/pom.xml A backend/manager/modules/welcome/exclude-filters.xml M backend/manager/modules/welcome/pom.xml M frontend/webadmin/modules/userportal-gwtp/pom.xml M frontend/webadmin/modules/webadmin/pom.xml 6 files changed, 124 insertions(+), 1 deletion(-) Approvals: Alon Bar-Lev: Verified Alexander Wels: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/45942 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6a6a28f11993f86794c955f210543c02ac209185 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: fix graphics on import
by ofrenkel＠redhat.com 10 Sep '15

10 Sep '15

Omer Frenkel has submitted this change and it was merged. Change subject: core: fix graphics on import ...................................................................... core: fix graphics on import 1. restore display type values: the values for cirrus (vnc) and qxl changed, this breaks backward compatibility with previously exported vms, so restored to original values. 2. the code that create graphics device on import was called too soon, and device was removed while reloading the vm from export domain during canDoAction, so moved the call to a better place. 3. fixed that code to select spice for qxl, if os support it, to match the previous values in the engine (qxl was always spice) Change-Id: I3fd8351a3f18428cfe905a39221756608b64da05 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1261446 Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportUtils.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/DisplayType.java A packaging/dbscripts/upgrade/03_06_1830_fix_display_type_numbers.sql 4 files changed, 19 insertions(+), 7 deletions(-) Approvals: Jenkins CI: Passed CI tests Frank Kobzik: Looks good to me, but someone else must approve Omer Frenkel: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/45941 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3fd8351a3f18428cfe905a39221756608b64da05 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: restapi: Serial console public key config
by juan.hernandez＠redhat.com 09 Sep '15

09 Sep '15

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Serial console public key config ...................................................................... restapi: Serial console public key config Add REST API to list, add and delete SSH Public Keys to users. Due to internal limitations, at most one key can be registered to any user. The API, however, already expose a collection interface to accomodate future extensions. Change-Id: I8a4fb034637d57e7d61255bdb4ad0b6ea1076717 Bug-Url: https://bugzilla.redhat.com/1254445 Signed-off-by: Francesco Romani <fromani(a)redhat.com> --- A backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/aaa/SSHPublicKeyResource.java A backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/aaa/SSHPublicKeysResource.java M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/aaa/UserResource.java M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml M backend/manager/modules/restapi/interface/definition/src/main/schema/api.xsd A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/aaa/BackendSSHPublicKeyResource.java A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/aaa/BackendSSHPublicKeysResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/aaa/BackendUserResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/aaa/BackendUsersResource.java A backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/SSHPublicKeyMapper.java 10 files changed, 329 insertions(+), 1 deletion(-) Approvals: Juan Hernandez: Looks good to me, approved Jenkins CI: Passed CI tests Francesco Romani: Verified -- To view, visit https://gerrit.ovirt.org/45054 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8a4fb034637d57e7d61255bdb4ad0b6ea1076717 Gerrit-PatchSet: 27 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Network utilisation is not shown for the VM
by ofrenkel＠redhat.com 09 Sep '15

09 Sep '15

Omer Frenkel has submitted this change and it was merged. Change subject: core: Network utilisation is not shown for the VM ...................................................................... core: Network utilisation is not shown for the VM Network utilization was not shown for a vm. The network utilization was calculated but not added to the network utilization history. Change-Id: I81100cc8369abe1ff8929478e1556c4e1ab81c2a Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1196640 Signed-off-by: Marcin Mirecki <mmirecki(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmAnalyzer.java 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Marcin Mirecki: Verified Alona Kaplan: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Omer Frenkel: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/43849 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I81100cc8369abe1ff8929478e1556c4e1ab81c2a Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-hosted-engine-ha[master]: packaging: fixing variable substitution and requiring sudo
by msivak＠redhat.com 09 Sep '15

09 Sep '15

Martin Sivák has submitted this change and it was merged. Change subject: packaging: fixing variable substitution and requiring sudo ...................................................................... packaging: fixing variable substitution and requiring sudo Fixing variable substitution and requiring sudo Change-Id: Icf576b814145f19f9f94eb94d210dfe85bc6bfdc Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M ovirt-hosted-engine-ha.spec.in M sudoers/Makefile.am 2 files changed, 2 insertions(+), 1 deletion(-) Approvals: Martin Sivák: Looks good to me, approved Simone Tiraboschi: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/45952 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icf576b814145f19f9f94eb94d210dfe85bc6bfdc Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: block move and copy for Cinder disks
by derez＠redhat.com 09 Sep '15

09 Sep '15

Daniel Erez has submitted this change and it was merged. Change subject: core: block move and copy for Cinder disks ...................................................................... core: block move and copy for Cinder disks Blocking move/copy operations on CanDo for Cinder disks: * Added validation on DiskValidator. * Modified CanDo on MoveDisksCommand and CopyImageGroupCommand. * Updated tests accordingly. Change-Id: I3c166b4f0190d0384283d69eab3e188b35986b2b Bug-Url: https://bugzilla.redhat.com/1258932 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CopyImageGroupCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExportRepoImageCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveDisksCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/storage/DiskValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ExportRepoImageCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/MoveDisksCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/MoveOrCopyDiskCommandTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 12 files changed, 62 insertions(+), 25 deletions(-) Approvals: Jenkins CI: Passed CI tests Daniel Erez: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/45792 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3c166b4f0190d0384283d69eab3e188b35986b2b Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0