January 2016 - Engine-commits - oVirt List Archives

Change in ovirt-engine-sdk[sdk_3.6]: sdk: Release 3.6.2.1
by juan.hernandez＠redhat.com 12 Jan '16

12 Jan '16

Juan Hernandez has submitted this change and it was merged. Change subject: sdk: Release 3.6.2.1 ...................................................................... sdk: Release 3.6.2.1 Change-Id: I5771ee2d81f0c619aa7a2aeb9bb918826a12aba6 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M Makefile M ovirt-engine-sdk-python.spec.in 2 files changed, 4 insertions(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me; Passed CI tests; Ready for merge -- To view, visit https://gerrit.ovirt.org/51696 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5771ee2d81f0c619aa7a2aeb9bb918826a12aba6 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: sdk_3.6 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk[sdk_3.6]: sdk: Regenerate against the latest API
by juan.hernandez＠redhat.com 12 Jan '16

12 Jan '16

Juan Hernandez has submitted this change and it was merged. Change subject: sdk: Regenerate against the latest API ...................................................................... sdk: Regenerate against the latest API This patch regenerates the SDK using the latest API obtained from the engine built from commit 853788e, tag ovirt-engine-3.6.2.5. Change-Id: I1317a375f69a0c8eed99afe5af3e1e285d559f33 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M generator/pom.xml M generator/src/main/resources/rsdl.xml M src/ovirtsdk/infrastructure/brokers.py 3 files changed, 10 insertions(+), 2 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me; Passed CI tests; Ready for merge -- To view, visit https://gerrit.ovirt.org/51695 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1317a375f69a0c8eed99afe5af3e1e285d559f33 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: sdk_3.6 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: Fix the SCM configuration for API model
by sbonazzo＠redhat.com 12 Jan '16

12 Jan '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: Fix the SCM configuration for API model ...................................................................... Fix the SCM configuration for API model The SCM configuration for the API model project is incorrect, the name of the project has an incorrect "-gerrit" suffix. This patch removes that suffix. Change-Id: Ibcef70d823d54661d63f8d024ff395a3d95cb4e2 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M jobs/confs/yaml/scms/ovirt-engine-api-model.yaml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified; Looks good to me; Ready for merge Juan Hernandez: Ready for review Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/51166 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibcef70d823d54661d63f8d024ff395a3d95cb4e2 Gerrit-PatchSet: 2 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: David Caro <dcaro(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: Fix the SCM configuration for API metamodel
by sbonazzo＠redhat.com 12 Jan '16

12 Jan '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: Fix the SCM configuration for API metamodel ...................................................................... Fix the SCM configuration for API metamodel The SCM configuration for the API metamodel project is incorrect, the name of the project has an incorrect "-gerrit" suffix. This patch removes that suffix. Change-Id: Iaa3006c30403325a85ce57fb958116514892bcc0 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M jobs/confs/yaml/scms/ovirt-engine-api-metamodel.yaml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified; Looks good to me; Ready for merge Juan Hernandez: Ready for review Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/51165 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaa3006c30403325a85ce57fb958116514892bcc0 Gerrit-PatchSet: 2 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: David Caro <dcaro(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6.2]: build: ovirt-engine-3.6.2.5
by tnisan＠redhat.com 12 Jan '16

12 Jan '16

Tal Nisan has submitted this change and it was merged. Change subject: build: ovirt-engine-3.6.2.5 ...................................................................... build: ovirt-engine-3.6.2.5 Change-Id: If7ac1b662ba7ef7061b01ba1ab3fe1f05889fc59 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M automation/build-artifacts.sh M backend/manager/dependencies/common/pom.xml M backend/manager/dependencies/pom.xml M backend/manager/dependencies/tools/pom.xml M backend/manager/extensions-tool/pom.xml M backend/manager/modules/aaa/pom.xml M backend/manager/modules/auth-plugin/pom.xml M backend/manager/modules/bll/pom.xml M backend/manager/modules/branding/pom.xml M backend/manager/modules/builtin-extensions/pom.xml M backend/manager/modules/common/pom.xml M backend/manager/modules/compat/pom.xml M backend/manager/modules/dal/pom.xml M backend/manager/modules/docs/pom.xml M backend/manager/modules/extensions-api-root/extensions-api/pom.xml M backend/manager/modules/extensions-api-root/pom.xml M backend/manager/modules/extensions-manager/pom.xml M backend/manager/modules/logger/pom.xml M backend/manager/modules/pom.xml M backend/manager/modules/restapi/interface/common/jaxrs/pom.xml M backend/manager/modules/restapi/interface/common/pom.xml M backend/manager/modules/restapi/interface/definition/pom.xml M backend/manager/modules/restapi/interface/pom.xml M backend/manager/modules/restapi/jaxrs/pom.xml M backend/manager/modules/restapi/pom.xml M backend/manager/modules/restapi/types/pom.xml M backend/manager/modules/restapi/webapp/pom.xml M backend/manager/modules/root/pom.xml M backend/manager/modules/scheduler/pom.xml M backend/manager/modules/searchbackend/pom.xml M backend/manager/modules/services/pom.xml M backend/manager/modules/utils/pom.xml M backend/manager/modules/uutils/pom.xml M backend/manager/modules/vdsbroker/pom.xml M backend/manager/modules/welcome/pom.xml M backend/manager/pom.xml M backend/manager/tools/pom.xml M backend/pom.xml M build-tools-root/checkstyles/pom.xml M build-tools-root/jboss-modules-maven-plugin/pom.xml M build-tools-root/ovirt-checkstyle-extension/pom.xml M build-tools-root/pom.xml M build/validations/pom.xml M ear/pom.xml M frontend/pom.xml M frontend/webadmin/modules/frontend-symbols/pom.xml M frontend/webadmin/modules/frontend/pom.xml M frontend/webadmin/modules/gwt-common/pom.xml M frontend/webadmin/modules/gwt-extension/pom.xml M frontend/webadmin/modules/pom.xml M frontend/webadmin/modules/uicommonweb/pom.xml M frontend/webadmin/modules/uicompat/pom.xml M frontend/webadmin/modules/userportal-gwtp/pom.xml M frontend/webadmin/modules/webadmin/pom.xml M frontend/webadmin/pom.xml M mavenmake/pom.xml M ovirt-engine.spec.in M pom.xml M version.mak 59 files changed, 66 insertions(+), 66 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/51686 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If7ac1b662ba7ef7061b01ba1ab3fe1f05889fc59 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6.2 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-3.6.2]: core: verify image removal during Live Merge
by tnisan＠redhat.com 12 Jan '16

12 Jan '16

Tal Nisan has submitted this change and it was merged. Change subject: core: verify image removal during Live Merge ...................................................................... core: verify image removal during Live Merge In the multi-step Live Merge process, an image is removed after the merge operation is completed by use of the deleteVolume vdsm verb. If vdsm dies during this task the task must be recovered when vdsm starts up, resulting in a task status of 'cleanSuccess'. Unfortunately, this status is ambiguous regarding whether the deletion succeeded or not, and this causes the entire Live Merge operation to fail. Not only does the initial attempt fail in this case, but a retry will encounter the same error and cleaning up the system requires manual intervention. This fix adds another step to Live Merge to check whether image deletion succeeds regardless of the returned status of deleteVolume. This allows Live Merge to succeed in above case where deletion did occur yet the command was unable to report the success. Note that SPM removal will fix this problem because deleteVolume will no longer report any ambiguous statuses, so this fix may be reverted once SPM removal is in place and the engine no longer needs compatibility with host versions having SPM. Change-Id: Ib3d8e35ff65cf2d9e0cf141a8a20f5dcd6cf8544 Bug-Url: https://bugzilla.redhat.com/1227497 Signed-off-by: Greg Padgett <gpadgett(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DestroyImageCheckCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotSingleDiskLiveCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RemoveSnapshotSingleDiskLiveStep.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/GetVolumeInfoVDSCommandParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSCommandType.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/GetVolumeInfoVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerConnector.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerWrapper.java A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VolumeInfoReturnForXmlRpc.java 12 files changed, 245 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Greg Padgett: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/51684 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib3d8e35ff65cf2d9e0cf141a8a20f5dcd6cf8544 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6.2 Gerrit-Owner: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: verify image removal during Live Merge
by tnisan＠redhat.com 12 Jan '16

12 Jan '16

Tal Nisan has submitted this change and it was merged. Change subject: core: verify image removal during Live Merge ...................................................................... core: verify image removal during Live Merge In the multi-step Live Merge process, an image is removed after the merge operation is completed by use of the deleteVolume vdsm verb. If vdsm dies during this task the task must be recovered when vdsm starts up, resulting in a task status of 'cleanSuccess'. Unfortunately, this status is ambiguous regarding whether the deletion succeeded or not, and this causes the entire Live Merge operation to fail. Not only does the initial attempt fail in this case, but a retry will encounter the same error and cleaning up the system requires manual intervention. This fix adds another step to Live Merge to check whether image deletion succeeds regardless of the returned status of deleteVolume. This allows Live Merge to succeed in above case where deletion did occur yet the command was unable to report the success. Note that SPM removal will fix this problem because deleteVolume will no longer report any ambiguous statuses, so this fix may be reverted once SPM removal is in place and the engine no longer needs compatibility with host versions having SPM. Change-Id: Ib3d8e35ff65cf2d9e0cf141a8a20f5dcd6cf8544 Bug-Url: https://bugzilla.redhat.com/1227497 Signed-off-by: Greg Padgett <gpadgett(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DestroyImageCheckCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotSingleDiskLiveCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RemoveSnapshotSingleDiskLiveStep.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/GetVolumeInfoVDSCommandParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSCommandType.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/GetVolumeInfoVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerConnector.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerWrapper.java A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VolumeInfoReturnForXmlRpc.java 12 files changed, 245 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Looks good to me, approved; Passed CI tests Greg Padgett: Verified -- To view, visit https://gerrit.ovirt.org/51683 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib3d8e35ff65cf2d9e0cf141a8a20f5dcd6cf8544 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: verify image removal during Live Merge
by tnisan＠redhat.com 12 Jan '16

12 Jan '16

Tal Nisan has submitted this change and it was merged. Change subject: core: verify image removal during Live Merge ...................................................................... core: verify image removal during Live Merge In the multi-step Live Merge process, an image is removed after the merge operation is completed by use of the deleteVolume vdsm verb. If vdsm dies during this task the task must be recovered when vdsm starts up, resulting in a task status of 'cleanSuccess'. Unfortunately, this status is ambiguous regarding whether the deletion succeeded or not, and this causes the entire Live Merge operation to fail. Not only does the initial attempt fail in this case, but a retry will encounter the same error and cleaning up the system requires manual intervention. This fix adds another step to Live Merge to check whether image deletion succeeds regardless of the returned status of deleteVolume. This allows Live Merge to succeed in above case where deletion did occur yet the command was unable to report the success. Note that SPM removal will fix this problem because deleteVolume will no longer report any ambiguous statuses, so this fix may be reverted once SPM removal is in place and the engine no longer needs compatibility with host versions having SPM. Change-Id: Ib3d8e35ff65cf2d9e0cf141a8a20f5dcd6cf8544 Bug-Url: https://bugzilla.redhat.com/1227497 Signed-off-by: Greg Padgett <gpadgett(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DestroyImageCheckCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/RemoveSnapshotSingleDiskLiveCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RemoveSnapshotSingleDiskLiveStep.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/GetVolumeInfoVDSCommandParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSCommandType.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/GetVolumeInfoVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerConnector.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerWrapper.java A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VolumeInfoReturnForXmlRpc.java 12 files changed, 242 insertions(+), 0 deletions(-) Approvals: Greg Padgett: Verified Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/51680 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib3d8e35ff65cf2d9e0cf141a8a20f5dcd6cf8544 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6.2]: core: validate profile is not attached before removing it
by tnisan＠redhat.com 12 Jan '16

12 Jan '16

Tal Nisan has submitted this change and it was merged. Change subject: core: validate profile is not attached before removing it ...................................................................... core: validate profile is not attached before removing it When deleting a profile, we will check that there are no vms/templates attached to the profile. For disk profile we'll check also for unattached disks (left disks). Change-Id: Ic927e020118354751943b9890daef52373e3896f Bug-Url: https://bugzilla.redhat.com/1142935 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/profiles/CpuProfileValidator.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/profiles/DiskProfileValidator.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/profiles/ProfileValidator.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/profiles/RemoveProfileCommandBase.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DiskImageDao.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DiskImageDaoImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDao.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDaoImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmTemplateDao.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmTemplateDaoImpl.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/DiskImageDaoTest.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmDaoTest.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmTemplateDaoTest.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M packaging/dbscripts/disk_images_sp.sql M packaging/dbscripts/vm_templates_sp.sql M packaging/dbscripts/vms_sp.sql 21 files changed, 307 insertions(+), 5 deletions(-) Approvals: Roman Mohr: Verified Jenkins CI: Passed CI tests Roy Golan: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/51674 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic927e020118354751943b9890daef52373e3896f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6.2 Gerrit-Owner: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Test for inequal column count
by mperina＠redhat.com 12 Jan '16

12 Jan '16

Martin Peřina has submitted this change and it was merged. Change subject: core: Test for inequal column count ...................................................................... core: Test for inequal column count In fixtures.xml number of defined columns and columns in each row should be equal. Change-Id: I43bf59366b1349407367715f8f0d50dedfd87bdf Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- A backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/FixturesTest.java M backend/manager/modules/dal/src/test/resources/fixtures.xml 2 files changed, 149 insertions(+), 0 deletions(-) Approvals: Martin Peřina: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/50772 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I43bf59366b1349407367715f8f0d50dedfd87bdf Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0