January 2016 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.6]: core: show snapshot name properly after live merge of snapsh...
by tnisan＠redhat.com 07 Jan '16

07 Jan '16

Tal Nisan has submitted this change and it was merged. Change subject: core: show snapshot name properly after live merge of snapshot disk ...................................................................... core: show snapshot name properly after live merge of snapshot disk After Live Merge of a snapshot disk (Storage > Disk Snapshots > Remove), the audit log shows the snapshot name of '<UNKNOWN>'. The problem is that the image record is used to look up the name, and this is not available after the merge operation is done. Instead, cache the snapshot name in the parameters and refer to this after the merge operation is complete. Change-Id: I253806b89f31cb31e0a145dfe22a6f3ba30579f8 Bug-Url: https://bugzilla.redhat.com/1204609 Signed-off-by: Greg Padgett <gpadgett(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskSnapshotsCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RemoveDiskSnapshotsParameters.java 2 files changed, 19 insertions(+), 6 deletions(-) Approvals: Greg Padgett: Verified Daniel Erez: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/51347 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I253806b89f31cb31e0a145dfe22a6f3ba30579f8 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: packaging: engine-backup: Fix notification on failure
by sbonazzo＠redhat.com 07 Jan '16

07 Jan '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: engine-backup: Fix notification on failure ...................................................................... packaging: engine-backup: Fix notification on failure engine-backup was displaying a misleading error msg after failing and trying to notify the engine. Added logic to not notify engine if log parameter is not passed. Change-Id: I50ad8f885e4d89af4896163a4c25300979f3c0db Bug-Url: https://bugzilla.redhat.com/1296520 Signed-off-by: Gonzalo Rafuls <grafuls(a)redhat.com> --- M packaging/bin/engine-backup.sh 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Looks good to me, approved Gonzalo Rafuls: Verified Jenkins CI: Passed CI tests Yedidyah Bar David: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/51510 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I50ad8f885e4d89af4896163a4c25300979f3c0db Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gonzalo Rafuls <grafuls(a)redhat.com> Gerrit-Reviewer: Gonzalo Rafuls <grafuls(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: Fix of MigrateDowntimeSupported option
by tnisan＠redhat.com 07 Jan '16

07 Jan '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Fix of MigrateDowntimeSupported option ...................................................................... core: Fix of MigrateDowntimeSupported option There was a typo in database upgrade script for the database option MigrateDowntimeSupported in commit 1a2a5179. As a result, the option name is different in the source code and in the database, producing error message in the log after otherwise successful live migration with clusters < 3.6. This commit fixes the typo in the database. Change-Id: I6a1f88b85c561b6a6b2e5aa59d4e1aeea005ad6a Bug-Url: https://bugzilla.redhat.com/1272084 Signed-off-by: Milan Zamazal <mzamazal(a)redhat.com> --- A packaging/dbscripts/upgrade/03_06_2000_fix_migratedowntime_option.sql M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql 2 files changed, 5 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Passed CI tests Arik Hadas: Looks good to me, approved Milan Zamazal: Verified -- To view, visit https://gerrit.ovirt.org/51491 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6a1f88b85c561b6a6b2e5aa59d4e1aeea005ad6a Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Milan Zamazal <mzamazal(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: userportal: Fix of FE NPE during too fast clicking at list r...
by tnisan＠redhat.com 07 Jan '16

07 Jan '16

Tal Nisan has submitted this change and it was merged. Change subject: userportal: Fix of FE NPE during too fast clicking at list refresh ...................................................................... userportal: Fix of FE NPE during too fast clicking at list refresh Too fast clicking at refresh button in Basic Userportal or Extended Userportal > VMs could cause nearly concurrent run of callbacks in UserPortal(Basic)ListModel#onVmAndPoolLoad() that resulted in getvms() returning null and thus to NPE. * Fields 'vms' and 'pools' transformed to local variables to prevent concurrent data manipulation. * Methods 'onVmAndPoolLoad' and 'finishSearch' moved to parent class - removing code duplication. Change-Id: I8d5bb5587c09cfb8981e51a6cb3202c4f0a9d174 Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1296458 --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/AbstractUserPortalListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalBasicListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalListModel.java 3 files changed, 121 insertions(+), 243 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Jakub Niedermertl: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/51496 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8d5bb5587c09cfb8981e51a6cb3202c4f0a9d174 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6.2]: build: ovirt-engine-3.6.2.3
by piotr.kliczewski＠gmail.com 07 Jan '16

07 Jan '16

Piotr Kliczewski has submitted this change and it was merged. Change subject: build: ovirt-engine-3.6.2.3 ...................................................................... build: ovirt-engine-3.6.2.3 Change-Id: I3fcaf8cc443f9670966ca9e54e6ca2e9ca31df26 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M automation/build-artifacts.sh M backend/manager/dependencies/common/pom.xml M backend/manager/dependencies/pom.xml M backend/manager/dependencies/tools/pom.xml M backend/manager/extensions-tool/pom.xml M backend/manager/modules/aaa/pom.xml M backend/manager/modules/auth-plugin/pom.xml M backend/manager/modules/bll/pom.xml M backend/manager/modules/branding/pom.xml M backend/manager/modules/builtin-extensions/pom.xml M backend/manager/modules/common/pom.xml M backend/manager/modules/compat/pom.xml M backend/manager/modules/dal/pom.xml M backend/manager/modules/docs/pom.xml M backend/manager/modules/extensions-manager/pom.xml M backend/manager/modules/logger/pom.xml M backend/manager/modules/pom.xml M backend/manager/modules/restapi/interface/common/jaxrs/pom.xml M backend/manager/modules/restapi/interface/common/pom.xml M backend/manager/modules/restapi/interface/definition/pom.xml M backend/manager/modules/restapi/interface/pom.xml M backend/manager/modules/restapi/jaxrs/pom.xml M backend/manager/modules/restapi/pom.xml M backend/manager/modules/restapi/types/pom.xml M backend/manager/modules/restapi/webapp/pom.xml M backend/manager/modules/root/pom.xml M backend/manager/modules/scheduler/pom.xml M backend/manager/modules/searchbackend/pom.xml M backend/manager/modules/services/pom.xml M backend/manager/modules/utils/pom.xml M backend/manager/modules/uutils/pom.xml M backend/manager/modules/vdsbroker/pom.xml M backend/manager/modules/welcome/pom.xml M backend/manager/pom.xml M backend/manager/tools/pom.xml M backend/pom.xml M build-tools-root/checkstyles/pom.xml M build-tools-root/jboss-modules-maven-plugin/pom.xml M build-tools-root/ovirt-checkstyle-extension/pom.xml M build-tools-root/pom.xml M build/validations/pom.xml M ear/pom.xml M frontend/pom.xml M frontend/webadmin/modules/frontend-symbols/pom.xml M frontend/webadmin/modules/frontend/pom.xml M frontend/webadmin/modules/gwt-common/pom.xml M frontend/webadmin/modules/gwt-extension/pom.xml M frontend/webadmin/modules/pom.xml M frontend/webadmin/modules/uicommonweb/pom.xml M frontend/webadmin/modules/uicompat/pom.xml M frontend/webadmin/modules/userportal-gwtp/pom.xml M frontend/webadmin/modules/webadmin/pom.xml M frontend/webadmin/pom.xml M mavenmake/pom.xml M ovirt-engine.spec.in M pom.xml M version.mak 57 files changed, 63 insertions(+), 60 deletions(-) Approvals: Piotr Kliczewski: Passed CI tests Martin Peřina: Looks good to me, approved Simone Tiraboschi: Verified; Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/51515 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3fcaf8cc443f9670966ca9e54e6ca2e9ca31df26 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6.2 Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-3.6.2]: build: post ovirt-engine-3.6.2.2
by piotr.kliczewski＠gmail.com 07 Jan '16

07 Jan '16

Piotr Kliczewski has submitted this change and it was merged. Change subject: build: post ovirt-engine-3.6.2.2 ...................................................................... build: post ovirt-engine-3.6.2.2 Change-Id: I413de9e89147d3009a5978d2d6284cf5981ed7ce Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M automation/build-artifacts.sh M backend/manager/dependencies/common/pom.xml M backend/manager/dependencies/pom.xml M backend/manager/dependencies/tools/pom.xml M backend/manager/extensions-tool/pom.xml M backend/manager/modules/aaa/pom.xml M backend/manager/modules/auth-plugin/pom.xml M backend/manager/modules/bll/pom.xml M backend/manager/modules/branding/pom.xml M backend/manager/modules/builtin-extensions/pom.xml M backend/manager/modules/common/pom.xml M backend/manager/modules/compat/pom.xml M backend/manager/modules/dal/pom.xml M backend/manager/modules/docs/pom.xml M backend/manager/modules/extensions-manager/pom.xml M backend/manager/modules/logger/pom.xml M backend/manager/modules/pom.xml M backend/manager/modules/restapi/interface/common/jaxrs/pom.xml M backend/manager/modules/restapi/interface/common/pom.xml M backend/manager/modules/restapi/interface/definition/pom.xml M backend/manager/modules/restapi/interface/pom.xml M backend/manager/modules/restapi/jaxrs/pom.xml M backend/manager/modules/restapi/pom.xml M backend/manager/modules/restapi/types/pom.xml M backend/manager/modules/restapi/webapp/pom.xml M backend/manager/modules/root/pom.xml M backend/manager/modules/scheduler/pom.xml M backend/manager/modules/searchbackend/pom.xml M backend/manager/modules/services/pom.xml M backend/manager/modules/utils/pom.xml M backend/manager/modules/uutils/pom.xml M backend/manager/modules/vdsbroker/pom.xml M backend/manager/modules/welcome/pom.xml M backend/manager/pom.xml M backend/manager/tools/pom.xml M backend/pom.xml M build-tools-root/checkstyles/pom.xml M build-tools-root/jboss-modules-maven-plugin/pom.xml M build-tools-root/ovirt-checkstyle-extension/pom.xml M build-tools-root/pom.xml M build/validations/pom.xml M ear/pom.xml M frontend/pom.xml M frontend/webadmin/modules/frontend-symbols/pom.xml M frontend/webadmin/modules/frontend/pom.xml M frontend/webadmin/modules/gwt-common/pom.xml M frontend/webadmin/modules/gwt-extension/pom.xml M frontend/webadmin/modules/pom.xml M frontend/webadmin/modules/uicommonweb/pom.xml M frontend/webadmin/modules/uicompat/pom.xml M frontend/webadmin/modules/userportal-gwtp/pom.xml M frontend/webadmin/modules/webadmin/pom.xml M frontend/webadmin/pom.xml M mavenmake/pom.xml M pom.xml 55 files changed, 57 insertions(+), 54 deletions(-) Approvals: Piotr Kliczewski: Looks good to me, but someone else must approve Martin Peřina: Looks good to me, approved Simone Tiraboschi: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/51492 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I413de9e89147d3009a5978d2d6284cf5981ed7ce Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6.2 Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-reports[master]: reports: fixed visual flaws in br49 reports
by sradco＠redhat.com 07 Jan '16

07 Jan '16

Shirly Radco has submitted this change and it was merged. Change subject: reports: fixed visual flaws in br49 reports ...................................................................... reports: fixed visual flaws in br49 reports Change-Id: Id1bbff9bf5c68f083280a51e578c75ae35917d8c Bug-Url: https://bugzilla.redhat.com/1259363 Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- M packaging/ovirt-reports/resources/Reports/Service_level/Hosts/heatmap_report_cpu_usage_br49_files/br49_legend.jrxml.data M packaging/ovirt-reports/resources/Reports/Service_level/Hosts/heatmap_report_cpu_usage_br49_files/heatmap_report_cpu_usage_br49_jrxml.data 2 files changed, 47 insertions(+), 23 deletions(-) Approvals: Shirly Radco: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/51493 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id1bbff9bf5c68f083280a51e578c75ae35917d8c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi: Replace 'boolen' type for 'boolean'
by tnisan＠redhat.com 07 Jan '16

07 Jan '16

Tal Nisan has submitted this change and it was merged. Change subject: restapi: Replace 'boolen' type for 'boolean' ...................................................................... restapi: Replace 'boolen' type for 'boolean' Change-Id: Ia2bd2b62df94d3b7f7998fabc38f58c8a633f380 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml 1 file changed, 6 insertions(+), 6 deletions(-) Approvals: Tal Nisan: Verified; Passed CI tests Juan Hernandez: Looks good to me, approved Amit Aviram: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/51435 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia2bd2b62df94d3b7f7998fabc38f58c8a633f380 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: Change min allocated memory of blank template
by tnisan＠redhat.com 07 Jan '16

07 Jan '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Change min allocated memory of blank template ...................................................................... core: Change min allocated memory of blank template The min allocated memory of blank template was by default 0 which is not correct and if such a template is edited, the validations fail. Fixed by changing the min allocated memory to memory size for the blank template if the min allocated memory was still 0 (do not touch if the user has already changed it). Change-Id: I860bf6567462b89260481d4435530295639a7c11 Bug-Url: https://bugzilla.redhat.com/1294488 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- A packaging/dbscripts/upgrade/03_06_1990_chance_min_allocated_mem_of_blank.sql 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Tomas Jelinek: Verified Martin Peřina: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/51502 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I860bf6567462b89260481d4435530295639a7c11 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: Importing a SD should override empty fields
by tnisan＠redhat.com 07 Jan '16

07 Jan '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Importing a SD should override empty fields ...................................................................... core: Importing a SD should override empty fields validate name length only if it is not empty. Empty name or empty description should not be used and should be set from the storageDomainInfo. Change-Id: I0c3a6f688d7f05a79182054a8e34abde14e70d2e Bug-Url: https://bugzilla.redhat.com/1295852 Bug-Url: https://bugzilla.redhat.com/1222571 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddExistingFileStorageDomainCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageDomainCommandBase.java 2 files changed, 17 insertions(+), 2 deletions(-) Approvals: Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/51464 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0c3a6f688d7f05a79182054a8e34abde14e70d2e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0