January 2016 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: engine: Clean few inspection warnings from BaseProviderProxy
by masayag＠redhat.com 05 Jan '16

05 Jan '16

Moti Asayag has submitted this change and it was merged. Change subject: engine: Clean few inspection warnings from BaseProviderProxy ...................................................................... engine: Clean few inspection warnings from BaseProviderProxy Change-Id: I3891bb837aa7c3b0be80755f6084351985aed833 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/BaseProviderProxy.java 1 file changed, 7 insertions(+), 12 deletions(-) Approvals: Jenkins CI: Passed CI tests Moti Asayag: Verified Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/51285 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3891bb837aa7c3b0be80755f6084351985aed833 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-ha[ovirt-hosted-engine-ha-1.3]: Tool to convert OVF to VDSM create VM parameters
by msivak＠redhat.com 05 Jan '16

05 Jan '16

Martin Sivák has submitted this change and it was merged. Change subject: Tool to convert OVF to VDSM create VM parameters ...................................................................... Tool to convert OVF to VDSM create VM parameters ovf2VmParams 1. toDict(ovf) Take an OVF string and will convert it to consumable VmParameters dict. See VmParameters in VDSM API JSON schema https://gerrit.ovirt.org/gitweb?p=vdsm.git;a=blob_plain;f=vdsm/rpc/vdsmapi-… 2. confFromOvf(ovf) A convenience method for creating the String representation of the params, used by 3.5 ha as vm.conf Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1139793 Change-Id: Ie7dd763dd701158e945ed2006520c6a073318d2c Signed-off-by: Roy Golan <rgolan(a)redhat.com> Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M .gitignore M configure.ac M ovirt_hosted_engine_ha/broker/Makefile.am A ovirt_hosted_engine_ha/broker/test/Makefile.am M ovirt_hosted_engine_ha/broker/test/test_monitor.py M ovirt_hosted_engine_ha/env/config.py M ovirt_hosted_engine_ha/lib/Makefile.am M ovirt_hosted_engine_ha/lib/heconflib.py A ovirt_hosted_engine_ha/lib/ovf/Makefile.am A ovirt_hosted_engine_ha/lib/ovf/__init__.py A ovirt_hosted_engine_ha/lib/ovf/ovf2VmParams.py A ovirt_hosted_engine_ha/lib/ovf/ovf2VmParams_test.py A ovirt_hosted_engine_ha/lib/ovf/ovf_store.py A ovirt_hosted_engine_ha/lib/ovf/ovf_test.xml A ovirt_hosted_engine_ha/lib/ovf/ovfenvelope.py 15 files changed, 9,767 insertions(+), 30 deletions(-) Approvals: Martin Sivák: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/51355 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie7dd763dd701158e945ed2006520c6a073318d2c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: ovirt-hosted-engine-ha-1.3 Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6.2]: core: update network status only if there's at least one hos...
by tnisan＠redhat.com 05 Jan '16

05 Jan '16

Tal Nisan has submitted this change and it was merged. Change subject: core: update network status only if there's at least one host with up status ...................................................................... core: update network status only if there's at least one host with up status Change-Id: Id45135af63e7cf11ffbc22292139fdcc12b3f7dc Bug-Url: https://bugzilla.redhat.com/1250063 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/NetworkClusterHelper.java 1 file changed, 107 insertions(+), 40 deletions(-) Approvals: Martin Mucha: Verified Alona Kaplan: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/51354 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id45135af63e7cf11ffbc22292139fdcc12b3f7dc Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6.2 Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: engine: Blank template doesn't appear in user portal's new v...
by tnisan＠redhat.com 05 Jan '16

05 Jan '16

Tal Nisan has submitted this change and it was merged. Change subject: engine: Blank template doesn't appear in user portal's new vm dialog ...................................................................... engine: Blank template doesn't appear in user portal's new vm dialog Regression caused by commit- Ibdb5e05a18c7c08be8aa68226289c3d524d82a9d Change-Id: I48d3c2879b4261bdead61fddc7ceff2cfc479e8b Bug-Url: https://bugzilla.redhat.com/1293152 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UserPortalNewVmModelBehavior.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tomas Jelinek: Looks good to me, approved Alona Kaplan: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/51275 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I48d3c2879b4261bdead61fddc7ceff2cfc479e8b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: Use shorter lambda syntax
by masayag＠redhat.com 05 Jan '16

05 Jan '16

Moti Asayag has submitted this change and it was merged. Change subject: engine: Use shorter lambda syntax ...................................................................... engine: Use shorter lambda syntax Change-Id: Ibe970afd63461b3fed3aa0b3a2fe6b1a594fa761 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/net/HttpURLConnectionBuilder.java 1 file changed, 2 insertions(+), 8 deletions(-) Approvals: Moti Asayag: Verified; Passed CI tests Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/51284 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibe970afd63461b3fed3aa0b3a2fe6b1a594fa761 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: Reduce amount of overloaded methods
by masayag＠redhat.com 05 Jan '16

05 Jan '16

Moti Asayag has submitted this change and it was merged. Change subject: engine: Reduce amount of overloaded methods ...................................................................... engine: Reduce amount of overloaded methods Few methods don't provide any advantage and can be removed. Change-Id: I915304ee3788ba0a012546c938f0e3b7f52ef485 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/foreman/ForemanHostProviderProxy.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/BaseProviderProxy.java 2 files changed, 4 insertions(+), 12 deletions(-) Approvals: Moti Asayag: Verified; Passed CI tests Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/51283 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I915304ee3788ba0a012546c938f0e3b7f52ef485 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: Rename SystemProvider to Engine[Foreman]Provider
by masayag＠redhat.com 05 Jan '16

05 Jan '16

Moti Asayag has submitted this change and it was merged. Change subject: engine: Rename SystemProvider to Engine[Foreman]Provider ...................................................................... engine: Rename SystemProvider to Engine[Foreman]Provider Change-Id: I62af9812bfdc8c8fcf54f73e355084d18304582e Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetErrataForEngineQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetErratumByIdForEngineQuery.java R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/foreman/EngineForemanProviderFinder.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/GetEngineForemanProviderQuery.java D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/GetSystemProviderQuery.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java 6 files changed, 45 insertions(+), 46 deletions(-) Approvals: Moti Asayag: Verified; Passed CI tests Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/51282 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I62af9812bfdc8c8fcf54f73e355084d18304582e Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: Rename errata queries names for engine
by masayag＠redhat.com 05 Jan '16

05 Jan '16

Moti Asayag has submitted this change and it was merged. Change subject: engine: Rename errata queries names for engine ...................................................................... engine: Rename errata queries names for engine The new names will refer to the engine server as 'engine' instead of 'system'. Change-Id: I5a7e7580591a645de8f9542edd15536ab963b124 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetErrataForEngineQuery.java R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetErratumByIdForEngineQuery.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/externalhostproviders/BackendSystemKatelloErrataResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/externalhostproviders/BackendSystemKatelloErratumResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/externalhostproviders/BackendSystemKatelloErrataResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/externalhostproviders/BackendSystemKatelloErratumResourceTest.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/EngineErrataListModel.java 9 files changed, 12 insertions(+), 13 deletions(-) Approvals: Juan Hernandez: Looks good to me, but someone else must approve Moti Asayag: Verified; Passed CI tests Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/51198 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5a7e7580591a645de8f9542edd15536ab963b124 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: Added missing gluster vdsm error codes
by amureini＠redhat.com 05 Jan '16

05 Jan '16

Allon Mureinik has submitted this change and it was merged. Change subject: engine: Added missing gluster vdsm error codes ...................................................................... engine: Added missing gluster vdsm error codes Change-Id: I828587fd6b54bac766feec45270d03182412ecba Bug-Url: https://bugzilla.redhat.com/1191514 Signed-off-by: Sahina Bose <sabose(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineError.java M backend/manager/modules/dal/src/main/resources/bundles/VdsmErrors.properties M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/AbstractGlusterBrokerCommand.java 3 files changed, 11 insertions(+), 2 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved; Passed CI tests Sahina Bose: Verified -- To view, visit https://gerrit.ovirt.org/51185 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I828587fd6b54bac766feec45270d03182412ecba Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: update network status only if there's at least one hos...
by oourfali＠redhat.com 05 Jan '16

05 Jan '16

Oved Ourfali has submitted this change and it was merged. Change subject: core: update network status only if there's at least one host with up status ...................................................................... core: update network status only if there's at least one host with up status Change-Id: Id45135af63e7cf11ffbc22292139fdcc12b3f7dc Bug-Url: https://bugzilla.redhat.com/1250063 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/NetworkClusterHelper.java 1 file changed, 107 insertions(+), 40 deletions(-) Approvals: Martin Mucha: Verified Alona Kaplan: Looks good to me, approved Oved Ourfali: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/50811 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id45135af63e7cf11ffbc22292139fdcc12b3f7dc Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0