January 2016 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: bll cleanup: removed unnecessary explicit typing.
by tjelinek＠redhat.com 26 Jan '16

26 Jan '16

Tomas Jelinek has submitted this change and it was merged. Change subject: core: bll cleanup: removed unnecessary explicit typing. ...................................................................... core: bll cleanup: removed unnecessary explicit typing. done via IDEAs 'explicit type can be replaced with <>' inspection Change-Id: I0d1a9fdf37f57799a9b165669d97f1d93687e71f Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/ActivateDeactivateVmNicCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/InternalClusterPolicies.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/PolicyUnitImpl.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/AddImageFromScratchCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/scheduling/policyunits/CpuPinningPolicyUnitTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/CpuPinningValidatorTest.java 8 files changed, 12 insertions(+), 13 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Martin Mucha: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/51846 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0d1a9fdf37f57799a9b165669d97f1d93687e71f Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-reports[master]: reports: fixed bug in br48 capacity planning
by sradco＠redhat.com 26 Jan '16

26 Jan '16

Shirly Radco has submitted this change and it was merged. Change subject: reports: fixed bug in br48 capacity planning ...................................................................... reports: fixed bug in br48 capacity planning Change-Id: Ie11ca2cddc23c4dd08f4837d5e1da5516ab22b38 Bug-Url: https://bugzilla.redhat.com/1257797 Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- M packaging/ovirt-reports/resources/Reports/Inventory/capacity_planning_br48_files/capacity_planning_br48_jrxml.data 1 file changed, 493 insertions(+), 418 deletions(-) Approvals: Shirly Radco: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/52691 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie11ca2cddc23c4dd08f4837d5e1da5516ab22b38 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Fix ClassCastException in SearchableListModel
by tjelinek＠redhat.com 26 Jan '16

26 Jan '16

Tomas Jelinek has submitted this change and it was merged. Change subject: webadmin: Fix ClassCastException in SearchableListModel ...................................................................... webadmin: Fix ClassCastException in SearchableListModel When new items are selected and determineSelectedItems tries to restore the selection, it blindly assumes that the list item is a subclass of IVdcQueryable which is now always the case: e.g. in the ImportVmModel. Change-Id: I679f132a2d23e285bd12380837d9eea58fb5f55d Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1293269 Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/SearchableListModel.java A frontend/webadmin/modules/uicommonweb/src/test/java/org/ovirt/engine/ui/uicommonweb/models/SearchableListModelTest.java 2 files changed, 41 insertions(+), 3 deletions(-) Approvals: Jenkins CI: Passed CI tests Martin Betak: Verified Vojtech Szocs: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/52694 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I679f132a2d23e285bd12380837d9eea58fb5f55d Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: missing constructor
by alkaplan＠redhat.com 26 Jan '16

26 Jan '16

Alona Kaplan has submitted this change and it was merged. Change subject: core: missing constructor ...................................................................... core: missing constructor absence of constructor which accepts EngineContext parameter can lead to runtime exceptions. Change-Id: I81ed218e127723855ecc8e2c71ce66b501f047fb Bug-Url: https://bugzilla.redhat.com/1299630 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/GetAllChildVlanInterfacesQuery.java 1 file changed, 6 insertions(+), 2 deletions(-) Approvals: Martin Mucha: Verified Alona Kaplan: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/52713 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I81ed218e127723855ecc8e2c71ce66b501f047fb Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: adding missing ctors
by tnisan＠redhat.com 26 Jan '16

26 Jan '16

Tal Nisan has submitted this change and it was merged. Change subject: core: adding missing ctors ...................................................................... core: adding missing ctors When the AsyncTaskManager creats a command it creates it without the context. When migrating the different flows to use coco rather than rely on the async task manager, the modified commands that were used as child commands until now will be created by the async task manager. This patch adds the missing parameters ctor to those commands. Change-Id: Iaae93b7e6b041749c4911806bfdb78fa4afe166c Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1300757 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddImageFromScratchCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateCloneOfTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateImageTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateSnapshotFromTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExtendImageSizeCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveImageGroupCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveTemplateSnapshotCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestoreFromSnapshotCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/TryBackToSnapshotCommand.java 9 files changed, 36 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Liron Aravot: Verified -- To view, visit https://gerrit.ovirt.org/52724 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaae93b7e6b041749c4911806bfdb78fa4afe166c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: frontend: Fix NPE in ImportVms Dialog
by tjelinek＠redhat.com 26 Jan '16

26 Jan '16

Tomas Jelinek has submitted this change and it was merged. Change subject: frontend: Fix NPE in ImportVms Dialog ...................................................................... frontend: Fix NPE in ImportVms Dialog Change-Id: I42b3837321eaf8684a23b410afff2d15e9f13773 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1293269 Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/ImportVmsPopupView.java 1 file changed, 1 insertion(+), 6 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Jenkins CI: Passed CI tests Martin Betak: Verified Arik Hadas: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/52693 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I42b3837321eaf8684a23b410afff2d15e9f13773 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: Add Attach Disk/Cpu profile permissions to all Import/Export...
by tnisan＠redhat.com 26 Jan '16

26 Jan '16

Tal Nisan has submitted this change and it was merged. Change subject: Add Attach Disk/Cpu profile permissions to all Import/Export capable roles ...................................................................... Add Attach Disk/Cpu profile permissions to all Import/Export capable roles Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1255405 Change-Id: Id2cc0e56bd1ea4a5f9aeac0684a2acc3998a5e9d Signed-off-by: Martin Sivak <msivak(a)redhat.com> --- A packaging/dbscripts/upgrade/03_06_2010_add_profile_perms_to_import_export.sql 1 file changed, 14 insertions(+), 0 deletions(-) Approvals: Martin Sivák: Verified Eli Mesika: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Roy Golan: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/52692 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id2cc0e56bd1ea4a5f9aeac0684a2acc3998a5e9d Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-release[master]: Bump version to align the overall oVirt version
by sbonazzo＠redhat.com 26 Jan '16

26 Jan '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: Bump version to align the overall oVirt version ...................................................................... Bump version to align the overall oVirt version Change-Id: Ie6b3108f17270dcc3c453e33d155518f5ac50883 Signed-off-by: Fabian Deutsch <fabiand(a)fedoraproject.org> --- M ovirt-release-master/configure.ac M ovirt-release-master/ovirt-release-master.spec.in 2 files changed, 6 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/52723 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie6b3108f17270dcc3c453e33d155518f5ac50883 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-release Gerrit-Branch: master Gerrit-Owner: Fabian Deutsch <fabiand(a)redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: ovirt-engine: drop 3.6.2 after GA
by sbonazzo＠redhat.com 26 Jan '16

26 Jan '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: ovirt-engine: drop 3.6.2 after GA ...................................................................... ovirt-engine: drop 3.6.2 after GA Change-Id: Id380b0bb134ca2d5ce3eb3720dfda866be8afc94 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M jobs/confs/projects/ovirt-engine/ovirt-engine_standard.yaml M jobs/confs/projects/ovirt-engine/ovirt-engine_upgrade-db.yaml 2 files changed, 0 insertions(+), 6 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/52726 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id380b0bb134ca2d5ce3eb3720dfda866be8afc94 Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: David Caro <dcaro(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-release[master]: node: Rename image placeholder package
by sbonazzo＠redhat.com 26 Jan '16

26 Jan '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: node: Rename image placeholder package ...................................................................... node: Rename image placeholder package Previously the image placeholder package was named `ovirt-release-master-placeholder`, which does not make sense. This patch is renaming the subpackage to `ovirt-node-ng-image-update-placeholder`. Change-Id: If4328acc6b7376d3c12a19a43b4c0a8c1bdd50a6 Signed-off-by: Fabian Deutsch <fabiand(a)fedoraproject.org> --- M ovirt-release-master/ovirt-release-master.spec.in 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Fabian Deutsch: Verified; Looks good to me, but someone else must approve Sandro Bonazzola: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/52722 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If4328acc6b7376d3c12a19a43b4c0a8c1bdd50a6 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-release Gerrit-Branch: master Gerrit-Owner: Fabian Deutsch <fabiand(a)redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0