October 2016 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: MacPoolCommandBase: @Inject MacPoolDao
by amureini＠redhat.com 25 Oct '16

25 Oct '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: MacPoolCommandBase: @Inject MacPoolDao ...................................................................... core: MacPoolCommandBase: @Inject MacPoolDao Change-Id: I0c6c65bbf0a809f994a2ca02da4258d010476cdb Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddMacPoolCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MacPoolCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveMacPoolCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateMacPoolCommand.java 4 files changed, 8 insertions(+), 9 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests Yevgeny Zaspitsky: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/64886 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0c6c65bbf0a809f994a2ca02da4258d010476cdb Gerrit-PatchSet: 19 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: LibvirtSecretCommandBase: @Inject LibvirtSecretDao
by amureini＠redhat.com 25 Oct '16

25 Oct '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: LibvirtSecretCommandBase: @Inject LibvirtSecretDao ...................................................................... core: LibvirtSecretCommandBase: @Inject LibvirtSecretDao Change-Id: I5fc390c3b47b1dceea97079b8a48b70e7a42a7cc Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/storage/AddLibvirtSecretCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/storage/LibvirtSecretCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/storage/RemoveLibvirtSecretCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/storage/UpdateLibvirtSecretCommand.java 4 files changed, 8 insertions(+), 7 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/64885 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5fc390c3b47b1dceea97079b8a48b70e7a42a7cc Gerrit-PatchSet: 19 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: EventSubscriptionCommandBase: @Inject EventDao
by amureini＠redhat.com 25 Oct '16

25 Oct '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: EventSubscriptionCommandBase: @Inject EventDao ...................................................................... core: EventSubscriptionCommandBase: @Inject EventDao @Inject the EventDao. Change-Id: Iaf92e98a23e891a5144db951fb3bedcb87524a03 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddEventSubscriptionCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/EventSubscriptionCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveEventSubscriptionCommand.java 3 files changed, 9 insertions(+), 10 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/64884 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaf92e98a23e891a5144db951fb3bedcb87524a03 Gerrit-PatchSet: 19 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: AbstractVmNumaNodeCommand#vdsNumaNodeDao
by amureini＠redhat.com 25 Oct '16

25 Oct '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: AbstractVmNumaNodeCommand#vdsNumaNodeDao ...................................................................... core: AbstractVmNumaNodeCommand#vdsNumaNodeDao This command already has an injected VdsNumaNodeDao instance, but there's also a getVdsNumaNodeDao() method that returns the instance provided by DbFacade. This patch cleans up the potentially buggy situation, and streamlines the code to use the injected instance. Change-Id: I2f5f5f42f9a10c0c466dba3f8e34cf8026fc90fa Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/numa/vm/AbstractVmNumaNodeCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/numa/vm/AbstractVmNumaNodeCommandTestBase.java 2 files changed, 1 insertion(+), 11 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/64883 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2f5f5f42f9a10c0c466dba3f8e34cf8026fc90fa Gerrit-PatchSet: 19 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: BaseIscsiBondCommand: @Inject IscsiBondDao
by amureini＠redhat.com 25 Oct '16

25 Oct '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: BaseIscsiBondCommand: @Inject IscsiBondDao ...................................................................... core: BaseIscsiBondCommand: @Inject IscsiBondDao @Inject the IscsiBondDao. Change-Id: I2335bd9d2f939dca36b15a73b84d66688cf47288 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/connection/iscsibond/AddIscsiBondCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/connection/iscsibond/BaseIscsiBondCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/connection/iscsibond/EditIscsiBondCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/connection/iscsibond/RemoveIscsiBondCommand.java 4 files changed, 19 insertions(+), 14 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/64882 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2335bd9d2f939dca36b15a73b84d66688cf47288 Gerrit-PatchSet: 19 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: CreateBrickCommand: @Inject StorageDeviceDao
by amureini＠redhat.com 25 Oct '16

25 Oct '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: CreateBrickCommand: @Inject StorageDeviceDao ...................................................................... core: CreateBrickCommand: @Inject StorageDeviceDao Change-Id: If0b3625d587d0e104552db85f77bc65b14d12f43 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/CreateBrickCommand.java 1 file changed, 8 insertions(+), 3 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/65203 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If0b3625d587d0e104552db85f77bc65b14d12f43 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: ManageGlusterServiceCommand: @Inject GlusterServiceDao
by amureini＠redhat.com 25 Oct '16

25 Oct '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: ManageGlusterServiceCommand: @Inject GlusterServiceDao ...................................................................... core: ManageGlusterServiceCommand: @Inject GlusterServiceDao @Inject the GlusterServiceDao and fix the test accordingly. Change-Id: Icdcf6688ba38d3c67c74a043ede7e3eb9c0d0026 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/ManageGlusterServiceCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/ManageGlusterServiceCommandTest.java 2 files changed, 5 insertions(+), 8 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/65202 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icdcf6688ba38d3c67c74a043ede7e3eb9c0d0026 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: ManageGlusterServiceCommand: @Inject GlusterServerServ...
by amureini＠redhat.com 25 Oct '16

25 Oct '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: ManageGlusterServiceCommand: @Inject GlusterServerServiceDao ...................................................................... core: ManageGlusterServiceCommand: @Inject GlusterServerServiceDao @Inject the GlusterServerServiceDao and fix the test accordingly. Change-Id: Ie0b3c144a3f6820fb75b8d25555b25c4f433829d Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/ManageGlusterServiceCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/ManageGlusterServiceCommandTest.java 2 files changed, 7 insertions(+), 7 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/65201 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie0b3c144a3f6820fb75b8d25555b25c4f433829d Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: ScheduleGlusterVolumeSnapshotCommandBase: @Inject Glus...
by amureini＠redhat.com 25 Oct '16

25 Oct '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: ScheduleGlusterVolumeSnapshotCommandBase: @Inject GlusterVolumeSnapshotScheduleDao ...................................................................... core: ScheduleGlusterVolumeSnapshotCommandBase: @Inject GlusterVolumeSnapshotScheduleDao @Inject the GlusterVolumeSnapshotScheduleDao. Change-Id: Ic0257d7baf56eb07f846d12c1c447df8d5555ec2 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/RescheduleGlusterVolumeSnapshotCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/ScheduleGlusterVolumeSnapshotCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/ScheduleGlusterVolumeSnapshotCommandBase.java 3 files changed, 8 insertions(+), 11 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified; Passed CI tests Sahina Bose: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/65200 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic0257d7baf56eb07f846d12c1c447df8d5555ec2 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: UpdateGlusterVolumeSnapshotConfigCommand: @Inject Glus...
by amureini＠redhat.com 25 Oct '16

25 Oct '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: UpdateGlusterVolumeSnapshotConfigCommand: @Inject GlusterVolumeSnapshotConfigDao ...................................................................... core: UpdateGlusterVolumeSnapshotConfigCommand: @Inject GlusterVolumeSnapshotConfigDao @Inject the GlusterVolumeSnapshotConfigDao. Change-Id: Ie6383c7506804b44fe5130df942d07dcbd3cbaaf Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/UpdateGlusterVolumeSnapshotConfigCommand.java 1 file changed, 8 insertions(+), 8 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests Sahina Bose: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/65199 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie6383c7506804b44fe5130df942d07dcbd3cbaaf Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0