October 2016 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: EndExternalStepCommandTest @Before annotation
by tnisan＠redhat.com 24 Oct '16

24 Oct '16

Tal Nisan has submitted this change and it was merged. Change subject: core: EndExternalStepCommandTest @Before annotation ...................................................................... core: EndExternalStepCommandTest @Before annotation Use the @Before annotation to set up the test instead of having to explicitly call setupMock() in each test case. Change-Id: I59a9f88a967dd6225535ffcdf665e07330d32148 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/EndExternalStepCommandTest.java 1 file changed, 3 insertions(+), 6 deletions(-) Approvals: Tal Nisan: Looks good to me, approved; Passed CI tests Allon Mureinik: Verified Objections: Jenkins CI: Failed CI tests -- To view, visit https://gerrit.ovirt.org/64795 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I59a9f88a967dd6225535ffcdf665e07330d32148 Gerrit-PatchSet: 16 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Remove EndExternalStepCommandTest#log
by tnisan＠redhat.com 24 Oct '16

24 Oct '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Remove EndExternalStepCommandTest#log ...................................................................... core: Remove EndExternalStepCommandTest#log Removed the unused mocked logger. Change-Id: I37dac353736e43fdb738396caaf0df91b7e5ce5b Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/EndExternalStepCommandTest.java 1 file changed, 0 insertions(+), 4 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/64796 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I37dac353736e43fdb738396caaf0df91b7e5ce5b Gerrit-PatchSet: 16 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: ClearExternalStepCommandTest @Spy annotation
by tnisan＠redhat.com 24 Oct '16

24 Oct '16

Tal Nisan has submitted this change and it was merged. Change subject: core: ClearExternalStepCommandTest @Spy annotation ...................................................................... core: ClearExternalStepCommandTest @Spy annotation Use the @Spy annotation to facilitate injecting mocks to the command under test in the following patches in the series. Change-Id: I1d190589fa849b429b1ab7e40311902941728bc0 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ClearExternalJobCommandTest.java 1 file changed, 14 insertions(+), 17 deletions(-) Approvals: Tal Nisan: Looks good to me, approved; Passed CI tests Allon Mureinik: Verified Objections: Jenkins CI: Failed CI tests -- To view, visit https://gerrit.ovirt.org/64797 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1d190589fa849b429b1ab7e40311902941728bc0 Gerrit-PatchSet: 16 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Remove ClearExternalStepCommandTest#log
by tnisan＠redhat.com 24 Oct '16

24 Oct '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Remove ClearExternalStepCommandTest#log ...................................................................... core: Remove ClearExternalStepCommandTest#log Removed the unused mocked logger. Change-Id: Ice02828f9cb36d19da7d8972e97e689bd2a2dad0 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ClearExternalJobCommandTest.java 1 file changed, 0 insertions(+), 3 deletions(-) Approvals: Tal Nisan: Looks good to me, approved; Passed CI tests Allon Mureinik: Verified Objections: Jenkins CI: Failed CI tests -- To view, visit https://gerrit.ovirt.org/64799 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ice02828f9cb36d19da7d8972e97e689bd2a2dad0 Gerrit-PatchSet: 16 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: ClearExternalStepCommandTest @Before annotation
by tnisan＠redhat.com 24 Oct '16

24 Oct '16

Tal Nisan has submitted this change and it was merged. Change subject: core: ClearExternalStepCommandTest @Before annotation ...................................................................... core: ClearExternalStepCommandTest @Before annotation Use the @Before annotation to set up the test instead of having to explicitly call setupMock() in each test case. Change-Id: I04e36ee60b96cb9229f23d061a91d7ab61c6cbdd Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ClearExternalJobCommandTest.java 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Tal Nisan: Looks good to me, approved; Passed CI tests Allon Mureinik: Verified Objections: Jenkins CI: Failed CI tests -- To view, visit https://gerrit.ovirt.org/64798 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I04e36ee60b96cb9229f23d061a91d7ab61c6cbdd Gerrit-PatchSet: 16 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: AddVdsSpmIdCommandTest @Spy annotation
by tnisan＠redhat.com 24 Oct '16

24 Oct '16

Tal Nisan has submitted this change and it was merged. Change subject: core: AddVdsSpmIdCommandTest @Spy annotation ...................................................................... core: AddVdsSpmIdCommandTest @Spy annotation Use the @Spy annotation to facilitate injecting mocks to the command under test in the following patches in the series. Change-Id: I62adc73946abe14ead613028dbf0bbde57db527e Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVdsSpmIdCommandTest.java 1 file changed, 5 insertions(+), 7 deletions(-) Approvals: Tal Nisan: Looks good to me, approved; Passed CI tests Allon Mureinik: Verified Objections: Jenkins CI: Failed CI tests -- To view, visit https://gerrit.ovirt.org/65192 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I62adc73946abe14ead613028dbf0bbde57db527e Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: ManageGlusterServiceCommandTest#validateFails
by tnisan＠redhat.com 24 Oct '16

24 Oct '16

Tal Nisan has submitted this change and it was merged. Change subject: core: ManageGlusterServiceCommandTest#validateFails ...................................................................... core: ManageGlusterServiceCommandTest#validateFails Remove double verification of the exact same usecase from this method. Change-Id: Ifdad91ccfdb25e2c7319c27e2e1717675cd5a039 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/ManageGlusterServiceCommandTest.java 1 file changed, 0 insertions(+), 4 deletions(-) Approvals: Tal Nisan: Looks good to me, approved; Passed CI tests Allon Mureinik: Verified Objections: Jenkins CI: Failed CI tests -- To view, visit https://gerrit.ovirt.org/65194 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifdad91ccfdb25e2c7319c27e2e1717675cd5a039 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: ManageGlusterServiceCommandTest: separate tests
by tnisan＠redhat.com 24 Oct '16

24 Oct '16

Tal Nisan has submitted this change and it was merged. Change subject: core: ManageGlusterServiceCommandTest: separate tests ...................................................................... core: ManageGlusterServiceCommandTest: separate tests Separate validateSucceedsWithValidActionTypes() to several test methods, one per test case, as per JUnit's best practices. Change-Id: Ifd82bf4ef2be3cbd07822756b4d3196ad57dbf9b Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/ManageGlusterServiceCommandTest.java 1 file changed, 16 insertions(+), 6 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/65193 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifd82bf4ef2be3cbd07822756b4d3196ad57dbf9b Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: ManageGlusterServiceCommandTest @Spy annotation
by tnisan＠redhat.com 24 Oct '16

24 Oct '16

Tal Nisan has submitted this change and it was merged. Change subject: core: ManageGlusterServiceCommandTest @Spy annotation ...................................................................... core: ManageGlusterServiceCommandTest @Spy annotation Use the @Spy annotation to facilitate injecting mocks to the command under test in the following patches in the series. Change-Id: Ia94af06bfea6762fdc50d7e580a9204c660662e0 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/ManageGlusterServiceCommandTest.java 1 file changed, 66 insertions(+), 88 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/65196 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia94af06bfea6762fdc50d7e580a9204c660662e0 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: ManageGlusterServiceCommand: inline members
by tnisan＠redhat.com 24 Oct '16

24 Oct '16

Tal Nisan has submitted this change and it was merged. Change subject: core: ManageGlusterServiceCommand: inline members ...................................................................... core: ManageGlusterServiceCommand: inline members Keeping members in the command that are just duplicates of the values form the parameters objects leads to data duplicity and potentially nasty bugs. This patch clears up the duplicity by using the values directly from the parameters. As a side bonus, this also makes the code cleaner and testing much easier. Change-Id: Ice26853743c914aa7bd448568fc5d808d8fa291f Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/ManageGlusterServiceCommand.java 1 file changed, 16 insertions(+), 32 deletions(-) Approvals: Tal Nisan: Looks good to me, approved; Passed CI tests Allon Mureinik: Verified Objections: Jenkins CI: Failed CI tests -- To view, visit https://gerrit.ovirt.org/65195 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ice26853743c914aa7bd448568fc5d808d8fa291f Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0