November 2016 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: InClusterUpgradeValidator type inference
by Code Review 30 Nov '16

30 Nov '16

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: core: InClusterUpgradeValidator type inference ...................................................................... core: InClusterUpgradeValidator type inference Change-Id: Ib87f7d5769c9d647dd6c48b78cda397c669c1177 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/InClusterUpgradeValidator.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Verified Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/67558 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib87f7d5769c9d647dd6c48b78cda397c669c1177 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Remove SupportedStorageFormats conf value
by Code Review 30 Nov '16

30 Nov '16

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: core: Remove SupportedStorageFormats conf value ...................................................................... core: Remove SupportedStorageFormats conf value Commit 1bfb5a deleted the unused SupportedStorageFormats config value from the database, but neglected removing it from 0000_config.sql. This patch finishes the job and makes sure this config value is not present in the codebase anymore. Change-Id: Id94a0e808c23984f0a2d3d62ac3fb84ecddbb1b9 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Verified Maor Lipchuk: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/67476 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id94a0e808c23984f0a2d3d62ac3fb84ecddbb1b9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0.6]: webadmin: fix Setup Networks tooltips
by Code Review 29 Nov '16

29 Nov '16

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: webadmin: fix Setup Networks tooltips ...................................................................... webadmin: fix Setup Networks tooltips The tooltips in the Setup Networks Dialog were rendering HTML. Fixed by calling SafeHtmlUtils.fromTrustedString(), and calling setHTML() on the tooltip instead of setText(). Change-Id: I36f99f9294d32e29c5f0bed810da0297f7153689 Bug-Url: https://bugzilla.redhat.com/1396915 Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/tooltip/WidgetTooltip.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/ItemInfoPopup.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/NetworkItemPanel.java 3 files changed, 10 insertions(+), 5 deletions(-) Approvals: Jenkins CI: Passed CI tests Greg Sheremeta: Verified Vojtech Szocs: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/67542 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I36f99f9294d32e29c5f0bed810da0297f7153689 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0.6 Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0.6]: webadmin: changed instance images flows to open the window a...
by Code Review 29 Nov '16

29 Nov '16

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: webadmin: changed instance images flows to open the window above VM window ...................................................................... webadmin: changed instance images flows to open the window above VM window Change-Id: Ieb1f07fceeff0b7975dc8ab51eab625c38d77fdd Bug-Url: https://bugzilla.redhat.com/1391466 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/HasDiskWindow.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/InstanceImageLineModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/InstanceImagesModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/VirtualMachineModule.java 5 files changed, 70 insertions(+), 19 deletions(-) Approvals: Tomas Jelinek: Verified Jenkins CI: Passed CI tests Vojtech Szocs: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/67536 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ieb1f07fceeff0b7975dc8ab51eab625c38d77fdd Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0.6 Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0.6]: webadmin, userportal: Support multiple dialogs per model
by Code Review 29 Nov '16

29 Nov '16

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: webadmin,userportal: Support multiple dialogs per model ...................................................................... webadmin,userportal: Support multiple dialogs per model Before this patch, each model can have only two dialog instances associated & shown at any given time: 1: (generic) dialog instance, bound to 'Window' property 2: (confirm) dialog instance, bound to 'ConfirmWindow' property After this patch, more (custom) dialog instances are supported by means of overriding corresponding ModelBoundPopupResolver methods: * for custom 'Window'-like properties - getWindowPropertyNames - getWindowModel - clearWindowModel * for custom 'ConfirmWindow'-like properties - getConfirmWindowPropertyNames - getConfirmWindowModel - clearConfirmWindowModel Change-Id: Ie136f6cdae498da7533017f4d160d3b4858b0c93 Bug-Url: https://bugzilla.redhat.com/1391466 Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/model/ModelBoundPopupHandler.java 1 file changed, 63 insertions(+), 28 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Jenkins CI: Passed CI tests Greg Sheremeta: Looks good to me, but someone else must approve Vojtech Szocs: Verified -- To view, visit https://gerrit.ovirt.org/67522 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie136f6cdae498da7533017f4d160d3b4858b0c93 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0.6 Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: webadmin: fix Setup Networks tooltips
by Code Review 29 Nov '16

29 Nov '16

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: webadmin: fix Setup Networks tooltips ...................................................................... webadmin: fix Setup Networks tooltips The tooltips in the Setup Networks Dialog were rendering HTML. Fixed by calling SafeHtmlUtils.fromTrustedString(), and calling setHTML() on the tooltip instead of setText(). Change-Id: I36f99f9294d32e29c5f0bed810da0297f7153689 Bug-Url: https://bugzilla.redhat.com/1396915 Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/tooltip/WidgetTooltip.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/ItemInfoPopup.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/NetworkItemPanel.java 3 files changed, 10 insertions(+), 5 deletions(-) Approvals: Jenkins CI: Passed CI tests Greg Sheremeta: Verified Vojtech Szocs: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/67541 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I36f99f9294d32e29c5f0bed810da0297f7153689 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: webadmin, userportal: Support multiple dialogs per model
by Code Review 29 Nov '16

29 Nov '16

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: webadmin,userportal: Support multiple dialogs per model ...................................................................... webadmin,userportal: Support multiple dialogs per model Before this patch, each model can have only two dialog instances associated & shown at any given time: 1: (generic) dialog instance, bound to 'Window' property 2: (confirm) dialog instance, bound to 'ConfirmWindow' property After this patch, more (custom) dialog instances are supported by means of overriding corresponding ModelBoundPopupResolver methods: * for custom 'Window'-like properties - getWindowPropertyNames - getWindowModel - clearWindowModel * for custom 'ConfirmWindow'-like properties - getConfirmWindowPropertyNames - getConfirmWindowModel - clearConfirmWindowModel Change-Id: Ie136f6cdae498da7533017f4d160d3b4858b0c93 Bug-Url: https://bugzilla.redhat.com/1391466 Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/model/ModelBoundPopupHandler.java 1 file changed, 63 insertions(+), 28 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Jenkins CI: Passed CI tests Greg Sheremeta: Looks good to me, but someone else must approve Vojtech Szocs: Verified -- To view, visit https://gerrit.ovirt.org/67521 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie136f6cdae498da7533017f4d160d3b4858b0c93 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: webadmin: changed instance images flows to open the window a...
by Code Review 29 Nov '16

29 Nov '16

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: webadmin: changed instance images flows to open the window above VM window ...................................................................... webadmin: changed instance images flows to open the window above VM window Change-Id: Ieb1f07fceeff0b7975dc8ab51eab625c38d77fdd Bug-Url: https://bugzilla.redhat.com/1391466 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/HasDiskWindow.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/InstanceImageLineModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/InstanceImagesModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/VirtualMachineModule.java 5 files changed, 70 insertions(+), 19 deletions(-) Approvals: Tomas Jelinek: Verified Jenkins CI: Passed CI tests Vojtech Szocs: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/67535 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ieb1f07fceeff0b7975dc8ab51eab625c38d77fdd Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: locking proxy must lock pool and not decorator.
by Code Review 29 Nov '16

29 Nov '16

>From Moti Asayag <masayag(a)redhat.com>: Moti Asayag has submitted this change and it was merged. Change subject: core: locking proxy must lock pool and not decorator. ...................................................................... core: locking proxy must lock pool and not decorator. it occured to me, that we must block concurrent access into decorators, however opposite is true. Concurrent access in decorators is not a problem in current implementation, however having locking proxy on top means, that decorators have extra access into the pool bypassing synchronization, which does cause a problem. Change-Id: I6e25394f00cbb6fe5dbc61886c2955f953db455f Bug-Url: https://bugzilla.redhat.com/1395462 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/macpool/DecoratedMacPoolFactory.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/macpool/DelegatingMacPoolDecorator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/macpool/DecoratedMacPoolFactoryTest.java 3 files changed, 65 insertions(+), 79 deletions(-) Approvals: Marcin Mirecki: Looks good to me, but someone else must approve Martin Mucha: Verified Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved Yevgeny Zaspitsky: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/67246 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6e25394f00cbb6fe5dbc61886c2955f953db455f Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0.6]: core: Make LSM CreateAllSnapshotsFromVmCommand validation in...
by Code Review 29 Nov '16

29 Nov '16

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: Make LSM CreateAllSnapshotsFromVmCommand validation internal ...................................................................... core: Make LSM CreateAllSnapshotsFromVmCommand validation internal Having the CreateAllSnapshotsFromVmCommand instance create for validation without the internal attribute will cause it to fail with "User is not logged in" failure Change-Id: I81a7b7ccfb229bbddcfc85cee94b89eb97fb86bf Bug-Url: https://bugzilla.redhat.com/1396108 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/lsm/LiveMigrateVmDisksCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/67538 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I81a7b7ccfb229bbddcfc85cee94b89eb97fb86bf Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0.6 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0