November 2016 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: @Inject GetVnicProfilesByNetworkIdQuery Daos
by Code Review 09 Nov '16

09 Nov '16

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: core: @Inject GetVnicProfilesByNetworkIdQuery Daos ...................................................................... core: @Inject GetVnicProfilesByNetworkIdQuery Daos @Inject the DAOs instead of explicitly getting them from DbFacade. Change-Id: Ibc66396fc8308ac84386fedf73b9ba82123e376b Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/GetVnicProfilesByNetworkIdQuery.java 1 file changed, 7 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/66334 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibc66396fc8308ac84386fedf73b9ba82123e376b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: @Inject GetVnicProfilesByDataCenterIdQuery Daos
by Code Review 09 Nov '16

09 Nov '16

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: core: @Inject GetVnicProfilesByDataCenterIdQuery Daos ...................................................................... core: @Inject GetVnicProfilesByDataCenterIdQuery Daos @Inject the DAOs instead of explicitly getting them from DbFacade. Change-Id: Iffc0b606e9d36ccece6596e3f2a577db1a8092c7 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/GetVnicProfilesByDataCenterIdQuery.java 1 file changed, 7 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/66333 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iffc0b606e9d36ccece6596e3f2a577db1a8092c7 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: @Inject GetVnicProfileByIdQuery Daos
by Code Review 09 Nov '16

09 Nov '16

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: core: @Inject GetVnicProfileByIdQuery Daos ...................................................................... core: @Inject GetVnicProfileByIdQuery Daos @Inject the DAOs instead of explicitly getting them from DbFacade. Change-Id: I44a62d92cd5a1080195407640f6e5fce3e9630b2 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/GetVnicProfileByIdQuery.java 1 file changed, 7 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/66332 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I44a62d92cd5a1080195407640f6e5fce3e9630b2 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: jsonrpc: version bump
by Code Review 09 Nov '16

09 Nov '16

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: jsonrpc: version bump ...................................................................... jsonrpc: version bump Change-Id: I3ca9060b89de0dd90e81e0720afa4c98634a7a4e Signed-off-by: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> --- M ovirt-engine.spec.in M pom.xml 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Piotr Kliczewski: Verified Martin Peřina: Looks good to me, approved Eyal Edri: Verified Gil Shinar: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/66317 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3ca9060b89de0dd90e81e0720afa4c98634a7a4e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine-sdk-java[master]: Use DiskAttachment.active explicitly
by Code Review 09 Nov '16

09 Nov '16

>From Ondra Machacek <omachace(a)redhat.com>: Ondra Machacek has submitted this change and it was merged. Change subject: Use DiskAttachment.active explicitly ...................................................................... Use DiskAttachment.active explicitly The 'DiskAttachment.active' attribute isn't mandatory when adding a disk attachment to a virtual machine, but if it isn't provided the result is undefined: the disk will be active in some situations, and won't in some other situations. To avoid that uncertainty it is better to always include it with the desired value. This patch changes the examples accordingly. Change-Id: I2e2882418d592b54bc6de270eaaf22ee0b173548 Related-To: https://bugzilla.redhat.com/1390517 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M sdk/src/test/java/org/ovirt/engine/sdk4/examples/AddVmDisk.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Ondra Machacek: Looks good to me, approved Juan Hernandez: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/66342 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2e2882418d592b54bc6de270eaaf22ee0b173548 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk[master]: Use DiskAttachment.active explicitly
by Code Review 09 Nov '16

09 Nov '16

>From Ondra Machacek <omachace(a)redhat.com>: Ondra Machacek has submitted this change and it was merged. Change subject: Use DiskAttachment.active explicitly ...................................................................... Use DiskAttachment.active explicitly The 'DiskAttachment.active' attribute isn't mandatory when adding a disk attachment to a virtual machine, but if it isn't provided the result is undefined: the disk will be active in some situations, and won't in some other situations. To avoid that uncertainty it is better to always include it with the desired value. This patch changes the examples accordingly. Change-Id: Icedc9fe74c2bc00cd158b66e81d478d273a4b605 Related-To: https://bugzilla.redhat.com/1390517 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M sdk/examples/add_vm_disk.py 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Ondra Machacek: Looks good to me, approved Juan Hernandez: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/66340 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icedc9fe74c2bc00cd158b66e81d478d273a4b605 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Add gluster inventory to DashboardDataServlet
by Code Review 09 Nov '16

09 Nov '16

>From Vojtech Szocs <vszocs(a)redhat.com>: Vojtech Szocs has submitted this change and it was merged. Change subject: webadmin: Add gluster inventory to DashboardDataServlet ...................................................................... webadmin: Add gluster inventory to DashboardDataServlet Add gluster volume inventory to DashboardDataServlet. This is required to add gluster volume aggregate status widget in the ovirt dashboard. Note: Currently this patch doesn't consider the bricks status for calculating volume status. I will update the patch to include two new status (UP Degraded, UP Partial) based on the brick status. Change-Id: Ifdeb87f34769487aee6ff8ca20a357d365a70a2e Bug-Url: https://bugzilla.redhat.com/1364999 Signed-off-by: Ramesh Nachimuthu <rnachimu(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterStatus.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/dashboard/DashboardDataServlet.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/dashboard/Inventory.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/dashboard/InventoryHelper.java A frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/dashboard/dao/GlusterVolumeEngineDao.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/dashboard/fake/FakeDataGenerator.java A frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/dashboard/maps/GlusterVolumeStatusMap.java A frontend/webadmin/modules/frontend/src/main/resources/org/ovirt/engine/ui/frontend/server/dashboard/dao/GlusterVolumeEngineDAO.properties 8 files changed, 147 insertions(+), 1 deletion(-) Approvals: Alexander Wels: Looks good to me, approved Jenkins CI: Passed CI tests Sahina Bose: Looks good to me, but someone else must approve Ramesh N: Verified -- To view, visit https://gerrit.ovirt.org/65698 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifdeb87f34769487aee6ff8ca20a357d365a70a2e Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: backend: Migrate OvfHelper to CDI
by Code Review 09 Nov '16

09 Nov '16

>From Martin Betak <mbetak(a)redhat.com>: Martin Betak has submitted this change and it was merged. Change subject: backend: Migrate OvfHelper to CDI ...................................................................... backend: Migrate OvfHelper to CDI Change-Id: I6bf4d61494620d0cbc1535766cad4844d60f8036 Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmFromConfigurationQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmOvfByVmIdQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ConvertVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/GetTemplatesFromExportDomainQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ImportVmFromConfigurationCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ImportVmTemplateFromConfigurationCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/GetUnregisteredEntitiesQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ovfstore/OvfHelper.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/exportimport/ImportVMFromConfigurationCommandTest.java 9 files changed, 61 insertions(+), 16 deletions(-) Approvals: Jenkins CI: Passed CI tests Martin Betak: Verified Allon Mureinik: Looks good to me, but someone else must approve Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/66321 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6bf4d61494620d0cbc1535766cad4844d60f8036 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-java[sdk_3.6]: sdk: Prepare for next development iteration
by Code Review 09 Nov '16

09 Nov '16

>From Juan Hernandez <juan.hernandez(a)redhat.com>: Juan Hernandez has submitted this change and it was merged. Change subject: sdk: Prepare for next development iteration ...................................................................... sdk: Prepare for next development iteration In preparation for the next development iteration this patch increases the version number, adds the SNAPSHOT suffix to the maven version and sets the RPM release number to 0.1. Change-Id: Ibf257fe51e842e9c1e250f215d0095b761c44288 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M sdk/Makefile M sdk/pom.xml 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/66351 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibf257fe51e842e9c1e250f215d0095b761c44288 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: sdk_3.6 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-java[sdk_3.6]: sdk: Release 3.6.10.0
by Code Review 09 Nov '16

09 Nov '16

>From Juan Hernandez <juan.hernandez(a)redhat.com>: Juan Hernandez has submitted this change and it was merged. Change subject: sdk: Release 3.6.10.0 ...................................................................... sdk: Release 3.6.10.0 Change-Id: I1cc0a2ab149f307c51da828074828df43bdc09db Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M sdk/Makefile M sdk/pom.xml M sdk/spec.el6.in M sdk/spec.el7.in M sdk/spec.fc20.in M sdk/spec.fc21.in M sdk/spec.fc22.in M sdk/spec.fc23.in M sdk/spec.fc24.in 9 files changed, 23 insertions(+), 2 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/66350 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1cc0a2ab149f307c51da828074828df43bdc09db Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: sdk_3.6 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0