November 2016 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-4.0]: core: remove GetCpuStatisticsByVdsId
by Code Review 09 Nov '16

09 Nov '16

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: remove GetCpuStatisticsByVdsId ...................................................................... core: remove GetCpuStatisticsByVdsId Remove the unused query GetCpuStatisticsByVdsId. Change-Id: I7bd92acee4bb77898788e1158e9e1df1a4317e96 Bug-Url: https://bugzilla.redhat.com/1340722 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/numa/host/GetCpuStatisticsByVdsIdQuery.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java 2 files changed, 0 insertions(+), 23 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/66052 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7bd92acee4bb77898788e1158e9e1df1a4317e96 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: core: remove vds_cpu_statistics
by Code Review 09 Nov '16

09 Nov '16

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: remove vds_cpu_statistics ...................................................................... core: remove vds_cpu_statistics Remove the table vds_cpu_statistics that the information stored in it is not queried anymore. This is significant as we identified that this table is being updated much too frequently, leading to serious performance degradation on large scale setups. Change-Id: I047017d2c90d253fdb6d5b0edc34bf5595b89647 Bug-Url: https://bugzilla.redhat.com/1340722 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/DbFacade.java D backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsCpuStatisticsDao.java D backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsCpuStatisticsDaoImpl.java D backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VdsCpuStatisticsDaoTest.java M backend/manager/modules/dal/src/test/resources/fixtures.xml M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/HostMonitoring.java A packaging/dbscripts/upgrade/04_00_0970_drop_table_vds_cpu_statistics.sql M packaging/dbscripts/vds_sp.sql 8 files changed, 2 insertions(+), 447 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/66053 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I047017d2c90d253fdb6d5b0edc34bf5595b89647 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: core: remove vm usage related histories from the database
by Code Review 09 Nov '16

09 Nov '16

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: remove vm usage related histories from the database ...................................................................... core: remove vm usage related histories from the database Now that VmStatistics are cached in VmManager, there is no need to dump several things they contain to the database. However, since we currently focus on easy and non-risky things, this patch addresses specifically the memory/cpu/network usage histories - these are really redundant being the database as they are only used by the webadmin that gathers the information using a (search) query that takes this information from VmManager. Unfortunately, we can neither drop the whole statistics from the database nor reduce the frequency of the updates at this stage. This kind of changes can improve performance on large-scale setups significantely since they reduce the amount of data dump into the database substantially. Change-Id: If72063205907c21d9bd80610a1c1ea1356a9c5e6 Bug-Url: https://bugzilla.redhat.com/1340722 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmStatisticsDaoImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmStatisticsDaoTest.java M backend/manager/modules/dal/src/test/resources/fixtures.xml M packaging/dbscripts/create_views.sql A packaging/dbscripts/upgrade/04_00_0980_remove_vm_related_usage_histories.sql M packaging/dbscripts/vms_sp.sql 6 files changed, 3 insertions(+), 78 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/66054 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If72063205907c21d9bd80610a1c1ea1356a9c5e6 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: GetManagementNetworkCandidatesQuery filtering
by Code Review 09 Nov '16

09 Nov '16

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: core: GetManagementNetworkCandidatesQuery filtering ...................................................................... core: GetManagementNetworkCandidatesQuery filtering GetManagementNetworkCandidatesQuery's is when setting up the management network, which is an administrative action, and is indeed only ever called by the webadmin. As such, the filtering parameters are never passed to it, and should be removed from the query's code, as they just cause confusion. Change-Id: I4ef4add9149701d4be307ebdf97e4f2eec9dcef1 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/GetManagementNetworkCandidatesQuery.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/dc/GetManagementNetworkCandidatesQueryTest.java 2 files changed, 2 insertions(+), 16 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/66287 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4ef4add9149701d4be307ebdf97e4f2eec9dcef1 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <wallaroo1976(a)gmail.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: @Inject GetNetworkLabelsByDataCenterIdQuery Daos
by Code Review 09 Nov '16

09 Nov '16

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: core: @Inject GetNetworkLabelsByDataCenterIdQuery Daos ...................................................................... core: @Inject GetNetworkLabelsByDataCenterIdQuery Daos @Inject the DAOs instead of explicitly getting them from DbFacade. Change-Id: Id829e624cf5226871e9b588851a9166ec8de2414 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/GetNetworkLabelsByDataCenterIdQuery.java 1 file changed, 12 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/66291 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id829e624cf5226871e9b588851a9166ec8de2414 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: @Inject GetInterfacesByLabelForNetworkQuery Daos
by Code Review 09 Nov '16

09 Nov '16

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: core: @Inject GetInterfacesByLabelForNetworkQuery Daos ...................................................................... core: @Inject GetInterfacesByLabelForNetworkQuery Daos @Inject the DAOs instead of explicitly getting them from DbFacade. Change-Id: I5b24c9e9cc5de5463a286cf44a51d13d095f8fb9 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/GetInterfacesByLabelForNetworkQuery.java 1 file changed, 19 insertions(+), 6 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/66286 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5b24c9e9cc5de5463a286cf44a51d13d095f8fb9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: @Inject GetAllNetworksQuery Daos
by Code Review 09 Nov '16

09 Nov '16

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: core: @Inject GetAllNetworksQuery Daos ...................................................................... core: @Inject GetAllNetworksQuery Daos @Inject the DAOs instead of explicitly getting them from DbFacade. Change-Id: I2ba4875765e67fb39726023fdee93b2d786a2875 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/GetAllNetworksQuery.java 1 file changed, 8 insertions(+), 4 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/66285 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2ba4875765e67fb39726023fdee93b2d786a2875 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: @Inject GetAllNetworksByQosIdQuery Daos
by Code Review 09 Nov '16

09 Nov '16

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: core: @Inject GetAllNetworksByQosIdQuery Daos ...................................................................... core: @Inject GetAllNetworksByQosIdQuery Daos @Inject the DAOs instead of explicitly getting them from DbFacade. Change-Id: I13bdde6f1a3443bd948e98d668cd1d172bd1f6cb Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/GetAllNetworksByQosIdQuery.java 1 file changed, 7 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/66284 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I13bdde6f1a3443bd948e98d668cd1d172bd1f6cb Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: GetManagementNetworkCandidatesQuery accessors
by Code Review 09 Nov '16

09 Nov '16

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: core: GetManagementNetworkCandidatesQuery accessors ...................................................................... core: GetManagementNetworkCandidatesQuery accessors With the test standardized in the previous patch, there's no need for public access methods of internal resources that the test can override. This patch cleans up the query's code by removing them. Change-Id: Icbca4468dd4fe90b1b35ed8344331e67aab2ca9e Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/GetManagementNetworkCandidatesQuery.java 1 file changed, 2 insertions(+), 10 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/66289 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icbca4468dd4fe90b1b35ed8344331e67aab2ca9e Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Standardize GetManagementNetworkCandidatesQueryTest
by Code Review 09 Nov '16

09 Nov '16

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: core: Standardize GetManagementNetworkCandidatesQueryTest ...................................................................... core: Standardize GetManagementNetworkCandidatesQueryTest Standardized the test to use the AbstractUserQueryTest framework. Change-Id: I37dd7eb2eb57d15885930b19ca03876cd3ea7857 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/dc/GetManagementNetworkCandidatesQueryTest.java 1 file changed, 13 insertions(+), 33 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/66288 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I37dd7eb2eb57d15885930b19ca03876cd3ea7857 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0