December 2016 - Engine-commits - oVirt List Archives

Change in ovirt-engine-sdk-java[master]: Update to model 4.1.24
by Code Review 15 Dec '16

15 Dec '16

>From Ondra Machacek <omachace(a)redhat.com>: Ondra Machacek has submitted this change and it was merged. Change subject: Update to model 4.1.24 ...................................................................... Update to model 4.1.24 The more relevant changes in this new version of the model are the following: * Added new `v4` value to the `StorageFormat` enum. Change-Id: I5ca4f00a7220499b16f18b58e743b7f9238feb43 Signed-off-by: Ondra Machacek <omachace(a)redhat.com> --- M pom.xml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Ondra Machacek: Verified; Looks good to me, approved Juan Hernandez: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/68513 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5ca4f00a7220499b16f18b58e743b7f9238feb43 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: master Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk[master]: Update to model 4.1.24
by Code Review 15 Dec '16

15 Dec '16

>From Ondra Machacek <omachace(a)redhat.com>: Ondra Machacek has submitted this change and it was merged. Change subject: Update to model 4.1.24 ...................................................................... Update to model 4.1.24 The more relevant changes in this new version of the model are the following: * Added new `v4` value to the `StorageFormat` enum. Change-Id: I478a08ac20079fc61814ee8d37fff672ea5058e8 Signed-off-by: Ondra Machacek <omachace(a)redhat.com> --- M pom.xml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Ondra Machacek: Verified; Looks good to me, approved Juan Hernandez: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Maor Lipchuk: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/68511 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I478a08ac20079fc61814ee8d37fff672ea5058e8 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-setup[master]: packaging: spec: require metrics package
by Code Review 15 Dec '16

15 Dec '16

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: spec: require metrics package ...................................................................... packaging: spec: require metrics package ovirt-host-deploy now install collectd and fluentd packages. Added to ovirt-hosted-engine-setup deps avoiding to get them installed later on by ovirt-host-deploy. This also allow to get those deps within ovirt-node-ng image. Change-Id: I9a71ffcc90e0105f2edce2921c23b8875bb6d0b6 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M ovirt-hosted-engine-setup.spec.in 1 file changed, 7 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests Yedidyah Bar David: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/68502 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9a71ffcc90e0105f2edce2921c23b8875bb6d0b6 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-host-deploy[ovirt-host-deploy-1.6]: metrics: Install fluentd and plugins
by Code Review 15 Dec '16

15 Dec '16

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. Change subject: metrics: Install fluentd and plugins ...................................................................... metrics: Install fluentd and plugins Change-Id: I36ca483799a075bcf5158f93f47154864cc3cfc3 Bug-Url: https://bugzilla.redhat.com/1371530 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> (cherry picked from commit 5d53119cc2f0598dfdeedab85613f8eb40d8a145) --- M configure.ac M src/plugins/ovirt-host-deploy/Makefile.am A src/plugins/ovirt-host-deploy/fluentd/Makefile.am A src/plugins/ovirt-host-deploy/fluentd/__init__.py A src/plugins/ovirt-host-deploy/fluentd/packages.py 5 files changed, 132 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/68500 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I36ca483799a075bcf5158f93f47154864cc3cfc3 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: ovirt-host-deploy-1.6 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: HandleVdsVersionCommand#validate early return
by Code Review 15 Dec '16

15 Dec '16

>From Moti Asayag <masayag(a)redhat.com>: Moti Asayag has submitted this change and it was merged. Change subject: core: HandleVdsVersionCommand#validate early return ...................................................................... core: HandleVdsVersionCommand#validate early return Use the early-return idiom to clean up this method and make it easier to read. Change-Id: If2710ddb0bed870b685a3b64070afe18a7a6c7b1 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HandleVdsVersionCommand.java 1 file changed, 5 insertions(+), 7 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Verified Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/68491 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If2710ddb0bed870b685a3b64070afe18a7a6c7b1 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: HandleVdsVersionCommand#checkClusterAdditionalFeatures...
by Code Review 15 Dec '16

15 Dec '16

>From Moti Asayag <masayag(a)redhat.com>: Moti Asayag has submitted this change and it was merged. Change subject: core: HandleVdsVersionCommand#checkClusterAdditionalFeaturesSupported ...................................................................... core: HandleVdsVersionCommand#checkClusterAdditionalFeaturesSupported Remove a redundant return statement at the end of a void method. Change-Id: I393e4d53787f0270d8db76c5f5043a7e456c2dbe Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HandleVdsVersionCommand.java 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Verified Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/68490 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I393e4d53787f0270d8db76c5f5043a7e456c2dbe Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: HandleVdsVersionCommand toString usage
by Code Review 15 Dec '16

15 Dec '16

>From Moti Asayag <masayag(a)redhat.com>: Moti Asayag has submitted this change and it was merged. Change subject: core: HandleVdsVersionCommand toString usage ...................................................................... core: HandleVdsVersionCommand toString usage Calling toString() on a string just returns the same object, making it somewhat redundant. This patch removes such a call in order to clean up the code a bit. Change-Id: Ib973be8d8b21feda3fc42a1d64d899904fac1333 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HandleVdsVersionCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Verified Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/68489 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib973be8d8b21feda3fc42a1d64d899904fac1333 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: HandleVdsVersionCommand type inference
by Code Review 15 Dec '16

15 Dec '16

>From Moti Asayag <masayag(a)redhat.com>: Moti Asayag has submitted this change and it was merged. Change subject: core: HandleVdsVersionCommand type inference ...................................................................... core: HandleVdsVersionCommand type inference Change-Id: Ic8108afd4583b840d53c222668ccc5c82e359522 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HandleVdsVersionCommand.java 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Verified Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/68488 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic8108afd4583b840d53c222668ccc5c82e359522 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-host-deploy[master]: metrics: Install fluentd and plugins
by Code Review 15 Dec '16

15 Dec '16

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. Change subject: metrics: Install fluentd and plugins ...................................................................... metrics: Install fluentd and plugins Change-Id: I36ca483799a075bcf5158f93f47154864cc3cfc3 Bug-Url: https://bugzilla.redhat.com/1371530 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M configure.ac M src/plugins/ovirt-host-deploy/Makefile.am A src/plugins/ovirt-host-deploy/fluentd/Makefile.am A src/plugins/ovirt-host-deploy/fluentd/__init__.py A src/plugins/ovirt-host-deploy/fluentd/packages.py 5 files changed, 132 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Jenkins CI: Passed CI tests Yedidyah Bar David: Verified -- To view, visit https://gerrit.ovirt.org/68498 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I36ca483799a075bcf5158f93f47154864cc3cfc3 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-host-deploy[ovirt-host-deploy-1.6]: metrics: Install collectd and plugins
by Code Review 15 Dec '16

15 Dec '16

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. Change subject: metrics: Install collectd and plugins ...................................................................... metrics: Install collectd and plugins Change-Id: Ieb739107c032bf207b5889806f9fb1a0ef6aaf60 Bug-Url: https://bugzilla.redhat.com/1371530 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> (cherry picked from commit a519130ee756be52c940a25d2cb6b5b4b2742230) --- M configure.ac M src/plugins/ovirt-host-deploy/Makefile.am A src/plugins/ovirt-host-deploy/collectd/Makefile.am A src/plugins/ovirt-host-deploy/collectd/__init__.py A src/plugins/ovirt-host-deploy/collectd/packages.py 5 files changed, 133 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/68497 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ieb739107c032bf207b5889806f9fb1a0ef6aaf60 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: ovirt-host-deploy-1.6 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0