December 2016 - Engine-commits - oVirt List Archives

Change in jenkins[master]: ovirt-engine: fix branch naming
by Code Review 19 Dec '16

19 Dec '16

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. Change subject: ovirt-engine: fix branch naming ...................................................................... ovirt-engine: fix branch naming 4.0 -> 4.1, typo in previous patch. Change-Id: I8ef18dadee5559ec44b3ce66a284b7cb7c9090e4 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M jobs/confs/projects/ovirt-engine/ovirt-engine_standard.yaml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved; Passed CI tests; Ready for merge -- To view, visit https://gerrit.ovirt.org/68723 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8ef18dadee5559ec44b3ce66a284b7cb7c9090e4 Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: remove unneeded query when getting vms to move to unknown
by Code Review 19 Dec '16

19 Dec '16

>From Arik Hadas <ahadas(a)redhat.com>: Arik Hadas has submitted this change and it was merged. Change subject: core: remove unneeded query when getting vms to move to unknown ...................................................................... core: remove unneeded query when getting vms to move to unknown When host monitoring gets a network exception during monitoring of a specific host, it switches this host to maintenance and moves all the VMs running on this host to Unknown. The retrieval of VMs that need to be switched to unknown was composed of two parts: 1. get all the VMs running on the host (their run_on_vds points to that host). 2. get all the VMs that migrate to the host (their migrating_to_vds points to that host) and also are in MigratingTo status. But (2) is redundant since at this phase of the migration run_on_vds must point to the destination host. Therefore, this part is removed. Note: the query for VM dynamics from the database was moved as a preparation for future changes. Change-Id: I1727da9d56cf3b21464da913942f115abeb1bd5b Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java 1 file changed, 7 insertions(+), 16 deletions(-) Approvals: Arik Hadas: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/68693 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1727da9d56cf3b21464da913942f115abeb1bd5b Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: minor refactoring in handling of vds network exceptions
by Code Review 19 Dec '16

19 Dec '16

>From Arik Hadas <ahadas(a)redhat.com>: Arik Hadas has submitted this change and it was merged. Change subject: core: minor refactoring in handling of vds network exceptions ...................................................................... core: minor refactoring in handling of vds network exceptions Change-Id: Ib72d7bff8e16946d151bea712972b5337b9131af Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java 1 file changed, 9 insertions(+), 7 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/68719 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib72d7bff8e16946d151bea712972b5337b9131af Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: fix product key insertion for Windows 2012/2016
by Code Review 19 Dec '16

19 Dec '16

>From Shahar Havivi <shavivi(a)redhat.com>: Shahar Havivi has submitted this change and it was merged. Change subject: engine: fix product key insertion for Windows 2012/2016 ...................................................................... engine: fix product key insertion for Windows 2012/2016 Product key was not properly set in sysprep tempalte for Windows 2012/2012R2/2016. Change-Id: I873a80a473531454e29339bc3f14e106dd6b9491 Signed-off-by: Tomáš Golembiovský <tgolembi(a)redhat.com> --- M packaging/conf/sysprep/sysprep.2k12x64 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Vinzenz Feenstra: Looks good to me, but someone else must approve Tomas Golembiovsky: Verified -- To view, visit https://gerrit.ovirt.org/68694 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I873a80a473531454e29339bc3f14e106dd6b9491 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Golembiovsky <tgolembi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tomas Golembiovsky <tgolembi(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: ovirt-engine: add 4.1 branch
by Code Review 19 Dec '16

19 Dec '16

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. Change subject: ovirt-engine: add 4.1 branch ...................................................................... ovirt-engine: add 4.1 branch ovirt-engine has been branched on Dec 19th 11:00 TLV time Change-Id: I80e272c75dda5d961b6cc8f57bdb22eb445e3cf2 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M jobs/confs/projects/ovirt-engine/ovirt-engine_findbugs.yaml M jobs/confs/projects/ovirt-engine/ovirt-engine_standard.yaml M jobs/confs/projects/ovirt-engine/ovirt-engine_upgrade-engine.yaml M jobs/confs/projects/ovirt/publish-rpms-nightly-4.1.yaml M jobs/confs/yaml/templates/find-bugs.yaml A jobs/ovirt-engine_upgrade_to_4.1/build_engine_rpm.sh A jobs/ovirt-engine_upgrade_to_4.1/cleanup.file.otopi A jobs/ovirt-engine_upgrade_to_4.1/cleanup.sh A jobs/ovirt-engine_upgrade_to_4.1/setup.file.otopi A jobs/ovirt-engine_upgrade_to_4.1/upgrade.sh 10 files changed, 909 insertions(+), 4 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/68708 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I80e272c75dda5d961b6cc8f57bdb22eb445e3cf2 Gerrit-PatchSet: 5 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: added error log for illegal host status during network...
by Code Review 19 Dec '16

19 Dec '16

>From Moti Asayag <masayag(a)redhat.com>: Moti Asayag has submitted this change and it was merged. Change subject: core: added error log for illegal host status during network setup ...................................................................... core: added error log for illegal host status during network setup when trying to setup a network while host status isn't compatible, an error message is sent, however it fails to include the status of the host; it only mentions the allowed. as of now we're only interested in knowing the status internally for debugging purposes and so a simple log message was added. Change-Id: I6c227607cfafbbd5e493c709e1484c1001c10607 Signed-off-by: Leon Goldberg <lgoldber(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/HostValidator.java 1 file changed, 18 insertions(+), 6 deletions(-) Approvals: Martin Mucha: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Leon Goldberg: Verified Dan Kenigsberg: Looks good to me, but someone else must approve Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/68356 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6c227607cfafbbd5e493c709e1484c1001c10607 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Leon Goldberg <lgoldber(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: cleanup in the hierarchy of vm refreshers
by Code Review 19 Dec '16

19 Dec '16

>From Arik Hadas <ahadas(a)redhat.com>: Arik Hadas has submitted this change and it was merged. Change subject: core: cleanup in the hierarchy of vm refreshers ...................................................................... core: cleanup in the hierarchy of vm refreshers PollAllVmStatsOnlyRefresher remains the only child of PollVmStatsRefresher. Therefore, this patch removes the former and merges its code into the latter. Change-Id: I41e00c4135ff5904b56ac7d90aac9bc244e5709e Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/EventVmStatsRefresher.java D backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/PollAllVmStatsOnlyRefresher.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/PollVmStatsRefresher.java 3 files changed, 7 insertions(+), 36 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/68692 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I41e00c4135ff5904b56ac7d90aac9bc244e5709e Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: minor refactoring in handling of vds network exceptions
by Code Review 19 Dec '16

19 Dec '16

>From Arik Hadas <ahadas(a)redhat.com>: Arik Hadas has submitted this change and it was merged. Change subject: core: minor refactoring in handling of vds network exceptions ...................................................................... core: minor refactoring in handling of vds network exceptions 1. calculate the timeout-to-fence only when needed. 2. extract the setting of vds status to not-responsive to one place. Change-Id: I9d573b149093cc7316162dd8ef0148bc33d11900 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java 1 file changed, 3 insertions(+), 4 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/68691 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9d573b149093cc7316162dd8ef0148bc33d11900 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: aaa-ldap: Add build jobs for 4.1
by Code Review 19 Dec '16

19 Dec '16

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. Change subject: aaa-ldap: Add build jobs for 4.1 ...................................................................... aaa-ldap: Add build jobs for 4.1 Change-Id: Iea5a6f666757e32aa141e63d2adcebf9e2f9cd68 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M jobs/confs/projects/ovirt-engine-extension-aaa-ldap/ovirt-engine-extension-aaa-ldap_create-rpms.yaml 1 file changed, 18 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved; Ready for merge Jenkins CI: Passed CI tests Yedidyah Bar David: Looks good to me -- To view, visit https://gerrit.ovirt.org/68661 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iea5a6f666757e32aa141e63d2adcebf9e2f9cd68 Gerrit-PatchSet: 2 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: SshHostRebootCommand type inference
by Code Review 19 Dec '16

19 Dec '16

>From Moti Asayag <masayag(a)redhat.com>: Moti Asayag has submitted this change and it was merged. Change subject: core: SshHostRebootCommand type inference ...................................................................... core: SshHostRebootCommand type inference Change-Id: I5ff651321ed080a84e6606589bb954cc70a5627c Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SshHostRebootCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Verified Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/68703 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5ff651321ed080a84e6606589bb954cc70a5627c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0