December 2016 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Pull up AddVmCommand#getAllImageSnapshots
by Code Review 14 Dec '16

14 Dec '16

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: core: Pull up AddVmCommand#getAllImageSnapshots ...................................................................... core: Pull up AddVmCommand#getAllImageSnapshots Pull up this method to the base class so it's easier to remove it in the next patch. Change-Id: I4ae429ecbe4663e95bccc30522d53d004a41a2c3 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmAndCloneImageCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromTemplateCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmCommandTestBase.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmFromSnapshotCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmFromTemplateCommandTest.java 6 files changed, 11 insertions(+), 27 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Martin Betak: Looks good to me, but someone else must approve Allon Mureinik: Verified; Passed CI tests Freddy Rolland: Looks good to me, but someone else must approve Objections: Jenkins CI: Failed CI tests -- To view, visit https://gerrit.ovirt.org/68363 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4ae429ecbe4663e95bccc30522d53d004a41a2c3 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: Fix guest agent in publisher jobs
by Code Review 14 Dec '16

14 Dec '16

>From Eyal Edri <eedri(a)redhat.com>: Eyal Edri has submitted this change and it was merged. Change subject: Fix guest agent in publisher jobs ...................................................................... Fix guest agent in publisher jobs Change-Id: I6e5c3497f7f5d96f6383b5d881d948e3f664df5b --- M jobs/confs/projects/ovirt/publish-rpms-nightly-3.6.yaml M jobs/confs/projects/ovirt/publish-rpms-nightly-4.0.yaml M jobs/confs/projects/ovirt/publish-rpms-nightly-4.1.yaml M jobs/confs/projects/ovirt/publish-rpms-nightly-master.yaml 4 files changed, 14 insertions(+), 10 deletions(-) Approvals: Eyal Edri: Looks good to me, approved; Ready for merge Gil Shinar: Verified; Ready for review Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/68380 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6e5c3497f7f5d96f6383b5d881d948e3f664df5b Gerrit-PatchSet: 3 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[sdk_4.0]: Add example of how to change fencing option
by Code Review 14 Dec '16

14 Dec '16

>From Juan Hernandez <juan.hernandez(a)redhat.com>: Juan Hernandez has submitted this change and it was merged. Change subject: Add example of how to change fencing option ...................................................................... Add example of how to change fencing option This patch adds an example that shows how to add or update an option of one of the fencing agents of a host. Change-Id: I74df2d74448825de52b62c26c02ed940a8d0d222 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit 5a6fc669493ca5761bfe104e853d9faa06e34a63) --- A sdk/examples/update_fencing_options.rb 1 file changed, 83 insertions(+), 0 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/68382 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I74df2d74448825de52b62c26c02ed940a8d0d222 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: sdk_4.0 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[master]: Add example of how to change fencing option
by Code Review 14 Dec '16

14 Dec '16

>From Juan Hernandez <juan.hernandez(a)redhat.com>: Juan Hernandez has submitted this change and it was merged. Change subject: Add example of how to change fencing option ...................................................................... Add example of how to change fencing option This patch adds an example that shows how to add or update an option of one of the fencing agents of a host. Change-Id: I74df2d74448825de52b62c26c02ed940a8d0d222 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- A sdk/examples/update_fencing_options.rb 1 file changed, 83 insertions(+), 0 deletions(-) Approvals: Ondra Machacek: Looks good to me, but someone else must approve Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/68027 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I74df2d74448825de52b62c26c02ed940a8d0d222 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: api: adding support to reduce luns from domain
by Code Review 14 Dec '16

14 Dec '16

>From Liron Aravot <laravot(a)redhat.com>: Liron Aravot has submitted this change and it was merged. Change subject: api: adding support to reduce luns from domain ...................................................................... api: adding support to reduce luns from domain Change-Id: I158081ca036e5465f95c4a30c47b3be57219947a Bug-Url: http://bugzilla.redhat.com/1403839 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainResourceTest.java 2 files changed, 39 insertions(+), 0 deletions(-) Approvals: Liron Aravot: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/67898 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I158081ca036e5465f95c4a30c47b3be57219947a Gerrit-PatchSet: 19 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: introducing ReduceSANStorageDomainDevicesCommand
by Code Review 14 Dec '16

14 Dec '16

>From Liron Aravot <laravot(a)redhat.com>: Liron Aravot has submitted this change and it was merged. Change subject: core: introducing ReduceSANStorageDomainDevicesCommand ...................................................................... core: introducing ReduceSANStorageDomainDevicesCommand This patch adds the EditSANStorageDomainDevicesCommand that'll be used to edit devices of a block storage domain. The command currently supports removing devices from domains and may be extended in the future to support domain extension as well. The command recieves as a parameter the list of devices to remove from the domain, the command will remove the devices one by one - making sure the data from each device is moved to devices that aren't in the removal list. Change-Id: I44e905833ecac7a6eba20bb418db82a3a622c4e4 Bug-Url: http://bugzilla.redhat.com/1403839 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/BlockStorageDomainHelper.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/ReduceSANStorageDomainDevicesCommand.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/storage/BlockStorageDomainValidator.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ReduceSANStorageDomainDevicesCommandParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties M backend/manager/modules/dal/src/main/resources/bundles/ExecutionMessages.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/frontend/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 14 files changed, 459 insertions(+), 1 deletion(-) Approvals: Liron Aravot: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/67897 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I44e905833ecac7a6eba20bb418db82a3a622c4e4 Gerrit-PatchSet: 17 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: adding RemoveDeviceFromSANStorageDomainCommand
by Code Review 14 Dec '16

14 Dec '16

>From Liron Aravot <laravot(a)redhat.com>: Liron Aravot has submitted this change and it was merged. Change subject: core: adding RemoveDeviceFromSANStorageDomainCommand ...................................................................... core: adding RemoveDeviceFromSANStorageDomainCommand This patch adds the RemoveDeviceFromSANStorageDomainCommand, the command will monitor and track the flow of removing the device from a storage domain. At first, the command will execute the MoveStorageDomainDevice command to move the data from the removed device to other devices of the storage domain. After the data was moved from the device the command will execute the ReduceStorageDomainDevice command to reduce the device from the domain. Change-Id: I3d68ffc1a373fb328c3229362f6888150b6e2eb2 Bug-Url: http://bugzilla.redhat.com/1403839 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/connection/IStorageHelper.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/connection/StorageHelperBase.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/RemoveDeviceFromSANStorageDomainCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RemoveDeviceFromSANStorageDomainCommandParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/job/StepEnum.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties M backend/manager/modules/dal/src/main/resources/bundles/ExecutionMessages.properties 9 files changed, 197 insertions(+), 5 deletions(-) Approvals: Liron Aravot: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/62793 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3d68ffc1a373fb328c3229362f6888150b6e2eb2 Gerrit-PatchSet: 17 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Introducing ReduceStorageDomainDeviceCommand
by Code Review 14 Dec '16

14 Dec '16

>From Liron Aravot <laravot(a)redhat.com>: Liron Aravot has submitted this change and it was merged. Change subject: core: Introducing ReduceStorageDomainDeviceCommand ...................................................................... core: Introducing ReduceStorageDomainDeviceCommand This patch adds the BLL ReduceStorageDomainDeviceCommand, responsible for executing and tracking the ReduceStorageDomainDevice vds command/job. Change-Id: I2849dc6a0cb98fdb994d26ae3f19edf44bf29daf Bug-Url: http://bugzilla.redhat.com/1403839 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/ReduceStorageDomainCommand.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ReduceStorageDomainCommandParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java 3 files changed, 68 insertions(+), 0 deletions(-) Approvals: Liron Aravot: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/63101 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2849dc6a0cb98fdb994d26ae3f19edf44bf29daf Gerrit-PatchSet: 15 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Introducing MoveStorageDomainDeviceCommand
by Code Review 14 Dec '16

14 Dec '16

>From Liron Aravot <laravot(a)redhat.com>: Liron Aravot has submitted this change and it was merged. Change subject: core: Introducing MoveStorageDomainDeviceCommand ...................................................................... core: Introducing MoveStorageDomainDeviceCommand This patch adds the BLL MoveStorageDomainDeviceCommand, responsible for executing and tracking the MoveStorageDomainDevice vds command/job. Change-Id: I0e6339ecdcee5d8bc9bbdcf19139b4f768a8aaea Bug-Url: http://bugzilla.redhat.com/1403839 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/MoveStorageDomainDeviceCommand.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/MoveStorageDomainDeviceCommandParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineError.java 4 files changed, 89 insertions(+), 0 deletions(-) Approvals: Liron Aravot: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/62792 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0e6339ecdcee5d8bc9bbdcf19139b4f768a8aaea Gerrit-PatchSet: 17 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: vdsbroker: adding ReduceStorageDomainVDSCommand
by Code Review 14 Dec '16

14 Dec '16

>From Liron Aravot <laravot(a)redhat.com>: Liron Aravot has submitted this change and it was merged. Change subject: vdsbroker: adding ReduceStorageDomainVDSCommand ...................................................................... vdsbroker: adding ReduceStorageDomainVDSCommand This patch adds the ReduceStorageDomainVDSCommand which executes the SDM.reduce_domain verb. This command should be executed only after that data was moved from the device using MoveStorageDomainDeviceVDSCommand. Change-Id: Ic944aa1787ffe0503a740a1c9b8549da0bb4599e Bug-Url: http://bugzilla.redhat.com/1403839 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/ReduceStorageDomainVDSCommandParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSCommandType.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/ReduceStorageDomainVDSCommand.java 5 files changed, 71 insertions(+), 0 deletions(-) Approvals: Liron Aravot: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/63100 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic944aa1787ffe0503a740a1c9b8549da0bb4599e Gerrit-PatchSet: 16 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0