December 2016 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: New VM has RND device by default
by Code Review 01 Dec '16

01 Dec '16

>From Tomas Jelinek <tjelinek(a)redhat.com>: Tomas Jelinek has submitted this change and it was merged. Change subject: core: New VM has RND device by default ...................................................................... core: New VM has RND device by default Script adds urandom rng device to Blank template and all predefined instance types. This causes that new VMs will inherit such RNG device. Custom instance types are not changed. The assumption is that if they were created without a RNG device, it was an intentional decision. Change-Id: I93a51b67c0e8bff06152d9fe7a4315efd509774d Bug-Url: https://bugzilla.redhat.com/1337101 Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> --- A packaging/dbscripts/upgrade/04_01_0560_vm_has_rng_device_by_default.sql 1 file changed, 50 insertions(+), 0 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Jakub Niedermertl: Verified Martin Peřina: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/67470 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I93a51b67c0e8bff06152d9fe7a4315efd509774d Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Fix of NPE when creating new instance type
by Code Review 01 Dec '16

01 Dec '16

>From Tomas Jelinek <tjelinek(a)redhat.com>: Tomas Jelinek has submitted this change and it was merged. Change subject: core: Fix of NPE when creating new instance type ...................................................................... core: Fix of NPE when creating new instance type During creation of new instance type a NPE was throw in RngUtils#validate since it expected a cluster param to be non-null. Separate flow added for non-cluster entities. Change-Id: I34824dce7d568d5191e182876b97f05fa09e9927 Bug-Url: https://bugzilla.redhat.com/1374227 Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/RngUtils.java 1 file changed, 16 insertions(+), 0 deletions(-) Approvals: Jakub Niedermertl: Verified Jenkins CI: Passed CI tests Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/67469 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I34824dce7d568d5191e182876b97f05fa09e9927 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi: Reflecting template RNG settings to new VM
by Code Review 01 Dec '16

01 Dec '16

>From Tomas Jelinek <tjelinek(a)redhat.com>: Tomas Jelinek has submitted this change and it was merged. Change subject: restapi: Reflecting template RNG settings to new VM ...................................................................... restapi: Reflecting template RNG settings to new VM Non-cluster vm-like entities (Blank template and instance types) use `urandom` rng source to encode both `urandom` and `random` depending on effective compatibility version. This version ensures that when new VM is created based on Blank template or instance type, rng source will be correctly interpreted. Change-Id: Id9a65fb4aa3d6aee126ba72beb0bca488ed56d33 Bug-Url: https://bugzilla.redhat.com/1374227 Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmAndCloneImageCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/VirtIoRngValidator.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmsResource.java A backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/RngUtils.java 8 files changed, 116 insertions(+), 59 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Jakub Niedermertl: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/67050 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id9a65fb4aa3d6aee126ba72beb0bca488ed56d33 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: frontend: use authz name instead of profile name for sysprep
by Code Review 01 Dec '16

01 Dec '16

>From Martin Peřina <mperina(a)redhat.com>: Martin Peřina has submitted this change and it was merged. Change subject: frontend: use authz name instead of profile name for sysprep ...................................................................... frontend: use authz name instead of profile name for sysprep VM dialog previously pre-filled value for domain in sysprep tab, as profile name. This is incorrect behaviour, as profile name is just user visible name used only for login. Authz name is the name of the authorization provider, which should reflect real domain name of the windows machine. This patch changes that. Change-Id: Ib19f4c4c51b1a9c62ca68afee330b9aec9893b88 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1380128 Signed-off-by: Ondra Machacek <omachace(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/RunOnceModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmInitModel.java 3 files changed, 5 insertions(+), 5 deletions(-) Approvals: Tomas Jelinek: Looks good to me, but someone else must approve Ondra Machacek: Verified Martin Peřina: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/66241 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib19f4c4c51b1a9c62ca68afee330b9aec9893b88 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-live[ovirt-live-4.1]: build: ovirt-live-4.1_beta1
by Code Review 01 Dec '16

01 Dec '16

>From Lev Veyde <lveyde(a)redhat.com>: Lev Veyde has submitted this change and it was merged. Change subject: build: ovirt-live-4.1_beta1 ...................................................................... build: ovirt-live-4.1_beta1 Change-Id: Iafe2a3b5303ba19ed9c4bd30e11a0007d6d0cf35 Signed-off-by: Lev Veyde <lveyde(a)redhat.com> --- M centos-7/Makefile M centos-7/kickstart/ovirt-live-ovirt-custom.ks.in 2 files changed, 5 insertions(+), 3 deletions(-) Approvals: Lev Veyde: Verified; Looks good to me, approved; Passed CI tests Sandro Bonazzola: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/67683 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iafe2a3b5303ba19ed9c4bd30e11a0007d6d0cf35 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-live Gerrit-Branch: ovirt-live-4.1 Gerrit-Owner: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-release[virt-sig]: centos-qemu-ev-test repo is unsigned
by Code Review 01 Dec '16

01 Dec '16

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. Change subject: centos-qemu-ev-test repo is unsigned ...................................................................... centos-qemu-ev-test repo is unsigned RPMs in testing repositories on buildlogs.centos.org are not signed. Change-Id: Ie0f9f05ee1317869023fcac149d2c819b7356820 Signed-off-by: Alan Pevec <alan.pevec(a)redhat.com> --- M centos-release-qemu-ev/CentOS-QEMU-EV.repo M centos-release-qemu-ev/centos-release-qemu-ev.spec 2 files changed, 5 insertions(+), 3 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/67659 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie0f9f05ee1317869023fcac149d2c819b7356820 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-release Gerrit-Branch: virt-sig Gerrit-Owner: Alan Pevec <alan.pevec(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: add Intel Skylake Family support for 4.1
by Code Review 01 Dec '16

01 Dec '16

>From Martin Peřina <mperina(a)redhat.com>: Martin Peřina has submitted this change and it was merged. Change subject: core: add Intel Skylake Family support for 4.1 ...................................................................... core: add Intel Skylake Family support for 4.1 Change-Id: I951cc9e6945b59870e7c233d466896c44cd84329 Bug-Url: https://bugzilla.redhat.com/1392872 Signed-off-by: Michal Skrivanek <michal.skrivanek(a)redhat.com> --- M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Tomas Jelinek: Looks good to me, but someone else must approve Martin Peřina: Looks good to me, approved Jenkins CI: Passed CI tests Michal Skrivanek: Verified -- To view, visit https://gerrit.ovirt.org/67651 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I951cc9e6945b59870e7c233d466896c44cd84329 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-live[ovirt-live-4.0]: build: ovirt-live 4.0.6_rc3
by Code Review 01 Dec '16

01 Dec '16

>From Lev Veyde <lveyde(a)redhat.com>: Lev Veyde has submitted this change and it was merged. Change subject: build: ovirt-live 4.0.6_rc3 ...................................................................... build: ovirt-live 4.0.6_rc3 Change-Id: Iff2c07c85a4d7a08f0645583c5e627ecf98a6094 Signed-off-by: Lev Veyde <lveyde(a)redhat.com> --- M centos-7/Makefile 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Lev Veyde: Verified; Looks good to me, approved Sandro Bonazzola: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/67655 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iff2c07c85a4d7a08f0645583c5e627ecf98a6094 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-live Gerrit-Branch: ovirt-live-4.0 Gerrit-Owner: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi: Update to model 4.1.22
by Code Review 01 Dec '16

01 Dec '16

>From Juan Hernandez <juan.hernandez(a)redhat.com>: Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Update to model 4.1.22 ...................................................................... restapi: Update to model 4.1.22 The more relevant changes in the new version of the model are the following: * Add `qcow_version` attribute to the `Disk` type. * Add `update` operation to the service that manages a specific disk, with support for updating the QCOW version of the disk. * Add `discard_after_delete` attribute to the `StorageDomain` type. Change-Id: I3c071d7ef76ddf07da263c19c5e866c6a86617f9 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M pom.xml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Ondra Machacek: Looks good to me, but someone else must approve Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/67574 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3c071d7ef76ddf07da263c19c5e866c6a86617f9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-java[sdk_4.0]: Update cloud-init example with custom script
by Code Review 01 Dec '16

01 Dec '16

>From Ondra Machacek <omachace(a)redhat.com>: Ondra Machacek has submitted this change and it was merged. Change subject: Update cloud-init example with custom script ...................................................................... Update cloud-init example with custom script This patch updates run vm with cloud-init example, with custom script, which will be executed when VM is deployed. Change-Id: Ib20f31947c83d7d051cd4d59cd73aa00aa0ee9c0 Signed-off-by: Ondra Machacek <omachace(a)redhat.com> (cherry picked from commit 78bcb3715cbb1fd9d1800af4a4f12428e045ef5e) --- M sdk/src/test/java/org/ovirt/engine/sdk4/examples/StartVmWithCloudInit.java 1 file changed, 10 insertions(+), 0 deletions(-) Approvals: Ondra Machacek: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/67644 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib20f31947c83d7d051cd4d59cd73aa00aa0ee9c0 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: sdk_4.0 Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0