February 2016 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: engine: optimize stream processing
by masayag＠redhat.com 29 Feb '16

29 Feb '16

Moti Asayag has submitted this change and it was merged. Change subject: engine: optimize stream processing ...................................................................... engine: optimize stream processing Avoid creating the intermediate list that is needed for adding all its members to another collection. Instead add them to the target collection on the fly. Change-Id: I70a7dc9a8455dd9adca37126d2a37c274ca5f99d Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java 1 file changed, 2 insertions(+), 3 deletions(-) Approvals: Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved Yevgeny Zaspitsky: Verified -- To view, visit https://gerrit.ovirt.org/54163 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I70a7dc9a8455dd9adca37126d2a37c274ca5f99d Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: Selectively enable VM field editing for hosted engine
by rgolan＠redhat.com 29 Feb '16

29 Feb '16

Roy Golan has submitted this change and it was merged. Change subject: Selectively enable VM field editing for hosted engine ...................................................................... Selectively enable VM field editing for hosted engine This patch adds a new annotation to VM and VmBase entities to mark certain fields as editable for hosted engine VM. Hosted engine fields are editable even though the VM is running. The relevant checkers are also updated to use this annotation instead of the more generic EditableField. Change-Id: Ie4e847530d5b6b0b407db7dcc0d04a8140bbab01 Signed-off-by: Martin Sivak <msivak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/EditableField.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/EditableHostedEngineField.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmBase.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ObjectIdentityChecker.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 12 files changed, 86 insertions(+), 10 deletions(-) Approvals: Martin Sivák: Verified Jenkins CI: Passed CI tests Roy Golan: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/53959 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie4e847530d5b6b0b407db7dcc0d04a8140bbab01 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[master]: Add example to show summary
by juan.hernandez＠redhat.com 29 Feb '16

29 Feb '16

Juan Hernandez has submitted this change and it was merged. Change subject: Add example to show summary ...................................................................... Add example to show summary This patch adds an example that shows how to get the API information provided by the system resource, including the summary. Change-Id: I4741f7a79a10f7b330fd5249549ab3a8ba4b722d Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- A sdk/examples/show_summary.rb 1 file changed, 41 insertions(+), 0 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests Objections: Jenkins CI: Failed CI tests -- To view, visit https://gerrit.ovirt.org/54149 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4741f7a79a10f7b330fd5249549ab3a8ba4b722d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[master]: Update to version 4.0.7 of the model
by juan.hernandez＠redhat.com 29 Feb '16

29 Feb '16

Juan Hernandez has submitted this change and it was merged. Change subject: Update to version 4.0.7 of the model ...................................................................... Update to version 4.0.7 of the model This patch updates to version 4.0.7 of the model, which adds support for the "Api" type. Updating to this version of the model requires also to update to version 1.0.4 of the metamodel. Change-Id: If686e40978418f3b5d2892a449a5d87343920a93 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M pom.xml 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/54148 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If686e40978418f3b5d2892a449a5d87343920a93 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: engine: Fix migration policy update for running VM
by tnisan＠redhat.com 29 Feb '16

29 Feb '16

Tal Nisan has submitted this change and it was merged. Change subject: engine: Fix migration policy update for running VM ...................................................................... engine: Fix migration policy update for running VM Problem description: -------------------- When a VM is running and its migration policy is changed to pinned - OR A pinned VM is running and it dedicated hosts list is modified. The VM may running on un-dedicated host, locking the VM away from its dedicated host. Requiring VM reboot. Desired behavior: ----------------- 1. When a VM is running and changing migration policy from un-pinned to pinned. - Validate the VM is running on one of the targeted pinned hosts, - Fail with adequate warning. - Proceed with normal update. 2. When pinned VM is running and changing the list of dedicated hosts. And the dedicated hosts list excluding the pinned host. - Validate the VM is running on one of the targeted pinned hosts, - Fail with adequate warning. - Proceed with normal update. Implementation: -------------- Add canDoAction constraint on modify a pinned VM, if it is running - must run on its dedicated host. (UpdateVmCommand.java) Change-Id: Ib3dc32a2b92ea0d111328eb6a6803fa91c015836 Bug-Url: https://bugzilla.redhat.com/1058384 Signed-off-by: Andrej Krejcir <akrejcir(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/VmValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmCommandTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 7 files changed, 115 insertions(+), 2 deletions(-) Approvals: Martin Sivák: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Roy Golan: Looks good to me, approved Andrej Krejcir: Verified -- To view, visit https://gerrit.ovirt.org/53922 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib3dc32a2b92ea0d111328eb6a6803fa91c015836 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6.3]: webadmin: edit running VM is not possible
by tnisan＠redhat.com 29 Feb '16

29 Feb '16

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: edit running VM is not possible ...................................................................... webadmin: edit running VM is not possible It was not possible to edit the running VM. The reason was that the VmNextRunConfigurationModel in constructor always inited the latch which by default had the 'available' flag set to true (even not shown since this flag was set sooner than the listener which would actually show it was registered). As a consequence, the validate() method returned false, since the latch was "available" and unchecked. But since it was not rendered, it was not obvious to the user what the problem is making the dialog impossible to submit. The fix was just to move the initialization of the latch to the proper place. Change-Id: I13f9b6d072c2ba8a2113936e95223df9b9f4db7e Bug-Url: https://bugzilla.redhat.com/1312636 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmNextRunConfigurationModel.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tomas Jelinek: Verified Jenkins CI: Passed CI tests Martin Betak: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/54159 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I13f9b6d072c2ba8a2113936e95223df9b9f4db7e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6.3 Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Encapsulate fields in pending package
by tnisan＠redhat.com 29 Feb '16

29 Feb '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Encapsulate fields in pending package ...................................................................... core: Encapsulate fields in pending package Change-Id: I95fef3d687ded900f6287d0acaa0ca7d0c67e4f4 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/pending/PendingCpuCores.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/pending/PendingMemory.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/pending/PendingResource.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/pending/PendingResourceManager.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/pending/PendingVM.java 5 files changed, 14 insertions(+), 14 deletions(-) Approvals: Tal Nisan: Verified Martin Sivák: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Roy Golan: Looks good to me, approved Freddy Rolland: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/51819 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I95fef3d687ded900f6287d0acaa0ca7d0c67e4f4 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: webadmin: edit running VM is not possible
by tnisan＠redhat.com 29 Feb '16

29 Feb '16

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: edit running VM is not possible ...................................................................... webadmin: edit running VM is not possible It was not possible to edit the running VM. The reason was that the VmNextRunConfigurationModel in constructor always inited the latch which by default had the 'available' flag set to true (even not shown since this flag was set sooner than the listener which would actually show it was registered). As a consequence, the validate() method returned false, since the latch was "available" and unchecked. But since it was not rendered, it was not obvious to the user what the problem is making the dialog impossible to submit. The fix was just to move the initialization of the latch to the proper place. Change-Id: I13f9b6d072c2ba8a2113936e95223df9b9f4db7e Bug-Url: https://bugzilla.redhat.com/1312636 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmNextRunConfigurationModel.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tomas Jelinek: Verified Jenkins CI: Passed CI tests Martin Betak: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/54152 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I13f9b6d072c2ba8a2113936e95223df9b9f4db7e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: reports: add 3.6 branch jobs
by sbonazzo＠redhat.com 29 Feb '16

29 Feb '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: reports: add 3.6 branch jobs ...................................................................... reports: add 3.6 branch jobs Change-Id: I5b0ad9a82110c750d8530c456c525497d5169fb8 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M jobs/confs/projects/ovirt-reports/ovirt-reports_create-rpms.yaml M jobs/confs/projects/ovirt/publish-rpms-nightly-3.6.yaml 2 files changed, 13 insertions(+), 3 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/54154 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5b0ad9a82110c750d8530c456c525497d5169fb8 Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[master]: Don't generate service modules twice
by juan.hernandez＠redhat.com 29 Feb '16

29 Feb '16

Juan Hernandez has submitted this change and it was merged. Change subject: Don't generate service modules twice ...................................................................... Don't generate service modules twice A previous patch reduced the number of files, so that all the services are included in a single "services.rb" file. But it did so in such a way that each service is declared in a nested module: # For all the services: module Ovirt module SDK module V4 # For each service, which is wrong: module Ovirt module SDK module V4 ... end end end end end end This patch fixes that issue. Change-Id: I45b9fb34b603d40a34a0c2b68b284935c6c06525 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M generator/src/main/java/org/ovirt/sdk/ruby/ServicesGenerator.java 1 file changed, 0 insertions(+), 8 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/54137 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I45b9fb34b603d40a34a0c2b68b284935c6c06525 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0