March 2016 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: Column fixes in unregistered disks sub tab.
by mlipchuk＠redhat.com 30 Mar '16

30 Mar '16

Maor Lipchuk has submitted this change and it was merged. Change subject: webadmin: Column fixes in unregistered disks sub tab. ...................................................................... webadmin: Column fixes in unregistered disks sub tab. Fixing size column and alocation column, also adding actual size column to unregistered disks sub tab. Change-Id: Ib9bcf6e659c22fd270ab79415c3b74f28b0650cd Bug-Url: https://bugzilla.redhat.com/1138139 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/storage/SubTabStorageRegisterDiskImageView.java 1 file changed, 6 insertions(+), 2 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Maor Lipchuk: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/55333 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib9bcf6e659c22fd270ab79415c3b74f28b0650cd Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi: Update to version 4.0.11 of the model
by juan.hernandez＠redhat.com 30 Mar '16

30 Mar '16

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Update to version 4.0.11 of the model ...................................................................... restapi: Update to version 4.0.11 of the model This patch updates the API to use version 4.0.11 of the model, which includes the following changes: * Removed the operation to move a virtual machine from one storage domain to another. * Added the "IpVersion" enum type to the model. * Added the IPv6 "AUTOCONF" value to the "BootProtocol" enum type. Change-Id: I8953fe1c6c68e5bc95662342c8193fa77a1019d3 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendCapabilitiesResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/adapters/V3IPInAdapter.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/adapters/V3IpAddressAssignmentInAdapter.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/adapters/V3IpAddressAssignmentOutAdapter.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/adapters/V3IpOutAdapter.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/servers/V3VmServer.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmResourceTest.java D backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/IpVersion.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/IpVersionMapper.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/NetworkAttachmentMapper.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/ReportedDeviceMapper.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/openstack/OpenStackSubnetMapper.java M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/NetworkAttachmentMapperTest.java M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/ReportedDeviceMapperTest.java M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/openstack/OpenStackSubnetMapperTest.java M pom.xml 17 files changed, 20 insertions(+), 96 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/55414 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8953fe1c6c68e5bc95662342c8193fa77a1019d3 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: ClusterDaoImpl parameterSource fix
by ahadas＠redhat.com 30 Mar '16

30 Mar '16

Arik Hadas has submitted this change and it was merged. Change subject: core: ClusterDaoImpl parameterSource fix ...................................................................... core: ClusterDaoImpl parameterSource fix Elements of MigrationBandwidthLimitType are serializad using Enum name instead of number. Change-Id: I92827cd61888e2e51ad5b1a8769d4c9c9cad92ec Bug-Url: https://bugzilla.redhat.com/1252426 Feature-Page: http://www.ovirt.org/Features/Migration_Enhancements Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/ClusterDaoImpl.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jakub Niedermertl: Verified Jenkins CI: Passed CI tests Marek Libra: Looks good to me, but someone else must approve Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/54887 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I92827cd61888e2e51ad5b1a8769d4c9c9cad92ec Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marek Libra <mlibra(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-ha[master]: Save the disconnected vNIC info to vm.conf when converting t...
by msivak＠redhat.com 30 Mar '16

30 Mar '16

Martin Sivák has submitted this change and it was merged. Change subject: Save the disconnected vNIC info to vm.conf when converting the OVF image ...................................................................... Save the disconnected vNIC info to vm.conf when converting the OVF image Some vNICs might not be plugged in and the --vm-start command should handle that properly. Trying to connect a vNIC like that can fail the VM start as the network might not be available on the host. Change-Id: If0ae1af6152236a0c4a7d767ae828a91cfd4dbd2 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1319785 Signed-off-by: Martin Sivak <msivak(a)redhat.com> --- M ovirt_hosted_engine_ha/lib/ovf/ovf2VmParams.py M ovirt_hosted_engine_ha/lib/ovf/ovf2VmParams_test.py M ovirt_hosted_engine_ha/lib/ovf/ovf_test.xml 3 files changed, 36 insertions(+), 1 deletion(-) Approvals: Martin Sivák: Verified; Looks good to me, approved; Passed CI tests Simone Tiraboschi: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/55003 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If0ae1af6152236a0c4a7d767ae828a91cfd4dbd2 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: dal: Update creation date in unregistered map table.
by mlipchuk＠redhat.com 30 Mar '16

30 Mar '16

Maor Lipchuk has submitted this change and it was merged. Change subject: dal: Update creation date in unregistered map table. ...................................................................... dal: Update creation date in unregistered map table. Update the creation date when mapping unregistered disks in the dal Change-Id: I1e4225b726cb3cadab181f6a84bf8e6036b3ce59 Bug-Url: https://bugzilla.redhat.com/1138139 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/UnregisteredDisksDaoImpl.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/55331 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1e4225b726cb3cadab181f6a84bf8e6036b3ce59 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: do not ping too often
by masayag＠redhat.com 30 Mar '16

30 Mar '16

Moti Asayag has submitted this change and it was merged. Change subject: core: do not ping too often ...................................................................... core: do not ping too often Code has a bug causing polling (with FutureVDSCommandType.Poll / ping verb) too bursty when host is responding fast. Changes: 1. method waitBetweenPolls is moved from end of method to the start. When wait is needed, it's the first thing which is done. 2. field lastTimeBeforePoll is introduced. After waiting this field is set with current time. In next execution, waitBetweenPolls will wait if requested POLLING_BREAK is not met. 3. in waitBetweenPolls while is introduced, because Thread.sleep does not guarantee to wait for requested time period, actually it may sometimes return way sooner than that (see comment in method). Not that important changes: 4. extracted reading value from task / handling timeouts to single method for code clarity 5. added trace logging for next time this class misbehaves. Change-Id: I2569376eae0b67591f669438a9742b34ba7ff568 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworkPoller.java 1 file changed, 49 insertions(+), 17 deletions(-) Approvals: Martin Mucha: Verified Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/54644 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2569376eae0b67591f669438a9742b34ba7ff568 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: VmDiskListModel: LSM supported
by amureini＠redhat.com 29 Mar '16

29 Mar '16

Allon Mureinik has submitted this change and it was merged. Change subject: webadmin: VmDiskListModel: LSM supported ...................................................................... webadmin: VmDiskListModel: LSM supported Since the engine only supports DCs of compatibility version of 3.5 and above, live storage migration should always be supported, and there's no need to check it. Change-Id: I9e3c56f4c4d5d1a4689679904bb969f8cb9ccec5 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmDiskListModel.java 1 file changed, 0 insertions(+), 45 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/55366 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9e3c56f4c4d5d1a4689679904bb969f8cb9ccec5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: VmDiskListModel: extend disk supported
by amureini＠redhat.com 29 Mar '16

29 Mar '16

Allon Mureinik has submitted this change and it was merged. Change subject: webadmin: VmDiskListModel: extend disk supported ...................................................................... webadmin: VmDiskListModel: extend disk supported Since the engine only supports DCs of compatibility version of 3.5 and above, extending a disk should always be supported, and there's no need to check it. Change-Id: I3a989e07eaeaca7ad5fab9f1263dd2f1d95ef588 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmDiskListModel.java 1 file changed, 1 insertion(+), 28 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/55365 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3a989e07eaeaca7ad5fab9f1263dd2f1d95ef588 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: HE: Enable hosted engine vNIC editing
by rgolan＠redhat.com 29 Mar '16

29 Mar '16

Roy Golan has submitted this change and it was merged. Change subject: HE: Enable hosted engine vNIC editing ...................................................................... HE: Enable hosted engine vNIC editing This patch enabled vNIC management for the hosted engine VM, But the management interface (ovirtmgmt) can't be deactivated for the HE VM. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1319769 Change-Id: Ic85659ef7c036762afa64a43e7bda7e7d527f483 Signed-off-by: Martin Sivak <msivak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/ActivateDeactivateVmNicCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/AddVmInterfaceCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/RemoveVmInterfaceCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/validation/VmActionByVmOriginTypeValidator.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 9 files changed, 36 insertions(+), 0 deletions(-) Approvals: Martin Mucha: Looks good to me, but someone else must approve Roy Golan: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/55075 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic85659ef7c036762afa64a43e7bda7e7d527f483 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tomer Saban <tsaban(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: AsyncDataProvider commented out code
by amureini＠redhat.com 29 Mar '16

29 Mar '16

Allon Mureinik has submitted this change and it was merged. Change subject: webadmin: AsyncDataProvider commented out code ...................................................................... webadmin: AsyncDataProvider commented out code Remove old, outdated, commented out code from AsyncDataProvider. Change-Id: Ifacd711cbfd32464730af39fd0e4e76df93b42ec Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java 1 file changed, 0 insertions(+), 12 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/55371 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifacd711cbfd32464730af39fd0e4e76df93b42ec Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0