March 2016 - Engine-commits - oVirt List Archives

Change in ovirt-engine-sdk-ruby[master]: Add compression support
by juan.hernandez＠redhat.com 15 Mar '16

15 Mar '16

Juan Hernandez has submitted this change and it was merged. Change subject: Add compression support ...................................................................... Add compression support This patch adds a new "compress" parameter to the constructor of the connection class to indicate if the SDK should ask the server to send compressed responses. Change-Id: Ia75ee8c3bfe2c98648a2b3751652b7faa4e857ee Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- A sdk/examples/enable_compression.rb M sdk/lib/ovirtsdk4/http.rb 2 files changed, 55 insertions(+), 0 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/54771 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia75ee8c3bfe2c98648a2b3751652b7faa4e857ee Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[master]: Fix the type of the "timeout" parameter
by juan.hernandez＠redhat.com 15 Mar '16

15 Mar '16

Juan Hernandez has submitted this change and it was merged. Change subject: Fix the type of the "timeout" parameter ...................................................................... Fix the type of the "timeout" parameter The documentation of the "timeout" parameter says that it is of type "Boolean", but it is an "Integer". This patch fixes that issue. Change-Id: I2da077b7c04521e3da2727f08ca299f6e44dcf27 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M sdk/lib/ovirtsdk4/http.rb 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/54770 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2da077b7c04521e3da2727f08ca299f6e44dcf27 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: LiveMigrateDiskCommand - shared locks are unneeded
by derez＠redhat.com 15 Mar '16

15 Mar '16

Daniel Erez has submitted this change and it was merged. Change subject: core: LiveMigrateDiskCommand - shared locks are unneeded ...................................................................... core: LiveMigrateDiskCommand - shared locks are unneeded Shared locks are not needed on LiveMigrateDiskCommand as they are already added by LiveMigrateVmDisksCommand. Change-Id: I31065f76ba5ef866bf968f03f76446ea1041b4ab Bug-Url: https://bugzilla.redhat.com/1313744 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/lsm/LiveMigrateDiskCommand.java 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: Daniel Erez: Verified Jenkins CI: Passed CI tests Maor Lipchuk: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/54730 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I31065f76ba5ef866bf968f03f76446ea1041b4ab Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: hostdev: Fix cleanup treatment in RefreshHostDevicesCommand
by tnisan＠redhat.com 15 Mar '16

15 Mar '16

Tal Nisan has submitted this change and it was merged. Change subject: hostdev: Fix cleanup treatment in RefreshHostDevicesCommand ...................................................................... hostdev: Fix cleanup treatment in RefreshHostDevicesCommand The host device refresh logic that clears up vm_devices for host_devices that disappear from host incorrectly assumed that only one device with given name will exist in the vm_device table, which was incorrect for multiple reasons (one host_device attached to multiple VMs or device with same name from different host). Fixed by explicitly querying vm_device attachments only for current host and removing all with given name. Change-Id: I8f39599928195e9c485bf0e0a206caf6b821f580 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1312879 Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdev/RefreshHostDevicesCommand.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/HostDeviceDao.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/HostDeviceDaoImpl.java M packaging/dbscripts/host_device_sp.sql 4 files changed, 53 insertions(+), 8 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Jenkins CI: Passed CI tests Martin Betak: Verified -- To view, visit https://gerrit.ovirt.org/54766 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8f39599928195e9c485bf0e0a206caf6b821f580 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: console not correctly loaded for edit template
by mbetak＠redhat.com 15 Mar '16

15 Mar '16

Martin Betak has submitted this change and it was merged. Change subject: webadmin: console not correctly loaded for edit template ...................................................................... webadmin: console not correctly loaded for edit template The logic handling of the loading of the console was implemented only for the existing VMs. Fixed by moving it to a base class and calling it also from template. Change-Id: I43786b9738b116549c7d29e5eea53c05da60c3fe Bug-Url: https://bugzilla.redhat.com/1315886 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ExistingVmModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/TemplateVmModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java 3 files changed, 34 insertions(+), 33 deletions(-) Approvals: Tomas Jelinek: Verified Jenkins CI: Passed CI tests Martin Betak: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/54603 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I43786b9738b116549c7d29e5eea53c05da60c3fe Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in otopi[master]: licensing: Move copyright notices to LICENSE
by didi＠redhat.com 15 Mar '16

15 Mar '16

Yedidyah Bar David has submitted this change and it was merged. Change subject: licensing: Move copyright notices to LICENSE ...................................................................... licensing: Move copyright notices to LICENSE Change-Id: I678be719f3615a28454feab7fda491d3cacc7e61 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- A LICENSE M Makefile.am M build/Makefile.am M build/otopi-bundle.in.in M build/python.inc M build/subst.inc M configure.ac M m4/ax_ln_sr.m4 M otopi.spec.in M src/Makefile.am M src/bin/Makefile.am M src/bin/otopi M src/java/Event.java M src/java/MachineDialogParser.java M src/java/MachineDialogParserTest.java M src/java/Makefile.am M src/java/SoftError.java M src/java/pom.xml.in M src/otopi/Makefile.am M src/otopi/__init__.py M src/otopi/__main__.py M src/otopi/base.py M src/otopi/codegen/Makefile.am M src/otopi/codegen/__init__.py M src/otopi/codegen/__main__.py M src/otopi/command.py M src/otopi/common.py M src/otopi/config.py.in.in M src/otopi/constants.py M src/otopi/context.py M src/otopi/dialog.py M src/otopi/filetransaction.py M src/otopi/main.py M src/otopi/minidnf.py M src/otopi/miniyum.py M src/otopi/packager.py M src/otopi/plugin.py M src/otopi/services.py M src/otopi/transaction.py M src/otopi/util.py M src/plugins/Makefile.am M src/plugins/otopi/Makefile.am M src/plugins/otopi/core/Makefile.am M src/plugins/otopi/core/__init__.py M src/plugins/otopi/core/config.py M src/plugins/otopi/core/log.py M src/plugins/otopi/core/misc.py M src/plugins/otopi/core/transaction.py M src/plugins/otopi/dialog/Makefile.am M src/plugins/otopi/dialog/__init__.py M src/plugins/otopi/dialog/cli.py M src/plugins/otopi/dialog/constants.py M src/plugins/otopi/dialog/human.py M src/plugins/otopi/dialog/machine.py M src/plugins/otopi/dialog/misc.py M src/plugins/otopi/network/Makefile.am M src/plugins/otopi/network/__init__.py M src/plugins/otopi/network/firewalld.py M src/plugins/otopi/network/hostname.py M src/plugins/otopi/network/iptables.py M src/plugins/otopi/network/ssh.py M src/plugins/otopi/packagers/Makefile.am M src/plugins/otopi/packagers/__init__.py M src/plugins/otopi/packagers/dnfpackager.py M src/plugins/otopi/packagers/yumpackager.py M src/plugins/otopi/services/Makefile.am M src/plugins/otopi/services/__init__.py M src/plugins/otopi/services/openrc.py M src/plugins/otopi/services/rhel.py M src/plugins/otopi/services/systemd.py M src/plugins/otopi/system/Makefile.am M src/plugins/otopi/system/__init__.py M src/plugins/otopi/system/clock.py M src/plugins/otopi/system/command.py M src/plugins/otopi/system/info.py M src/plugins/otopi/system/reboot.py 76 files changed, 20 insertions(+), 1,125 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Simone Tiraboschi: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Rafael Martins: Looks good to me, but someone else must approve Yedidyah Bar David: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/54709 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I678be719f3615a28454feab7fda491d3cacc7e61 Gerrit-PatchSet: 2 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: Adapted to the new lago workdir layout
by dcaro＠redhat.com 15 Mar '16

15 Mar '16

David Caro has submitted this change and it was merged. Change subject: Adapted to the new lago workdir layout ...................................................................... Adapted to the new lago workdir layout Change-Id: Icef87a6e8d584e443fd3ef8a8769370bc90eab71 Signed-off-by: David Caro <dcaroest(a)redhat.com> --- M jobs/confs/shell-scripts/system_tests.collect_logs.sh 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests David Caro: Verified; Looks good to me; Ready for merge -- To view, visit https://gerrit.ovirt.org/54742 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icef87a6e8d584e443fd3ef8a8769370bc90eab71 Gerrit-PatchSet: 2 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: David Caro <dcaro(a)redhat.com> Gerrit-Reviewer: David Caro <dcaro(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: hostdev: Fix cleanup treatment in RefreshHostDevicesCommand
by tjelinek＠redhat.com 15 Mar '16

15 Mar '16

Tomas Jelinek has submitted this change and it was merged. Change subject: hostdev: Fix cleanup treatment in RefreshHostDevicesCommand ...................................................................... hostdev: Fix cleanup treatment in RefreshHostDevicesCommand The host device refresh logic that clears up vm_devices for host_devices that disappear from host incorrectly assumed that only one device with given name will exist in the vm_device table, which was incorrect for multiple reasons (one host_device attached to multiple VMs or device with same name from different host). Fixed by explicitly querying vm_device attachments only for current host and removing all with given name. Change-Id: I8f39599928195e9c485bf0e0a206caf6b821f580 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1312879 Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdev/RefreshHostDevicesCommand.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/HostDeviceDao.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/HostDeviceDaoImpl.java M packaging/dbscripts/host_device_sp.sql 4 files changed, 51 insertions(+), 9 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Martin Peřina: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Martin Betak: Verified Shmuel Leib Melamud: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/54612 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8f39599928195e9c485bf0e0a206caf6b821f580 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: aaa: Clarify unauthorized_client error message
by mperina＠redhat.com 15 Mar '16

15 Mar '16

Martin Peřina has submitted this change and it was merged. Change subject: aaa: Clarify unauthorized_client error message ...................................................................... aaa: Clarify unauthorized_client error message When installed from rpms it is required to access engine using the the FQDN instead of ip address. The unauthorized_client exception is raised when accessed using ip address. Add "It's required to access the system using FQDN." to the unauthorized client error message. Change-Id: I4e887b6f38254d34d732c0dc077a9046582ae2a5 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/utils/SSOConstants.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Martin Peřina: Looks good to me, but someone else must approve Ravi Nori: Verified Jenkins CI: Passed CI tests Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/54741 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4e887b6f38254d34d732c0dc077a9046582ae2a5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-ha[ovirt-hosted-engine-ha-1.3]: build: post ovirt-hosted-engine-ha-1.3.5
by msivak＠redhat.com 15 Mar '16

15 Mar '16

Martin Sivák has submitted this change and it was merged. Change subject: build: post ovirt-hosted-engine-ha-1.3.5 ...................................................................... build: post ovirt-hosted-engine-ha-1.3.5 Change-Id: I64065a04ea8021827f2d42099060beffd0d335a0 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M configure.ac M ovirt-hosted-engine-ha.spec.in 2 files changed, 9 insertions(+), 6 deletions(-) Approvals: Sandro Bonazzola: Verified Martin Sivák: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/54749 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I64065a04ea8021827f2d42099060beffd0d335a0 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: ovirt-hosted-engine-ha-1.3 Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0