March 2016 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.6.4]: core: CommandBase - avoid setting end status prematurely
by tnisan＠redhat.com 07 Mar '16

07 Mar '16

Tal Nisan has submitted this change and it was merged. Change subject: core: CommandBase - avoid setting end status prematurely ...................................................................... core: CommandBase - avoid setting end status prematurely In change I49b7f506dc1142c3a559d0e6f64813e2ade02254 the code checking whether the command should status should be updated after execution was updated. As some of the commands are adding the tasks to the internal task id list instead of using the getTaskIdList() method it'll cause those commands to be marked as ended although the tasks are still running. This patch adds a check to the internal list as well to avoid that issue. Change-Id: I2251dd808734f297c5e3907b9f106d6cf87fbd18 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1310390 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/54433 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2251dd808734f297c5e3907b9f106d6cf87fbd18 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6.4 Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi: Fix failure to send V3 RSDL
by juan.hernandez＠redhat.com 07 Mar '16

07 Mar '16

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Fix failure to send V3 RSDL ...................................................................... restapi: Fix failure to send V3 RSDL Currently the RSDL document is generated by the V4 server, and there is no way to convert it into a V3 equivalent. To avoid that this patch moves the loading of the V3 RSDL to the V3 adapter, where it can be loaded using the V3 specific JAXB object. Change-Id: Id694fa248cb4cef08f5536cb0ea4ab3806393dcf Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/pom.xml M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/rsdl/RsdlManager.java M backend/manager/modules/restapi/interface/definition/src/main/modules/org/ovirt/engine/api/restapi-definition/main/module.xml M backend/manager/modules/restapi/interface/definition/src/main/resources/v3/rsdl.xml M backend/manager/modules/restapi/interface/definition/src/main/resources/v3/rsdl_gluster.xml M backend/manager/modules/restapi/jaxrs/pom.xml M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendApiResource.java A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/rsdl/RsdlLoader.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/servers/V3SystemServer.java M backend/manager/modules/restapi/jaxrs/src/main/modules/org/ovirt/engine/api/restapi-jaxrs/main/module.xml 10 files changed, 136 insertions(+), 72 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/54421 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id694fa248cb4cef08f5536cb0ea4ab3806393dcf Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-live[master]: All-In-One import
by sbonazzo＠redhat.com 07 Mar '16

07 Mar '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: All-In-One import ...................................................................... All-In-One import - Added All-In-One plugins that were dropped in ovirt-engine - Updated VDSM calls, adapting to new API on master - Updated SDK calls, adapting to new API on master - Updated supported CPU Families Change-Id: I1dfd148aef880968b3ec16dff32879daf0a36e03 Bug-Url: https://bugzilla.redhat.com/1282799 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M ovirt-engine-setup-plugin-live/Makefile.am A ovirt-engine-setup-plugin-live/conf/Makefile.am A ovirt-engine-setup-plugin-live/conf/ovirt-host-deploy/10-packaging-aio.conf A ovirt-engine-setup-plugin-live/conf/ovirt-host-deploy/Makefile.am M ovirt-engine-setup-plugin-live/configure.ac A ovirt-engine-setup-plugin-live/firewalld/Makefile.am A ovirt-engine-setup-plugin-live/firewalld/ovirt-aio.xml.in M ovirt-engine-setup-plugin-live/ovirt-engine-setup-plugin-live.spec.in M ovirt-engine-setup-plugin-live/src/ovirt_live/constants.py M ovirt-engine-setup-plugin-live/src/plugins/Makefile.am A ovirt-engine-setup-plugin-live/src/plugins/all-in-one/Makefile.am A ovirt-engine-setup-plugin-live/src/plugins/all-in-one/__init__.py A ovirt-engine-setup-plugin-live/src/plugins/all-in-one/core.py A ovirt-engine-setup-plugin-live/src/plugins/all-in-one/cpu.py A ovirt-engine-setup-plugin-live/src/plugins/all-in-one/firewall.py A ovirt-engine-setup-plugin-live/src/plugins/all-in-one/sshd.py A ovirt-engine-setup-plugin-live/src/plugins/all-in-one/storage.py A ovirt-engine-setup-plugin-live/src/plugins/all-in-one/vdsmi.py M ovirt-engine-setup-plugin-live/src/plugins/ovirt_live/Makefile.am M ovirt-engine-setup-plugin-live/src/plugins/ovirt_live/core.py 20 files changed, 1,432 insertions(+), 25 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/48670 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1dfd148aef880968b3ec16dff32879daf0a36e03 Gerrit-PatchSet: 12 Gerrit-Project: ovirt-live Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: dropping 3.5 jobs
by sbonazzo＠redhat.com 07 Mar '16

07 Mar '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: dropping 3.5 jobs ...................................................................... dropping 3.5 jobs Change-Id: Ieceb21bfba06e2bf7b2ec6869b7686a765dca2f8 Signed-off-by: ngoldin <ngoldin(a)redhat.com> --- M jobs/confs/projects/nsis-simple-service-plugin/nsis-simple-service-plugin.yaml M jobs/confs/projects/otopi/otopi_create-rpms.yaml M jobs/confs/projects/ovirt-dwh/ovirt-dwh_create-rpms.yaml M jobs/confs/projects/ovirt-engine-cli/ovirt-engine-cli_build-artifacts.yaml M jobs/confs/projects/ovirt-engine-extension-aaa-ldap/ovirt-engine-extension-aaa-ldap_create-rpms.yaml M jobs/confs/projects/ovirt-engine-sdk-java/ovirt-engine-sdk-java_create-rpms.yaml M jobs/confs/projects/ovirt-engine-sdk/ovirt-engine-sdk_build-artifacts.yaml M jobs/confs/projects/ovirt-engine/ovirt-engine_upgrade-db.yaml M jobs/confs/projects/ovirt-engine/ovirt-engine_upgrade-engine.yaml M jobs/confs/projects/ovirt-host-deploy/ovirt-host-deploy_create-rpms.yaml M jobs/confs/projects/ovirt-hosted-engine-ha/ovirt-hosted-engine-ha_create-rpms.yaml M jobs/confs/projects/ovirt-hosted-engine-setup/ovirt-hosted-engine_stardard.yaml M jobs/confs/projects/ovirt-image-uploader/ovirt-image-uploader_standard.yaml M jobs/confs/projects/ovirt-iso-uploader/ovirt-iso-uploader_create-rpms.yaml M jobs/confs/projects/ovirt-log-collector/ovirt-log-collector_create-rpms.yaml M jobs/confs/projects/ovirt-node/ovirt-node-job.yaml M jobs/confs/projects/ovirt-release/ovirt-release_standard.yaml M jobs/confs/projects/ovirt-reports/ovirt-reports_create-rpms.yaml D jobs/confs/projects/ovirt/publish-rpms-nightly-3.5.yaml M jobs/confs/projects/ovirt/system-tests.yaml M jobs/confs/projects/py2exe-py2.7/py2exe-py2.7.yaml M jobs/confs/projects/python-windows/python-windows.yaml M jobs/confs/projects/pywin32-py2.7/pywin32-py2.7.yaml D jobs/confs/projects/spice-qxl/spice-qxl.yaml M jobs/confs/projects/vcredist-x86/vcredist-x86.yaml D jobs/confs/projects/vdsm-jsonrpc-java/vdsm-jsonrpc-java_create-rpms.yaml M jobs/confs/projects/vdsm/vdsm_standard.yaml D jobs/confs/projects/virtio-win-drivers/virtio-win-drivers.yaml 28 files changed, 0 insertions(+), 495 deletions(-) Approvals: Sandro Bonazzola: Looks good to me; Ready for merge Nadav Goldin: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/54418 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ieceb21bfba06e2bf7b2ec6869b7686a765dca2f8 Gerrit-PatchSet: 2 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Nadav Goldin <ngoldin(a)redhat.com> Gerrit-Reviewer: David Caro <dcaro(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6.4]: restapi: Don't fail with unexpected version numbers
by tnisan＠redhat.com 07 Mar '16

07 Mar '16

Tal Nisan has submitted this change and it was merged. Change subject: restapi: Don't fail with unexpected version numbers ...................................................................... restapi: Don't fail with unexpected version numbers Currently the API assumes that the format of version numbers is something like 4.3.1-100, and it fails due to an array index out of bounds exception if it has a different format. This patch makes this code more tolerant, and avoids the failures. Change-Id: Icaf19907ee09b8e4db731c3516520abce2527d50 Bug-Url: https://bugzilla.redhat.com/1311616 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit 430b799dc656e51244ae97a32340370f4469c6ad) --- M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VersionMapper.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java A backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/VersionMapperTest.java 3 files changed, 236 insertions(+), 64 deletions(-) Approvals: Juan Hernandez: Verified Jenkins CI: Passed CI tests Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/54423 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icaf19907ee09b8e4db731c3516520abce2527d50 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6.4 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-host-deploy[master]: ovirt-node-ng: Support yum obsoletes
by sbonazzo＠redhat.com 07 Mar '16

07 Mar '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: ovirt-node-ng: Support yum obsoletes ...................................................................... ovirt-node-ng: Support yum obsoletes ovirt-node-ng intends to rely on rpm spec file 'Obsoletes:'. See also: http://www.ovirt.org/node/4.0/update/ Change-Id: I52e5c17767c82567f0d474efb0753b3052be43a8 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M src/plugins/ovirt-host-mgmt/packages/update.py 1 file changed, 7 insertions(+), 1 deletion(-) Approvals: Fabian Deutsch: Looks good to me, but someone else must approve Sandro Bonazzola: Looks good to me, approved Eli Mesika: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/54416 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I52e5c17767c82567f0d474efb0753b3052be43a8 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: Always persist changes to hosted-engine VM (avoid usin...
by tnisan＠redhat.com 07 Mar '16

07 Mar '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Always persist changes to hosted-engine VM (avoid using NEXT_RUN) ...................................................................... core: Always persist changes to hosted-engine VM (avoid using NEXT_RUN) Engine VM can't use the Next-Run configuration features using the snapshots as its config must be saved ad hoc whenever there is a change. Hot plug support remains untouched and we should benefit from it with no change. This patch also prevents editing an unmanaged hosted engine VM. Change-Id: I5fb7650b37b792c4717492e8ed08c5dd178861cd Bug-Url: https://bugzilla.redhat.com/1290478 Signed-off-by: Roy Golan <rgolan(a)redhat.com> Signed-off-by: Martin Sivak <msivak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 8 files changed, 22 insertions(+), 8 deletions(-) Approvals: Tal Nisan: Passed CI tests Martin Sivák: Verified Roy Golan: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/51343 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5fb7650b37b792c4717492e8ed08c5dd178861cd Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: Selectively enable VM field editing for hosted engine
by tnisan＠redhat.com 07 Mar '16

07 Mar '16

Tal Nisan has submitted this change and it was merged. Change subject: Selectively enable VM field editing for hosted engine ...................................................................... Selectively enable VM field editing for hosted engine This patch adds a new annotation to VM and VmBase entities to mark certain fields as editable for hosted engine VM. Hosted engine fields are editable even though the VM is running. The relevant checkers are also updated to use this annotation instead of the more generic EditableField. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1160094 Change-Id: Ie4e847530d5b6b0b407db7dcc0d04a8140bbab01 Signed-off-by: Martin Sivak <msivak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/EditableHostedEngineField.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmBase.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ObjectIdentityChecker.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 10 files changed, 81 insertions(+), 4 deletions(-) Approvals: Martin Sivák: Verified Jenkins CI: Passed CI tests Roy Golan: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/54261 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie4e847530d5b6b0b407db7dcc0d04a8140bbab01 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi: Fix potential NPE in instance type mapper
by oourfali＠redhat.com 07 Mar '16

07 Mar '16

Oved Ourfali has submitted this change and it was merged. Change subject: restapi: Fix potential NPE in instance type mapper ...................................................................... restapi: Fix potential NPE in instance type mapper This patch fixes a potential NPE in that maps an API instance type to the corresponding backend type. Change-Id: I690e5abc5d27f9073c6f99469fda71d222131ad4 Coverity-Id: 1324991 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/InstanceTypeMapper.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tomas Jelinek: Looks good to me, approved Juan Hernandez: Verified Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/54373 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I690e5abc5d27f9073c6f99469fda71d222131ad4 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6.4]: engine: ObjectIdentityChecker: Exclude transient fields from...
by tnisan＠redhat.com 07 Mar '16

07 Mar '16

Tal Nisan has submitted this change and it was merged. Change subject: engine: ObjectIdentityChecker: Exclude transient fields from comparison ...................................................................... engine: ObjectIdentityChecker: Exclude transient fields from comparison Added new TransientField annotation to mark fields that are not stored in the DB so their values should be ignored when comparing objects with ObjectIdentityChecker. Change-Id: I9ac3388bd2c89c57d69d1766f9fb1c79f635452b Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1238742 Signed-off-by: Shmuel Melamud <smelamud(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/TransientField.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmBase.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ObjectIdentityChecker.java 4 files changed, 35 insertions(+), 3 deletions(-) Approvals: Jenkins CI: Passed CI tests Shmuel Leib Melamud: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/54399 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9ac3388bd2c89c57d69d1766f9fb1c79f635452b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6.4 Gerrit-Owner: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0