April 2016 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Fix unsatisfied dependency in SchedulingManagerTest
by mperina＠redhat.com 22 Apr '16

22 Apr '16

Martin Peřina has submitted this change and it was merged. Change subject: core: Fix unsatisfied dependency in SchedulingManagerTest ...................................................................... core: Fix unsatisfied dependency in SchedulingManagerTest Fixes unsatisfied dependency issue raised by patch I070c68d9377b8266f193c118c8b6dbfa979bd865. Change-Id: I1f3edc91699c1605171e1b4236d79a9f293f6448 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/scheduling/CommonTestMocks.java 1 file changed, 6 insertions(+), 0 deletions(-) Approvals: Martin Peřina: Verified; Looks good to me, approved Ravi Nori: Verified; Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/56515 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1f3edc91699c1605171e1b4236d79a9f293f6448 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in samples-uiplugins[master]: Cockpit UI Plugin for webadmin
by vszocs＠redhat.com 22 Apr '16

22 Apr '16

Vojtech Szocs has submitted this change and it was merged. Change subject: Cockpit UI Plugin for webadmin ...................................................................... Cockpit UI Plugin for webadmin With this plugin, the host main-tab shows new subtab embedding Cockpit which is running on the selected host. The host's right-click menu is enriched for new 'Cockpit' action leading to opening new browser window/tab with the host's Cockpit. When Cockpit is not running on the selected host, the menu action is disabled and the embedding subtab shows content of noCockpit.html page. See the README for more information. See cockpit.json for configuration. Change-Id: If70347aadcb30c14a0db05d9e9c4398cba09a05b Signed-off-by: Marek Libra <mlibra(a)redhat.com> --- A cockpit-plugin/README.cockpit A cockpit-plugin/cockpit-resources/index.html A cockpit-plugin/cockpit-resources/noCockpit.html A cockpit-plugin/cockpit.json 4 files changed, 152 insertions(+), 0 deletions(-) Approvals: Marek Libra: Verified Vojtech Szocs: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/56392 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If70347aadcb30c14a0db05d9e9c4398cba09a05b Gerrit-PatchSet: 2 Gerrit-Project: samples-uiplugins Gerrit-Branch: master Gerrit-Owner: Marek Libra <mlibra(a)redhat.com> Gerrit-Reviewer: Marek Libra <mlibra(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <mskrivan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Fix NPE in SessionDataContainer during logout
by mperina＠redhat.com 22 Apr '16

22 Apr '16

Martin Peřina has submitted this change and it was merged. Change subject: core: Fix NPE in SessionDataContainer during logout ...................................................................... core: Fix NPE in SessionDataContainer during logout Fixes NPE in SessionDataContainder during logout, which was caused by direct instantiation of SSOSessionUtils which contains CDI injected instance of JobDao. Change-Id: I070c68d9377b8266f193c118c8b6dbfa979bd865 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/SessionDataContainer.java 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Martin Peřina: Verified; Looks good to me, approved Ravi Nori: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/56495 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I070c68d9377b8266f193c118c8b6dbfa979bd865 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk[master]: Fix return of action
by juan.hernandez＠redhat.com 22 Apr '16

22 Apr '16

Juan Hernandez has submitted this change and it was merged. Change subject: Fix return of action ...................................................................... Fix return of action If action of service has output parameter we should return it from service action call. Change-Id: I8c9235b6536b5cce01f2236310b409c25e12d955 Signed-off-by: Ondra Machacek <omachace(a)redhat.com> --- M generator/src/main/java/org/ovirt/sdk/python/ServicesGenerator.java M sdk/lib/ovirtsdk4/service.py 2 files changed, 11 insertions(+), 1 deletion(-) Approvals: Ondra Machacek: Verified Juan Hernandez: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/56493 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8c9235b6536b5cce01f2236310b409c25e12d955 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: build: add check to ensure one helptag per line
by gshereme＠redhat.com 22 Apr '16

22 Apr '16

Greg Sheremeta has submitted this change and it was merged. Change subject: build: add check to ensure one helptag per line ...................................................................... build: add check to ensure one helptag per line Add check to ensure one helptag per line. The build will fail with a message if someone adds a tag that spans lines. We need help tags to be one per line for parsing purposes. Change-Id: I2a5a907ef397fa427b6ce805b89502a5ccd25c72 Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- M Makefile A build/helptag-oneline-check.py 2 files changed, 109 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Greg Sheremeta: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/56061 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2a5a907ef397fa427b6ce805b89502a5ccd25c72 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Scott Dickerson <sdickers(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: fixed helptags to be on single line
by gshereme＠redhat.com 22 Apr '16

22 Apr '16

Greg Sheremeta has submitted this change and it was merged. Change subject: engine: fixed helptags to be on single line ...................................................................... engine: fixed helptags to be on single line Helptags must be on a single line since they are parsed by a python script. Fixed. Change-Id: I72d2bb8de81375c6cd6ecc5adf59c5b8719df1b1 Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/help/HelpTag.java 1 file changed, 6 insertions(+), 12 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Alexander Wels: Looks good to me, approved Jenkins CI: Passed CI tests Greg Sheremeta: Verified -- To view, visit https://gerrit.ovirt.org/56057 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I72d2bb8de81375c6cd6ecc5adf59c5b8719df1b1 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: Add Python to build Node.js modules
by dcaro＠redhat.com 22 Apr '16

22 Apr '16

David Caro has submitted this change and it was merged. Change subject: Add Python to build Node.js modules ...................................................................... Add Python to build Node.js modules Some of the Node.js modules that we need use Python in their build scripts, so it needs to be installed in the build environment. Change-Id: Ib57a964b1d91089caab642ab65b957eeac873979 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M jobs/confs/projects/ovirt-engine-nodejs-modules/ovirt-engine-nodejs-modules.yaml 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Juan Hernandez: Verified; Ready for review Jenkins CI: Passed CI tests David Caro: Looks good to me; Ready for merge -- To view, visit https://gerrit.ovirt.org/56499 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib57a964b1d91089caab642ab65b957eeac873979 Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: David Caro <dcaro(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: standard ci: add unit tests to check-patch.sh
by sbonazzo＠redhat.com 22 Apr '16

22 Apr '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: standard ci: add unit tests to check-patch.sh ...................................................................... standard ci: add unit tests to check-patch.sh - replacing legacy unit tests jobs Change-Id: I86dc30702e1c9ecef11232d4c402ddb650d5303e Signed-off-by: Eyal Edri <eedri(a)redhat.com> Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M automation/check-patch.sh 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/56467 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I86dc30702e1c9ecef11232d4c402ddb650d5303e Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: David Caro <dcaro(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Sharon Naftaly <snaftaly(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: Add C++ compiler to build Node.js modules
by sbonazzo＠redhat.com 22 Apr '16

22 Apr '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: Add C++ compiler to build Node.js modules ...................................................................... Add C++ compiler to build Node.js modules Some of the Node.js modules that we need have native components written in C++, so in order to build them the C++ compiler needs to be installed. This patch adds the required "gcc-c++" package to the list packages installed before running the build. Change-Id: Ia9e313edc2ac7de430c5eb89f1e6f9dbab9b50c0 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M jobs/confs/projects/ovirt-engine-nodejs-modules/ovirt-engine-nodejs-modules.yaml 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me; Ready for merge Juan Hernandez: Ready for review Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/56490 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia9e313edc2ac7de430c5eb89f1e6f9dbab9b50c0 Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-java[master]: Add unit tests
by juan.hernandez＠redhat.com 22 Apr '16

22 Apr '16

Juan Hernandez has submitted this change and it was merged. Change subject: Add unit tests ...................................................................... Add unit tests Change-Id: Ic433a7b21a87cf459b9741023a58b484bfdd5cd5 Signed-off-by: Ondra Machacek <omachace(a)redhat.com> --- A sdk/src/test/java/org/ovirt/engine/sdk4/ActionReaderTest.java A sdk/src/test/java/org/ovirt/engine/sdk4/ClusterServiceTest.java A sdk/src/test/java/org/ovirt/engine/sdk4/ConnectionCreateTest.java A sdk/src/test/java/org/ovirt/engine/sdk4/ConnectionTimeoutTest.java A sdk/src/test/java/org/ovirt/engine/sdk4/ConnectionUseTest.java A sdk/src/test/java/org/ovirt/engine/sdk4/DataCentersServiceTest.java A sdk/src/test/java/org/ovirt/engine/sdk4/FollowLinkTest.java M sdk/src/test/java/org/ovirt/engine/sdk4/ServerTest.java A sdk/src/test/java/org/ovirt/engine/sdk4/StorageDomainsServiceTest.java A sdk/src/test/java/org/ovirt/engine/sdk4/VmTest.java A sdk/src/test/java/org/ovirt/engine/sdk4/VmsServiceTest.java 11 files changed, 861 insertions(+), 5 deletions(-) Approvals: Ondra Machacek: Verified Juan Hernandez: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/56388 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic433a7b21a87cf459b9741023a58b484bfdd5cd5 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: master Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0