April 2016 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: engine: Stop checking if hosts support live merge
by amureini＠redhat.com 19 Apr '16

19 Apr '16

Allon Mureinik has submitted this change and it was merged. Change subject: engine: Stop checking if hosts support live merge ...................................................................... engine: Stop checking if hosts support live merge oVirt Engine 3.5.1 introduced the live merge feature in the 3.5 DC level. However, this DC version allowed RHEL 6.y and RHEL 7.0 hosts with [relatively] old qemu and libvirt versions which did not support it, forcing the engine to explicitly check if the host running a VM a snapshot should be merged on supports the feature. Since commit 6eecdd7 only DCs of level 3.6 or higher are supported, meaning that the underlying platform is EL 7.1 or Fedora 22 (at least). The qemu and libvirt versions there support live merging snapshots, making this check redundant. Removing this check not only cleans up the code considerably, but also reduces execution time in a noticeable way by removing additional database flows from various places in the flow. Change-Id: I227efa20d9d7c26c15d536c378734563c87887dc Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/RemoveDiskSnapshotsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/RemoveSnapshotCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/VmValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/snapshots/RemoveDiskSnapshotsCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/snapshots/RemoveSnapshotCommandTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDS.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsDynamic.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineError.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDaoImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDynamicDaoImpl.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M backend/manager/modules/dal/src/main/resources/bundles/VdsmErrors.properties M backend/manager/modules/dal/src/test/resources/fixtures.xml M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsProperties.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmSnapshotListModel.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/VdsmErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/VdsmErrors.properties M packaging/dbscripts/create_views.sql A packaging/dbscripts/upgrade/04_00_0510_remove_live_merge_support_check.sql M packaging/dbscripts/vds_sp.sql 25 files changed, 7 insertions(+), 133 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/56306 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I227efa20d9d7c26c15d536c378734563c87887dc Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: Stop checking if hosts support live snapshot
by amureini＠redhat.com 19 Apr '16

19 Apr '16

Allon Mureinik has submitted this change and it was merged. Change subject: engine: Stop checking if hosts support live snapshot ...................................................................... engine: Stop checking if hosts support live snapshot Old VDSM versions on EL servers required qemu-kvm, which is a stripped down upstream flavor of qemu that does not support live snapshots. This created a situation where even though a host had a sufficiently high VDSM version to be part of a cluster that theoretically allowed live snapshots (i.e., 3.1 or above), the host itself may not have supported this feature, leading to the need to check for it explicitly, regardless of the cluster version. Modern VDSM versions (specifically, 4.17 or above, which is the minimal requirement to connect to the current engine) require qemu-kvm-[rh]ev in their spec file, promising the ability to perform live snapshots. This commit removes the liveSnapshotSupported property from VdsDynamic, VDS, the relevant database objects and any [redundant ]validations around it. Note that this property is visible in the REST API, although it's a read-only property which cannot be updated or manipulated. As the REST API model currently still specifies this property, the current patch does not remove it, but instead stubs it with a hardcoded `true` value. A subsequent patch will require a newer ovirt-engine-api-model version (which is not yet released at the time this patch was authored) to remove it from the API too. Change-Id: I9f1bcbd898885b999a57184eba8bc65c9c993900 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/CreateAllSnapshotsFromVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/lsm/LiveMigrateVmDisksCommand.java D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/LiveSnapshotValidator.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDS.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsDynamic.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDaoImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDynamicDaoImpl.java M backend/manager/modules/dal/src/test/resources/fixtures.xml M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/HostMapper.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsProperties.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostGeneralModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/host/SubTabHostGeneralInfoView.java M packaging/dbscripts/create_views.sql A packaging/dbscripts/upgrade/04_00_0520_remove_live_snapshot_support_check.sql M packaging/dbscripts/upgrade/post_upgrade/0010_add_object_column_white_list_table.sql M packaging/dbscripts/vds_sp.sql 18 files changed, 4 insertions(+), 100 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/56307 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9f1bcbd898885b999a57184eba8bc65c9c993900 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi: Remove Host#liveSnapshotSupport from V4 API
by amureini＠redhat.com 19 Apr '16

19 Apr '16

Allon Mureinik has submitted this change and it was merged. Change subject: restapi: Remove Host#liveSnapshotSupport from V4 API ...................................................................... restapi: Remove Host#liveSnapshotSupport from V4 API The previous patch removed the liveSnapshotSupport property from the backend VDS object and the related classes, but did not change the API (other than hollowing it out). This patch completes the job by consuming the updated ovirt-engine-api-model artifact that removes this property from the new V4 API. In order to preserve backwards compatibility, the V3 API will continue to report a `true` value, which is set in a hard-coded manner. Note that even in the previous version this is a read-only property which could not be updated (neither via the API nor by any other action via the engine - the only way to affect this property is, theoretically, to install/remove/update the qemu-kvm-[rhev] package on the host, but see below). Additionally, any host that can participate in a 3.6 or newer cluster will have this property as `true` anyway, as explained in the previous patch. Change-Id: I160d7ed8742128fdaac88bdc2228f4739139c5f5 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/adapters/V3HostInAdapter.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/adapters/V3HostOutAdapter.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/HostMapper.java M pom.xml 4 files changed, 3 insertions(+), 10 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/56308 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I160d7ed8742128fdaac88bdc2228f4739139c5f5 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Console related VmDynamic properties changed together
by ahadas＠redhat.com 19 Apr '16

19 Apr '16

Arik Hadas has submitted this change and it was merged. Change subject: core: Console related VmDynamic properties changed together ...................................................................... core: Console related VmDynamic properties changed together VmDynamic business entity has 3 properties identifying: consoleCurrentUserName, consoleUserId and clientIp. Client IP address is updated when the user connects to and disconnects from console, "consoleUserId" is updated in SetVmTicketCommand and when VM is started. I.e. it survives console disconnection. Before this patch "consoleCurrentUserName" was set similarly as "consoleUserId" but also set to `null` during user disconnection form console. Thus after console disconnect "consoleCurrentUserName" did not correspond to "consoleUserId" This patch unifies behavior of "consoleCurrentUserName" and "consoleUserId" so that they both survives console disconnect. Frontend is altered to to behave the same way as before i.e. "Console User" is only showed if the user is actually connected. Change-Id: Iff69ffd09a252f24bd66981ffbde80830ef74e5b Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsEventListener.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmDynamic.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalItemModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmGuestInfoModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/pool/SubTabPoolVmView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/template/SubTabTemplateVmView.java 6 files changed, 19 insertions(+), 15 deletions(-) Approvals: Jakub Niedermertl: Verified Jenkins CI: Passed CI tests Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/56002 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iff69ffd09a252f24bd66981ffbde80830ef74e5b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Host devices - driver column - backend
by ahadas＠redhat.com 19 Apr '16

19 Apr '16

Arik Hadas has submitted this change and it was merged. Change subject: core: Host devices - driver column - backend ...................................................................... core: Host devices - driver column - backend * New column 'driver' in 'host_device' table + appropriate changes in DAO mappers, stored procedures, business entity and DAO tests. * Data are written in RefreshHostDevicesCommand and shown in 'Host Devices' subtabs - following frontend patch. Change-Id: I5cc4cdcbc5c54078d02d03a056fba62e390f3b5a Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/HostDevice.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/HostDeviceDaoImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/HostDeviceDaoTest.java M backend/manager/modules/dal/src/test/resources/fixtures.xml M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsProperties.java M packaging/dbscripts/host_device_sp.sql A packaging/dbscripts/upgrade/04_00_0500_hostdevice_add_column_driver.sql 8 files changed, 70 insertions(+), 7 deletions(-) Approvals: Jakub Niedermertl: Verified Jenkins CI: Passed CI tests Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/56227 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5cc4cdcbc5c54078d02d03a056fba62e390f3b5a Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: packaging: setup: initialize DWHCoreEnv.ENABLE
by sbonazzo＠redhat.com 19 Apr '16

19 Apr '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: initialize DWHCoreEnv.ENABLE ...................................................................... packaging: setup: initialize DWHCoreEnv.ENABLE So that dev env does not fail without dwh installed. Change-Id: Ic9ba6d9a7982371721dabd4c599b455d94efcb5d Bug-Url: https://bugzilla.redhat.com/1318665 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/dwh_database.py 1 file changed, 9 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Martin Peřina: Verified; Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Yedidyah Bar David: Verified -- To view, visit https://gerrit.ovirt.org/56341 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic9ba6d9a7982371721dabd4c599b455d94efcb5d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi: Fix of exception while getting vv file
by tjelinek＠redhat.com 19 Apr '16

19 Apr '16

Tomas Jelinek has submitted this change and it was merged. Change subject: restapi: Fix of exception while getting vv file ...................................................................... restapi: Fix of exception while getting vv file "IllegalArgumentException: No enum constant org.ovirt.engine.api.model.GraphicsType.spice" was throw when vv file was requsted using REST api. The case was that conversion of string "spice" (decoded console id - 7370696365) was converted to actual instance of GraphicsType enum using #valueOf() isntead of custom #valueFrom(). Change-Id: I36ffbb0dea8b2d7c994718663ecebc508cce966f Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendGraphicsConsoleResource.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tomas Jelinek: Looks good to me, approved Jakub Niedermertl: Verified Juan Hernandez: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/56303 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I36ffbb0dea8b2d7c994718663ecebc508cce966f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi: Error hangling in BackendVmGraphicsConsoleResource
by tjelinek＠redhat.com 19 Apr '16

19 Apr '16

Tomas Jelinek has submitted this change and it was merged. Change subject: restapi: Error hangling in BackendVmGraphicsConsoleResource ...................................................................... restapi: Error hangling in BackendVmGraphicsConsoleResource The patch handles possible failure of ConfigureConsoleOptionsQuery called from method #generateDescriptor(). It may fail due to insufficient permissions. Standard error reporting can't be used here because it produces an explanatory reponse body and there is no MessageBodyWriter for 'application/x-virt-viewer' content type. Thus it would procude a HTML stacktrace about missing MessageBodyWriter. The error is logged and reported to client only using status code 500. Response body is empty. Change-Id: I1a22ba4f998dd317348393e6292614aedae3b8ec Bug-Url: https://bugzilla.redhat.com/1305600 Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmGraphicsConsoleResource.java 1 file changed, 16 insertions(+), 5 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Jakub Niedermertl: Verified Juan Hernandez: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/53243 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1a22ba4f998dd317348393e6292614aedae3b8ec Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: packaging: setup: versionlock tools-backup
by tnisan＠redhat.com 19 Apr '16

19 Apr '16

Tal Nisan has submitted this change and it was merged. Change subject: packaging: setup: versionlock tools-backup ...................................................................... packaging: setup: versionlock tools-backup To avoid an error when tyring to run 'yum update'. Bug-Url: https://bugzilla.redhat.com/1321249 Change-Id: I9c19cbf4d903f7871ee78b2e16e900cabdffeeee Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> (cherry picked from commit 0e3798e44abc3d84627cdb70e9e08637aca5e235) --- M packaging/setup/ovirt_engine_setup/constants.py 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Jenkins CI: Passed CI tests Yedidyah Bar David: Verified -- To view, visit https://gerrit.ovirt.org/56241 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9c19cbf4d903f7871ee78b2e16e900cabdffeeee Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: open Cockpit port in firewall
by tnisan＠redhat.com 19 Apr '16

19 Apr '16

Tal Nisan has submitted this change and it was merged. Change subject: core: open Cockpit port in firewall ...................................................................... core: open Cockpit port in firewall Cockpit will be the default administration interface in Node 4.0. The cockpit port (9090/tcp) should be added to the list of default ports to be opened, when the user decides to let engine manage the firewall fo the host. Change-Id: Ieef7fa196ae3459fb5d0697687d46b4747ce7860 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1314781 Signed-off-by: emesika <emesika(a)redhat.com> --- M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Martin Peřina: Verified Jenkins CI: Passed CI tests Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/56323 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ieef7fa196ae3459fb5d0697687d46b4747ce7860 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0