May 2016 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-4.0]: restapi: Add V3 IO exception mapper
by tnisan＠redhat.com 31 May '16

31 May '16

Tal Nisan has submitted this change and it was merged. Change subject: restapi: Add V3 IO exception mapper ...................................................................... restapi: Add V3 IO exception mapper Currently version 3 of the API doesn't have a specific IO exception mapper, as exceptions are handled by version 4, and then tranlsated to the version 3 format. But some exceptions happen before version 4 is called, for example the exceptions that happen during validation of integer values. In order to handle this kind of exceptions like we used to do in the past, we need a version 3 specific mapper. This patch adds it. Change-Id: I2622a162bfd92bc29bb35271e918c9cc7f3c8b6f Bug-Url: https://bugzilla.redhat.com/1339907 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit 9c23fd98783402d559ab156810ee5f445c9aa48c) --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/V3Application.java A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/V3IOExceptionMapper.java A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/V3UsageFinder.java 3 files changed, 187 insertions(+), 0 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/58404 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2622a162bfd92bc29bb35271e918c9cc7f3c8b6f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: restapi: Check watchdog model and action before mapping
by tnisan＠redhat.com 31 May '16

31 May '16

Tal Nisan has submitted this change and it was merged. Change subject: restapi: Check watchdog model and action before mapping ...................................................................... restapi: Check watchdog model and action before mapping This patch changes the API so that watchdog model and action attributes are checked before trying to map them, as otherwise the mapping produces NPEs. Change-Id: Ie7f188500df909f8c123fb90e7dd4c46a7c0787a Bug-Url: https://bugzilla.redhat.com/1338502 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit 63d4ffcda24f312eb67ca311a976aa428c1fba04) --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendInstanceTypeWatchdogResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendInstanceTypeWatchdogsResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendTemplateWatchdogResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendTemplateWatchdogsResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmWatchdogResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmWatchdogsResource.java 6 files changed, 54 insertions(+), 12 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/58403 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie7f188500df909f8c123fb90e7dd4c46a7c0787a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: restapi: Fix V3 input mapping of boot sequence
by tnisan＠redhat.com 31 May '16

31 May '16

Tal Nisan has submitted this change and it was merged. Change subject: restapi: Fix V3 input mapping of boot sequence ...................................................................... restapi: Fix V3 input mapping of boot sequence With the introduction of type safe enums in the API the boot devices need to be mapped using the BootDevice.fromValue method. Change-Id: Ic31e6b8c824b808ae64670033d1f4cdbd1608aad Bug-Url: https://bugzilla.redhat.com/1333340 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit afc2e483717220504248230ae4c5f15d752d62c6) --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/adapters/V3OperatingSystemInAdapter.java 1 file changed, 5 insertions(+), 11 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/58405 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic31e6b8c824b808ae64670033d1f4cdbd1608aad Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-dwh[master]: build: after build dwh for 4.0 rc
by Shirly Radco 31 May '16

31 May '16

Shirly Radco has submitted this change and it was merged. Change subject: build: after build dwh for 4.0 rc ...................................................................... build: after build dwh for 4.0 rc Fixed version. Change-Id: Iec6a29578613579f2dd4a3e842cfa29e84abb146 Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- M version.mak 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Shirly Radco: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/58362 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iec6a29578613579f2dd4a3e842cfa29e84abb146 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-dwh[master]: build: dwh build for 4.0 rc
by Shirly Radco 31 May '16

31 May '16

Shirly Radco has submitted this change and it was merged. Change subject: build: dwh build for 4.0 rc ...................................................................... build: dwh build for 4.0 rc bumped RPM_RELEASE. Change-Id: I977c71611f321eaaf7b11d460e017fdb0029eaf6 Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- M version.mak 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Shirly Radco: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/58361 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I977c71611f321eaaf7b11d460e017fdb0029eaf6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: PluginModel default search
by awels＠redhat.com 31 May '16

31 May '16

Alexander Wels has submitted this change and it was merged. Change subject: webadmin: PluginModel default search ...................................................................... webadmin: PluginModel default search - The plugin model default search string was null which caused a npe when doing comparisons against other strings Change-Id: I212caa34dcd1208c3c2e59e5a92f0a321e8ee609 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1340928 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/CommonModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/plugin/PluginModel.java 2 files changed, 2 insertions(+), 1 deletion(-) Approvals: Alexander Wels: Verified Jenkins CI: Passed CI tests Vojtech Szocs: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/58396 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I212caa34dcd1208c3c2e59e5a92f0a321e8ee609 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: Add ovirt-imageio stable branch for 4.0
by dcaro＠redhat.com 31 May '16

31 May '16

David Caro has submitted this change and it was merged. Change subject: Add ovirt-imageio stable branch for 4.0 ...................................................................... Add ovirt-imageio stable branch for 4.0 Change-Id: I345fd9f97025b07da8ee0808a2a6eeb0760e3f4d Signed-off-by: Nir Soffer <nsoffer(a)redhat.com> --- M jobs/confs/projects/ovirt-imageio/ovirt-imageio.yaml M jobs/confs/projects/ovirt/publish-rpms-nightly-4.0.yaml 2 files changed, 3 insertions(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests David Caro: Verified; Looks good to me; Passed CI tests; Ready for merge -- To view, visit https://gerrit.ovirt.org/58402 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I345fd9f97025b07da8ee0808a2a6eeb0760e3f4d Gerrit-PatchSet: 2 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: David Caro <dcaro(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi: Fix V3 input mapping of boot sequence
by juan.hernandez＠redhat.com 31 May '16

31 May '16

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Fix V3 input mapping of boot sequence ...................................................................... restapi: Fix V3 input mapping of boot sequence With the introduction of type safe enums in the API the boot devices need to be mapped using the BootDevice.fromValue method. Change-Id: Ic31e6b8c824b808ae64670033d1f4cdbd1608aad Bug-Url: https://bugzilla.redhat.com/1333340 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/adapters/V3OperatingSystemInAdapter.java 1 file changed, 5 insertions(+), 11 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/58278 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic31e6b8c824b808ae64670033d1f4cdbd1608aad Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi: Add V3 IO exception mapper
by juan.hernandez＠redhat.com 31 May '16

31 May '16

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Add V3 IO exception mapper ...................................................................... restapi: Add V3 IO exception mapper Currently version 3 of the API doesn't have a specific IO exception mapper, as exceptions are handled by version 4, and then tranlsated to the version 3 format. But some exceptions happen before version 4 is called, for example the exceptions that happen during validation of integer values. In order to handle this kind of exceptions like we used to do in the past, we need a version 3 specific mapper. This patch adds it. Change-Id: I2622a162bfd92bc29bb35271e918c9cc7f3c8b6f Bug-Url: https://bugzilla.redhat.com/1339907 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/V3Application.java A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/V3IOExceptionMapper.java A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/V3UsageFinder.java 3 files changed, 187 insertions(+), 0 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/58260 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2622a162bfd92bc29bb35271e918c9cc7f3c8b6f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi: Check watchdog model and action before mapping
by juan.hernandez＠redhat.com 31 May '16

31 May '16

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Check watchdog model and action before mapping ...................................................................... restapi: Check watchdog model and action before mapping This patch changes the API so that watchdog model and action attributes are checked before trying to map them, as otherwise the mapping produces NPEs. Change-Id: Ie7f188500df909f8c123fb90e7dd4c46a7c0787a Bug-Url: https://bugzilla.redhat.com/1338502 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendInstanceTypeWatchdogResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendInstanceTypeWatchdogsResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendTemplateWatchdogResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendTemplateWatchdogsResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmWatchdogResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmWatchdogsResource.java 6 files changed, 54 insertions(+), 12 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/58249 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie7f188500df909f8c123fb90e7dd4c46a7c0787a Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0