June 2016 - Engine-commits - oVirt List Archives

Change in ovirt-engine-cli[master]: cli: Iterate all permutations of parent identifiers
by juan.hernandez＠redhat.com 10 Jun '16

10 Jun '16

Juan Hernandez has submitted this change and it was merged. Change subject: cli: Iterate all permutations of parent identifiers ...................................................................... cli: Iterate all permutations of parent identifiers When the CLI processes a command that contains multiple parent identifiers it should process all the permutations in order to find the correct collection. For example, for the following command: # add vm --id 123 \ --parent-cluster-identifier 456 \ --parent-affinitygroup-identifier 789 The CLI should try the following permutations: 1) --parent-cluster-identifier, --parent-affinitygroup-identifier 2) --parent-affinitygroup-identifier, --parent-cluster-identifier Which should result in trying the following API URLs: 1) /clusters/456/affinitygroups/789 2) /affinitygroups/789/clusters/456 The first will work, the second will not, as it doesn't exist. This is theory, but in practice the CLI doesn't try these permutations correctly, only the first one. In addition the ordering of the permutations depends on the names of the options. For example, if the options don't have the "parent" prefix, then the order of the permutations will be different, and the first one, the only actually tried, will also be different. This patch fixes the code that tries these permutations, so that it will actually try all of them, till one succeeds. Change-Id: I9ea62ef10f8cf04d9e7ee54b2ac420555bd567be Bug-Url: https://bugzilla.redhat.com/1335844 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M src/ovirtcli/command/command.py 1 file changed, 58 insertions(+), 35 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/59010 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9ea62ef10f8cf04d9e7ee54b2ac420555bd567be Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-setup[master]: upgrade: fixing env configuration on upgrade
by stirabos＠redhat.com 10 Jun '16

10 Jun '16

Simone Tiraboschi has submitted this change and it was merged. Change subject: upgrade: fixing env configuration on upgrade ...................................................................... upgrade: fixing env configuration on upgrade Fixing env configuration on upgrade to correcty handle cases like when 3.6 was deployed without using the appliance (pxe, cdrom) or without configuring it via the generated cloud-init image. Change-Id: I5a30cf98a2fd1f778fecacfa6e8bb69aff45ee3b Bug-Url: https://bugzilla.redhat.com/1344310 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M src/plugins/gr-he-common/core/remote_answerfile.py M src/plugins/gr-he-common/vm/cloud_init.py 2 files changed, 36 insertions(+), 13 deletions(-) Approvals: Simone Tiraboschi: Verified; Looks good to me, approved Jenkins CI: Passed CI tests Rafael Martins: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/58985 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5a30cf98a2fd1f778fecacfa6e8bb69aff45ee3b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi: VmPool properties list reviewed in RSDL
by mperina＠redhat.com 10 Jun '16

10 Jun '16

Martin Peřina has submitted this change and it was merged. Change subject: restapi: VmPool properties list reviewed in RSDL ...................................................................... restapi: VmPool properties list reviewed in RSDL The list of VmPool action properties conforms the 'VmPoolMapper'. Change-Id: I93f323e6481f613607832dbc03ba3cf663d58faa Bug-Url: https://bugzilla.redhat.com/1318703 Signed-off-by: Marek Libra <mlibra(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Ondra Machacek: Looks good to me, but someone else must approve Juan Hernandez: Looks good to me, approved Jenkins CI: Passed CI tests Marek Libra: Verified -- To view, visit https://gerrit.ovirt.org/58977 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I93f323e6481f613607832dbc03ba3cf663d58faa Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Marek Libra <mlibra(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Marek Libra <mlibra(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: restapi: Set ActiveDirectoryOu in InitializationMapper
by piotr.kliczewski＠gmail.com 10 Jun '16

10 Jun '16

Piotr Kliczewski has submitted this change and it was merged. Change subject: restapi: Set ActiveDirectoryOu in InitializationMapper ...................................................................... restapi: Set ActiveDirectoryOu in InitializationMapper The value was not set before this fix. Change-Id: Ic9f121cac0807f1ae3a4fbc47f1910528addb00f Bug-Url: https://bugzilla.redhat.com/1344426 Signed-off-by: Marek Libra <mlibra(a)redhat.com> --- M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/InitializationMapper.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Juan Hernandez: Looks good to me, approved Jenkins CI: Passed CI tests Marek Libra: Verified -- To view, visit https://gerrit.ovirt.org/58961 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic9f121cac0807f1ae3a4fbc47f1910528addb00f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Marek Libra <mlibra(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Marek Libra <mlibra(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: restapi: VM Start action properties list reviewed in RSDL
by piotr.kliczewski＠gmail.com 10 Jun '16

10 Jun '16

Piotr Kliczewski has submitted this change and it was merged. Change subject: restapi: VM Start action properties list reviewed in RSDL ...................................................................... restapi: VM Start action properties list reviewed in RSDL The action properties list conforms the 'Initialization to VmInit' mapper (org.ovirt.engine.api.restapi.types.InitializationMapper) Bug-Url: https://bugzilla.redhat.com/1318701 Change-Id: I4b2e32ef4d0af0301df0444c075c445b9cf6acc7 Signed-off-by: Marek Libra <mlibra(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml 1 file changed, 23 insertions(+), 0 deletions(-) Approvals: Juan Hernandez: Looks good to me, approved Jenkins CI: Passed CI tests Marek Libra: Verified -- To view, visit https://gerrit.ovirt.org/58929 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4b2e32ef4d0af0301df0444c075c445b9cf6acc7 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Marek Libra <mlibra(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Marek Libra <mlibra(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Sync db scripts numbering between master and ovirt-eng...
by mperina＠redhat.com 10 Jun '16

10 Jun '16

Martin Peřina has submitted this change and it was merged. Change subject: core: Sync db scripts numbering between master and ovirt-engine-4.0 ...................................................................... core: Sync db scripts numbering between master and ovirt-engine-4.0 Synchronizes database upgrade scripts numbering between master and ovirt-engine-4.0 branch. This should fix database upgrade issues from ovirt-engine-4.0 to master. Change-Id: I0c6415eca58bee5fd790d88b3a960ce0779512f8 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- R packaging/dbscripts/upgrade/04_00_0730_remove_filter_from_passthrough_vnics.sql R packaging/dbscripts/upgrade/04_00_0740_remove_allow_dhcp_server_filter.sql R packaging/dbscripts/upgrade/04_00_0750_add_mac_pool_id_to_vds_group.sql R packaging/dbscripts/upgrade/04_00_0760_empty_current_cd_to_null.sql R packaging/dbscripts/upgrade/04_00_0770_remove_mac_pool_id_from_storage_pool.sql R packaging/dbscripts/upgrade/04_00_0780_move_guest_mem_fields_to_statistics.sql 6 files changed, 0 insertions(+), 0 deletions(-) Approvals: Martin Peřina: Verified; Looks good to me, approved Eyal Edri: Verified; Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/58936 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0c6415eca58bee5fd790d88b3a960ce0779512f8 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: build: post ovirt-engine-4.0.0.4
by amarchuk＠redhat.com 10 Jun '16

10 Jun '16

Anton Marchukov has submitted this change and it was merged. Change subject: build: post ovirt-engine-4.0.0.4 ...................................................................... build: post ovirt-engine-4.0.0.4 Change-Id: I6e2828c3222e34969669cc9e0ef5f8915285cc53 Signed-off-by: Rafael Martins <rmartins(a)redhat.com> --- M automation/build-artifacts.sh M backend/manager/dependencies/common/pom.xml M backend/manager/dependencies/pom.xml M backend/manager/dependencies/tools/pom.xml M backend/manager/extensions-tool/pom.xml M backend/manager/modules/aaa/pom.xml M backend/manager/modules/auth-plugin/pom.xml M backend/manager/modules/bll/pom.xml M backend/manager/modules/branding/pom.xml M backend/manager/modules/builtin-extensions/pom.xml M backend/manager/modules/common/pom.xml M backend/manager/modules/compat/pom.xml M backend/manager/modules/dal/pom.xml M backend/manager/modules/docs/pom.xml M backend/manager/modules/enginesso/pom.xml M backend/manager/modules/extensions-api-root/extensions-api/pom.xml M backend/manager/modules/extensions-api-root/pom.xml M backend/manager/modules/extensions-manager/pom.xml M backend/manager/modules/logger/pom.xml M backend/manager/modules/pom.xml M backend/manager/modules/restapi/interface/common/jaxrs/pom.xml M backend/manager/modules/restapi/interface/common/pom.xml M backend/manager/modules/restapi/interface/definition/pom.xml M backend/manager/modules/restapi/interface/pom.xml M backend/manager/modules/restapi/jaxrs/pom.xml M backend/manager/modules/restapi/pom.xml M backend/manager/modules/restapi/types/pom.xml M backend/manager/modules/restapi/webapp/pom.xml M backend/manager/modules/root/pom.xml M backend/manager/modules/scheduler/pom.xml M backend/manager/modules/searchbackend/pom.xml M backend/manager/modules/services/pom.xml M backend/manager/modules/utils/pom.xml M backend/manager/modules/uutils/pom.xml M backend/manager/modules/vdsbroker/pom.xml M backend/manager/modules/welcome/pom.xml M backend/manager/pom.xml M backend/manager/tools/pom.xml M backend/pom.xml M build-tools-root/checkstyles/pom.xml M build-tools-root/ovirt-checkstyle-extension/pom.xml M build-tools-root/ovirt-findbugs-filters/pom.xml M build-tools-root/pom.xml M build/validations/pom.xml M ear/pom.xml M frontend/pom.xml M frontend/webadmin/modules/frontend-symbols/pom.xml M frontend/webadmin/modules/frontend/pom.xml M frontend/webadmin/modules/gwt-common/pom.xml M frontend/webadmin/modules/gwt-extension/pom.xml M frontend/webadmin/modules/pom.xml M frontend/webadmin/modules/uicommonweb/pom.xml M frontend/webadmin/modules/uicompat/pom.xml M frontend/webadmin/modules/userportal-gwtp/pom.xml M frontend/webadmin/modules/webadmin/pom.xml M frontend/webadmin/pom.xml M mavenmake/pom.xml M pom.xml M version.mak 59 files changed, 66 insertions(+), 63 deletions(-) Approvals: Piotr Kliczewski: Looks good to me, but someone else must approve Simone Tiraboschi: Looks good to me, but someone else must approve Anton Marchukov: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/58983 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6e2828c3222e34969669cc9e0ef5f8915285cc53 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: build: ovirt-engine-4.0.0.4
by amarchuk＠redhat.com 10 Jun '16

10 Jun '16

Anton Marchukov has submitted this change and it was merged. Change subject: build: ovirt-engine-4.0.0.4 ...................................................................... build: ovirt-engine-4.0.0.4 Change-Id: I6679e78628db7ce5888a5450a205eb545f42e98e Signed-off-by: Rafael Martins <rmartins(a)redhat.com> --- M automation/build-artifacts.sh M backend/manager/dependencies/common/pom.xml M backend/manager/dependencies/pom.xml M backend/manager/dependencies/tools/pom.xml M backend/manager/extensions-tool/pom.xml M backend/manager/modules/aaa/pom.xml M backend/manager/modules/auth-plugin/pom.xml M backend/manager/modules/bll/pom.xml M backend/manager/modules/branding/pom.xml M backend/manager/modules/builtin-extensions/pom.xml M backend/manager/modules/common/pom.xml M backend/manager/modules/compat/pom.xml M backend/manager/modules/dal/pom.xml M backend/manager/modules/docs/pom.xml M backend/manager/modules/enginesso/pom.xml M backend/manager/modules/extensions-api-root/extensions-api/pom.xml M backend/manager/modules/extensions-api-root/pom.xml M backend/manager/modules/extensions-manager/pom.xml M backend/manager/modules/logger/pom.xml M backend/manager/modules/pom.xml M backend/manager/modules/restapi/interface/common/jaxrs/pom.xml M backend/manager/modules/restapi/interface/common/pom.xml M backend/manager/modules/restapi/interface/definition/pom.xml M backend/manager/modules/restapi/interface/pom.xml M backend/manager/modules/restapi/jaxrs/pom.xml M backend/manager/modules/restapi/pom.xml M backend/manager/modules/restapi/types/pom.xml M backend/manager/modules/restapi/webapp/pom.xml M backend/manager/modules/root/pom.xml M backend/manager/modules/scheduler/pom.xml M backend/manager/modules/searchbackend/pom.xml M backend/manager/modules/services/pom.xml M backend/manager/modules/utils/pom.xml M backend/manager/modules/uutils/pom.xml M backend/manager/modules/vdsbroker/pom.xml M backend/manager/modules/welcome/pom.xml M backend/manager/pom.xml M backend/manager/tools/pom.xml M backend/pom.xml M build-tools-root/checkstyles/pom.xml M build-tools-root/ovirt-checkstyle-extension/pom.xml M build-tools-root/ovirt-findbugs-filters/pom.xml M build-tools-root/pom.xml M build/validations/pom.xml M ear/pom.xml M frontend/pom.xml M frontend/webadmin/modules/frontend-symbols/pom.xml M frontend/webadmin/modules/frontend/pom.xml M frontend/webadmin/modules/gwt-common/pom.xml M frontend/webadmin/modules/gwt-extension/pom.xml M frontend/webadmin/modules/pom.xml M frontend/webadmin/modules/uicommonweb/pom.xml M frontend/webadmin/modules/uicompat/pom.xml M frontend/webadmin/modules/userportal-gwtp/pom.xml M frontend/webadmin/modules/webadmin/pom.xml M frontend/webadmin/pom.xml M mavenmake/pom.xml M ovirt-engine.spec.in M pom.xml M version.mak 60 files changed, 65 insertions(+), 65 deletions(-) Approvals: Piotr Kliczewski: Looks good to me, but someone else must approve Simone Tiraboschi: Looks good to me, but someone else must approve Anton Marchukov: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/58982 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6679e78628db7ce5888a5450a205eb545f42e98e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine-sdk-java[master]: Update to model 4.0.20 and metamodel 1.0.14
by omachace＠redhat.com 10 Jun '16

10 Jun '16

Ondra Machacek has submitted this change and it was merged. Change subject: Update to model 4.0.20 and metamodel 1.0.14 ...................................................................... Update to model 4.0.20 and metamodel 1.0.14 Change-Id: I1fae2cd1df479c9d0857975d62506cd16093b9d9 Signed-off-by: Ondra Machacek <omachace(a)redhat.com> --- M pom.xml 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Ondra Machacek: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/58984 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1fae2cd1df479c9d0857975d62506cd16093b9d9 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: master Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: core: Fix type of ConfigValues.Ipv6Supported
by piotr.kliczewski＠gmail.com 10 Jun '16

10 Jun '16

Piotr Kliczewski has submitted this change and it was merged. Change subject: core: Fix type of ConfigValues.Ipv6Supported ...................................................................... core: Fix type of ConfigValues.Ipv6Supported Fixes type of ConfigValues.Ipv6Supported from String to Boolean to be able to call Config.<Boolean> get() method. If type is String then of course ClassCastException it thrown. Change-Id: I773af6c508f8249eb5de6c9c1fac8a3777a2d763 Bug-Url: https://bugzilla.redhat.com/1344355 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Piotr Kliczewski: Looks good to me, but someone else must approve Martin Peřina: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/58967 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I773af6c508f8249eb5de6c9c1fac8a3777a2d763 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0