June 2016 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: engine: Insufficient free macs while there is enough macs in...
by alkaplan＠redhat.com 09 Jun '16

09 Jun '16

Alona Kaplan has submitted this change and it was merged. Change subject: engine: Insufficient free macs while there is enough macs in pool ...................................................................... engine: Insufficient free macs while there is enough macs in pool When required mac address allocation is bigger than available macs count in a specific mac range in mac pool, while smaller than available macs count in mac pool, 'Insufficient amount of free MACs' error happens. This patch avoid consuming a mac range with the mac count bigger than the mac rang's available macs. Change-Id: Ib37c77f6f017942a409df02657df656ac5ea9d38 Signed-off-by: plysan <plysab(a)gmail.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/macpool/MacsStorage.java 1 file changed, 6 insertions(+), 1 deletion(-) Approvals: Martin Mucha: Verified Alona Kaplan: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/51615 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib37c77f6f017942a409df02657df656ac5ea9d38 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org> Gerrit-Reviewer: plysan <plysab(a)gmail.com>

1 0

Change in ovirt-engine[master]: core: ActivateStorageDomainCommandTest type inference
by amureini＠redhat.com 09 Jun '16

09 Jun '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: ActivateStorageDomainCommandTest type inference ...................................................................... core: ActivateStorageDomainCommandTest type inference Change-Id: I912e81f9f0e287605eb6f03590fca11cfd162f87 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/domain/ActivateStorageDomainCommandTest.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/58880 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I912e81f9f0e287605eb6f03590fca11cfd162f87 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-java[master]: Fix example of listing vms in SDK README file
by omachace＠redhat.com 09 Jun '16

09 Jun '16

Ondra Machacek has submitted this change and it was merged. Change subject: Fix example of listing vms in SDK README file ...................................................................... Fix example of listing vms in SDK README file Change-Id: I2d135110750fc03d31abdde1e7db3c5962a414d7 Signed-off-by: Ondra Machacek <omachace(a)redhat.com> --- M sdk/README.adoc 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Ondra Machacek: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/58887 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2d135110750fc03d31abdde1e7db3c5962a414d7 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: master Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi: don't ignore new template's name on import image fr...
by tnisan＠redhat.com 09 Jun '16

09 Jun '16

Tal Nisan has submitted this change and it was merged. Change subject: restapi: don't ignore new template's name on import image from Glance ...................................................................... restapi: don't ignore new template's name on import image from Glance When importing an image as a template from Glance, if the URL that is used is of the form "/api/openstackimageproviders/<provider_id>/images/<image_id>/import" and the template's name is specified, it is ignored and not passed to ImportRepoImageCommand. This patch passes this parameter if it is specified. Change-Id: I60f44c0d519e7deea29095543b1a06ac0d6a1ef4 Bug-Url: https://bugzilla.redhat.com/1344048 Signed-off-by: Idan Shaby <ishaby(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/openstack/BackendOpenStackImageResource.java 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Looks good to me, but someone else must approve; Passed CI tests Juan Hernandez: Looks good to me, approved Freddy Rolland: Looks good to me, but someone else must approve Idan Shaby: Verified -- To view, visit https://gerrit.ovirt.org/58869 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I60f44c0d519e7deea29095543b1a06ac0d6a1ef4 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: core: Allow adding 3.6 host without deploying HE
by tnisan＠redhat.com 09 Jun '16

09 Jun '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Allow adding 3.6 host without deploying HE ...................................................................... core: Allow adding 3.6 host without deploying HE The validation for adding hosts to 3.6 should allow action of 'none' on those hosts since it doesn't have any effect on HE install and 3.6 supports that. Change-Id: Ifbe61e41f145e2e8fefcb9f69b4ef24ae1f090e0 Bug-Url: https://bugzilla.redhat.com/1342500 Signed-off-by: Roy Golan <rgolan(a)redhat.com> (cherry picked from commit 3ce2b9d34aac26a2f66b660432203a2eb1b6f50e) --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/HostValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/HostValidatorTest.java 2 files changed, 12 insertions(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Roy Golan: Verified Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/58842 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifbe61e41f145e2e8fefcb9f69b4ef24ae1f090e0 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Set disk profile on image creation or update
by dfediuck＠redhat.com 09 Jun '16

09 Jun '16

Doron Fediuck has submitted this change and it was merged. Change subject: webadmin: Set disk profile on image creation or update ...................................................................... webadmin: Set disk profile on image creation or update Set the disk profile when an image is created or updated. Change-Id: Ifdc5528419f14af4424dca42a9af3ee81122adc5 Bug-Url: https://bugzilla.redhat.com/1297734 Signed-off-by: Roman Mohr <rmohr(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/AbstractDiskModel.java 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Roman Mohr: Verified Alexander Wels: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/58763 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifdc5528419f14af4424dca42a9af3ee81122adc5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: backend: generate default template's name for repo-image
by derez＠redhat.com 09 Jun '16

09 Jun '16

Daniel Erez has submitted this change and it was merged. Change subject: backend: generate default template's name for repo-image ...................................................................... backend: generate default template's name for repo-image When importing an image from glance as a template, if the template's name is not specified then we generate a default one in ImportRepoImageCopyTaskHandler::createTemplate. The problem with this is that ImportRepoImageCommand doesn't know about this auto generated template's name (it's null in the command's parameters), and then the template is logged as a part of the event as "<UNKNOWN>", although it's created with its default name. This patch generates that default template's name in the command instead of the handler. Change-Id: I7386be3d2c1254dc3df0dfab9c6c340b41a00aed Bug-Url: https://bugzilla.redhat.com/1324780 Signed-off-by: Idan Shaby <ishaby(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/repoimage/ImportRepoImageCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/repoimage/ImportRepoImageCopyTaskHandler.java 2 files changed, 10 insertions(+), 3 deletions(-) Approvals: Tal Nisan: Looks good to me, but someone else must approve Daniel Erez: Looks good to me, approved Jenkins CI: Passed CI tests Idan Shaby: Verified -- To view, visit https://gerrit.ovirt.org/58866 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7386be3d2c1254dc3df0dfab9c6c340b41a00aed Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: fix DAO test falure
by masayag＠redhat.com 09 Jun '16

09 Jun '16

Moti Asayag has submitted this change and it was merged. Change subject: core: fix DAO test falure ...................................................................... core: fix DAO test falure The change populates the default value of LEGACY to Cluster.requiredSwitchTypeForCluster. That fixes the NPE that is thrown in MapSqlParameterSource of ClusterDaoImpl that assumes the field is non-nullable. Change-Id: I6bf23da75829f79f79e5a160b3f637bc0b04dda4 Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Cluster.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved Yevgeny Zaspitsky: Verified -- To view, visit https://gerrit.ovirt.org/58876 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6bf23da75829f79f79e5a160b3f637bc0b04dda4 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: really fix div by 0 exception
by awels＠redhat.com 08 Jun '16

08 Jun '16

Alexander Wels has submitted this change and it was merged. Change subject: webadmin: really fix div by 0 exception ...................................................................... webadmin: really fix div by 0 exception - On a VM without a disk the query would fail. I thought I had fixed the problem early but I had messed up the way the sql worked, this patch fixes the problem. Change-Id: I9c1f0ad0554828063c62e0f2541f8aba3193bad2 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1342098 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/frontend/src/main/resources/org/ovirt/engine/ui/frontend/server/dashboard/dao/StorageDomainDwhDAO.properties 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Alexander Wels: Verified Jenkins CI: Passed CI tests Greg Sheremeta: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/58878 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9c1f0ad0554828063c62e0f2541f8aba3193bad2 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: webadmin: Populate external network id during subnet create
by tnisan＠redhat.com 08 Jun '16

08 Jun '16

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Populate external network id during subnet create ...................................................................... webadmin: Populate external network id during subnet create AddNetworkOnProviderCommand requires external network id to create subnets on an external provider. Only the network id, but not the external id was returned after the network was created. The patch changes the return value after the network was created from just the network id to network, so that all required parameters can be retrieved. Change-Id: I5941abd9148f7d6dce45c7056ef7224e7ec51904 Bug-Url: https://bugzilla.redhat.com/1216081 Signed-off-by: mirecki <mmirecki(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/network/AddNetworkOnProviderCommand.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/NewNetworkModel.java 2 files changed, 8 insertions(+), 11 deletions(-) Approvals: Marcin Mirecki: Verified Alona Kaplan: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/58828 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5941abd9148f7d6dce45c7056ef7224e7ec51904 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0