June 2016 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core, webadmin: change switch type default value.
by alkaplan＠redhat.com 08 Jun '16

08 Jun '16

Alona Kaplan has submitted this change and it was merged. Change subject: core,webadmin: change switch type default value. ...................................................................... core,webadmin: change switch type default value. currently the switch type default value has to be LEGACY, regardless of cluster version Change-Id: I9e30bf9b87ee5bb274f434e1ea3b451209f6998c Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/network/DefaultSwitchType.java 1 file changed, 1 insertion(+), 3 deletions(-) Approvals: Marcin Mirecki: Looks good to me, but someone else must approve Martin Mucha: Verified Alona Kaplan: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/57955 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9e30bf9b87ee5bb274f434e1ea3b451209f6998c Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: add SwitchType to cluster dialog
by alkaplan＠redhat.com 08 Jun '16

08 Jun '16

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: add SwitchType to cluster dialog ...................................................................... webadmin: add SwitchType to cluster dialog Change-Id: I9d8ff77cea8931c121c721743da721bd689d5770 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/ConfigurationValues.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterPopupView.ui.xml M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/ApplicationConstants.properties 7 files changed, 58 insertions(+), 1 deletion(-) Approvals: Martin Mucha: Verified Alona Kaplan: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/56264 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9d8ff77cea8931c121c721743da721bd689d5770 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: eliminate unnecessary (and complicating) events.
by alkaplan＠redhat.com 08 Jun '16

08 Jun '16

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: eliminate unnecessary (and complicating) events. ...................................................................... webadmin: eliminate unnecessary (and complicating) events. previous code fired serie of events — first it fired update change of version field, but informing about update to some not real value. Then real value was calculated and field was changed to that value(multiple times). So there was a) unnecessary events b) one event which was wrong. after update only one event is generated and with correct value. Motivation: following patch wants to update switch type field value if value of version field is changed to version older than 4.0. Because of that, we cannot tolerate any 'version updated to 3.6' invalid event even if it's followed immediately with 'version updated to 4.0' . Such event can be fired ONLY if version was actually changed to 3.6. Change-Id: I20064dfa01b068c8e43472507519d782e6c98ba3 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterModel.java 1 file changed, 21 insertions(+), 16 deletions(-) Approvals: Marcin Mirecki: Looks good to me, but someone else must approve Martin Mucha: Verified Alona Kaplan: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/56263 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I20064dfa01b068c8e43472507519d782e6c98ba3 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: pass SwitchType from Cluster to HostNetwork
by alkaplan＠redhat.com 08 Jun '16

08 Jun '16

Alona Kaplan has submitted this change and it was merged. Change subject: core: pass SwitchType from Cluster to HostNetwork ...................................................................... core: pass SwitchType from Cluster to HostNetwork Change-Id: I2c4a5a61a99aae0824899cee3223e864921ad6d8 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksCommand.java 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Martin Mucha: Verified Alona Kaplan: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/56202 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2c4a5a61a99aae0824899cee3223e864921ad6d8 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: use SwitchType when creating cluster.
by alkaplan＠redhat.com 08 Jun '16

08 Jun '16

Alona Kaplan has submitted this change and it was merged. Change subject: core: use SwitchType when creating cluster. ...................................................................... core: use SwitchType when creating cluster. when creating new cluster and switch type is not provided, default one is calculated. when updating existing cluster and switch type is not provided, value of record being updated is used. Change-Id: Id898adb888e586c1f2b6395aa80fc0d430ef1029 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddClusterCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ClusterOperationCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateClusterCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddClusterCommandTest.java 4 files changed, 50 insertions(+), 29 deletions(-) Approvals: Martin Mucha: Verified Alona Kaplan: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/56201 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id898adb888e586c1f2b6395aa80fc0d430ef1029 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: add test for identifying different SwitchType
by alkaplan＠redhat.com 08 Jun '16

08 Jun '16

Alona Kaplan has submitted this change and it was merged. Change subject: core: add test for identifying different SwitchType ...................................................................... core: add test for identifying different SwitchType Change-Id: Ifa6c5dee04b2c12799287e595f77bef7e2bfa3e1 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/NetworkInSyncWithVdsNetworkInterfaceTest.java 1 file changed, 18 insertions(+), 0 deletions(-) Approvals: Martin Mucha: Verified Alona Kaplan: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/56198 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifa6c5dee04b2c12799287e595f77bef7e2bfa3e1 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: removed duplicates + code format.
by alkaplan＠redhat.com 08 Jun '16

08 Jun '16

Alona Kaplan has submitted this change and it was merged. Change subject: core: removed duplicates + code format. ...................................................................... core: removed duplicates + code format. Change-Id: Iea0b9fbdd58ec583e0b5ec3ddcf7625933ca4210 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/ReportedConfiguration.java M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/NetworkInSyncWithVdsNetworkInterfaceTest.java 2 files changed, 121 insertions(+), 112 deletions(-) Approvals: Martin Mucha: Verified Alona Kaplan: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/56197 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iea0b9fbdd58ec583e0b5ec3ddcf7625933ca4210 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: simplified use of ReportedConfiguration
by alkaplan＠redhat.com 08 Jun '16

08 Jun '16

Alona Kaplan has submitted this change and it was merged. Change subject: core: simplified use of ReportedConfiguration ...................................................................... core: simplified use of ReportedConfiguration Change-Id: I80f0b4734cb3fd5082a2476be4d2f4f6ff2641dd Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/ReportedConfiguration.java M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/NetworkInSyncWithVdsNetworkInterfaceTest.java 2 files changed, 33 insertions(+), 30 deletions(-) Approvals: Martin Mucha: Verified Alona Kaplan: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/56196 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I80f0b4734cb3fd5082a2476be4d2f4f6ff2641dd Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: check if also switch type is in sync
by alkaplan＠redhat.com 08 Jun '16

08 Jun '16

Alona Kaplan has submitted this change and it was merged. Change subject: core: check if also switch type is in sync ...................................................................... core: check if also switch type is in sync added new ReportedConfigurationType and updated NetworkInSyncWithVdsNetworkInterface so that switch type differences are taken into account and reported Change-Id: I68f4cf0ce93123bef1e620193631afd707244170 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/GetNetworkAttachmentsByHostIdQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/ReportedConfigurationsFiller.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/host/ReportedConfigurationsFillerTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/ReportedConfigurationType.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/NetworkInSyncWithVdsNetworkInterface.java M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/NetworkInSyncWithVdsNetworkInterfaceTest.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/NetworkImplementationDetailsUtils.java M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/BaseNetworkImplementationDetailsUtilsTest.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/NetworkOutOfSyncPanel.java M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/ApplicationConstants.properties 11 files changed, 242 insertions(+), 106 deletions(-) Approvals: Martin Mucha: Verified Alona Kaplan: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/56195 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I68f4cf0ce93123bef1e620193631afd707244170 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: removed unused methods
by alkaplan＠redhat.com 08 Jun '16

08 Jun '16

Alona Kaplan has submitted this change and it was merged. Change subject: core: removed unused methods ...................................................................... core: removed unused methods Change-Id: I394af9c846caf2aea707bbc61853d8dda2ee5ba7 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/NetworkInSyncWithVdsNetworkInterface.java 1 file changed, 0 insertions(+), 35 deletions(-) Approvals: Marcin Mirecki: Looks good to me, but someone else must approve Martin Mucha: Verified Alona Kaplan: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/56194 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I394af9c846caf2aea707bbc61853d8dda2ee5ba7 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0