June 2016 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: engine: fix NPE related to switchType
by masayag＠redhat.com 13 Jun '16

13 Jun '16

Moti Asayag has submitted this change and it was merged. Change subject: engine: fix NPE related to switchType ...................................................................... engine: fix NPE related to switchType seen while adding 3.6 host Change-Id: I028cdc17207ea785f24e75f3e74d5d97d0f89306 Signed-off-by: Sahina Bose <sabose(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java 1 file changed, 4 insertions(+), 3 deletions(-) Approvals: Martin Mucha: Verified Jenkins CI: Passed CI tests Sahina Bose: Looks good to me, but someone else must approve Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/59000 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I028cdc17207ea785f24e75f3e74d5d97d0f89306 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: AddLocalStorageDomainCommand type inference
by amureini＠redhat.com 13 Jun '16

13 Jun '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: AddLocalStorageDomainCommand type inference ...................................................................... core: AddLocalStorageDomainCommand type inference Change-Id: I5f02adb7ba82a7c2983662bee1d71a84c9508068 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/AddLocalStorageDomainCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/59027 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5f02adb7ba82a7c2983662bee1d71a84c9508068 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: AddLocalStorageDomainCommand DbFacade
by amureini＠redhat.com 13 Jun '16

13 Jun '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: AddLocalStorageDomainCommand DbFacade ...................................................................... core: AddLocalStorageDomainCommand DbFacade Use the available methods to get the relevant DAOs instead of using DbFacade.getInstance() directly. This is done both to clean up the code and to make unit testing easier. Change-Id: Ibdb076a421d14f0ce71bb1926bafc7fb013e24ee Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/AddLocalStorageDomainCommand.java 1 file changed, 2 insertions(+), 4 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/59029 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibdb076a421d14f0ce71bb1926bafc7fb013e24ee Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: AddLocalStorageDomainCommand#validate early return
by amureini＠redhat.com 13 Jun '16

13 Jun '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: AddLocalStorageDomainCommand#validate early return ...................................................................... core: AddLocalStorageDomainCommand#validate early return Use the early return (fail-fat) idiom to clean up the code and make it easier to read. Change-Id: I6be202168a5131d2f0a16b104d2a826c49f901de Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/AddLocalStorageDomainCommand.java 1 file changed, 31 insertions(+), 32 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/59028 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6be202168a5131d2f0a16b104d2a826c49f901de Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: api: api doesnt pass the vminit when increasing vm in pool v2
by shavivi＠redhat.com 13 Jun '16

13 Jun '16

Shahar Havivi has submitted this change and it was merged. Change subject: api: api doesnt pass the vminit when increasing vm in pool v2 ...................................................................... api: api doesnt pass the vminit when increasing vm in pool v2 First patch solve the issue if the template have vminit and not pass it to the new VM, What was missing was if the pool edited the vminit we don't want to take the vminit from the template but from the pool. (since the pool is not saving the vminit in the database we take it from one of the vms - this is the same behaviour as the UI) Change-Id: I8572c71665016bf3a8cab033989b2473f0ce994b Bug-Url: https://bugzilla.redhat.com/1339287 Signed-off-by: Shahar Havivi <shaharh(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmPoolResource.java 1 file changed, 4 insertions(+), 1 deletion(-) Approvals: Shahar Havivi: Verified Juan Hernandez: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/58851 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8572c71665016bf3a8cab033989b2473f0ce994b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: core: Auto select correct graphics device on Template creation
by tnisan＠redhat.com 13 Jun '16

13 Jun '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Auto select correct graphics device on Template creation ...................................................................... core: Auto select correct graphics device on Template creation The treatment performed in AddVmCommand initilization was missing from AddVmTemplateCommand. Moved the method to VmHandler and called both from AddVmCommand and AddVmTemplateCommand. Also when importing to ppc cluster another bug manifested itself with auto selection of soundcard. Since soundcard is not supported on ppc the null default value passed in parameters was not overwritten and caused NPE in later command execution. Now we set the soundcard explicitly to false if it remains null after the treatment. Change-Id: I66a4b8175f13511df2ed95cff5893522a18a9e4b Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1341639 Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmTemplateCommandTest.java 4 files changed, 67 insertions(+), 42 deletions(-) Approvals: Jenkins CI: Passed CI tests Martin Betak: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/59009 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I66a4b8175f13511df2ed95cff5893522a18a9e4b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marek Libra <mlibra(a)redhat.com> Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-live[ovirt-live-4.0]: build: ovirt-live 4.0.0_rc2
by lveyde＠redhat.com 13 Jun '16

13 Jun '16

Lev Veyde has submitted this change and it was merged. Change subject: build: ovirt-live 4.0.0_rc2 ...................................................................... build: ovirt-live 4.0.0_rc2 Change-Id: Idf284b67df1af0045109ddb1acd462ab50b150cd Signed-off-by: Lev Veyde <lveyde(a)redhat.com> --- M centos-7/Makefile 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Lev Veyde: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/58864 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idf284b67df1af0045109ddb1acd462ab50b150cd Gerrit-PatchSet: 1 Gerrit-Project: ovirt-live Gerrit-Branch: ovirt-live-4.0 Gerrit-Owner: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Auto select correct graphics device on Template creation
by ahadas＠redhat.com 13 Jun '16

13 Jun '16

Arik Hadas has submitted this change and it was merged. Change subject: core: Auto select correct graphics device on Template creation ...................................................................... core: Auto select correct graphics device on Template creation The treatment performed in AddVmCommand initilization was missing from AddVmTemplateCommand. Moved the method to VmHandler and called both from AddVmCommand and AddVmTemplateCommand. Also when importing to ppc cluster another bug manifested itself with auto selection of soundcard. Since soundcard is not supported on ppc the null default value passed in parameters was not overwritten and caused NPE in later command execution. Now we set the soundcard explicitly to false if it remains null after the treatment. Change-Id: I66a4b8175f13511df2ed95cff5893522a18a9e4b Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1341639 Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmTemplateCommandTest.java 4 files changed, 67 insertions(+), 42 deletions(-) Approvals: Jenkins CI: Passed CI tests Martin Betak: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/58871 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I66a4b8175f13511df2ed95cff5893522a18a9e4b Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marek Libra <mlibra(a)redhat.com> Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: restapi: VmPool properties list reviewed in RSDL
by tnisan＠redhat.com 13 Jun '16

13 Jun '16

Tal Nisan has submitted this change and it was merged. Change subject: restapi: VmPool properties list reviewed in RSDL ...................................................................... restapi: VmPool properties list reviewed in RSDL The list of VmPool action properties conforms the 'VmPoolMapper'. Change-Id: I93f323e6481f613607832dbc03ba3cf663d58faa Bug-Url: https://bugzilla.redhat.com/1318703 Signed-off-by: Marek Libra <mlibra(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Juan Hernandez: Looks good to me, approved Jenkins CI: Passed CI tests Marek Libra: Verified -- To view, visit https://gerrit.ovirt.org/59003 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I93f323e6481f613607832dbc03ba3cf663d58faa Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Marek Libra <mlibra(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Marek Libra <mlibra(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: restapi: Set V3 statistic values type correctly
by tnisan＠redhat.com 13 Jun '16

13 Jun '16

Tal Nisan has submitted this change and it was merged. Change subject: restapi: Set V3 statistic values type correctly ...................................................................... restapi: Set V3 statistic values type correctly Currently the type of statistics values isn't copied correctly in the V3 compatibility layer. This patches fixes that error. Change-Id: I081ff7d2007c2098b1c3ad6f061c72afff78dc76 Bug-Url: https://bugzilla.redhat.com/1343118 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit a014020bf89ae45721f5150ac598ca0d887b3175) --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/adapters/V3StatisticOutAdapter.java 1 file changed, 16 insertions(+), 20 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/59013 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I081ff7d2007c2098b1c3ad6f061c72afff78dc76 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0