June 2016 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-4.0]: webadmin: when attaching net to a new bond, it shouldn't get...
by tnisan＠redhat.com 07 Jun '16

07 Jun '16

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: when attaching net to a new bond, it shouldn't get bond's params ...................................................................... webadmin: when attaching net to a new bond, it shouldn't get bond's params Change-Id: Iecc35fa26d6ba85d1f172046f46b83f9c6194aa7 Bug-Url: https://bugzilla.redhat.com/1340624 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/LogicalNetworkModelParametersHelper.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Alona Kaplan: Verified Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/58657 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iecc35fa26d6ba85d1f172046f46b83f9c6194aa7 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: engine: Can't assign ip for a network attached to the same n...
by tnisan＠redhat.com 07 Jun '16

07 Jun '16

Tal Nisan has submitted this change and it was merged. Change subject: engine: Can't assign ip for a network attached to the same nic as mgmt ...................................................................... engine: Can't assign ip for a network attached to the same nic as mgmt The validation that caused this wrong blocking is 'networkIpAddressWasSameAsHostnameAndChanged()'. Comparing the code of the validation in the old setup network command to the new one, shows that besides the bug in the title, the old logic was changed by mistake. After rethinking about this validation we came to conclusion that the old and the new validations block cases that may be permitted by the vdsm. So we decided, for now, to remove the engine level validation. In case of a real problem, the vdsm will perform a rollback. Change-Id: Ia965a98c0a466d77238f45254f95e008145befcc Bug-Url: https://bugzilla.redhat.com/1340702 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksValidator.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/NetworkAttachmentValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/NetworkAttachmentValidatorTest.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostSetupNetworksModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/NetworkAttachmentModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/UIConstants.properties 7 files changed, 2 insertions(+), 175 deletions(-) Approvals: Alona Kaplan: Verified Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/58658 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia965a98c0a466d77238f45254f95e008145befcc Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-setup[master]: storage: avoid writing mnt_options value if not set
by stirabos＠redhat.com 07 Jun '16

07 Jun '16

Simone Tiraboschi has submitted this change and it was merged. Change subject: storage: avoid writing mnt_options value if not set ...................................................................... storage: avoid writing mnt_options value if not set Avoid writing mnt_options value if not set otherwise ovirt-ha-agent will read 'None' and the mount after a reboot will fail. Change-Id: I68c4e6144c307a5acf919967c8c8079d37f0b1d1 Bug-Url: https://bugzilla.redhat.com/1342988 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M src/plugins/gr-he-setup/core/conf.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Simone Tiraboschi: Verified; Looks good to me, approved Jenkins CI: Passed CI tests Yedidyah Bar David: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/58672 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I68c4e6144c307a5acf919967c8c8079d37f0b1d1 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Ryan Barry <rbarry(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Kernel cmdline typo
by mbetak＠redhat.com 07 Jun '16

07 Jun '16

Martin Betak has submitted this change and it was merged. Change subject: webadmin: Kernel cmdline typo ...................................................................... webadmin: Kernel cmdline typo In Host dialog, Kernel tab. Disability tooltip hint: User Reset button drop all custom parameters and enable checkboxes. -> Use Reset button to drop all custom parameters and enable checkboxes. Change-Id: Ic3919b0d3c58990d9f79f2ddcd6103f076cb07fd Bug-Url: https://bugzilla.redhat.com/1343134 Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> --- M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/UIConstants.properties 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jakub Niedermertl: Verified Jenkins CI: Passed CI tests Martin Betak: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/58687 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic3919b0d3c58990d9f79f2ddcd6103f076cb07fd Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: No UpdateVmCommand after Cluster Edit for external VMs
by ahadas＠redhat.com 07 Jun '16

07 Jun '16

Arik Hadas has submitted this change and it was merged. Change subject: core: No UpdateVmCommand after Cluster Edit for external VMs ...................................................................... core: No UpdateVmCommand after Cluster Edit for external VMs The UpdateClusterCommand avoids calling the UpdateVmCommand for External and HostedEngine VMs to prevent validation failure. Change-Id: I2120451866c8fad1a0c39635a07d056ab45a0f86 Bug-Url: https://bugzilla.redhat.com/1341145 Signed-off-by: Marek Libra <mlibra(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateClusterCommand.java 1 file changed, 10 insertions(+), 8 deletions(-) Approvals: Tomas Jelinek: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Marek Libra: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/58365 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2120451866c8fad1a0c39635a07d056ab45a0f86 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Marek Libra <mlibra(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marek Libra <mlibra(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: added a job for testing oVirt 4.0
by dcaro＠redhat.com 07 Jun '16

07 Jun '16

David Caro has submitted this change and it was merged. Change subject: added a job for testing oVirt 4.0 ...................................................................... added a job for testing oVirt 4.0 Change-Id: Ia479a307d1983141bb5ac529baa1b4724542e708 Signed-off-by: gbenhaim <galbh2(a)gmail.com> --- M jobs/confs/projects/ovirt/system-tests.yaml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Gal Ben Haim: Verified; Ready for review Jenkins CI: Passed CI tests David Caro: Looks good to me; Ready for merge -- To view, visit https://gerrit.ovirt.org/58685 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia479a307d1983141bb5ac529baa1b4724542e708 Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Gal Ben Haim <galbh2(a)gmail.com> Gerrit-Reviewer: David Caro <dcaro(a)redhat.com> Gerrit-Reviewer: Gal Ben Haim <galbh2(a)gmail.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6.7]: core: Insert valid graphics and display devices in HE VM
by tnisan＠redhat.com 06 Jun '16

06 Jun '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Insert valid graphics and display devices in HE VM ...................................................................... core: Insert valid graphics and display devices in HE VM Update imported manged hosted engine VMs with valid video and graphics devices. Change-Id: I36e7b2acdf692abd1af7ad2a90e27797116498aa Bug-Url: https://bugzilla.redhat.com/1326810 Bug-Url:https://bugzilla.redhat.com/1328921 Signed-off-by: Roman Mohr <rmohr(a)redhat.com> --- A packaging/dbscripts/upgrade/03_06_2130_add_graphics_and_video_devices_to_he.sql 1 file changed, 53 insertions(+), 0 deletions(-) Approvals: Eli Mesika: Looks good to me, but someone else must approve Roman Mohr: Verified Jenkins CI: Passed CI tests Roy Golan: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/58314 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I36e7b2acdf692abd1af7ad2a90e27797116498aa Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6.7 Gerrit-Owner: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: engine: Set default filter on vnic profile created for new n...
by tnisan＠redhat.com 06 Jun '16

06 Jun '16

Tal Nisan has submitted this change and it was merged. Change subject: engine: Set default filter on vnic profile created for new network/dc ...................................................................... engine: Set default filter on vnic profile created for new network/dc Change-Id: I8cea5499c51fd7c57f74f3d96d22912f815092c6 Bug-Url: https://bugzilla.redhat.com/1336401 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/NetworkHelper.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/AddNetworkCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/AddVnicProfileCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/AddEmptyStoragePoolCommand.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/NetworkModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/BaseImportNetworksModel.java 6 files changed, 26 insertions(+), 17 deletions(-) Approvals: Alona Kaplan: Verified Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/58656 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8cea5499c51fd7c57f74f3d96d22912f815092c6 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Validate creation date is bigger then deleted snapshot.
by mlipchuk＠redhat.com 06 Jun '16

06 Jun '16

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Validate creation date is bigger then deleted snapshot. ...................................................................... core: Validate creation date is bigger then deleted snapshot. Snapshots can be removed only if those were created after the creation date of the previewed snapshot the was commited. Since the date is maintained in the DataBase with UTC indication, there is no possibility for DST misshappans. Change-Id: I7d4f1ff79337848b12a2e6b43c27144c46f1ec9d Bug-Url: https://bugzilla.redhat.com/1290427 Signed-off-by: Maor Lipchuk <maorlipchuk(a)gmail.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/RestoreAllSnapshotsCommand.java 1 file changed, 12 insertions(+), 3 deletions(-) Approvals: Shahar Havivi: Looks good to me, but someone else must approve Maor Lipchuk: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/58551 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7d4f1ff79337848b12a2e6b43c27144c46f1ec9d Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Handle snapshot entity instead of snapshot id.
by mlipchuk＠redhat.com 06 Jun '16

06 Jun '16

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Handle snapshot entity instead of snapshot id. ...................................................................... core: Handle snapshot entity instead of snapshot id. On restore we should use the snapshot entity instead only the snapshot id to indicate the snapshot that should be deleted don commit or undo operations. The reason for using the snapshot entity is to be able to get more information about the deleted snapshot like the creation date. Change-Id: I590b52d25bb774c886fe1e4e8741f2affbf2e9b8 Bug-Url: https://bugzilla.redhat.com/1290427 Signed-off-by: Maor Lipchuk <maorlipchuk(a)gmail.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/RestoreAllSnapshotsCommand.java 1 file changed, 13 insertions(+), 10 deletions(-) Approvals: Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/58550 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I590b52d25bb774c886fe1e4e8741f2affbf2e9b8 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0