June 2016 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: log vms retrieved on statistics polling
by ahadas＠redhat.com 01 Jun '16

01 Jun '16

Arik Hadas has submitted this change and it was merged. Change subject: core: log vms retrieved on statistics polling ...................................................................... core: log vms retrieved on statistics polling Log the VMs we get from VDSM on statistics monitoring cycles. Only the first eight digits in the VM ID are printed along with its status. We add this in order to produce more data that could help us with on- going bug investigation. Change-Id: I9fa187c317e4bac5cc4ef41541a1c31532fa909b Bug-Url: https://bugzilla.redhat.com/1339291 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmsStatisticsFetcher.java 1 file changed, 16 insertions(+), 0 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Shmuel Leib Melamud: Looks good to me, but someone else must approve Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/58409 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9fa187c317e4bac5cc4ef41541a1c31532fa909b Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <mskrivan(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: do not validate free mac addresses when importing temp...
by alkaplan＠redhat.com 01 Jun '16

01 Jun '16

Alona Kaplan has submitted this change and it was merged. Change subject: core: do not validate free mac addresses when importing template ...................................................................... core: do not validate free mac addresses when importing template When importing template it's not needed to make sure there are enough of macs in pool. Until we create VM out of this template no nics will be needed, so this too-early check may falsely succeed and falsely fail. Also when pool is also bound to VmPool check of free macs for template would not be possible(or at least sane), since we do not know, what pool will be used, and we may end up checking in wrong pool. Change-Id: I1c568ce28dc901ef89416473ef0cf960f3276b1e Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ImportVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ImportVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/VmNicMacsUtils.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/exportimport/ImportVmTemplateCommandTest.java 4 files changed, 25 insertions(+), 23 deletions(-) Approvals: Martin Mucha: Verified Alona Kaplan: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/53463 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1c568ce28dc901ef89416473ef0cf960f3276b1e Gerrit-PatchSet: 16 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: fixes related to validating nics mac addresses
by alkaplan＠redhat.com 01 Jun '16

01 Jun '16

Alona Kaplan has submitted this change and it was merged. Change subject: core: fixes related to validating nics mac addresses ...................................................................... core: fixes related to validating nics mac addresses Code in two touched duplicate methods is about to change in following patch. Knowing that I extracted this duplicity. • duplicity removed • method removed from ImportValidator where it does not belong • removed unneccesary 'upcast' Change-Id: If85a8b5b4f462a83aa70701090d57958beee3326 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ImportVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ImportVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/ImportValidator.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/VmNicMacsUtils.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/exportimport/ImportVmTemplateCommandTest.java 5 files changed, 69 insertions(+), 43 deletions(-) Approvals: Martin Mucha: Verified Alona Kaplan: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/53462 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If85a8b5b4f462a83aa70701090d57958beee3326 Gerrit-PatchSet: 16 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: remove link to mac pool from storage pool.
by alkaplan＠redhat.com 01 Jun '16

01 Jun '16

Alona Kaplan has submitted this change and it was merged. Change subject: core: remove link to mac pool from storage pool. ...................................................................... core: remove link to mac pool from storage pool. Bug-Url: https://bugzilla.redhat.com/994283 Change-Id: I8c9d5bb5abb69e73c5aa9c1ba51c868b687cff27 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StoragePoolDao.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StoragePoolDaoImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/StoragePoolDaoTest.java M backend/manager/modules/dal/src/test/resources/fixtures.xml M packaging/dbscripts/storages_sp.sql A packaging/dbscripts/upgrade/04_00_0750_remove_mac_pool_id_from_storage_pool.sql 6 files changed, 12 insertions(+), 68 deletions(-) Approvals: Martin Mucha: Verified Alona Kaplan: Looks good to me, approved; Passed CI tests Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/51427 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8c9d5bb5abb69e73c5aa9c1ba51c868b687cff27 Gerrit-PatchSet: 25 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: moved reference to mac pool from DataCenter to Clu...
by alkaplan＠redhat.com 01 Jun '16

01 Jun '16

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: moved reference to mac pool from DataCenter to Cluster ...................................................................... webadmin: moved reference to mac pool from DataCenter to Cluster Bug-Url: https://bugzilla.redhat.com/994283 Change-Id: Ibfbeb0c2b992c127c6fa148b160913cd22e708c0 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/ConfigureLocalStorageModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/ClusterModule.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/DataCenterModule.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/cluster/ClusterPopupPresenterWidget.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/datacenter/DataCenterPopupPresenterWidget.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterPopupView.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/datacenter/DataCenterPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/datacenter/DataCenterPopupView.ui.xml M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/ApplicationConstants.properties 15 files changed, 321 insertions(+), 344 deletions(-) Approvals: Martin Mucha: Verified Alona Kaplan: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/51426 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibfbeb0c2b992c127c6fa148b160913cd22e708c0 Gerrit-PatchSet: 24 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: Solve db update script collision
by tnisan＠redhat.com 01 Jun '16

01 Jun '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Solve db update script collision ...................................................................... core: Solve db update script collision DB update script with number 03062120 existed two times. Change-Id: I87e7c94a39566b756e08600554c0b28287a1baee Signed-off-by: Roman Mohr <rmohr(a)redhat.com> --- R packaging/dbscripts/upgrade/03_06_2130_add_graphics_and_video_devices_to_he.sql 1 file changed, 0 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/58431 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I87e7c94a39566b756e08600554c0b28287a1baee Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in gerrit-admin[master]: Add basic lago development env with gerrit server
by dcaro＠redhat.com 01 Jun '16

01 Jun '16

David Caro has submitted this change and it was merged. Change subject: Add basic lago development env with gerrit server ...................................................................... Add basic lago development env with gerrit server That helps a lot to actually test the hooks Change-Id: I594e917d9d98e4cf8ae835dcd033db4e4827d426 Signed-off-by: David Caro <dcaroest(a)redhat.com> --- A LagoInitFile A scripts/deploy_gerrit_server.sh A scripts/install_hook_dispatcher.sh A scripts/start_lago_env.sh 4 files changed, 117 insertions(+), 0 deletions(-) Approvals: David Caro: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/58086 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I594e917d9d98e4cf8ae835dcd033db4e4827d426 Gerrit-PatchSet: 4 Gerrit-Project: gerrit-admin Gerrit-Branch: master Gerrit-Owner: David Caro <dcaro(a)redhat.com> Gerrit-Reviewer: David Caro <dcaro(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Gal Ben Haim Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: automation: Perform minimal GWT build on merged patches
by tnisan＠redhat.com 01 Jun '16

01 Jun '16

Tal Nisan has submitted this change and it was merged. Change subject: automation: Perform minimal GWT build on merged patches ...................................................................... automation: Perform minimal GWT build on merged patches Add execution of GWT build for English locale and Firefox only for all merged patches to detect possible issues in GWT build. Change-Id: I9a243ae09c613b087f164b9798e97ca2e6291f67 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M automation/check-merged.sh 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Tomas Jelinek: Looks good to me, but someone else must approve Tal Nisan: Looks good to me, approved Martin Peřina: Verified Eyal Edri: Looks good to me, but someone else must approve Barak Korren: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Vojtech Szocs: Looks good to me, but someone else must approve Arik Hadas: Looks good to me, but someone else must approve Moti Asayag: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/58246 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9a243ae09c613b087f164b9798e97ca2e6291f67 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: Missing call super.getJobMessageProperties
by tnisan＠redhat.com 01 Jun '16

01 Jun '16

Tal Nisan has submitted this change and it was merged. Change subject: engine: Missing call super.getJobMessageProperties ...................................................................... engine: Missing call super.getJobMessageProperties In ImportVmTemplateCommand, the super method of getJobMessageProperties was not called. Also an unneeded jobproperties was removed since now the super method is called. This patch addresses Coverity CID 1353694 Change-Id: I8349e4b0296855f0430fff79f60df736d24a141d Signed-off-by: Fred Rolland <frolland(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ImportVmTemplateCommand.java 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Freddy Rolland: Verified -- To view, visit https://gerrit.ovirt.org/58415 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8349e4b0296855f0430fff79f60df736d24a141d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: Insert valid graphics and display devices in HE VM
by piotr.kliczewski＠gmail.com 01 Jun '16

01 Jun '16

Piotr Kliczewski has submitted this change and it was merged. Change subject: core: Insert valid graphics and display devices in HE VM ...................................................................... core: Insert valid graphics and display devices in HE VM Update imported manged hosted engine VMs with valid video and graphics devices. Change-Id: I36e7b2acdf692abd1af7ad2a90e27797116498aa Bug-Url: https://bugzilla.redhat.com/1326810 Bug-Url:https://bugzilla.redhat.com/1328921 Signed-off-by: Roman Mohr <rmohr(a)redhat.com> --- A packaging/dbscripts/upgrade/03_06_2120_add_graphics_and_video_devices_to_he.sql 1 file changed, 53 insertions(+), 0 deletions(-) Approvals: Piotr Kliczewski: Passed CI tests Eli Mesika: Looks good to me, but someone else must approve Roman Mohr: Verified Roy Golan: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/58099 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I36e7b2acdf692abd1af7ad2a90e27797116498aa Gerrit-PatchSet: 17 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <mskrivan(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0