July 2016 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: StorageDomainNumberOfVmDisksComparator domain list
by amureini＠redhat.com 20 Jul '16

20 Jul '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: StorageDomainNumberOfVmDisksComparator domain list ...................................................................... core: StorageDomainNumberOfVmDisksComparator domain list Remove the domain list parameter from StorageDomainNumberOfVmDisksComparator. The list of domains can be inferred from the collection of disks, and any domains missing from that list can assumed to have 0 relevant disks on them by using getOrDefault(key, 0). Change-Id: I24af6711c92f05215846364e85151717aed4a668 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/memory/MemoryStorageHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/memory/sdcomparators/StorageDomainNumberOfVmDisksComparator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/memory/MemoryStorageHandlerTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/memory/sdcomparators/StorageDomainNumberOfVmDisksComparatorTest.java 4 files changed, 12 insertions(+), 26 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests Idan Shaby: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/60654 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I24af6711c92f05215846364e85151717aed4a668 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: StorageDomainNumberOfVmDisksComparator streaming
by amureini＠redhat.com 20 Jul '16

20 Jul '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: StorageDomainNumberOfVmDisksComparator streaming ...................................................................... core: StorageDomainNumberOfVmDisksComparator streaming The StorageDomainNumberOfVmDisksComparator constructor converts a collections of DiskImages to a map from the storage domain id to the number of VMs located on it. This is much easier to do with Java 8's steam APIs instead of reinventing the wheel ourselves. As a side effect of this patch, the Map was converted from Map<Guid, Integer> to Map<Guid, Long> to conform to Collectors.counting()'s API. This may add some minor memory consumption overhead, as Longs are larger than Integers, but this is negligible as this Comparator is extremely short lived. Change-Id: Id8271fd39eb270090f25ebd9bd32351d61fa465b Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/memory/sdcomparators/StorageDomainNumberOfVmDisksComparator.java 1 file changed, 7 insertions(+), 15 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests Idan Shaby: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/60655 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id8271fd39eb270090f25ebd9bd32351d61fa465b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: rm MemoryStorageHandleTest#StorageDomainRejectingFilter
by amureini＠redhat.com 20 Jul '16

20 Jul '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: rm MemoryStorageHandleTest#StorageDomainRejectingFilter ...................................................................... core: rm MemoryStorageHandleTest#StorageDomainRejectingFilter StorageDomainRejectingFilter can be replaced with a one-liner simple lambda, there's no reason to bloat the code with an entire class for it. Change-Id: Ida531dfa246761b6d508e53ad3a64fa370e7d5a8 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/memory/MemoryStorageHandlerTest.java 1 file changed, 4 insertions(+), 18 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests Idan Shaby: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/60690 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ida531dfa246761b6d508e53ad3a64fa370e7d5a8 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: MemoryStorageHandlerTest collections
by amureini＠redhat.com 20 Jul '16

20 Jul '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: MemoryStorageHandlerTest collections ...................................................................... core: MemoryStorageHandlerTest collections Use Collections.singletonList instead of Arrays.asList with a single argument for a [minor] performance improvement. Change-Id: I028ce83a8a6b56f58672458a21e5767c3bf312f4 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/memory/MemoryStorageHandlerTest.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests Idan Shaby: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/60689 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I028ce83a8a6b56f58672458a21e5767c3bf312f4 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: MemoryStorageHandlerTest type inference
by amureini＠redhat.com 20 Jul '16

20 Jul '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: MemoryStorageHandlerTest type inference ...................................................................... core: MemoryStorageHandlerTest type inference Change-Id: Icce372e7bedb9bd2c461efb9827ed6dceac7f3d8 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/memory/MemoryStorageHandlerTest.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests Idan Shaby: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/60688 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icce372e7bedb9bd2c461efb9827ed6dceac7f3d8 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: bll: search: don't replace all ocurrence of pattern
by tnisan＠redhat.com 20 Jul '16

20 Jul '16

Tal Nisan has submitted this change and it was merged. Change subject: bll: search: don't replace all ocurrence of pattern ...................................................................... bll: search: don't replace all ocurrence of pattern Previously we replaced all occurances of pattern in search text, which could lead in replacing unwanted characters. This patch changes the behaviour in a way, that we just replace first found characters. Change-Id: I659b9a6043643cc3ad2358bb12fa46cadb6e0f4d Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1358286 Signed-off-by: Ondra Machacek <omachace(a)redhat.com> (cherry picked from commit 85642149c1780dd943b2aef817f586b7defb0cc2) --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SearchQuery.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Ondra Machacek: Verified Martin Peřina: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/60900 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I659b9a6043643cc3ad2358bb12fa46cadb6e0f4d Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: restapi: Issue Usage Message For Bad Request
by tnisan＠redhat.com 20 Jul '16

20 Jul '16

Tal Nisan has submitted this change and it was merged. Change subject: restapi: Issue Usage Message For Bad Request ...................................................................... restapi: Issue Usage Message For Bad Request When user enters a malformed request body, direct them to the relevant section in model.html for correct usage. Bug-Url: http://bugzilla.redhat.com/1337240 Change-Id: Ie2554335f8ec0dd488d722f8b5f5d30b323dfbbe Signed-off-by: Ori Liel <oliel(a)redhat.com> (cherry picked from commit 1d6797aed97b04a7a359885bc6b2fd920b79b46f) --- A backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/rsdl/ServiceTree.java A backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/rsdl/ServiceTreeNode.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/validation/IOExceptionMapper.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/validation/JsonExceptionMapper.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/validation/UsageFinder.java A backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/validation/UsageFinderTest.java 6 files changed, 460 insertions(+), 82 deletions(-) Approvals: Ori Liel: Verified Juan Hernandez: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/60710 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie2554335f8ec0dd488d722f8b5f5d30b323dfbbe Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-release[ovirt-4.0]: node: require dracut-fips
by sbonazzo＠redhat.com 20 Jul '16

20 Jul '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: node: require dracut-fips ...................................................................... node: require dracut-fips Require dracut-fips so users can enable FIPS if desired Change-Id: Icbefb95885cd7f78b5e4fadc18043b5723bb8814 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1339526 Signed-off-by: Ryan Barry <rbarry(a)redhat.com> --- M ovirt-release40.spec.in 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/60350 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icbefb95885cd7f78b5e4fadc18043b5723bb8814 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-release Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Ryan Barry <rbarry(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-release[master]: node: require dracut-fips
by sbonazzo＠redhat.com 20 Jul '16

20 Jul '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: node: require dracut-fips ...................................................................... node: require dracut-fips Pull dracut-fips into the image, so users can enable FIPS if desired Change-Id: I4ac37b94388568cc7b880a39828692335d338fc8 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1339526 Signed-off-by: Ryan Barry <rbarry(a)redhat.com> --- M ovirt-release-master.spec.in 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/60348 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4ac37b94388568cc7b880a39828692335d338fc8 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-release Gerrit-Branch: master Gerrit-Owner: Ryan Barry <rbarry(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-release[ovirt-4.0]: node: enable rsyslog and auditd by default
by sbonazzo＠redhat.com 20 Jul '16

20 Jul '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: node: enable rsyslog and auditd by default ...................................................................... node: enable rsyslog and auditd by default This should match platform https://bugzilla.redhat.com/show_bug.cgi?id=1349373 https://bugzilla.redhat.com/show_bug.cgi?id=1349366 Change-Id: Ifda34be1f6199f4e095d991d929533f5bf08c074 Signed-off-by: Ryan Barry <rbarry(a)redhat.com> --- M ovirt-release40.spec.in 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Douglas Schilling Landgraf: Looks good to me, but someone else must approve Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/60536 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifda34be1f6199f4e095d991d929533f5bf08c074 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-release Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Ryan Barry <rbarry(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0