July 2016 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: Present shared SD and local DCs on attach.
by mlipchuk＠redhat.com 12 Jul '16

12 Jul '16

Maor Lipchuk has submitted this change and it was merged. Change subject: webadmin: Present shared SD and local DCs on attach. ...................................................................... webadmin: Present shared SD and local DCs on attach. Present local Data Centers when attaching a shared SD from Data Centers -> Storage sub tab, and present shared storage domains when attaching a storage domain from the Data Center subtab in storage main tab Change-Id: I41dcae28e37214ca05974f29bacdd6d3d6961757 Bug-Url: https://bugzilla.redhat.com/1302185 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterStorageListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageDataCenterListModel.java 2 files changed, 2 insertions(+), 5 deletions(-) Approvals: Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, approved Allon Mureinik: Looks good to me, but someone else must approve Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/60171 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I41dcae28e37214ca05974f29bacdd6d3d6961757 Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: New SD types should not be filtered for local DCs.
by mlipchuk＠redhat.com 12 Jul '16

12 Jul '16

Maor Lipchuk has submitted this change and it was merged. Change subject: webadmin: New SD types should not be filtered for local DCs. ...................................................................... webadmin: New SD types should not be filtered for local DCs. ISO and export could be attached to a local DC although regualr data SDs were not allowed. This fix should allow all types of SDs to be attached to a local DC and on a shared DC we only filtering he local SD option Based on that approach, new and edit storage models should not filter storage domains' types based on the Data Center they are related to, since local Data Centers should now support shared storage domains too. Change-Id: Iae37ba0fa517a3689a6e921cf9d37e52e04e2444 Bug-Url: https://bugzilla.redhat.com/1302185 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/NewEditStorageModelBehavior.java 1 file changed, 2 insertions(+), 3 deletions(-) Approvals: Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, approved Allon Mureinik: Looks good to me, but someone else must approve Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/60172 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iae37ba0fa517a3689a6e921cf9d37e52e04e2444 Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Rename storageTypeComparator to be more specific.
by mlipchuk＠redhat.com 12 Jul '16

12 Jul '16

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Rename storageTypeComparator to be more specific. ...................................................................... core: Rename storageTypeComparator to be more specific. StorageTypeComperator simply compare between file and block storage domain. File type is a more complex type than only file or block therefore renaming the class to be more specific to StorageTypeFileComparator. Change-Id: I128362e6261962e453686b75e9804ea25a950ed5 Bug-Url: https://bugzilla.redhat.com/1353137 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/memory/MemoryStorageHandler.java R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/memory/sdcomparators/StorageTypeFileComparator.java R backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/memory/sdcomparators/StorageTypeFileComparatorTest.java 3 files changed, 6 insertions(+), 6 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/60298 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I128362e6261962e453686b75e9804ea25a950ed5 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin:Enable storage type at data center popup.
by mlipchuk＠redhat.com 12 Jul '16

12 Jul '16

Maor Lipchuk has submitted this change and it was merged. Change subject: webadmin:Enable storage type at data center popup. ...................................................................... webadmin:Enable storage type at data center popup. Do not disable storage type combo box when updating data center, even if storage domains are already attached. It is the backend responsibility to validate whether a data center can change its storage type based on the storage domain attached to it. Change-Id: Ic551bb93ba684afdec909b75ec2183b405476ff2 Bug-Url: https://bugzilla.redhat.com/1302185 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterListModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/UIConstants.properties 3 files changed, 0 insertions(+), 19 deletions(-) Approvals: Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, approved Allon Mureinik: Looks good to me, but someone else must approve Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/60235 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic551bb93ba684afdec909b75ec2183b405476ff2 Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in gerrit-admin[master]: dropping the skip on moving downstream bugs to MODIFIED
by eedri＠redhat.com 11 Jul '16

11 Jul '16

Eyal Edri has submitted this change and it was merged. Change subject: dropping the skip on moving downstream bugs to MODIFIED ...................................................................... dropping the skip on moving downstream bugs to MODIFIED It might be that in the past we didn't move RHEV bugs to MODIFIED because it required a downstream patch to be included in the fix. This patch assumes that if a bug was included in a commit msg in upstream code it means the patch is fixing that bug and bug status should be updated Change-Id: I805fd00577b0155086c6147375afa2197ea1e326 Signed-off-by: Eyal Edri <eedri(a)redhat.com> --- M hooks/custom_hooks/change-merged.set_MODIFIED 1 file changed, 8 insertions(+), 8 deletions(-) Approvals: Eyal Edri: Verified; Looks good to me, approved; Passed CI tests Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/60523 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I805fd00577b0155086c6147375afa2197ea1e326 Gerrit-PatchSet: 1 Gerrit-Project: gerrit-admin Gerrit-Branch: master Gerrit-Owner: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: core: Cluster update triggers VM update only if necessary
by tnisan＠redhat.com 11 Jul '16

11 Jul '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Cluster update triggers VM update only if necessary ...................................................................... core: Cluster update triggers VM update only if necessary There was a problem when user tried to edit Cluster while there was a migrating VM in the Cluster. The root cause was collision of VM locks of MigrateVmCommand and UpdateVmCommand called by UpdateClusterCommand. This patch doesn't solve the problem entirely. It only lowers the probability its occurrence by triggering UpdateVmCommand only if cluster compatibility level was changed. Change-Id: Ieccac1f08847681d5f326b9c54a99364720cfdb0 Bug-Url: https://bugzilla.redhat.com/1349526 Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateClusterCommand.java 1 file changed, 8 insertions(+), 5 deletions(-) Approvals: Jakub Niedermertl: Verified Jenkins CI: Passed CI tests Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/60490 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ieccac1f08847681d5f326b9c54a99364720cfdb0 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: restapi: Avoid NPE when external event has link but not id
by tnisan＠redhat.com 11 Jul '16

11 Jul '16

Tal Nisan has submitted this change and it was merged. Change subject: restapi: Avoid NPE when external event has link but not id ...................................................................... restapi: Avoid NPE when external event has link but not id Currently when an external event is added we support links to specific objects, for examaple, to add an event with a link to a specific virtual machine we accept the following event: <event> <description>File system /home is full</description> <severity>alert</severity> <origin>mymonitor</origin> <custom_id>1467879754</custom_id> <vm id="aae98225-5b73-490d-a252-899209af17e9"/> </event> But we don't check if the "id" attribute of the link is actually populated, which generates a NPE. For example, if the caller sends the name instead of the id: <event> <description>File system /home is full</description> <severity>alert</severity> <origin>mymonitor</origin> <custom_id>1467879754</custom_id> <vm> <name>myvm</name> </vm> </event> This isn't supported at the moment, but it shound't generate a NPE, it should just be ignored. This patch changes the event mapper so that it checks if the id is present. Change-Id: I13a174699e66833d6b31f50d0bb03967c178458e Bug-Url: https://bugzilla.redhat.com/1353460 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit 195ac1b2e655629416373e8106cbcdb516b2ae3a) --- M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/EventMapper.java 1 file changed, 35 insertions(+), 21 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/60515 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I13a174699e66833d6b31f50d0bb03967c178458e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-setup[master]: vm_status: add global maintenance to --json output
by stirabos＠redhat.com 11 Jul '16

11 Jul '16

Simone Tiraboschi has submitted this change and it was merged. Change subject: vm_status: add global maintenance to --json output ...................................................................... vm_status: add global maintenance to --json output This was missed in the previous patch. Poll whether the cluster is in global maintenance and report it in machine readable output as well Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1353537 Change-Id: If1ba93ddd53beddca2100c44072bc301e02d8a2a Signed-off-by: Ryan Barry <rbarry(a)redhat.com> --- M src/ovirt_hosted_engine_setup/vm_status.py 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Simone Tiraboschi: Looks good to me, approved Jenkins CI: Passed CI tests Ryan Barry: Verified -- To view, visit https://gerrit.ovirt.org/59950 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If1ba93ddd53beddca2100c44072bc301e02d8a2a Gerrit-PatchSet: 6 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Ryan Barry <rbarry(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ryan Barry <rbarry(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: Move Java SDK checks and build to Fedora 24
by sbonazzo＠redhat.com 11 Jul '16

11 Jul '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: Move Java SDK checks and build to Fedora 24 ...................................................................... Move Java SDK checks and build to Fedora 24 This patch moves the Java SDK jobs for the master branch from Fedora 23 to Fedora24. Change-Id: Ia54c514dd4e20971726b01525e297818fe15ad7e Signed-off-by: Ondra Machacek <omachace(a)redhat.com> --- M jobs/confs/projects/ovirt-engine-sdk-java/ovirt-engine-sdk-java_build-artifacts.yaml M jobs/confs/projects/ovirt-engine-sdk-java/ovirt-engine-sdk-java_create-rpms.yaml 2 files changed, 11 insertions(+), 3 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me; Ready for merge Ondra Machacek: Ready for review Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/60487 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia54c514dd4e20971726b01525e297818fe15ad7e Gerrit-PatchSet: 2 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: add 'completed' method to RollbackHandler
by tnisan＠redhat.com 11 Jul '16

11 Jul '16

Tal Nisan has submitted this change and it was merged. Change subject: core: add 'completed' method to RollbackHandler ...................................................................... core: add 'completed' method to RollbackHandler motivation: there's missing onComplete method allowing to do some actions only when transaction completed. Usecases: - 'client' returns MAC address back to MAC address pool. After doing that, rollback can occur and in that case we need to put that MAC address back to pool. Simple 'onRollback' listener seems to be sufficient for that at first, but we need to realize, that putting MAC address back to pool makes it immediately available for other threads, which means we may encounter problems in on rollback handler if someone used this MAC address meantime. So correct solution here would be, when returning MAC address back to pool, pool adds this MAC address to some collection to be returned, and does so only when related transaction succeeded. - OVF refresh is needed when hosted engine VM is edited, but the procedure requires all data to be already present in the database. Fixes: • CommandBase implements RollbackHandler. This is from OO point of view wrong, since command is not a RollbackHandler. • Previous point also touches another issue — having method 'rollback' directly on Command class, declared as 'non final' means that one can easily make error and suppress logging in CommandBase.rollback method while overriding it to add some custom handling. This should be encapsulated, no one should have possibility to tinker with CommandBase RollbackHandler. Multiple handler can be registered, so every command requiring it's own code in rollback handler, should declare and register his own. In case where order of handlers matter, we can defined composite RollbackHandler, but I do not expect necessity of doing so in near future. Bug-Url: https://bugzilla.redhat.com/1283062 Bug-Url: https://bugzilla.redhat.com/1343991 Change-Id: I352be763c84b2c3e640dbc23d15a5a294a6193e1 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddMacPoolCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveCinderSnapshotDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveMacPoolCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotSingleDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateMacPoolCommand.java A backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/transaction/NoOpTransactionCompletionListener.java D backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/transaction/RollbackHandler.java A backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/transaction/TransactionCompletionListener.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/transaction/TransactionSupport.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VDSCommandBase.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/AddNetworkVDSCommand.java 12 files changed, 185 insertions(+), 119 deletions(-) Approvals: Martin Sivák: Verified Martin Mucha: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/54014 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I352be763c84b2c3e640dbc23d15a5a294a6193e1 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0