July 2016 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Unify similar methods in VdsBrokerObjectsBuilder
by tnisan＠redhat.com 10 Jul '16

10 Jul '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Unify similar methods in VdsBrokerObjectsBuilder ...................................................................... core: Unify similar methods in VdsBrokerObjectsBuilder The methods extractIntegerList and extracStringtList (sic) are doing exactly the same aside for the fact that one returns null when elements are not found and the second returns an empty list. Both methods were unified to a single method Change-Id: Iedfd72038d28e92b1fd078a8d5536c8334f70733 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java 1 file changed, 11 insertions(+), 27 deletions(-) Approvals: Tal Nisan: Verified Jenkins CI: Passed CI tests Maor Lipchuk: Looks good to me, approved Ala Hino: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/58928 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iedfd72038d28e92b1fd078a8d5536c8334f70733 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Use Java streaming API in VdsBrokerObjectsBuilder
by tnisan＠redhat.com 10 Jul '16

10 Jul '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Use Java streaming API in VdsBrokerObjectsBuilder ...................................................................... core: Use Java streaming API in VdsBrokerObjectsBuilder Change-Id: I6c756b7bfae4c76759ba7feb79f13d8eb7ede007 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java 1 file changed, 29 insertions(+), 45 deletions(-) Approvals: Tal Nisan: Verified Jenkins CI: Passed CI tests Maor Lipchuk: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/58927 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6c756b7bfae4c76759ba7feb79f13d8eb7ede007 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: VmPoolSimpleUserCommandBase cleanup
by ahadas＠redhat.com 10 Jul '16

10 Jul '16

Arik Hadas has submitted this change and it was merged. Change subject: core: VmPoolSimpleUserCommandBase cleanup ...................................................................... core: VmPoolSimpleUserCommandBase cleanup Removing redundant code from VmPoolSimpleUserCommandBase. Change-Id: I3104ca7357f1fb6149db7d3fbeebb158b85cebf9 Signed-off-by: Shmuel Melamud <smelamud(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmPoolSimpleUserCommandBase.java 1 file changed, 5 insertions(+), 10 deletions(-) Approvals: Jenkins CI: Passed CI tests Shmuel Leib Melamud: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/60339 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3104ca7357f1fb6149db7d3fbeebb158b85cebf9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Cleanup of AddVmToPoolCommand
by ahadas＠redhat.com 10 Jul '16

10 Jul '16

Arik Hadas has submitted this change and it was merged. Change subject: core: Cleanup of AddVmToPoolCommand ...................................................................... core: Cleanup of AddVmToPoolCommand Removing unnecessary method overrides from AddVmToPoolCommand. Change-Id: Ib47573960bdd7e4187194c1de1bfe4763ea655eb Signed-off-by: Shmuel Melamud <smelamud(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmToPoolCommand.java 1 file changed, 1 insertion(+), 10 deletions(-) Approvals: Jenkins CI: Passed CI tests Shmuel Leib Melamud: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/60334 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib47573960bdd7e4187194c1de1bfe4763ea655eb Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: engine: use clusterId if dcId isn't available in ImportValid...
by tnisan＠redhat.com 10 Jul '16

10 Jul '16

Tal Nisan has submitted this change and it was merged. Change subject: engine: use clusterId if dcId isn't available in ImportValidator ...................................................................... engine: use clusterId if dcId isn't available in ImportValidator Change-Id: I5d2426da7249c14611b4d9ee70f32c7896dcbb3b Bug-Url: https://bugzilla.redhat.com/1351145 Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/ImportValidator.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ImportParameters.java 2 files changed, 19 insertions(+), 4 deletions(-) Approvals: Jenkins CI: Passed CI tests Arik Hadas: Looks good to me, approved Yevgeny Zaspitsky: Verified -- To view, visit https://gerrit.ovirt.org/60344 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5d2426da7249c14611b4d9ee70f32c7896dcbb3b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: v2v: vmware tooltip in import dialog is located incorrectly
by tnisan＠redhat.com 10 Jul '16

10 Jul '16

Tal Nisan has submitted this change and it was merged. Change subject: v2v: vmware tooltip in import dialog is located incorrectly ...................................................................... v2v: vmware tooltip in import dialog is located incorrectly Bug-Url: https://bugzilla.redhat.com/1350501 Signed-off-by: Shahar Havivi <shaharh(a)redhat.com> Change-Id: I22d458ac9d74206f4a7b785353db9894c641b8e9 --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/ImportVmsPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/ImportVmsPopupView.ui.xml M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/ApplicationConstants.properties 4 files changed, 17 insertions(+), 17 deletions(-) Approvals: Shahar Havivi: Verified Daniel Erez: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/60246 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I22d458ac9d74206f4a7b785353db9894c641b8e9 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: deploy: Update number of detection retries
by oourfali＠redhat.com 10 Jul '16

10 Jul '16

Oved Ourfali has submitted this change and it was merged. Change subject: deploy: Update number of detection retries ...................................................................... deploy: Update number of detection retries During host deploy there could be situation where vdsm is in recovery. In NetworkConfigurator we use 120 seconds to wait for vdsm to recover. This change increases number of retries for protocol detectopm, so with timeout between retries (5 sec) we use similar timeout as in NetworkConfigurator. Change-Id: I69b3021a0cb57fb53121c2600049816169025c0e Signed-off-by: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Bug-Url: https://bugzilla.redhat.com/1350763 --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql 2 files changed, 4 insertions(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved Oved Ourfali: Verified -- To view, visit https://gerrit.ovirt.org/60431 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I69b3021a0cb57fb53121c2600049816169025c0e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: improve vm_monitoring_view
by ahadas＠redhat.com 10 Jul '16

10 Jul '16

Arik Hadas has submitted this change and it was merged. Change subject: core: improve vm_monitoring_view ...................................................................... core: improve vm_monitoring_view Instead of querying vm_static and then filtering VMs (rather than templates and instance types), lets do it more efficiently: we query vm_dynamic (only VMs have entry in vm_dynamic) and join the result with vm_static. Change-Id: Icf4c1130826b1118354f97878d4b82001621f471 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M packaging/dbscripts/create_views.sql 1 file changed, 3 insertions(+), 4 deletions(-) Approvals: Eli Mesika: Looks good to me, but someone else must approve Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/60341 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icf4c1130826b1118354f97878d4b82001621f471 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: use stream in getAllRunningByVds
by ahadas＠redhat.com 10 Jul '16

10 Jul '16

Arik Hadas has submitted this change and it was merged. Change subject: core: use stream in getAllRunningByVds ...................................................................... core: use stream in getAllRunningByVds Change-Id: I4c2d75dfdd0a93dce9994585fdf2589fe217559c Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDaoImpl.java 1 file changed, 4 insertions(+), 7 deletions(-) Approvals: Eli Mesika: Looks good to me, but someone else must approve Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/60340 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4c2d75dfdd0a93dce9994585fdf2589fe217559c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: ovirt-hosted-engine-ha_create-rpms: add 4.0 branch
by sbonazzo＠redhat.com 08 Jul '16

08 Jul '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: ovirt-hosted-engine-ha_create-rpms: add 4.0 branch ...................................................................... ovirt-hosted-engine-ha_create-rpms: add 4.0 branch use 4.0 branch instead of master for 4.0 jobs. Change-Id: Ifd990c207ed38f7400f4faaae7655812019a9d73 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M jobs/confs/projects/ovirt-hosted-engine-ha/ovirt-hosted-engine-ha_create-rpms.yaml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified; Looks good to me; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/60411 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifd990c207ed38f7400f4faaae7655812019a9d73 Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0